#metabrainz

/

      • weirditude joined the channel
      • 2019-10-24 29729, 2019

      • Lotheric has quit
      • 2019-10-24 29738, 2019

      • weirditude has quit
      • 2019-10-24 29728, 2019

      • djinni`_ has quit
      • 2019-10-24 29730, 2019

      • djinni` joined the channel
      • 2019-10-24 29724, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-10-24 29705, 2019

      • D4RK-PH0ENiX has quit
      • 2019-10-24 29742, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-10-24 29729, 2019

      • weirditude joined the channel
      • 2019-10-24 29707, 2019

      • weirditude has quit
      • 2019-10-24 29746, 2019

      • weirditude joined the channel
      • 2019-10-24 29702, 2019

      • weirditude has quit
      • 2019-10-24 29710, 2019

      • travis-ci joined the channel
      • 2019-10-24 29710, 2019

      • travis-ci
        Project bookbrainz-data-js build #1283: passed in 2 min 16 sec: https://travis-ci.org/bookbrainz/bookbrainz-data-…
      • 2019-10-24 29710, 2019

      • travis-ci has left the channel
      • 2019-10-24 29731, 2019

      • d4rkie joined the channel
      • 2019-10-24 29726, 2019

      • D4RK-PH0ENiX has quit
      • 2019-10-24 29717, 2019

      • Lotheric joined the channel
      • 2019-10-24 29715, 2019

      • d4rkie has quit
      • 2019-10-24 29749, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-10-24 29755, 2019

      • weirditude joined the channel
      • 2019-10-24 29753, 2019

      • weirditude has quit
      • 2019-10-24 29706, 2019

      • weirditude joined the channel
      • 2019-10-24 29702, 2019

      • weirditude has quit
      • 2019-10-24 29715, 2019

      • weirditude joined the channel
      • 2019-10-24 29749, 2019

      • weirditu_ joined the channel
      • 2019-10-24 29738, 2019

      • weirditude has quit
      • 2019-10-24 29730, 2019

      • weirditude joined the channel
      • 2019-10-24 29731, 2019

      • weirditu_ has quit
      • 2019-10-24 29714, 2019

      • weirditu_ joined the channel
      • 2019-10-24 29714, 2019

      • weirditude has quit
      • 2019-10-24 29736, 2019

      • weirditude joined the channel
      • 2019-10-24 29717, 2019

      • weirditu_ has quit
      • 2019-10-24 29742, 2019

      • weirditu_ joined the channel
      • 2019-10-24 29738, 2019

      • weirditude has quit
      • 2019-10-24 29719, 2019

      • weirditude joined the channel
      • 2019-10-24 29719, 2019

      • weirditu_ has quit
      • 2019-10-24 29724, 2019

      • weirdit__ joined the channel
      • 2019-10-24 29724, 2019

      • weirditude has quit
      • 2019-10-24 29730, 2019

      • weirditude joined the channel
      • 2019-10-24 29730, 2019

      • weirdit__ has quit
      • 2019-10-24 29705, 2019

      • weirditu_ joined the channel
      • 2019-10-24 29704, 2019

      • weirditude has quit
      • 2019-10-24 29743, 2019

      • weirditu_ has quit
      • 2019-10-24 29724, 2019

      • Nyanko-sensei has quit
      • 2019-10-24 29750, 2019

      • paurieraf joined the channel
      • 2019-10-24 29726, 2019

      • nav2002 joined the channel
      • 2019-10-24 29708, 2019

      • Cyna
        reosarevok: what is the recommended max length of a line in a react file ?
      • 2019-10-24 29737, 2019

      • Cyna
        when working with zulip, it was around 80 chars. is it the same here ?
      • 2019-10-24 29702, 2019

      • reosarevok
      • 2019-10-24 29707, 2019

      • reosarevok
        Seems 78
      • 2019-10-24 29750, 2019

      • Cyna
        huh should be a number div by 10, dont you think 🤔
      • 2019-10-24 29756, 2019

      • Cyna
        78 seems an odd choice
      • 2019-10-24 29754, 2019

      • reosarevok
        I dunno, I didn't set it :D
      • 2019-10-24 29708, 2019

      • reosarevok
        On that matter: bitmap, yvanzo: is there any reason we have ignoreStrings true?
      • 2019-10-24 29752, 2019

      • reosarevok
        We try to avoid them being too long anyway and with backtick multilines there seems to be no reason not to enforce max-len for them
      • 2019-10-24 29736, 2019

      • bitmap
        yeah I think that was before we could use `` for translated strings
      • 2019-10-24 29750, 2019

      • reosarevok
        Should we change it?
      • 2019-10-24 29704, 2019

      • reosarevok
        (also, do you know why 78 and not the default 80? Not that I mind either way)
      • 2019-10-24 29708, 2019

      • bitmap
        sure :)
      • 2019-10-24 29743, 2019

      • bitmap
        I mean it is 80 for all intents and purposes, 78 just gives you some wiggle room for line numbers or diff markers and such
      • 2019-10-24 29716, 2019

      • bitmap
        it's not uncommon to have it set to 72 or 76 or 78
      • 2019-10-24 29733, 2019

      • weirditude joined the channel
      • 2019-10-24 29747, 2019

      • weirditude has quit
      • 2019-10-24 29734, 2019

      • weirditude joined the channel
      • 2019-10-24 29753, 2019

      • BrainzGit
        [metabrainz.org] PROTechThor opened pull request #337 (master…PROTechThor-readme-edit): Minor grammatical changes https://github.com/metabrainz/metabrainz.org/pull…
      • 2019-10-24 29711, 2019

      • weirditude has quit
      • 2019-10-24 29707, 2019

      • Nyanko-sensei joined the channel
      • 2019-10-24 29717, 2019

      • D4RK-PH0ENiX has quit
      • 2019-10-24 29719, 2019

      • ruaok
        Mooooin!
      • 2019-10-24 29703, 2019

      • legoktm has quit
      • 2019-10-24 29717, 2019

      • reosarevok
        Moin!
      • 2019-10-24 29738, 2019

      • c1e0 joined the channel
      • 2019-10-24 29729, 2019

      • legoktm joined the channel
      • 2019-10-24 29752, 2019

      • weirditude joined the channel
      • 2019-10-24 29716, 2019

      • chhavi_ joined the channel
      • 2019-10-24 29753, 2019

      • nav2002 has quit
      • 2019-10-24 29713, 2019

      • BrainzGit
        [metabrainz.org] PROTechThor opened pull request #338 (master…patch-1): Minor changes https://github.com/metabrainz/metabrainz.org/pull…
      • 2019-10-24 29744, 2019

      • nav2002_ joined the channel
      • 2019-10-24 29704, 2019

      • BrainzGit
        [bookbrainz-site] MonkeyDo merged pull request #308 (master…500-error-fix): fix(profile):(Updated)Fixed the 500 error when Editing some author entities. https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2019-10-24 29744, 2019

      • BrainzGit
        [bookbrainz-site] MonkeyDo closed pull request #266 (master…warnings): Removed eslint and react warnings coming on building the application https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2019-10-24 29749, 2019

      • travis-ci joined the channel
      • 2019-10-24 29750, 2019

      • travis-ci
        Project bookbrainz-site build #2384: passed in 6 min 9 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2019-10-24 29750, 2019

      • travis-ci has left the channel
      • 2019-10-24 29713, 2019

      • nav2002_ has quit
      • 2019-10-24 29747, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-10-24 29755, 2019

      • nav2002__ joined the channel
      • 2019-10-24 29705, 2019

      • Nyanko-sensei has quit
      • 2019-10-24 29754, 2019

      • Nyanko-sensei joined the channel
      • 2019-10-24 29701, 2019

      • Gazooo has quit
      • 2019-10-24 29744, 2019

      • Gazooo joined the channel
      • 2019-10-24 29731, 2019

      • nav2002__ has quit
      • 2019-10-24 29719, 2019

      • revi joined the channel
      • 2019-10-24 29758, 2019

      • pristine__
        moin!
      • 2019-10-24 29711, 2019

      • yvanzo
        mo’’in’
      • 2019-10-24 29738, 2019

      • Nyanko-sensei has quit
      • 2019-10-24 29754, 2019

      • alastairp
        Cyna: reosarevok: talking about 80, here's an interesting story http://exple.tive.org/blarg/2019/10/23/80x25/
      • 2019-10-24 29727, 2019

      • d4rkie joined the channel
      • 2019-10-24 29755, 2019

      • Cyna
        Moin everyone :)
      • 2019-10-24 29739, 2019

      • pristine__
        ruaok: can one artist_msid have many artist_mbids list?
      • 2019-10-24 29711, 2019

      • pristine__
        alastairp: ^
      • 2019-10-24 29758, 2019

      • weirditude has quit
      • 2019-10-24 29759, 2019

      • weirditude joined the channel
      • 2019-10-24 29728, 2019

      • CatQuest
        pristine__: the oposte id thik more likly?
      • 2019-10-24 29729, 2019

      • CatQuest
        opposite*
      • 2019-10-24 29749, 2019

      • weirditude has quit
      • 2019-10-24 29708, 2019

      • weirditude joined the channel
      • 2019-10-24 29703, 2019

      • ruaok
        It can have a one or more Artist mbids, yes. That is why the mapping has an array in it...
      • 2019-10-24 29706, 2019

      • pristine__
        That's not what I meant..... A sec
      • 2019-10-24 29718, 2019

      • alastairp
        an artist msid is more like a musicbrainz artist credit
      • 2019-10-24 29735, 2019

      • alastairp
        so "Sonny and Cher" is a single artist msid (because that's what a client will sent to listenbrainz as the "artist")
      • 2019-10-24 29722, 2019

      • pristine__
      • 2019-10-24 29732, 2019

      • pristine__
        what about this?
      • 2019-10-24 29739, 2019

      • weirditude has quit
      • 2019-10-24 29745, 2019

      • alastairp
        what's that mapping from?
      • 2019-10-24 29720, 2019

      • pristine__
        the artist_msid, artist_mbid mapping rob made
      • 2019-10-24 29737, 2019

      • alastairp
        it'd be nice to see a list of the artist strings from both msb and mb in that list for comparison
      • 2019-10-24 29759, 2019

      • alastairp
        right, so a single artist msid _could_ be made up of more than 1 mbid
      • 2019-10-24 29708, 2019

      • alastairp
        because as I said, it could be a credit
      • 2019-10-24 29721, 2019

      • alastairp
        "Artist 1 feat. artist 2" -> [artist1, artist2]
      • 2019-10-24 29722, 2019

      • pristine__
        I just want to know that can one artist_msid map to multiple artist_mbids
      • 2019-10-24 29753, 2019

      • pristine__
        see the first two rows
      • 2019-10-24 29707, 2019

      • pristine__
        the artist_msids are same
      • 2019-10-24 29720, 2019

      • pristine__
        but the mbid they map to are different
      • 2019-10-24 29746, 2019

      • pristine__
        like you told me that one mbid can map to multiple msids (during the summit)
      • 2019-10-24 29754, 2019

      • pristine__
        is the reverse true?
      • 2019-10-24 29745, 2019

      • weirditude joined the channel
      • 2019-10-24 29748, 2019

      • pristine__
        CatQuest: yeah, you got it right. what I ask?
      • 2019-10-24 29710, 2019

      • pristine__
        so what do think about the gist I posted
      • 2019-10-24 29716, 2019

      • pristine__
        you*
      • 2019-10-24 29753, 2019

      • pristine__
        I am not talking about credits, I understand that an artist_mbids could be made of more than one mbid.
      • 2019-10-24 29740, 2019

      • alastairp
        pristine__: this is why I suggested that you should also display the artists
      • 2019-10-24 29745, 2019

      • alastairp
        I don't know why this is the case
      • 2019-10-24 29758, 2019

      • alastairp
        one option could be that they are multiple artists with the same name
      • 2019-10-24 29701, 2019

      • alastairp
        have you looked at them?
      • 2019-10-24 29744, 2019

      • pristine__
        nice. I will check that.....
      • 2019-10-24 29747, 2019

      • pristine__
        No
      • 2019-10-24 29753, 2019

      • pristine__
        not as of now
      • 2019-10-24 29756, 2019

      • pristine__
        I have been tweaking this and other things since morning, there are interesting observations, will share soon an yes I will check the artists
      • 2019-10-24 29700, 2019

      • pristine__
        in any case
      • 2019-10-24 29722, 2019

      • alastairp
      • 2019-10-24 29726, 2019

      • alastairp
      • 2019-10-24 29741, 2019

      • pristine__
        these are edge cases
      • 2019-10-24 29742, 2019

      • alastairp
      • 2019-10-24 29746, 2019

      • alastairp
        while they're not the most common case, I wouldn't treat artists with the same name as an edge case
      • 2019-10-24 29705, 2019

      • alastairp
        there are _many_ artists with the same name, this has to be considered as normal
      • 2019-10-24 29716, 2019

      • ruaok
        Hmm. That looks a bit fishy. Let me get to a computer and I'll have a look.
      • 2019-10-24 29736, 2019

      • weirditude has quit
      • 2019-10-24 29703, 2019

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1248 (master…eslint-string-max-len): Apply eslint max-len to strings and fix (most) warnings https://github.com/metabrainz/musicbrainz-server/…
      • 2019-10-24 29744, 2019

      • reosarevok
        +2,502 −753... bitmap, yvanzo: please don't kill me :p