hey _lucifer, are you planning on converting the app to React this summer of code ?
2020-03-29 08900, 2020
Cyna
Mr_Monkey: is there any other reason that bookbrainz is being inclined to use Solr over Elasticsearch other than being native with other MeB projects ?
2020-03-29 08913, 2020
ishaanshah[m]
iliekcomputers: I am not sure if this is a threat but currently the LB's lastfm api key is revealed through react developer tools.
2020-03-29 08946, 2020
ishaanshah[m] uploaded an image: 2020-03-29-141554_1365x638_scrot.png (132KB) < https://matrix.org/_matrix/media/r0/download/matrix.org/MXqyQATyXdYyZjNOWSTIdwKh >
2020-03-29 08912, 2020
_lucifer
Cyna: depends. stretch goal if time permits
2020-03-29 08953, 2020
ishaanshah[m]
I use a plugin
2020-03-29 08959, 2020
ishaanshah[m]
Dark-Reader
2020-03-29 08914, 2020
ishaanshah[m]
works, pretty well everywhere
2020-03-29 08957, 2020
rohitdandamudi joined the channel
2020-03-29 08913, 2020
c1e0_ joined the channel
2020-03-29 08955, 2020
c1e0 has quit
2020-03-29 08902, 2020
Gazooo has quit
2020-03-29 08920, 2020
madmouser1 has quit
2020-03-29 08915, 2020
ZaphodBeeblebrox joined the channel
2020-03-29 08915, 2020
ZaphodBeeblebrox has quit
2020-03-29 08915, 2020
ZaphodBeeblebrox joined the channel
2020-03-29 08934, 2020
CatQuest has quit
2020-03-29 08900, 2020
Sophist_UK has quit
2020-03-29 08917, 2020
iliekcomputers
ishaanshah[m]: yeah, that's a compromise we have to make. We've talked about it and are OK with leaking the key for now.
2020-03-29 08907, 2020
ishaanshah[m]
Ohk, I thought that it might bw risky
2020-03-29 08934, 2020
ishaanshah[m]
But how can it be fixed if we have to?
2020-03-29 08954, 2020
ishaanshah[m]
We will have to move the importer to backend right?
2020-03-29 08900, 2020
iliekcomputers
Yeah, which leads to copyright issues
2020-03-29 08946, 2020
ishaanshah[m]
Oh
2020-03-29 08945, 2020
ishaanshah[m]
iliekcomputers: Is the stats generation still running or something crashed, coz the stats on my page didn't change
2020-03-29 08941, 2020
iliekcomputers
I'll have to look, our spark setup is unstable
2020-03-29 08956, 2020
iliekcomputers
Maybe something broke
2020-03-29 08934, 2020
c1e0_ has quit
2020-03-29 08900, 2020
shivam-kapila
iliekcomputers: Afaik the delete a batch will be somewhat cumbersome. It says mixed indexing in shards prevents from deleting data. I am still looking for a solution.
2020-03-29 08900, 2020
shivam-kapila
Currently I found rebuilding indices and restart influx as a solution but that is not viable imo.
2020-03-29 08900, 2020
shivam-kapila
A possible reason could be version upgrade of influx due to which indexing changed.
2020-03-29 08943, 2020
iliekcomputers
shivam-kapila: at this point, it maybe easier to put the task in a queue and write a script that takes tasks from the queue and does them one by one
2020-03-29 08907, 2020
iliekcomputers
Influx is so bad jfc
2020-03-29 08900, 2020
shivam-kapila
Well it will be easier when switching to Timescale.
2020-03-29 08926, 2020
shivam-kapila
So putting the task in RMQ seems better
2020-03-29 08900, 2020
shivam-kapila
I will study about it. Thanks
2020-03-29 08939, 2020
Sophist-UK joined the channel
2020-03-29 08941, 2020
madmouser1 joined the channel
2020-03-29 08930, 2020
moufl has quit
2020-03-29 08952, 2020
madmouser1 has quit
2020-03-29 08943, 2020
madmouser1 joined the channel
2020-03-29 08950, 2020
moufl joined the channel
2020-03-29 08915, 2020
Sophist-UK has quit
2020-03-29 08940, 2020
madmouser1 has quit
2020-03-29 08912, 2020
madmouser1 joined the channel
2020-03-29 08931, 2020
madmouser1 has quit
2020-03-29 08913, 2020
madmouser1 joined the channel
2020-03-29 08914, 2020
scientist1642 joined the channel
2020-03-29 08941, 2020
scientist1642 has quit
2020-03-29 08925, 2020
scientist1642 joined the channel
2020-03-29 08942, 2020
madmouser1 has quit
2020-03-29 08942, 2020
ruaok
shivam-kapila: ping
2020-03-29 08911, 2020
ruaok
sorry for the delay... I feel great today, but I am finding more things we need to address in your proposal.
2020-03-29 08917, 2020
ruaok
`Next I will proceed with implementing changes in the RabbitMQ pipeline to exchange the new ratings data between listenbrainz-server and listenbrainz-spark.`
2020-03-29 08944, 2020
ruaok
this isn't quite right.
2020-03-29 08952, 2020
shivam-kapila has quit
2020-03-29 08913, 2020
ruaok
heh. I guess I'll make comments in the doc.
2020-03-29 08941, 2020
rohitdandamudi has quit
2020-03-29 08902, 2020
madmouser1 joined the channel
2020-03-29 08929, 2020
shivam-kapila joined the channel
2020-03-29 08931, 2020
shivam-kapila
ruaok: Hey. Sorry I was logged out at that time.
2020-03-29 08938, 2020
SothoTalKer_ joined the channel
2020-03-29 08901, 2020
SothoTalKer has quit
2020-03-29 08946, 2020
ruaok
np. I left comments in the doc.
2020-03-29 08959, 2020
shivam-kapila
ruaok: Thanks for that. I will start making the changes
2020-03-29 08952, 2020
SothoTalKer joined the channel
2020-03-29 08944, 2020
SothoTalKer_ has quit
2020-03-29 08920, 2020
Mr_Monkey
Cyna: Regarding Solr, it's mainly so that we can pool resources with the other MeB projects. It's much easier and saves resources to run only one standardised technology.
2020-03-29 08956, 2020
Mr_Monkey
prabal: I saw! Now that's contribution !
2020-03-29 08905, 2020
prabal
About that search button text overflow bug, I saw you commented in Endurance's PR. I guess he'd want to make that change himself. I am not fixing it for now. It's not on priority right?
2020-03-29 08954, 2020
prabal
Speaking of search result, how would you prefer to see collection search result. 1. Showing collections search result in the main search page? 2. In the `All Collections` page, a separate search bar for collections.
2020-03-29 08932, 2020
ruaok
shivam-kapila: ping me when you're done, so we can iterate faster today.
2020-03-29 08945, 2020
shivam-kapila
ruaok: Okay I will.
2020-03-29 08946, 2020
anshuman73 joined the channel
2020-03-29 08950, 2020
Mr_Monkey
prabal: I think if in the future we want to make advanced search features it makes sense to be in a separate page.
2020-03-29 08906, 2020
SothoTalKer has quit
2020-03-29 08924, 2020
SothoTalKer joined the channel
2020-03-29 08937, 2020
heyarne[m]
the satistics on the acousticbrainz website are still from february. is that related to the problems with listenbrainz stats?
aside from main and beta, is there another set of listenbrainz servers (in particular, a test/sandbox one not connected to "production" data)? or am I required to run my own local server if i want to test submissions?
shivam-kapila: ^^ turned out well. I had to consult some other recipes for tips on what spices to start with.
2020-03-29 08924, 2020
shivam-kapila
ruaok: Looks yum.😋 Ohh I forgot to list the spices quantities. I will add that to the doc.
2020-03-29 08955, 2020
ruaok
thanks!
2020-03-29 08945, 2020
shivam-kapila
enjoy the meal. :)
2020-03-29 08936, 2020
thomasross joined the channel
2020-03-29 08921, 2020
shivam-kapila
ruaok: Modified the proposal. :)
2020-03-29 08940, 2020
Sophist-UK joined the channel
2020-03-29 08913, 2020
KrachbummNT has quit
2020-03-29 08943, 2020
Chinmay3199
Mr_Monkey: Ping!
2020-03-29 08905, 2020
Mr_Monkey
Chinmay3199: pong
2020-03-29 08927, 2020
Sophist-UK has quit
2020-03-29 08913, 2020
Chinmay3199
For increasing our code coverage I need to write test cases. So in short I have to make test cases for every needful function right? Mostly the ones there in src/server/helper
2020-03-29 08941, 2020
Chinmay3199
Mr_Monkey: correct me if I'm getting it wrong here
2020-03-29 08940, 2020
Mr_Monkey
Chinmay3199: Any function that isn't tested should be tested, in an ideal world
2020-03-29 08906, 2020
Mr_Monkey
There's unit tests, and BookBrainz is in dire need of end-to-end tests as well
2020-03-29 08956, 2020
KrachbummNT joined the channel
2020-03-29 08956, 2020
Chinmay3199
That means I'd have to write as much cases as possible,sure. Thanks!
