if there is a log of mb deletions we could confirm this from there as well
2020-10-26 30018, 2020
Mr_Monkey
pristine___: Not sure, but mainly that I didn't have time to investigate what the problem was :)
2020-10-26 30021, 2020
Zastai joined the channel
2020-10-26 30045, 2020
Gazooo79494 joined the channel
2020-10-26 30002, 2020
pristine___
Will you be able to today?
2020-10-26 30041, 2020
Mr_Monkey
Yep
2020-10-26 30021, 2020
alastairp
_lucifer: thanks for the comments. I'm loading up a shell now
2020-10-26 30026, 2020
alastairp
to take a look at language stuff
2020-10-26 30044, 2020
pristine___
Mr_Monkey: also, did you read shivam-kapila 's comment on the PR. I agree that the ecllipse is not very clear about its func, maybe we can show emoticons on the card Or write something feedback: (eclipse V), though I also feel that it will look odd. Before moving on can we discuss about it?
2020-10-26 30054, 2020
Mr_Monkey
Perhaps a different icon other than the ellipsis would work, one that represents the idea of feedback
2020-10-26 30014, 2020
pristine___
Umm... Sounds like a plan. Do you have any suggestions for such icon? I will search too.
this gives the impression that once user click on it, there will be more feedback icons
2020-10-26 30027, 2020
pristine___
+1 here
2020-10-26 30001, 2020
pristine___
or can we do it the fb style?
2020-10-26 30018, 2020
BrainzGit
[listenbrainz-server] mayhem merged pull request #1154 (master…refactor-dir-recs): make separate dirs to store recording and artist recommendation scripts https://github.com/metabrainz/listenbrainz-server…
2020-10-26 30018, 2020
pristine___
once user hover on `like` text
2020-10-26 30036, 2020
pristine___
all the emotions will be displayed
2020-10-26 30040, 2020
shivam-kapila
+1
2020-10-26 30051, 2020
pristine___
(on a side note, fb animations are really cute, we can do that maybe later, not sure how much work is that)
2020-10-26 30006, 2020
shivam-kapila
Too much :p
2020-10-26 30046, 2020
Mr_Monkey
I like the smile-plus icon, but it requires a pro license which we don't have
2020-10-26 30013, 2020
ruaok
if it helps design, we can probably pay for a license.
2020-10-26 30053, 2020
shivam-kapila
I dont think we need to
2020-10-26 30059, 2020
Mr_Monkey
> once user hover on `like` text
2020-10-26 30000, 2020
Mr_Monkey
pristine___ what do you mean by that?
2020-10-26 30011, 2020
shivam-kapila
Pro style icons are easy to copy with some css
2020-10-26 30019, 2020
ruaok
$99/year. I wouldn't actually mind doing that. I think they do good work and it would be sensible for us to support them.
2020-10-26 30021, 2020
Mr_Monkey
ruaok: I think there's other ways to solve it to be honest
2020-10-26 30034, 2020
Mr_Monkey
No copying !
2020-10-26 30040, 2020
Mr_Monkey
Certainly not.
2020-10-26 30042, 2020
pristine___
Mr_Monkey: do you use fb?
2020-10-26 30059, 2020
Mr_Monkey
If you think it's justifiable ruaok , thn we could do that.
2020-10-26 30001, 2020
ruaok
ok, if you don't feel that we should, then ok. but as a general rule, $100/year isn't much and I like supporting other projects.
2020-10-26 30005, 2020
shivam-kapila
Mr_Monkey: not copying. Sorry. I meant designing
2020-10-26 30021, 2020
Mr_Monkey
Um, not a lot of FB, and pretty heavily modified with scripts.
can we do something like this, the ss I shared above?
2020-10-26 30017, 2020
Mr_Monkey
So, a button with some icon + like text , and when the user hovers over it we show the dropdown. That sounds good to me, especially if that's a choice the FB design team took (suposedly after a good amount of A/B testing)
2020-10-26 30034, 2020
pristine___
yes
2020-10-26 30058, 2020
Mr_Monkey
Personally, design-wise I hate that they're so freaking big, but the mechanism is totally sane
2020-10-26 30018, 2020
pristine___
:p
2020-10-26 30029, 2020
Mr_Monkey
Gosh, I hadn't seen they animated them.
2020-10-26 30041, 2020
pristine___
yeah, it looks cute to me
2020-10-26 30042, 2020
pristine___
:p
2020-10-26 30052, 2020
Mr_Monkey
I feel like I'm back to the days of MSN Messenger…
2020-10-26 30011, 2020
pristine___
so i much work is it? combining text + some icon (I prefer thumbs up here)
2020-10-26 30040, 2020
pristine___
I have no idea how to do that in css
2020-10-26 30042, 2020
pristine___
:(
2020-10-26 30051, 2020
pristine___
ruaok: thanks for the merge :)
2020-10-26 30059, 2020
ruaok
np
2020-10-26 30004, 2020
Mr_Monkey
How much work? well, you already have pretty much everything in place I think. Changing the ellipsis icon to a thumbs up icon with text, and changing the dropdown mechanism to trigger on hover and click
2020-10-26 30044, 2020
pristine___
Ah! sounds *not-that-difficult-to-me*
2020-10-26 30045, 2020
pristine___
:p
2020-10-26 30032, 2020
pristine___
but before moving on to this (text+icon), I think we should resolve the other comments on the PR, ping me when you run the PR on your local machine
2020-10-26 30001, 2020
Gore joined the channel
2020-10-26 30053, 2020
Mr_Monkey
OK, I'm running it now, and got a few comments. Will put them on the PR directly.
2020-10-26 30053, 2020
Mr_Monkey
I'm also going to have a look at the stopPropagation thing.
2020-10-26 30036, 2020
pristine___
Mr_Monkey: I think we don't need the stopPropogation thing if we want to adopt fb stuff. Can you please open fb and try liking/loving/or anything a picture/post?
2020-10-26 30001, 2020
pristine___
I really love the whole process of giving feedback in fb
2020-10-26 30046, 2020
Mr_Monkey
I trust you, to be honest
2020-10-26 30054, 2020
Mr_Monkey
One less problem to solve
2020-10-26 30059, 2020
pristine___
It like hober over the text, click on the feedback icon, the drop down will close and the selected emoji will be displayed in place of the text.
2020-10-26 30054, 2020
pristine___
Mr_Monkey: thanks! I wanted you to have a look since I won't be able to write the whole process :p
2020-10-26 30032, 2020
Mr_Monkey
I think that'll work well
2020-10-26 30052, 2020
pristine___
(And my kids glove can code that)
2020-10-26 30001, 2020
pristine___
:p
2020-10-26 30057, 2020
Mr_Monkey
One thing I'm not convinced by is the look of the icons currently, with the css styling.
2020-10-26 30057, 2020
Mr_Monkey
What I originally had in mind was to use the solid and regular FA icons for hover/non-hover states, instead of using css to change their look
2020-10-26 30058, 2020
pristine___
Regular like? Without color
2020-10-26 30037, 2020
pristine___
Is there a different name/class for regular icon and a solid icon? That ways we won't need css, we can just change the class for hover/non-hover
2020-10-26 30059, 2020
shivam-kapila
Yep
2020-10-26 30045, 2020
Mr_Monkey
Exactly that
2020-10-26 30017, 2020
pristine___
Oh. Cool
2020-10-26 30020, 2020
Mr_Monkey
You'd have something like this to import both styles:
Yes, but simply once as (for example): color: #C62828;
2020-10-26 30020, 2020
Mr_Monkey
And we won't be changing from `color` to `stroke` anymore
2020-10-26 30016, 2020
Mr_Monkey
Which means that hover detection would need to be done in the RecommendationControl component to decide using the solid or regular icon, instead of with CSS
2020-10-26 30036, 2020
Mr_Monkey
You can use something like this in RecControl: ` onMouseEnter={this.toggleHover} onMouseLeave={this.toggleHover}` to detect hovering on the element.
2020-10-26 30036, 2020
Mr_Monkey
`toggleHover` would set a state boolean `hovered`, which you would then use to decide which icon to use, along with a `feedback` *prop*.
2020-10-26 30036, 2020
Mr_Monkey
In short you want this (pseudo code ahead): `if (this.props.feedback === "" && this.state.hoverred) {//use the 'solid' icon} else {//use the 'regular' icon}`
2020-10-26 30050, 2020
Mr_Monkey
Something along those lines in any case
2020-10-26 30043, 2020
Mr_Monkey
I have to run now (family in town) but if you have questions do ask and I'll answer this evening before the meeting.
Really good quality tshirt ruaok ! The print looks really good
2020-10-26 30037, 2020
ruaok
glad to hear that! where was it shippped from?
2020-10-26 30017, 2020
reosarevok
yvanzo: I just saw https://github.com/metabrainz/musicbrainz-server/… - I guess if I literally just want to disable this, the best option is to pass a separate disabled boolean and have disabled={disabled || frozen} but if you prefer something else do let me know
2020-10-26 30054, 2020
alastairp
hi reosarevok
2020-10-26 30011, 2020
alastairp
got some time to talk about languages and language codes?
2020-10-26 30033, 2020
reosarevok
I guess?
2020-10-26 30042, 2020
reosarevok
Have a video meeting in 50 min but nothing before that
we ran into this issue when CatQuest wrote a review and tagged it "no" - Norwegian, rather than one of the two specific languages inside that macrolanguage, Bokmål or Nynorsk
