ruaok: can you ping me when you're around? Got a few questions about LB tests
2020-11-30 33507, 2020
ruaok
Moin. Still Out running some errands... Will ping in an hour or so.
2020-11-30 33502, 2020
alastairp
OK, I'm in no rush. see you later
2020-11-30 33529, 2020
yvanzo
reosarevok: thanks, I fixed it.
2020-11-30 33514, 2020
Nyanko-sensei has quit
2020-11-30 33514, 2020
Nyanko-sensei joined the channel
2020-11-30 33534, 2020
ruaok
hour? whatever. what'cha got, alastairp ?
2020-11-30 33501, 2020
alastairp
ruaok: you added your tests to integration tests. Is that because this was the only place that had the timescale db set up?
2020-11-30 33532, 2020
alastairp
because based on what I understand from these tests, your stuff would fit better in the unit tests (it's just putting in/reading from the db)
2020-11-30 33556, 2020
alastairp
it seems like the integration tests are for testing pipelines - stuff goes in, gets queued, gets picked up, etc)
2020-11-30 33527, 2020
alastairp
it makes sense to me that we create TS tables in the unit tests, and add these playlist tests to the unit tests section
2020-11-30 33545, 2020
ruaok
hmmm.
2020-11-30 33512, 2020
ruaok
I went looking or the API tests and couldn't find them, then remembered that they are in the integration tests, then added the tests there.
2020-11-30 33536, 2020
ruaok
that is to say, I hadn't really considered the question. now that you mentioned it, not sure why that is.
2020-11-30 33512, 2020
ruaok
I can try to move them to unit tests and see if anything asplodes.
2020-11-30 33519, 2020
alastairp
there is a tomato/potato question about what the boundary is between unit/int tests
2020-11-30 33542, 2020
alastairp
my thought was that the integration tests only existed because we had data flowing through a pipeline of multiple services
2020-11-30 33547, 2020
alastairp
*my understanding
2020-11-30 33551, 2020
ruaok
I'm actually with you -- given that we *can* put them in unit tests, why not?
2020-11-30 33556, 2020
alastairp
cool
2020-11-30 33510, 2020
alastairp
I don't mind doing that - because I'm right at the point where I need TS in the unit tests for DB tests
2020-11-30 33525, 2020
ruaok
cool, perfect. thanks.
2020-11-30 33533, 2020
alastairp
so I'll add TS to the test setup, and move yours (after taking a look to see if it fits in with other tests)
2020-11-30 33547, 2020
ruaok
I'll try and focus on finishing that troi branch I promised to have done more than a week ago.
2020-11-30 33555, 2020
ruaok
great
2020-11-30 33538, 2020
ruaok
any chance you can look at the mega branch mbid-mapping soon?
2020-11-30 33538, 2020
alastairp
you said cool, perfect, and thanks. so now I need to come up with another one word reply indicating agreement that doesn't make it seem like i'm just copying you
2020-11-30 33558, 2020
alastairp
I have the tab open, and it's on today's list
2020-11-30 33519, 2020
ruaok
brilliant!
2020-11-30 33523, 2020
ruaok
;-0
2020-11-30 33510, 2020
alastairp
OK, interesting. there are a small handful of view tests in the unit tests, but you're right that all API tests are in integrations.
2020-11-30 33529, 2020
alastairp
definitely something to double-check with iliekcomputers if we can grab his time for 5 minutes
2020-11-30 33528, 2020
abhinavohri joined the channel
2020-11-30 33517, 2020
abhinavohri
@alastairp I have some doubts related to my two PRs.
2020-11-30 33524, 2020
v6lur joined the channel
2020-11-30 33520, 2020
CatQuest
so, how long since I asked to change my email adress on the wiki should I except to get that confirmation email?
2020-11-30 33522, 2020
BestSteve has quit
2020-11-30 33500, 2020
BestSteve joined the channel
2020-11-30 33504, 2020
CatQuest
expect*
2020-11-30 33516, 2020
sumedh has quit
2020-11-30 33548, 2020
sumedh joined the channel
2020-11-30 33525, 2020
bitmap has quit
2020-11-30 33509, 2020
zas
a forum user cannot log in after he changed his email address on MB, known issue?
2020-11-30 33520, 2020
bitmap joined the channel
2020-11-30 33530, 2020
reosarevok
Freso: ^ ?
2020-11-30 33557, 2020
reosarevok
(not known to me)
2020-11-30 33553, 2020
zas
He gets "There is a problem with your account. Please contact the site's administrator" error even from a fresh browser window (new browser, no cookies)
2020-11-30 33510, 2020
reosarevok
This is in discourse, not MB proper, right?
2020-11-30 33515, 2020
zas
yes
2020-11-30 33528, 2020
zas
I'll enable SSO verbose logging and see what's going on
2020-11-30 33533, 2020
reosarevok
Maybe the stuff that should propagate updates to discourse broke or something. I'm not sure how that is set up though
ruaok: I want to run some more database/testing stuff past you
2020-11-30 33513, 2020
ruaok
k
2020-11-30 33502, 2020
alastairp
timescale tests currently drop db/createdb after each test. unit tests don't drop the db, they just remove all of the tables
2020-11-30 33533, 2020
ruaok
I've slowly been working to make TS tests more robust.
2020-11-30 33558, 2020
ruaok
namely, so that sequential tests can be run on the same DB, so that we can setup the DB once for any given test run.
2020-11-30 33511, 2020
alastairp
docker postgres has this functionality to create a db and a user at startup time. I'm wondering if this would be a nice thing to do. In my view it's the correct way to do it
2020-11-30 33516, 2020
ruaok
e.g random user names for each run.
2020-11-30 33532, 2020
alastairp
ah, cool. I think that ties in with the direction that I want to go too, then
2020-11-30 33543, 2020
ruaok
yeah, I think we're on the same path.
2020-11-30 33507, 2020
alastairp
because there are a _lot_ of moving parts here - lots of different test superclasses that do slightly different things
2020-11-30 33518, 2020
ruaok
effectively I want the tests to be ... not idempotent, but.. isolated
2020-11-30 33519, 2020
ruaok
?
2020-11-30 33537, 2020
alastairp
yeah, I see what you mean
2020-11-30 33524, 2020
alastairp
another way I've seen these kind of tests work, at the beginning of each test a transaction is started, and then it's rolled back at the end. This is a lot faster than tearing down database tables after each test
2020-11-30 33529, 2020
alastairp
but that's for another day, I think
2020-11-30 33523, 2020
ruaok
that would work too...
2020-11-30 33538, 2020
alastairp
oh, I guess I understand the reasoning for not creating db on container startup for LB - it's because we have both LB and MsB stuff in the same database cluster
2020-11-30 33540, 2020
alastairp
now I remember
2020-11-30 33531, 2020
alastairp
so now the question is do we keep things consistent between TS and regular PG cluster, or do we do setup differently in each?
2020-11-30 33503, 2020
alastairp
ugh, I'm opening a can of worms here, but for LB dev, there's really no reason to not just use the TS cluster for all 3 databases, right??!
2020-11-30 33511, 2020
ruaok
make TS better. I don't see the importance of consistency here. just document that they do things differently.
2020-11-30 33550, 2020
ruaok
TS can be used for all.
2020-11-30 33516, 2020
ruaok
part of the current state of things is because we haven't drank the kool aid on TS yet.
2020-11-30 33529, 2020
alastairp
I'll open a ticket for that
2020-11-30 33530, 2020
ruaok
but I'm ok with it now. its been solid and I've been enjoying having it.
2020-11-30 33523, 2020
shivam-kapila
Are you talking about migrating postgres stuff to TS in lb
2020-11-30 33556, 2020
alastairp
shivam-kapila: just using the same server process for all databases
2020-11-30 33509, 2020
shivam-kapila
Okay okay
2020-11-30 33509, 2020
alastairp
because timescale _is_ postgres, just with an extension
2020-11-30 33538, 2020
alastairp
so it seems a waste to start 2 postgres servers. Let's just start one, and use it for all 3 of our databases (listens, user data, messybrainz)
