Over the weekend BenOckmore reported that the BB last dump on the ftp was early last month. I spent a bit of time investigating the issue and finished fixing it today.
2020-12-21 35616, 2020
Mr_Monkey
Now to implement an email server to receive cronjob failure alerts !
2020-12-21 35621, 2020
CatQuest
!m BenOckmore & Mr_Monkey
2020-12-21 35621, 2020
BrainzBot
You're doing good work, BenOckmore & Mr_Monkey!
2020-12-21 35625, 2020
Mr_Monkey
That's it for me.
2020-12-21 35628, 2020
Mr_Monkey
ruaok: go !
2020-12-21 35636, 2020
ruaok
yoyoyo
2020-12-21 35644, 2020
Freso
CatQuest: As a Dane, I’ve said a lot of bad things about Sweden this year.
2020-12-21 35651, 2020
CatQuest
lol
2020-12-21 35658, 2020
ruaok
last week was a lot of playlist hacking and also working up some data for the LB xmas present.
2020-12-21 35633, 2020
ruaok
if you've been submitting listens to LB, you should be able to see the tracks that you first submitted in 2020 here:
amazing work! so nice to see all of this work over the last few years turn into super simple "get results quickly" infrastructure
2020-12-21 35635, 2020
CatQuest
I have never heard (of) Endless Boogie before but awesomename!
2020-12-21 35641, 2020
ruaok
the idea is to make two playlist for people in the next couple of days: tracks that you discovered in 2020 (well submitted first) and tracks released in 2020 that you played a few times.
2020-12-21 35649, 2020
ruaok
alastairp: thanks.
2020-12-21 35608, 2020
ruaok
so, yes, it is now easy to produce some pretty complex things with all the work we've been doing.
2020-12-21 35627, 2020
ruaok
we've hoping to release the playlist stuff in production, but call the playlist features "beta".
2020-12-21 35633, 2020
CatQuest
huh so lastfm import no works
2020-12-21 35640, 2020
ruaok
we need it in production in order to be able to make the playlists for other people.
2020-12-21 35606, 2020
ruaok
I really hope we can finish this before xmas. 🤞
2020-12-21 35624, 2020
ruaok
_lucifer: go
2020-12-21 35633, 2020
_lucifer
Hi! all
2020-12-21 35628, 2020
_lucifer
I worked on improving the tests so that the resources (sample xml files) used in MB SOLR become human readable and easier to review.
2020-12-21 35646, 2020
Freso
(Only jmp_music__ left on my list! Last call for anyone else who wants to give review!)
2020-12-21 35618, 2020
_lucifer
Further, as yvanzo completed the work in the sir part, I updated my PRs in the solr for merging.
2020-12-21 35622, 2020
_lucifer
That's it for me.
2020-12-21 35629, 2020
_lucifer
jmp_music__: next?
2020-12-21 35612, 2020
Freso
Or maybe jmp_music__ is not around. :)
2020-12-21 35630, 2020
Freso
Alright, final item on the agenda:
2020-12-21 35635, 2020
Freso
Freso: Next meeting
2020-12-21 35645, 2020
CatQuest
i januar
2020-12-21 35651, 2020
Freso
So, this is just a reminder from last week, that there is no meeting next week!
2020-12-21 35604, 2020
Freso
So the next meeting will be on January 4th!
2020-12-21 35616, 2020
Freso
And that’s all for this item. :p
2020-12-21 35642, 2020
Freso
Still no jmp_music__
2020-12-21 35653, 2020
CatQuest
🎄
2020-12-21 35653, 2020
Freso
So I guess that rounds out the last meeting of this year.
2020-12-21 35609, 2020
_lucifer
Happy holidays to all!
2020-12-21 35639, 2020
Freso
Thank you everyone who gave reviews, everyone who was around, everyone who’s worked on any of all our projects over this year!
2020-12-21 35620, 2020
Mr_Monkey
Buenas Fiestas !
2020-12-21 35628, 2020
CatQuest
God Jul!
2020-12-21 35650, 2020
Freso
Take care of yourselves this holiday season, happy celebrations if you celebrate, and remember to still adhere to all the guidelines. The pandemic is not over yet, so stay safe! ❤️
2020-12-21 35605, 2020
Freso
</BANG>
2020-12-21 35616, 2020
_lucifer
alastairp: aroun?
2020-12-21 35621, 2020
yvanzo
Thanks Freso!
2020-12-21 35631, 2020
Mr_Monkey
Thanks Freso!
2020-12-21 35658, 2020
ruaok
alastairp: when do you want to get moving on the playlist stuff?
2020-12-21 35608, 2020
ruaok wonders if there is time to finish off one more salsa
2020-12-21 35630, 2020
alastairp
ruaok: I just pushed, collaborator tests are working now
2020-12-21 35600, 2020
ruaok
did you make the changes to the API layer too?
2020-12-21 35602, 2020
alastairp
I'm continuing to work on other improvements, but they're not necessary for your stuff. what do you think is next?
2020-12-21 35607, 2020
alastairp
yes, I fixed the API
2020-12-21 35614, 2020
ruaok
great, thanks!
2020-12-21 35638, 2020
ruaok
I think the next thing to do is to consider what remains to be done for us to merge this PR.
2020-12-21 35650, 2020
alastairp
should I do a quick 15 minute review?
2020-12-21 35658, 2020
alastairp
5 minute even
2020-12-21 35658, 2020
ruaok
that would be great.
2020-12-21 35627, 2020
ruaok
my code has no more TODOs in it, so I think I am done. which would be great, so I can focus on the troi work this evening.
2020-12-21 35628, 2020
alastairp
ok, sounds good
2020-12-21 35622, 2020
alastairp
I didn't do private collaborating playlists, will look at that after the review
2020-12-21 35607, 2020
sumedh has quit
2020-12-21 35614, 2020
alastairp
Mr_Monkey: did you add the new spotify permissions?
2020-12-21 35619, 2020
Mr_Monkey
Yes. It'll require users to un-link and re-link their account, and there's a prompt for that if the permissions aren't set for playlists
2020-12-21 35656, 2020
alastairp
ah, I guess I didn't get to that part of the code
2020-12-21 35658, 2020
alastairp
good-o
2020-12-21 35656, 2020
alastairp
_lucifer: hi, sorry. didn't see your question
2020-12-21 35605, 2020
_lucifer
alastairp: I hope to resume work on CB in the coming days and wanted to discuss a few things beforehand in case you are unavailable at that time.
2020-12-21 35621, 2020
alastairp
sure! what's on your mind
2020-12-21 35611, 2020
_lucifer
i just took a look on my pending PRs. the artist and recording ones need tests, i'll try to take that up first. what's the status of the mocks pr? I saw your comment on it.
2020-12-21 35637, 2020
_lucifer
I think if possible we should just increase the timeout for now and merge it
I think there are only 3-4 things that should be addressed for this release, everything else can be improved after the fact
2020-12-21 35601, 2020
Gazooo79494 has quit
2020-12-21 35642, 2020
Gazooo79494 joined the channel
2020-12-21 35633, 2020
ruaok
ok, I'll see about getting all the comments addressed this evening.
2020-12-21 35630, 2020
ruaok
alastairp: was the public in the arg only about not having it in the JSON? I thought there was more to it than that... but I cant recall from the haze of hackdays.
2020-12-21 35607, 2020
ruaok
alastairp: still about?
2020-12-21 35601, 2020
alastairp
ruaok: hi, for ~15m more
2020-12-21 35616, 2020
alastairp
I'm pretty sure that the public arg was because there was nowhere else to put it
2020-12-21 35619, 2020
ruaok
aight, lets hammer out two issues, should be doable.
2020-12-21 35629, 2020
alastairp
which means that we must have decided to not put it in the json?
2020-12-21 35646, 2020
ruaok
ok, I can't recall another reason. I'll make that happen, since it is in the json and the UI needs the flag.
2020-12-21 35602, 2020
alastairp
ah right, that's why it's there. good idea
2020-12-21 35613, 2020
ruaok
I'll do it between commits so if it asplodes then I can back it out.
2020-12-21 35641, 2020
ruaok
comment about listenbrainz/tests/integration/test_playlist_api.py line 654...
when you query with ?offset=0&count=1, I understand that you should get 1 playlist back, but there should be a field that says that there are 2 playlists in total matching this query
2020-12-21 35633, 2020
ruaok
yeah, understand what you are saying now.
2020-12-21 35636, 2020
alastairp
> 'count' is the parameter
2020-12-21 35640, 2020
ruaok
ok, the rest should be doable.
2020-12-21 35640, 2020
alastairp
was probably a bit unclear
2020-12-21 35643, 2020
alastairp
nic
2020-12-21 35644, 2020
alastairp
nice
2020-12-21 35603, 2020
alastairp
I'll add tomorrow morning the private flag to the collaboration db method
2020-12-21 35610, 2020
alastairp
and hook it into the api
2020-12-21 35613, 2020
ruaok
k
2020-12-21 35634, 2020
ruaok
good, because tomorrow I need to be 100% on troi.
2020-12-21 35618, 2020
v6lur has quit
2020-12-21 35610, 2020
Lotheric received a threat because of the leak (I think) :)
2020-12-21 35623, 2020
Lotheric
The guy is asking for a bitcoin deposit lol
2020-12-21 35641, 2020
ruaok
ha!
2020-12-21 35615, 2020
Lotheric
I know ****** is one of your password on day of hack..
2020-12-21 35615, 2020
Lotheric
Lets get directly to the point.
2020-12-21 35615, 2020
Lotheric
Not one person has paid me to check about you.
2020-12-21 35615, 2020
Lotheric
You do not know me and you're probably thinking why you are getting this email?
2020-12-21 35615, 2020
Lotheric
in fact, i actually placed a malware on the...
2020-12-21 35618, 2020
Lotheric
and it goes on
2020-12-21 35648, 2020
Lotheric
it's an old password though, not using it anymore :)
2020-12-21 35607, 2020
ruaok
wait. hang. on.
2020-12-21 35611, 2020
ruaok
an MB password?
2020-12-21 35621, 2020
Lotheric
I think it was yeah in 2019
2020-12-21 35626, 2020
Lotheric
but I changed it
2020-12-21 35637, 2020
ruaok
was something guessable?
2020-12-21 35653, 2020
Lotheric
nope, not even a word from the dictionary
2020-12-21 35622, 2020
ruaok
yvanzo: bitmap reosarevok : did we miss something in our audit???
