#metabrainz

/

      • zas has quit
      • 2020-12-30 36547, 2020

      • zas joined the channel
      • 2020-12-30 36510, 2020

      • d4rkie has quit
      • 2020-12-30 36552, 2020

      • Nyanko-sensei joined the channel
      • 2020-12-30 36540, 2020

      • stechnaz joined the channel
      • 2020-12-30 36517, 2020

      • stechnaz has quit
      • 2020-12-30 36503, 2020

      • BestSteve has quit
      • 2020-12-30 36505, 2020

      • BestSteve joined the channel
      • 2020-12-30 36541, 2020

      • shivam-kapila
        Morning
      • 2020-12-30 36505, 2020

      • shivam-kapila
        Seems like people have now started jumping in.
      • 2020-12-30 36508, 2020

      • shivam-kapila
        Yay!!
      • 2020-12-30 36519, 2020

      • vasharma05 joined the channel
      • 2020-12-30 36530, 2020

      • vasharma05 has quit
      • 2020-12-30 36528, 2020

      • vasharma05 joined the channel
      • 2020-12-30 36527, 2020

      • davic has quit
      • 2020-12-30 36545, 2020

      • BrainzGit
        [critiquebrainz] AbhinavOhri opened pull request #328 (master…change_draft): [CB-392]-After Saving draft, cannot publish without making some change. https://github.com/metabrainz/critiquebrainz/pull…
      • 2020-12-30 36538, 2020

      • sumedh joined the channel
      • 2020-12-30 36532, 2020

      • yokel has quit
      • 2020-12-30 36522, 2020

      • yokel joined the channel
      • 2020-12-30 36538, 2020

      • yokel has quit
      • 2020-12-30 36534, 2020

      • sumedh has quit
      • 2020-12-30 36526, 2020

      • vasharma05
        Hello Everyone! I am Vineet Sharma from NIT Hamirpur and I would love to contribute in here. I am proficient in working in React.js, Node.js and Django. I have gone through bookbrainz website and code-base and have build it up on my local system. Mentors. can you help me with some tickets to start.
      • 2020-12-30 36549, 2020

      • yvanzo
        Hi vasharma05, I’m not into BookBrainz development but you might be interested in https://tickets.metabrainz.org/issues/?jql=projec…
      • 2020-12-30 36509, 2020

      • yvanzo
        Now deploying MB Solr 3.4 on production cloud.
      • 2020-12-30 36532, 2020

      • vasharma05
        Hi yvanzo , thank you for the ticket, I'll be happy to do the work.
      • 2020-12-30 36556, 2020

      • yokel joined the channel
      • 2020-12-30 36559, 2020

      • yvanzo
        vasharma05: no problem, it is a list of tickets actually, so you can pick the ticket you prefer.
      • 2020-12-30 36524, 2020

      • vasharma05
        Sure! Thank you
      • 2020-12-30 36542, 2020

      • yvanzo
        Reloading mbsssss on production cloud.
      • 2020-12-30 36530, 2020

      • sumedh joined the channel
      • 2020-12-30 36543, 2020

      • yvanzo
        Updating SIR on pink for production.
      • 2020-12-30 36511, 2020

      • v6lur joined the channel
      • 2020-12-30 36531, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1840 (master…MBS-10954): MBS-8141 / MBS-10954: Small improvements to Remove DiscId page https://github.com/metabrainz/musicbrainz-server/…
      • 2020-12-30 36538, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1841 (master…MBS-10915): MBS-10915: Show "Remove track" button for data tracks even with discid https://github.com/metabrainz/musicbrainz-server/…
      • 2020-12-30 36501, 2020

      • Gazooo79494 has quit
      • 2020-12-30 36544, 2020

      • Gazooo79494 joined the channel
      • 2020-12-30 36539, 2020

      • yvanzo
        Updating search triggers on floyd in production database.
      • 2020-12-30 36505, 2020

      • CatQuest
        vasharma05: hi! we'd surely welcome more contributors on bookbrainz! <3
      • 2020-12-30 36517, 2020

      • CatQuest
        I see you've also found #bookbrainz
      • 2020-12-30 36520, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1842 (master…MBS-10913): MBS-10913: Show removed standalone recordings as such https://github.com/metabrainz/musicbrainz-server/…
      • 2020-12-30 36555, 2020

      • yvanzo
        Done with updates, just need reindexing artists, recordings, releases, and release groups.
      • 2020-12-30 36523, 2020

      • d4rkie joined the channel
      • 2020-12-30 36522, 2020

      • D4RK-PH0_ has quit
      • 2020-12-30 36509, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1843 (master…MBS-10830): MBS-10830: Only show Remove link if entity can be removed https://github.com/metabrainz/musicbrainz-server/…
      • 2020-12-30 36535, 2020

      • lks has quit
      • 2020-12-30 36547, 2020

      • lks joined the channel
      • 2020-12-30 36506, 2020

      • v6lur has quit
      • 2020-12-30 36509, 2020

      • devorizon
        In pull request https://github.com/metabrainz/listenbrainz-server… , i mistakenly made a new branch over another PR branch which i was working on previously, i can't `git rebase master` the new branch as it is showing me `Current branch is up to date.` ... i think it's because the previous PR branch is also in the commit history of the new branch so it's giving me the same result ..
      • 2020-12-30 36509, 2020

      • devorizon
        can anyone tell me how can i rebase the only commits made in the new branch with master?
      • 2020-12-30 36518, 2020

      • shivam-kapila
        devorizon: please do git rebase -i upstream/master
      • 2020-12-30 36536, 2020

      • shivam-kapila
        Drop the unnecessary commits
      • 2020-12-30 36510, 2020

      • shivam-kapila
        And force push
      • 2020-12-30 36558, 2020

      • Clint
        don't forget to fetch first
      • 2020-12-30 36531, 2020

      • shivam-kapila
        Thanks Clint :)
      • 2020-12-30 36543, 2020

      • devorizon
        > 5:36 PM <shivam-kapila> devorizon: please do git rebase -i upstream/master
      • 2020-12-30 36543, 2020

      • devorizon
        Thanks shivam-kapila :)
      • 2020-12-30 36526, 2020

      • Etua joined the channel
      • 2020-12-30 36541, 2020

      • Etua has quit
      • 2020-12-30 36550, 2020

      • BrainzGit
        [listenbrainz-server] ruuda opened pull request #1215 (master…docs-content-type): Document that Content-Type header is required for submit-listens https://github.com/metabrainz/listenbrainz-server…
      • 2020-12-30 36546, 2020

      • sumedh has quit
      • 2020-12-30 36523, 2020

      • zas
        yvanzo: load on mb solr nodes increased a lot since half an hour, likely related to deployment earlier, but is it expected?
      • 2020-12-30 36509, 2020

      • devorizon
        shivam-kapila:
      • 2020-12-30 36559, 2020

      • devorizon
        shivam-kapila: I would to discuss https://github.com/metabrainz/listenbrainz-server… , `we should pull out the state as a type just like the props`.. are you saying i should put these private variables as a component's state ?
      • 2020-12-30 36543, 2020

      • shivam-kapila
        devorizon: sorry. wasn't clear in the comment
      • 2020-12-30 36500, 2020

      • shivam-kapila
        do you see we have declared a type for props here
      • 2020-12-30 36500, 2020

      • shivam-kapila
      • 2020-12-30 36526, 2020

      • shivam-kapila
        actually I saw now that these are private. nvm please ignore. sorry
      • 2020-12-30 36526, 2020

      • chaban
      • 2020-12-30 36526, 2020

      • BrainzBot
        MBS-11299: ISE when searching for events
      • 2020-12-30 36511, 2020

      • chaban
        There are also reports about 400 Bad Request in the forum: https://community.metabrainz.org/t/20910/166
      • 2020-12-30 36553, 2020

      • shivam-kapila
        devorizon: I have added a comment on the PR for further fixes.
      • 2020-12-30 36544, 2020

      • D4RK-PH0_ joined the channel
      • 2020-12-30 36550, 2020

      • d4rkie has quit
      • 2020-12-30 36530, 2020

      • devorizon
        >8:57 PM <shivam-kapila> devorizon: I have added a comment on the PR for further fixes.
      • 2020-12-30 36530, 2020

      • devorizon
        ok
      • 2020-12-30 36537, 2020

      • sumedh joined the channel
      • 2020-12-30 36518, 2020

      • reosarevok
      • 2020-12-30 36519, 2020

      • BrainzBot
        MBS-11299: ISE when searching for events
      • 2020-12-30 36523, 2020

      • BestSteve has quit
      • 2020-12-30 36556, 2020

      • BestSteve joined the channel
      • 2020-12-30 36511, 2020

      • Lotheric
      • 2020-12-30 36520, 2020

      • Lotheric
        anything that can be done on MB side for it to work ?
      • 2020-12-30 36503, 2020

      • yvanzo
        zas: Yes, I actually reindexed artists, releases and release groups starting from 15:00 CET.
      • 2020-12-30 36518, 2020

      • yvanzo
        I’m trying to reindex recordings soon.
      • 2020-12-30 36548, 2020

      • yvanzo
        reosarevok: no, thanks
      • 2020-12-30 36553, 2020

      • yvanzo
        chaban: fix in progress, thanks for having reported
      • 2020-12-30 36540, 2020

      • yvanzo
        fixed on test.mb.o
      • 2020-12-30 36504, 2020

      • reosarevok
        yvanzo, bitmap: wanna meet or chill today?
      • 2020-12-30 36527, 2020

      • bitmap
        I'm available if there's anything for us to go over
      • 2020-12-30 36500, 2020

      • bitmap
        I reviewed some stuff earlier and left a few small comments, will continue after I eat
      • 2020-12-30 36529, 2020

      • bitmap
        but all the bug fixes should be approved iirc
      • 2020-12-30 36530, 2020

      • yvanzo
        bitmap: Is it possible to lengthen timeout on pink to help with reindexing recordings?
      • 2020-12-30 36514, 2020

      • bitmap
        we can change DETERMINE_MAX_REQUEST_TIME in consul but that's about it
      • 2020-12-30 36559, 2020

      • bitmap
        oh, you mean for DB queries
      • 2020-12-30 36501, 2020

      • yvanzo
        it's for MBS, not PG, right?
      • 2020-12-30 36503, 2020

      • yvanzo
        yes
      • 2020-12-30 36522, 2020

      • bitmap
        yes, you can set that per user or per db
      • 2020-12-30 36539, 2020

      • yvanzo
        sir connects as musicbrainz user
      • 2020-12-30 36526, 2020

      • bitmap
        ah, we can't alter those on the slave though, sorry
      • 2020-12-30 36541, 2020

      • bitmap
        it'd have to be set in the session/transaction
      • 2020-12-30 36502, 2020

      • bitmap
        we should probably have a separate user or modify sir to set statement_timeout
      • 2020-12-30 36502, 2020

      • yvanzo
      • 2020-12-30 36500, 2020

      • davic joined the channel
      • 2020-12-30 36539, 2020

      • BrainzGit
        [mb-solr] release v3.4.1 has been published by yvanzo: https://github.com/metabrainz/mb-solr/releases/ta…
      • 2020-12-30 36547, 2020

      • bitmap
        yeah, probably
      • 2020-12-30 36544, 2020

      • yvanzo
        I will release musicbrainz-docker with SIR for now.
      • 2020-12-30 36551, 2020

      • yvanzo
        s/with/without/
      • 2020-12-30 36556, 2020

      • yvanzo
        Deploying patch to production cloud.
      • 2020-12-30 36558, 2020

      • reosarevok
      • 2020-12-30 36559, 2020

      • BrainzBot
        MBS-11300: Suggested recordings brings bad results
      • 2020-12-30 36554, 2020

      • bitmap
        I could check why it doesn't appear
      • 2020-12-30 36546, 2020

      • bitmap
        hmm. maybe it's different in the context of a larger release but I can't reproduce it if I only add that track in isolation
      • 2020-12-30 36507, 2020

      • bitmap
        it suggests the correct recording as the first result for me
      • 2020-12-30 36553, 2020

      • reosarevok
        Why would it be different in a larger release? D:
      • 2020-12-30 36500, 2020

      • reosarevok
        I forget how the code works I guess
      • 2020-12-30 36512, 2020

      • bitmap
        it shouldn't, but
      • 2020-12-30 36511, 2020

      • sumedh has quit
      • 2020-12-30 36509, 2020

      • yvanzo
        Deployed fix for event search results in prod.
      • 2020-12-30 36536, 2020

      • chaban
        !m yvanzo
      • 2020-12-30 36536, 2020

      • BrainzBot
        You're doing good work, yvanzo!
      • 2020-12-30 36514, 2020

      • yvanzo
        bitmap, reosarevok: recordings are being reindexed at a slow pace but still :)
      • 2020-12-30 36501, 2020

      • Gazooo79494 has quit
      • 2020-12-30 36546, 2020

      • Gazooo79494 joined the channel
      • 2020-12-30 36526, 2020

      • v6lur joined the channel
      • 2020-12-30 36508, 2020

      • yokel has quit
      • 2020-12-30 36517, 2020

      • yokel joined the channel
      • 2020-12-30 36508, 2020

      • v6lur has quit
      • 2020-12-30 36521, 2020

      • d4rkie joined the channel