0:22 AM
zas has quit
0:22 AM
zas joined the channel
0:52 AM
d4rkie has quit
0:52 AM
Nyanko-sensei joined the channel
2:41 AM
stechnaz joined the channel
2:42 AM
stechnaz has quit
4:20 AM
BestSteve has quit
4:23 AM
BestSteve joined the channel
5:13 AM
shivam-kapila
Morning
5:14 AM
Seems like people have now started jumping in.
5:14 AM
Yay!!
5:27 AM
vasharma05 joined the channel
5:40 AM
vasharma05 has quit
5:53 AM
vasharma05 joined the channel
6:32 AM
davic has quit
6:38 AM
BrainzGit
6:41 AM
sumedh joined the channel
7:25 AM
yokel has quit
7:31 AM
yokel joined the channel
7:54 AM
yokel has quit
8:37 AM
sumedh has quit
8:43 AM
vasharma05
Hello Everyone! I am Vineet Sharma from NIT Hamirpur and I would love to contribute in here. I am proficient in working in React.js, Node.js and Django. I have gone through bookbrainz website and code-base and have build it up on my local system. Mentors. can you help me with some tickets to start.
8:50 AM
yvanzo
8:55 AM
Now deploying MB Solr 3.4 on production cloud.
8:55 AM
vasharma05
Hi yvanzo , thank you for the ticket, I'll be happy to do the work.
8:57 AM
yokel joined the channel
8:57 AM
yvanzo
vasharma05: no problem, it is a list of tickets actually, so you can pick the ticket you prefer.
8:58 AM
vasharma05
Sure! Thank you
9:15 AM
yvanzo
Reloading mbsssss on production cloud.
9:21 AM
sumedh joined the channel
9:27 AM
Updating SIR on pink for production.
9:42 AM
v6lur joined the channel
9:45 AM
BrainzGit
10:01 AM
10:05 AM
Gazooo79494 has quit
10:06 AM
Gazooo79494 joined the channel
10:08 AM
yvanzo
Updating search triggers on floyd in production database.
10:17 AM
CatQuest
vasharma05: hi! we'd surely welcome more contributors on bookbrainz! <3
10:17 AM
I see you've also found #bookbrainz
10:18 AM
BrainzGit
10:24 AM
yvanzo
Done with updates, just need reindexing artists, recordings, releases, and release groups.
10:40 AM
d4rkie joined the channel
10:42 AM
D4RK-PH0_ has quit
10:51 AM
BrainzGit
10:58 AM
lks has quit
10:58 AM
lks joined the channel
11:16 AM
v6lur has quit
12:03 PM
devorizon
In pull request
https://github.com/metabrainz/listenbrainz-serv... , i mistakenly made a new branch over another PR branch which i was working on previously, i can't `git rebase master` the new branch as it is showing me `Current branch is up to date.` ... i think it's because the previous PR branch is also in the commit history of the new branch so it's giving me the same result ..
12:03 PM
can anyone tell me how can i rebase the only commits made in the new branch with master?
12:06 PM
shivam-kapila
devorizon: please do git rebase -i upstream/master
12:06 PM
Drop the unnecessary commits
12:07 PM
And force push
12:07 PM
Clint
don't forget to fetch first
12:08 PM
shivam-kapila
Thanks Clint :)
12:32 PM
devorizon
> 5:36 PM <shivam-kapila> devorizon: please do git rebase -i upstream/master
12:32 PM
Thanks shivam-kapila :)
12:43 PM
Etua joined the channel
12:43 PM
Etua has quit
12:45 PM
BrainzGit
13:39 PM
sumedh has quit
14:58 PM
zas
yvanzo: load on mb solr nodes increased a lot since half an hour, likely related to deployment earlier, but is it expected?
15:00 PM
devorizon
shivam-kapila:
15:01 PM
15:15 PM
shivam-kapila
devorizon: sorry. wasn't clear in the comment
15:16 PM
do you see we have declared a type for props here
15:16 PM
15:17 PM
actually I saw now that these are private. nvm please ignore. sorry
15:24 PM
chaban
15:24 PM
BrainzBot
MBS-11299: ISE when searching for events
15:25 PM
chaban
15:27 PM
shivam-kapila
devorizon: I have added a comment on the PR for further fixes.
15:34 PM
D4RK-PH0_ joined the channel
15:37 PM
d4rkie has quit
16:21 PM
devorizon
>8:57 PM <shivam-kapila> devorizon: I have added a comment on the PR for further fixes.
16:21 PM
ok
16:30 PM
sumedh joined the channel
16:41 PM
reosarevok
16:41 PM
BrainzBot
MBS-11299: ISE when searching for events
16:51 PM
BestSteve has quit
16:52 PM
BestSteve joined the channel
16:54 PM
Lotheric
16:54 PM
anything that can be done on MB side for it to work ?
17:02 PM
yvanzo
zas: Yes, I actually reindexed artists, releases and release groups starting from 15:00 CET.
17:02 PM
I’m trying to reindex recordings soon.
17:11 PM
reosarevok: no, thanks
17:31 PM
chaban: fix in progress, thanks for having reported
17:50 PM
fixed on test.mb.o
18:04 PM
reosarevok
yvanzo, bitmap: wanna meet or chill today?
18:06 PM
bitmap
I'm available if there's anything for us to go over
18:07 PM
I reviewed some stuff earlier and left a few small comments, will continue after I eat
18:07 PM
but all the bug fixes should be approved iirc
18:08 PM
yvanzo
bitmap: Is it possible to lengthen timeout on pink to help with reindexing recordings?
18:09 PM
bitmap
we can change DETERMINE_MAX_REQUEST_TIME in consul but that's about it
18:09 PM
oh, you mean for DB queries
18:10 PM
yvanzo
it's for MBS, not PG, right?
18:10 PM
yes
18:10 PM
bitmap
yes, you can set that per user or per db
18:11 PM
yvanzo
sir connects as musicbrainz user
18:16 PM
bitmap
ah, we can't alter those on the slave though, sorry
18:16 PM
it'd have to be set in the session/transaction
18:18 PM
we should probably have a separate user or modify sir to set statement_timeout
18:21 PM
yvanzo
18:22 PM
davic joined the channel
18:22 PM
BrainzGit
18:22 PM
bitmap
yeah, probably
18:23 PM
yvanzo
I will release musicbrainz-docker with SIR for now.
18:23 PM
s/with/without/
18:26 PM
Deploying patch to production cloud.
18:27 PM
reosarevok
18:27 PM
BrainzBot
MBS-11300: Suggested recordings brings bad results
18:28 PM
bitmap
I could check why it doesn't appear
18:39 PM
hmm. maybe it's different in the context of a larger release but I can't reproduce it if I only add that track in isolation
18:40 PM
it suggests the correct recording as the first result for me
18:40 PM
reosarevok
Why would it be different in a larger release? D:
18:41 PM
I forget how the code works I guess
18:41 PM
bitmap
it shouldn't, but
18:43 PM
sumedh has quit
18:46 PM
yvanzo
Deployed fix for event search results in prod.
18:46 PM
chaban
!m yvanzo
18:46 PM
BrainzBot
You're doing good work, yvanzo!
19:20 PM
yvanzo
bitmap, reosarevok: recordings are being reindexed at a slow pace but still :)
20:05 PM
Gazooo79494 has quit
20:06 PM
Gazooo79494 joined the channel
20:14 PM
v6lur joined the channel
20:42 PM
yokel has quit
20:43 PM
yokel joined the channel
23:57 PM
v6lur has quit
23:57 PM
d4rkie joined the channel