but is giving the folowing error `ERROR: not found: /code/listenbrainz/listenbrainz/webserver/static/js/src/LastFMImporterModal.test.tsx
2021-01-04 00402, 2021
devorizon
(no name '/code/listenbrainz/listenbrainz/webserver/static/js/src/LastFMImporterModal.test.tsx' in any of [])`
2021-01-04 00433, 2021
alastairp
hi devorizon, you'll have to use './test.sh fe' to run javascript (frontend) tests
2021-01-04 00419, 2021
alastairp
but looking at the script it looks like there's no way to specify a single test, perhaps Mr_Monkey can chime in here and see if we can add this functionality to `npm test`
You can try adding a double dash before specifying the path (denoting that the argument should be passed to the npm command:
2021-01-04 00406, 2021
Mr_Monkey
`./test.sh fe -- listenbrainz/webserver/static/js/src/LastFMImporterModal.test.tsx` is worth a try
2021-01-04 00421, 2021
alastairp
Mr_Monkey: that won't work, because test.sh doesn't pass arguments to npm test
2021-01-04 00431, 2021
alastairp
but if npm test accepts them, then we should add that
2021-01-04 00437, 2021
Mr_Monkey
Right.
2021-01-04 00433, 2021
Mr_Monkey
running `npm test -- listenbrainz/webserver/static/js/src/LastFMImporterModal.test.tsx` does work to specify a file
2021-01-04 00456, 2021
Mr_Monkey
(and would also allow to pass other command line arguments to jest, I suppose)
2021-01-04 00421, 2021
devorizon
yes it worked.. although i ran jest in watch mode, it also worked. thanks :)
2021-01-04 00435, 2021
Mr_Monkey
devorizon: If you have node installed locally, you can run the front-end tests directly on your machine instead of using the docker setup, by running the commands above in your terminal
2021-01-04 00440, 2021
Mr_Monkey
Ah good :)
2021-01-04 00454, 2021
Mr_Monkey
ishaanshah: Can I assign LB-781 to you? I'm not familiar with any of the listening activity code, so I think you might have better insight.
Hi devorizon i'll have look at the lastfm pr tomorrow
2021-01-04 00415, 2021
devorizon
sure ishaanshah ... thanks :)
2021-01-04 00431, 2021
bitmap
reosarevok: that makes sense, I can look into it
2021-01-04 00435, 2021
shivam-kapila
ishaanshah: hey LTNS. How u doing
2021-01-04 00432, 2021
ruaok will arrive a few mins late today
2021-01-04 00407, 2021
CatQuest
[13:20] <ruaok> wow. the UK won't extradite assange. he got really lucky.
2021-01-04 00407, 2021
CatQuest
thanks for that note
2021-01-04 00407, 2021
CatQuest
2021 is looking better thna the previous already
2021-01-04 00422, 2021
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, MeB (yvanzo)
2021-01-04 00400, 2021
Freso
<BANG>
2021-01-04 00400, 2021
Freso
It’s World Braille Monday and first meeting Monday of 2021!
Wait, yvanzo, did you want to go first or not? I got confused about what we ended up with. :x
2021-01-04 00456, 2021
Mr_Monkey
Happy new year everyone !
2021-01-04 00420, 2021
Freso
If not, reosarevok: go!
2021-01-04 00426, 2021
yvanzo
Hi!
2021-01-04 00431, 2021
Freso
Oh, nvm reo :)(
2021-01-04 00421, 2021
yvanzo
To replace the traditional New Year’s Eve fireworks, here is an animated (2:43) git history of MetaBrainz projects in 2020: https://youtu.be/ZKO-mT_pJcY
2021-01-04 00444, 2021
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews
2021-01-04 00444, 2021
Mr_Monkey
Oh nice !
2021-01-04 00456, 2021
Freso
Nice!
2021-01-04 00407, 2021
shivam-kapila
Wow
2021-01-04 00421, 2021
_lucifer
!m yvanzo
2021-01-04 00421, 2021
BrainzBot
You're doing good work, yvanzo!
2021-01-04 00456, 2021
yvanzo
Most main projects are represented. If you don’t see one main contributor, it’s because they were too productive to be statically represented! :D
2021-01-04 00423, 2021
yvanzo
Since last meeting, I finally updated MB search, see blog post.
2021-01-04 00455, 2021
yvanzo
(It completely defeated the development workflow I posted earlier, so I have to update docs again.)
2021-01-04 00415, 2021
yvanzo
Also found that the bugged .dockerignore file for SIR was similar for most of our Python projects.
2021-01-04 00444, 2021
yvanzo
I already submitted a patch for ListenBrainz, will do the same with other projects.
2021-01-04 00411, 2021
ruaok appears
2021-01-04 00430, 2021
yvanzo
Now I’m trying to catch up with MBS PR reviews.
2021-01-04 00444, 2021
yvanzo
Fin, go ruaok!
2021-01-04 00452, 2021
ruaok
uhm.
2021-01-04 00458, 2021
Freso
(Other people up: reosarevok, Freso, alastairp, bitmap, Mr_Monkey, zas, _lucifer, CatQuest, shivam-kapila, jmp_music – anyone else who want to give review, let me know ASAP. :))
2021-01-04 00400, 2021
ruaok
not much to report. xmas. nye.
2021-01-04 00414, 2021
CatQuest
bill nye the xmas guy
2021-01-04 00419, 2021
ruaok
I reconciled our accounts today and we're $15k in the hole for the year.
2021-01-04 00424, 2021
ruaok
in theory we earned $45k more had those two paid us on time. which for 2020 is a pretty good result, having lost a few customers.
2021-01-04 00458, 2021
ruaok
then last year, just before xmas I managed to deliver the year end playlists, which actually were quite nice, IMHO.
2021-01-04 00413, 2021
Mr_Monkey agrees
2021-01-04 00420, 2021
ruaok
I found one bug, but that was because of a spotify export, something we'll improve with a better mapping in due time.
2021-01-04 00413, 2021
ruaok
but my partner and I listened to our playlists and felt that they were a good reflection of the year and the year review was particularly nice since it limited each artist to 2 tracks, which got me far further down the list of top recordings.
2021-01-04 00440, 2021
ruaok
that was it. tomorrow I have another day of year and stuff and then hopefully on wednesday I can get back to technical work,.
2021-01-04 00444, 2021
ruaok
Mr_Monkey: go
2021-01-04 00448, 2021
Mr_Monkey
Hai !
2021-01-04 00452, 2021
CatQuest
:D
2021-01-04 00444, 2021
Mr_Monkey
Not much to report either since last meeting, mostly fixing the bookbrainz dump cron job that was temporarily broken and finishing up some playlist features before the end of year surprise
2021-01-04 00454, 2021
Mr_Monkey
And quiet celebrations :)
2021-01-04 00457, 2021
CatQuest
:D
2021-01-04 00403, 2021
Mr_Monkey
That's me ! bitmap go !
2021-01-04 00415, 2021
bitmap
hello and happy new years :)
2021-01-04 00428, 2021
ruaok notes that there were zero comments posted to the community post about playlists: https://community.metabrainz.org/t/a-holiday-present-from-the-listenbrainz-team/510364 sigh.
2021-01-04 00443, 2021
bitmap
I didn't accomplish a ton during the holidays, but did work some more on the event art archive UI for MBS
2021-01-04 00458, 2021
bitmap
otherwise I spent a good chunk of time on code review
2021-01-04 00432, 2021
bitmap
and deployed a couple minor things, i.e. the postgres health check fixes we worked on a couple weeks back and a DBDefs fix to enable the recording first release date feature in production
2021-01-04 00459, 2021
bitmap
I think that's about it, so reosarevok go!
2021-01-04 00406, 2021
reosarevok
Hi!
2021-01-04 00420, 2021
CatQuest
:D
2021-01-04 00437, 2021
reosarevok
I had a proper rest for a few days
2021-01-04 00449, 2021
CatQuest
\o/
2021-01-04 00455, 2021
reosarevok
Then I started fixing stuff reported in the last few days
2021-01-04 00415, 2021
reosarevok
I'm really bad at keeping the number of PRs down, sorry bitmap / yvanzo :/
2021-01-04 00426, 2021
reosarevok
Oh, and I merged some stuff :)
2021-01-04 00409, 2021
reosarevok
Think that's about it. CatQuest go?
2021-01-04 00410, 2021
CatQuest
meow!
2021-01-04 00412, 2021
CatQuest
I didn't do anything because holidays and stuff!
2021-01-04 00438, 2021
CatQuest
and I won't be doing much until the 6th either. 13 days of christmas and al lthat
2021-01-04 00407, 2021
CatQuest
but I have started planning. I'll be updating the berimbau and looking into adding the stack of books to bookbrainz
2021-01-04 00447, 2021
CatQuest
other than that it's still "quiet before the storm" here. still dark until 9-10 am you know, norway
2021-01-04 00449, 2021
CatQuest
fin
2021-01-04 00458, 2021
CatQuest
next can be. has zas goen yet? if he has
2021-01-04 00404, 2021
zas
Hey
2021-01-04 00419, 2021
Freso
(Other people up: Freso, alastairp, _lucifer, shivam-kapila, jmp_music – anyone else who want to give review, let me know ASAP. :))
2021-01-04 00446, 2021
zas
I did usual supervision (hopefully nothing bad happened during holidays)
2021-01-04 00405, 2021
zas
user support (mostly unblacklisting)
2021-01-04 00438, 2021
zas
also worked on Picard, we plan 2 new releases very soon (2.5.x stable + 2.6)
2021-01-04 00454, 2021
zas
fin. _lucifer ?
2021-01-04 00428, 2021
Freso
Or… alastairp, go!
2021-01-04 00432, 2021
alastairp
hi
2021-01-04 00422, 2021
alastairp
did a big push the week before christmas to get playlist stuff released - did a bunch of general backend + frontend + deploy + blog post stuff and got it out on the 24th
2021-01-04 00441, 2021
alastairp
then took the rest of the year off, just slowly getting back into code review today
2021-01-04 00451, 2021
alastairp
that's it. Freso?
2021-01-04 00413, 2021
Freso
o/
2021-01-04 00446, 2021
Freso
Not much for me either. Just holing up and reading and studying and having a covid scare (tested negative, and am alright now). Spent a bit of time hardening and reorganising my systems a bit, to hopefully be better to manage things. :x
2021-01-04 00400, 2021
Freso
fin.
2021-01-04 00406, 2021
Freso
shivam-kapila: Around? If so, go!
2021-01-04 00413, 2021
shivam-kapila
Hi
2021-01-04 00421, 2021
CatQuest
💪 freso
2021-01-04 00423, 2021
shivam-kapila
Happy new year guys
2021-01-04 00435, 2021
shivam-kapila
Mostly caught upin uni work till 30
2021-01-04 00440, 2021
CatQuest
🎊
2021-01-04 00451, 2021
shivam-kapila
After that I started working on cover art part
2021-01-04 00402, 2021
Freso
(Only jmp_music__ left on my list, unless _lucifer turns up. :x Last call for others who may want to give review!)
2021-01-04 00402, 2021
shivam-kapila
Helped devorizon a lil
2021-01-04 00412, 2021
shivam-kapila
Some code reviews
2021-01-04 00427, 2021
shivam-kapila
Mr_Monkey: caught a front end issue
2021-01-04 00437, 2021
shivam-kapila
Shot a pr for that
2021-01-04 00416, 2021
shivam-kapila
Thats it... Trying to be more productive
2021-01-04 00422, 2021
shivam-kapila
jmp_music__: go
2021-01-04 00422, 2021
Freso
(Oh, also, I have exam next Monday. I should be around for meeting, but, yeah, studying this week, writing exam next week.)
2021-01-04 00405, 2021
_lucifer
hi all and Happy New Year!!
2021-01-04 00413, 2021
Freso
Oh, _lucifer! Go go!
2021-01-04 00418, 2021
shivam-kapila
(Freso: all the best)
2021-01-04 00420, 2021
Freso
jmp_music__: Ping?
2021-01-04 00430, 2021
Freso
If no jmp_music__, then _lucifer is last to review today. :)
2021-01-04 00434, 2021
CatQuest
all best for freso exames! gambatte!
2021-01-04 00417, 2021
_lucifer
I worked on my existing open prs for CB and opened a PR the playlist updates in LB.
2021-01-04 00430, 2021
_lucifer
that's it for me.
2021-01-04 00454, 2021
Freso
No word from jmp_music__, so I think that’s that for reviews as well!
2021-01-04 00403, 2021
Freso
Thank you everyone who gave reviews!
2021-01-04 00412, 2021
Freso
And thank you everyone who were around for your time!
2021-01-04 00413, 2021
Freso
I hope everyone got safely into Gregorian year 2021; remember to keep your distance, washing yours hands, and wearing a mask! Happy new year's! 🎉 🎉 🎉
2021-01-04 00416, 2021
Freso
</BANG>
2021-01-04 00420, 2021
yvanzo
Thanks Freso!
2021-01-04 00421, 2021
Mr_Monkey
Thanks !
2021-01-04 00438, 2021
shivam-kapila
Thanks!
2021-01-04 00417, 2021
alastairp
kepstin: hmm, your offline musicplayer doesn't let you input mbids? :)
2021-01-04 00409, 2021
alastairp
the ideal would be that your player supports loading xspf, because there's a bunch of resolving things built into that, but you can't have everything I ghuess...
2021-01-04 00417, 2021
kepstin
sure would be nice if you could make a playlist format with mbid URN instead of a filename, eh
2021-01-04 00428, 2021
kepstin
huh, i'm not actually familiar with xspf
2021-01-04 00453, 2021
kepstin
fwiw, i'm using rhythmbox which actually does have mbids in its database, i wonder if i can drop one in the search box
2021-01-04 00436, 2021
kepstin
nope, it doesn't search them :(
2021-01-04 00450, 2021
kepstin
(also it only has the track mbids not recording mbids)
