but is giving the folowing error `ERROR: not found: /code/listenbrainz/listenbrainz/webserver/static/js/src/LastFMImporterModal.test.tsx
(no name '/code/listenbrainz/listenbrainz/webserver/static/js/src/LastFMImporterModal.test.tsx' in any of [])`
alastairp
hi devorizon, you'll have to use './test.sh fe' to run javascript (frontend) tests
but looking at the script it looks like there's no way to specify a single test, perhaps Mr_Monkey can chime in here and see if we can add this functionality to `npm test`
You can try adding a double dash before specifying the path (denoting that the argument should be passed to the npm command:
`./test.sh fe -- listenbrainz/webserver/static/js/src/LastFMImporterModal.test.tsx` is worth a try
alastairp
Mr_Monkey: that won't work, because test.sh doesn't pass arguments to npm test
but if npm test accepts them, then we should add that
Mr_Monkey
Right.
running `npm test -- listenbrainz/webserver/static/js/src/LastFMImporterModal.test.tsx` does work to specify a file
(and would also allow to pass other command line arguments to jest, I suppose)
devorizon
yes it worked.. although i ran jest in watch mode, it also worked. thanks :)
Mr_Monkey
devorizon: If you have node installed locally, you can run the front-end tests directly on your machine instead of using the docker setup, by running the commands above in your terminal
Ah good :)
ishaanshah: Can I assign LB-781 to you? I'm not familiar with any of the listening activity code, so I think you might have better insight.
Hi devorizon i'll have look at the lastfm pr tomorrow
devorizon
sure ishaanshah ... thanks :)
bitmap
reosarevok: that makes sense, I can look into it
shivam-kapila
ishaanshah: hey LTNS. How u doing
ruaok will arrive a few mins late today
CatQuest
[13:20] <ruaok> wow. the UK won't extradite assange. he got really lucky.
thanks for that note
2021 is looking better thna the previous already
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, MeB (yvanzo)
Freso
<BANG>
It’s World Braille Monday and first meeting Monday of 2021!
Wait, yvanzo, did you want to go first or not? I got confused about what we ended up with. :x
Mr_Monkey
Happy new year everyone !
Freso
If not, reosarevok: go!
yvanzo
Hi!
Freso
Oh, nvm reo :)(
yvanzo
To replace the traditional New Year’s Eve fireworks, here is an animated (2:43) git history of MetaBrainz projects in 2020: https://youtu.be/ZKO-mT_pJcY
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews
Mr_Monkey
Oh nice !
Freso
Nice!
shivam-kapila
Wow
_lucifer
!m yvanzo
BrainzBot
You're doing good work, yvanzo!
yvanzo
Most main projects are represented. If you don’t see one main contributor, it’s because they were too productive to be statically represented! :D
Since last meeting, I finally updated MB search, see blog post.
(It completely defeated the development workflow I posted earlier, so I have to update docs again.)
Also found that the bugged .dockerignore file for SIR was similar for most of our Python projects.
I already submitted a patch for ListenBrainz, will do the same with other projects.
ruaok appears
Now I’m trying to catch up with MBS PR reviews.
Fin, go ruaok!
ruaok
uhm.
Freso
(Other people up: reosarevok, Freso, alastairp, bitmap, Mr_Monkey, zas, _lucifer, CatQuest, shivam-kapila, jmp_music – anyone else who want to give review, let me know ASAP. :))
ruaok
not much to report. xmas. nye.
CatQuest
bill nye the xmas guy
ruaok
I reconciled our accounts today and we're $15k in the hole for the year.
in theory we earned $45k more had those two paid us on time. which for 2020 is a pretty good result, having lost a few customers.
then last year, just before xmas I managed to deliver the year end playlists, which actually were quite nice, IMHO.
Mr_Monkey agrees
I found one bug, but that was because of a spotify export, something we'll improve with a better mapping in due time.
but my partner and I listened to our playlists and felt that they were a good reflection of the year and the year review was particularly nice since it limited each artist to 2 tracks, which got me far further down the list of top recordings.
that was it. tomorrow I have another day of year and stuff and then hopefully on wednesday I can get back to technical work,.
Mr_Monkey: go
Mr_Monkey
Hai !
CatQuest
:D
Mr_Monkey
Not much to report either since last meeting, mostly fixing the bookbrainz dump cron job that was temporarily broken and finishing up some playlist features before the end of year surprise
And quiet celebrations :)
CatQuest
:D
Mr_Monkey
That's me ! bitmap go !
bitmap
hello and happy new years :)
ruaok notes that there were zero comments posted to the community post about playlists: https://community.metabrainz.org/t/a-holiday-present-from-the-listenbrainz-team/510364 sigh.
I didn't accomplish a ton during the holidays, but did work some more on the event art archive UI for MBS
otherwise I spent a good chunk of time on code review
and deployed a couple minor things, i.e. the postgres health check fixes we worked on a couple weeks back and a DBDefs fix to enable the recording first release date feature in production
I think that's about it, so reosarevok go!
reosarevok
Hi!
CatQuest
:D
reosarevok
I had a proper rest for a few days
CatQuest
\o/
reosarevok
Then I started fixing stuff reported in the last few days
I'm really bad at keeping the number of PRs down, sorry bitmap / yvanzo :/
Oh, and I merged some stuff :)
Think that's about it. CatQuest go?
CatQuest
meow!
I didn't do anything because holidays and stuff!
and I won't be doing much until the 6th either. 13 days of christmas and al lthat
but I have started planning. I'll be updating the berimbau and looking into adding the stack of books to bookbrainz
other than that it's still "quiet before the storm" here. still dark until 9-10 am you know, norway
fin
next can be. has zas goen yet? if he has
zas
Hey
Freso
(Other people up: Freso, alastairp, _lucifer, shivam-kapila, jmp_music – anyone else who want to give review, let me know ASAP. :))
zas
I did usual supervision (hopefully nothing bad happened during holidays)
user support (mostly unblacklisting)
also worked on Picard, we plan 2 new releases very soon (2.5.x stable + 2.6)
fin. _lucifer ?
Freso
Or… alastairp, go!
alastairp
hi
did a big push the week before christmas to get playlist stuff released - did a bunch of general backend + frontend + deploy + blog post stuff and got it out on the 24th
then took the rest of the year off, just slowly getting back into code review today
that's it. Freso?
Freso
o/
Not much for me either. Just holing up and reading and studying and having a covid scare (tested negative, and am alright now). Spent a bit of time hardening and reorganising my systems a bit, to hopefully be better to manage things. :x
fin.
shivam-kapila: Around? If so, go!
shivam-kapila
Hi
CatQuest
💪 freso
shivam-kapila
Happy new year guys
Mostly caught upin uni work till 30
CatQuest
🎊
shivam-kapila
After that I started working on cover art part
Freso
(Only jmp_music__ left on my list, unless _lucifer turns up. :x Last call for others who may want to give review!)
shivam-kapila
Helped devorizon a lil
Some code reviews
Mr_Monkey: caught a front end issue
Shot a pr for that
Thats it... Trying to be more productive
jmp_music__: go
Freso
(Oh, also, I have exam next Monday. I should be around for meeting, but, yeah, studying this week, writing exam next week.)
_lucifer
hi all and Happy New Year!!
Freso
Oh, _lucifer! Go go!
shivam-kapila
(Freso: all the best)
Freso
jmp_music__: Ping?
If no jmp_music__, then _lucifer is last to review today. :)
CatQuest
all best for freso exames! gambatte!
_lucifer
I worked on my existing open prs for CB and opened a PR the playlist updates in LB.
that's it for me.
Freso
No word from jmp_music__, so I think that’s that for reviews as well!
Thank you everyone who gave reviews!
And thank you everyone who were around for your time!
I hope everyone got safely into Gregorian year 2021; remember to keep your distance, washing yours hands, and wearing a mask! Happy new year's! 🎉 🎉 🎉
</BANG>
yvanzo
Thanks Freso!
Mr_Monkey
Thanks !
shivam-kapila
Thanks!
alastairp
kepstin: hmm, your offline musicplayer doesn't let you input mbids? :)
the ideal would be that your player supports loading xspf, because there's a bunch of resolving things built into that, but you can't have everything I ghuess...
kepstin
sure would be nice if you could make a playlist format with mbid URN instead of a filename, eh
huh, i'm not actually familiar with xspf
fwiw, i'm using rhythmbox which actually does have mbids in its database, i wonder if i can drop one in the search box
nope, it doesn't search them :(
(also it only has the track mbids not recording mbids)