#metabrainz

[bookbrainz-site] LordSputnik opened pull request #546 (master…webpack5): Migrate to Webpack 5 and improve bundle size https://github.com/bookbrainz/bookbrainz-site/p...

mo’’in’

updating beta.mb.o

updating mb.o

done with both

!m yvanzo

You're doing good work, yvanzo!

reosarevok: blog post is available for review

Lemme see

yvanzo: added one word, seems fine to me :)

Thanks!

hi Lyto and _lucifer, the link appears to work for me too - take note that it's on an ftp site, not http and your connection may be doing funny things with it

alastairp: hi!

yeah that's a poosibility

I have added the tests for editor to BU as well. These database tests however only work with Python3. I tried testing with Python2 but they fail due to some encoding errors.

It might be possible to make the tests work with Python2 byt changing the test data used but I am not sure if its worth the effort.

specifically, chrome (and I believe firefox now too?), don't support ftp natively any more. on my mac it passed off the download to finder.

I don't mind not supporting those tests in python2

early this year I should look at finalising the python3 migration for AB

great

really, the main focus here is jmp_music__'s work on integrating scikit-learn.

we have to make sure that it's integrated through the whole model training pipeline, and then ensure that the models using both the old and new system are approximately equal

we did a lot of work on that over the last year, so I'm quite happy with it

I do not have any other particular tasks at hand currently so I can take that up.

Is there some document or ticket which I can read to get upto date on work, alastairp ?

great, let's organise a time to have a quick chat with jmp_music__ about what he's done and what's missing

I'll write up some quick notes about all of the things that we need and we can see what step we're up to

great, thanks!

_lucifer: https://docs.google.com/document/d/1OWRDEdGbYqC...

hello

happy new year!

these are the 4 key features that we need. We're still looking at testing the first two items, but you could definitely continue with the third one

iliekcomputers: !!!

hi! how are you?

moin!

hi alastairp, hi iliekcomputers!

long time no see!

alastairp: good good, last 3 months at work were quite busy. i took 3 weeks off for the new years, just getting back now. :D

congrats on shipping the playlists, they look really nice!

thanks. loads of cleanup still...

ooh, we moved off travis to jenkins, nice

we got a lot of shit done in the past 3 months. :)

yeah, trying to follow your lead in lots of small incremental improvements

Hey iliekcomputers, happy new year to you too!

hey zas, _lucifer !

zas: I cleaned up ~10gb of images from williams, but I think that the amount of free space is low enough that this will always be a problem if we don't move stuff

do you have some thoughts? I'll try and update test scripts to clean up better, I don't know why they weren't doing it

otherwise we look at moving jenkins? :/

if jenkins is using the disk space, then lets.

having the FTP site AND jenkins on one machine is bound to create diskspace issues.

lets find a machine that has more free diskspace and move there. it would be easier than moving the FTP to the storage box.

which would likely affect FTP speeds.

theoretically, if we get it to clean up after itself it should use no more than 1 version of the image per test run

but that's still looking at many gb given how many tests we have now

my guess is that recording's first release date increased search indexes dumps and maybe JSON dumps too.

it still sounds like a diskspace heavy task that might be best elsewhere.

yvanzo: very likely yes.

OK. I'm happy to try and tackle the migration if someone suggests a new location

zas: do you have an idea for another server?

iliekcomputers: hey, while I have you here, can you give my user (alastairp) on readthedocs admin on listenbrainz? I see that you're the only other admin there :)

yes, sure.

ruaok: you asked me to ping you after we had finished doing playlist stuff to remind you to configure https on similarity.acoustibcrainz.org on bono

ah yes.

where does that installation live, again?

/home/acousticbrainz/acousticbrainz-server

using the docker-compose.yml file in that directory

I think your docker-compose foo is stronger than mine... I just got used to using docker run commands from a shell script.

what needs doing?

making a gist

Mr_Monkey: ruaok: I'm teaching the next 3 weeks on weds and thurs, plus the newer restrictions and recommendations I'm not sure I'll make it into the office this week

maybe next week I'll see how things are going and see if Friday works

agreed, this week I have too much other stuff that needs doing.

friday would be better than wed for me now.

ruaok: is the network flag necessary for LE, or is it just what you use to link your containers to have access to the mb database?

alastairp: LE

alastairp: Sure, I was also thinking of staying in this week at least

but its both, really, alastairp

can you please un-vim?

done

but what the LE container does is look for HTTP ports that get exposed from containers. if it finds some and these magic variables are set, it configures the HTTPS LE bits and the proxy.

once you bring your container up, look at the output from the le container.

btw, I suspect that the trick that you were after was this: https://docs.docker.com/compose/networking/#use...

to link to an external network you have to define it first before using it in the service

yes, I've used that trick before.

and I have that code laying around in some docker compose file, I just couldnt find it last time I looked.

oh. funkwhale on a personal VM. heh.

ruaok: just in case it helps: what I use as a setup in a lot of projects is having nginx proxy + letsencrypt installed with the compose file at https://github.com/phw/docker-nginx-proxy-letse...

we use the same stuff. yay. :)

> Creating/renewal similarity.acousticbrainz.org certificates... (similarity.acousticbrainz.org)

with a separate project. then the actual project also uses the same network + the variables

that's some serious black magic, thansk!

alastairp: yeah, I'd normally be opposed to that, but it turns out to be quite solid.

Mr_Monkey: dry hopping now

Yum !

updating mb.o for logs sanity

alastairp: what's your username on rtd?

alastairp

[musicbrainz-server] reosarevok opened pull request #1855 (master…MBS-11324): MBS-11324: Trim input in the barcode otherlookups field https://github.com/metabrainz/musicbrainz-serve...

added

thanks

ah, now I can see the build failure

yvanzo: logs sanity as in?

reosarevok: thanks for the blog post, I just published it.

reosarevok: checking cover art presence, see https://github.com/metabrainz/musicbrainz-serve...

[musicbrainz-docker] release v-2021-01-11 has been published by yvanzo: https://github.com/metabrainz/musicbrainz-docke...

reosarevok: it was bugged already but rarely triggered until then.

Oh, ok. Good catch, thanks

Good catch from zas actually ^

New stuff that needs changing keeps appearing even before I'm done with the previous one :D

updating beta.mb.o too

ruaok, alastairp: you want to move jenkins somewhere else? can it run on a hetzner VM? does it depend on mb-hetzner infrastructure (consul etc...)?

it has no requirements on other hetzner infrastructure

although I think bitmap has a few processes that do work on jenkins and then put the data somewhere, but I guess that's just an rsync

ok, let's wait for bitmap then, and we'll decide what to do

ruaok: I thought about kiki, I think we should just replace the machine, with new OS & SSDs, but can we still have the second interface as an option? I would go for AX41-NVME since they provide more cores. That's the time to upgrade our scripts to fit new Ubuntu versions.

So the plan would be to switch to herb (fully, with mbstats)

and just replace kiki hardware

then I need some time to configure it properly and adapt scripts to new OS, so we are a bit weak for few days... (herb's failure is always possible)

or do we have one rack space left?