[musicbrainz-server] reosarevok merged pull request #1931 (master…MBS-10076): MBS-10076 / MBS-11403: Friendlier error when deleting attribute that has children https://github.com/metabrainz/musicbrainz-server/…
ruaok: do we want to make creating dataframes and calculating user similarity two different steps or should a request for similarity implicitly create the dataframes?
2021-03-03 06234, 2021
_lucifer
iliekcomputers: ^
2021-03-03 06208, 2021
ruaok
can creating dataframes be a common step for recommendations and user similarity?
2021-03-03 06219, 2021
ruaok
in which case, separate, clearly.
2021-03-03 06248, 2021
_lucifer
yes but i think the time periods will almost always differ
2021-03-03 06205, 2021
_lucifer
we are thinking in years for similarity but weeks for recommendations
2021-03-03 06217, 2021
ruaok
ok, so data reuse is not likely then. but code reuse -- is it the same code at least?
2021-03-03 06239, 2021
_lucifer
yeah, i am doing that. code will definelty be reused.
2021-03-03 06200, 2021
ruaok
the lets keep it as two steps to keep things similar to how recs are being generated.
I put the event time on the right in the end despite my initial reaction yesterday, otherwise the mobile view is really going to be a nightmare
2021-03-03 06223, 2021
Mr_Monkey
shivam-kapila: you were right about the time ! :p
2021-03-03 06241, 2021
iliekcomputers
ruaok: we didn't consider one thing.
2021-03-03 06250, 2021
iliekcomputers
i want to keep these endpoints in a separate blueprint.
2021-03-03 06213, 2021
iliekcomputers
so it'd be great if the prefix could be `/1/timeline-event`
2021-03-03 06209, 2021
ruaok
but its an action done for a specific user, so I feel that it should be under /1/user/<user_name>
2021-03-03 06220, 2021
iliekcomputers
hmm.
2021-03-03 06233, 2021
ruaok
otherwise this API endpoint is not consistent with our other user focused endpoints.
2021-03-03 06250, 2021
iliekcomputers
yeah, thinking about it, you're right.
2021-03-03 06200, 2021
iliekcomputers
i'll change it.
2021-03-03 06219, 2021
ruaok
I'm reading tests now, will submit review soon.
2021-03-03 06207, 2021
ruaok
`Token plsnohack` lol
2021-03-03 06234, 2021
ruaok
submitted.
2021-03-03 06238, 2021
iliekcomputers
:D
2021-03-03 06201, 2021
Rohan_Pillai has quit
2021-03-03 06218, 2021
MajorLurker joined the channel
2021-03-03 06250, 2021
MajorLurker has quit
2021-03-03 06224, 2021
sumedh has quit
2021-03-03 06248, 2021
shivam-kapila
Mr_Monkey: haha. atj also voted for the same. Meanwhile I have a small feedback
2021-03-03 06202, 2021
shivam-kapila
The icons on circles look a bit misaligned
2021-03-03 06204, 2021
shivam-kapila
In*
2021-03-03 06249, 2021
shivam-kapila
(Maybe because they arent symmetric along the vertical)
2021-03-03 06257, 2021
Mr_Monkey
Yeah, I'm stacking two FA icons (one circle, one icon on top) and scaling them, and haven't gotten to either tuning it or replacing it with CSS
2021-03-03 06232, 2021
Mr_Monkey
Not sure how consistent the vertical spacing is between icons. We'll see.
2021-03-03 06209, 2021
shivam-kapila
Hm. Overall it looks soothing to eyes
2021-03-03 06216, 2021
Sophist-UK has quit
2021-03-03 06223, 2021
Rohan_Pillai joined the channel
2021-03-03 06217, 2021
Sophist-UK joined the channel
2021-03-03 06215, 2021
Rohan_Pillai has quit
2021-03-03 06218, 2021
reosarevok
Jeez, that like button on my similar artists page is a bit *too* Facebook, isn't it?
2021-03-03 06238, 2021
reosarevok
I guess it's not trademarked or anything, but maybe we can make it a bit less blatant :D
2021-03-03 06259, 2021
zas
Why a Spotify Premium account is required to play listens on lb?
2021-03-03 06214, 2021
ruaok
there are several reasons. one is a permissions thing that we need that comes with premium, I think. I don't recall the details. and listening to 30 second previews is only a shit experience...
2021-03-03 06220, 2021
Mr_Monkey
zas: We can only play full songs in a webpage for users with a premium Spotify account. Currently the backup solution (Youtube player) is broken.
2021-03-03 06253, 2021
zas
Since most of my listens come from Bandcamp, I'd expect to be able to play them from there instead, but I guess this will come at some point.
2021-03-03 06232, 2021
Mr_Monkey
Bandcamp doesn't offer an API to play music unfortunately
2021-03-03 06247, 2021
Mr_Monkey
They do provide embedded players though
2021-03-03 06214, 2021
Mr_Monkey
But no search API. Provided the listen has a bandcamp URI we should be able to play it in the embedded player
2021-03-03 06258, 2021
atj
Bandcamp URIs are per release 99% of the time
2021-03-03 06200, 2021
zas
yes, even though that's a bit tricky, as we discussed before, the URI alone doesn't suffice to embed the player, as one needs id
2021-03-03 06207, 2021
ruaok
_lucifer: ping
2021-03-03 06215, 2021
_lucifer
ruaok: pong
2021-03-03 06228, 2021
ruaok
hey, I finally have time to do some hacking.
2021-03-03 06248, 2021
ruaok
the existing PR implemented most of what I had intended to do, so its not clear what I should work on next.
2021-03-03 06252, 2021
CatQuest
honestly i prefer listening to music per-album anyway so...
2021-03-03 06200, 2021
Mr_Monkey
I think currently the issue with Bandcamp URIs in the listens is that we only have the album URI, not that of the song
2021-03-03 06207, 2021
ruaok
is there anything on the python/lemmy side I can help with on user similarity?
2021-03-03 06208, 2021
Mr_Monkey
Ah, that was just mentionned :p
2021-03-03 06219, 2021
_lucifer
great, I just updated the branch refactor dataframe code for reuse.
2021-03-03 06223, 2021
reosarevok
Mr_Monkey, zas: if an MBID exists, the MB data might have a Bandcamp link
2021-03-03 06237, 2021
Mr_Monkey
But similarly, to an album page presumably?
2021-03-03 06255, 2021
reosarevok
(when MB has a release bandcamp link, a bot could probably fairly trivially link the recordings to the track pages)
2021-03-03 06255, 2021
_lucifer
not really, i just need to know the format of messages expected by the lb side.
2021-03-03 06256, 2021
zas
yes, but for the album, not for the track, so we need something to look to the album's containing the recording
