[musicbrainz-server] reosarevok merged pull request #1931 (master…MBS-10076): MBS-10076 / MBS-11403: Friendlier error when deleting attribute that has children https://github.com/metabrainz/musicbrainz-serve...
ruaok: do we want to make creating dataframes and calculating user similarity two different steps or should a request for similarity implicitly create the dataframes?
iliekcomputers: ^
ruaok
can creating dataframes be a common step for recommendations and user similarity?
in which case, separate, clearly.
_lucifer
yes but i think the time periods will almost always differ
we are thinking in years for similarity but weeks for recommendations
ruaok
ok, so data reuse is not likely then. but code reuse -- is it the same code at least?
_lucifer
yeah, i am doing that. code will definelty be reused.
ruaok
the lets keep it as two steps to keep things similar to how recs are being generated.
I put the event time on the right in the end despite my initial reaction yesterday, otherwise the mobile view is really going to be a nightmare
shivam-kapila: you were right about the time ! :p
iliekcomputers
ruaok: we didn't consider one thing.
i want to keep these endpoints in a separate blueprint.
so it'd be great if the prefix could be `/1/timeline-event`
ruaok
but its an action done for a specific user, so I feel that it should be under /1/user/<user_name>
iliekcomputers
hmm.
ruaok
otherwise this API endpoint is not consistent with our other user focused endpoints.
iliekcomputers
yeah, thinking about it, you're right.
i'll change it.
ruaok
I'm reading tests now, will submit review soon.
`Token plsnohack` lol
submitted.
iliekcomputers
:D
Rohan_Pillai has quit
MajorLurker joined the channel
MajorLurker has quit
sumedh has quit
shivam-kapila
Mr_Monkey: haha. atj also voted for the same. Meanwhile I have a small feedback
The icons on circles look a bit misaligned
In*
(Maybe because they arent symmetric along the vertical)
Mr_Monkey
Yeah, I'm stacking two FA icons (one circle, one icon on top) and scaling them, and haven't gotten to either tuning it or replacing it with CSS
Not sure how consistent the vertical spacing is between icons. We'll see.
shivam-kapila
Hm. Overall it looks soothing to eyes
Sophist-UK has quit
Rohan_Pillai joined the channel
Sophist-UK joined the channel
Rohan_Pillai has quit
reosarevok
Jeez, that like button on my similar artists page is a bit *too* Facebook, isn't it?
I guess it's not trademarked or anything, but maybe we can make it a bit less blatant :D
zas
Why a Spotify Premium account is required to play listens on lb?
ruaok
there are several reasons. one is a permissions thing that we need that comes with premium, I think. I don't recall the details. and listening to 30 second previews is only a shit experience...
Mr_Monkey
zas: We can only play full songs in a webpage for users with a premium Spotify account. Currently the backup solution (Youtube player) is broken.
zas
Since most of my listens come from Bandcamp, I'd expect to be able to play them from there instead, but I guess this will come at some point.
Mr_Monkey
Bandcamp doesn't offer an API to play music unfortunately
They do provide embedded players though
But no search API. Provided the listen has a bandcamp URI we should be able to play it in the embedded player
atj
Bandcamp URIs are per release 99% of the time
zas
yes, even though that's a bit tricky, as we discussed before, the URI alone doesn't suffice to embed the player, as one needs id
ruaok
_lucifer: ping
_lucifer
ruaok: pong
ruaok
hey, I finally have time to do some hacking.
the existing PR implemented most of what I had intended to do, so its not clear what I should work on next.
CatQuest
honestly i prefer listening to music per-album anyway so...
Mr_Monkey
I think currently the issue with Bandcamp URIs in the listens is that we only have the album URI, not that of the song
ruaok
is there anything on the python/lemmy side I can help with on user similarity?
Mr_Monkey
Ah, that was just mentionned :p
_lucifer
great, I just updated the branch refactor dataframe code for reuse.
reosarevok
Mr_Monkey, zas: if an MBID exists, the MB data might have a Bandcamp link
Mr_Monkey
But similarly, to an album page presumably?
reosarevok
(when MB has a release bandcamp link, a bot could probably fairly trivially link the recordings to the track pages)
_lucifer
not really, i just need to know the format of messages expected by the lb side.
zas
yes, but for the album, not for the track, so we need something to look to the album's containing the recording