#metabrainz

/

      • alastairp
        _lucifer: sorry, did we finalise a decision on tags?
      • 2021-04-16 10607, 2021

      • _lucifer
        alastairp: i have pushed a change to match with regex for now but we can discuss again when you are available.
      • 2021-04-16 10616, 2021

      • _lucifer
      • 2021-04-16 10618, 2021

      • alastairp
        that's fine by me
      • 2021-04-16 10637, 2021

      • alastairp
      • 2021-04-16 10643, 2021

      • alastairp
      • 2021-04-16 10650, 2021

      • alastairp
        man I love Air NZ
      • 2021-04-16 10607, 2021

      • _lucifer
        cool, let me know when you have reviewed the two GH action PRs. I'll merge and test it once.
      • 2021-04-16 10614, 2021

      • alastairp
        (context: quarantine-free travel between AU and NZ, plus https://en.wikipedia.org/wiki/Underarm_bowling_in…)
      • 2021-04-16 10611, 2021

      • Mr_Monkey
        ruaok: The PR looks pretty good, although there are parts I'm ill equipped to review.
      • 2021-04-16 10611, 2021

      • Mr_Monkey
        Reviewed my own front-end code too, looks like nothing's missing.
      • 2021-04-16 10649, 2021

      • ruaok
        yay. the PR still needs quite a bit of cleanup, but thanks!
      • 2021-04-16 10657, 2021

      • shivam-kapila
        *and
      • 2021-04-16 10651, 2021

      • Mr_Monkey
        So apparently, even though the LB documentation says "A minimal payload must include track_metadata/artist_name and track_metadata/track_name elements" it's currently possible to submit listens without those elements.
      • 2021-04-16 10605, 2021

      • Mr_Monkey
        This is what it looks like on the front-end https://usercontent.irccloud-cdn.com/file/zfoVwlf…
      • 2021-04-16 10649, 2021

      • Mr_Monkey
        In this case, there are artist_ and recording_ MBIDs, so perhaps we could add a check and fetch the metadata accordingly before inserting the listen?
      • 2021-04-16 10639, 2021

      • Mr_Monkey
        Otherwise, perhaps we should not allow submitting listens with that missing data?
      • 2021-04-16 10643, 2021

      • Mr_Monkey
        IMO if the MBIDs are there the listen should be accepted and augmented with the relevant metadata.
      • 2021-04-16 10608, 2021

      • Mr_Monkey
        I create LB-870 to track that
      • 2021-04-16 10609, 2021

      • BrainzBot
        LB-870: If track/artist names are missing, listens are blank on the page https://tickets.metabrainz.org/browse/LB-870
      • 2021-04-16 10618, 2021

      • shivam-kapila
      • 2021-04-16 10625, 2021

      • shivam-kapila
        Line 170
      • 2021-04-16 10636, 2021

      • shivam-kapila
        Line 157 sorry
      • 2021-04-16 10600, 2021

      • shivam-kapila
        In this case its not missing rather those are empty strings
      • 2021-04-16 10603, 2021

      • alastairp
        interesting, that doesn't look good
      • 2021-04-16 10612, 2021

      • alastairp
        but we also check against empty strings
      • 2021-04-16 10643, 2021

      • alastairp
        though, this data is transformed in a few places between the db and the api, so we could double-check that the data in the db is actually correct
      • 2021-04-16 10623, 2021

      • shivam-kapila
        > but we also check against empty strings
      • 2021-04-16 10624, 2021

      • shivam-kapila
        Umm. Where. I dont remember this.
      • 2021-04-16 10611, 2021

      • Mr_Monkey
        that `if not listen['track_metadata']['track_name']:` check does not fail for empty strings
      • 2021-04-16 10626, 2021

      • shivam-kapila
        Yeah. I also suspected that. Although I was confused
      • 2021-04-16 10656, 2021

      • alastairp
        shivam-kapila: did you know that you can click on a line number and link to it directly? :)
      • 2021-04-16 10627, 2021

      • shivam-kapila
        Yep. But I am using the android app which doesnt support that yet
      • 2021-04-16 10627, 2021

      • alastairp
        oh
      • 2021-04-16 10643, 2021

      • alastairp
        Mr_Monkey: maybe we can grab 10 minutes this afternoon to verify this?
      • 2021-04-16 10650, 2021

      • Mr_Monkey
        Sure thing
      • 2021-04-16 10616, 2021

      • Mr_Monkey
        I mean, I ran a quick test on an online python editor and confirmed it :)
      • 2021-04-16 10618, 2021

      • Mr_Monkey
      • 2021-04-16 10650, 2021

      • _lucifer
        ruaok: it appears we'll have to deal with the dependencies manually anyways. the workers nodes do not use docker so we need to manually install python packages on all machines.
      • 2021-04-16 10659, 2021

      • Mr_Monkey
        We could also look at LB-731 while looking at listen validation
      • 2021-04-16 10600, 2021

      • BrainzBot
        LB-731: Should users be allowed to submit listens in the future? https://tickets.metabrainz.org/browse/LB-731
      • 2021-04-16 10650, 2021

      • Mr_Monkey
        ruaok: I confirm that as expected the pagination PR on test.lb fixes tickets LB-701 and LB-862, that's great :)
      • 2021-04-16 10651, 2021

      • BrainzBot
        LB-701: My listen page is almost empty https://tickets.metabrainz.org/browse/LB-701
      • 2021-04-16 10651, 2021

      • BrainzBot
        LB-862: Listens view broken after deleting last.fm imported tracks https://tickets.metabrainz.org/browse/LB-862
      • 2021-04-16 10607, 2021

      • _lucifer
        alastairp: were you able to take a look again at the GH actions PR?
      • 2021-04-16 10657, 2021

      • alastairp
        _lucifer: approved
      • 2021-04-16 10617, 2021

      • _lucifer
        thanks! :D I'll merge.
      • 2021-04-16 10620, 2021

      • alastairp
        I suspect we'll need to disable the jobs in Jenkins too to stop it from also trying to run tests?
      • 2021-04-16 10641, 2021

      • _lucifer
        yes, we'll need to do that
      • 2021-04-16 10614, 2021

      • BrainzGit
        [listenbrainz-server] amCap1712 merged pull request #1385 (master…gh): Ciao Jenkins! https://github.com/metabrainz/listenbrainz-server…
      • 2021-04-16 10625, 2021

      • _lucifer
        alastairp, should i go ahead and disable?
      • 2021-04-16 10604, 2021

      • sumedh has quit
      • 2021-04-16 10650, 2021

      • sumedh joined the channel
      • 2021-04-16 10622, 2021

      • alastairp
        _lucifer: what about existing PRs? They're going to have to rebase against master to get the workflow files?
      • 2021-04-16 10626, 2021

      • _lucifer
        alastairp: no i think they would work out of the box.
      • 2021-04-16 10644, 2021

      • _lucifer
        let me see if i have an open PR and push a commit to it.
      • 2021-04-16 10656, 2021

      • _lucifer
        alastairp: https://github.com/metabrainz/listenbrainz-server… it picked up automatically
      • 2021-04-16 10637, 2021

      • alastairp
        oh great, thanks for checking
      • 2021-04-16 10624, 2021

      • _lucifer
        let's disable jenkins projects then?
      • 2021-04-16 10628, 2021

      • alastairp
        yes!
      • 2021-04-16 10630, 2021

      • BrainzGit
        [listenbrainz-server] amCap1712 merged pull request #1386 (master…deploy-image): Automatically build and push image to Docker Hub when new tag is pushed https://github.com/metabrainz/listenbrainz-server…
      • 2021-04-16 10655, 2021

      • _lucifer
        jenkins projects disabled!
      • 2021-04-16 10621, 2021

      • ruaok
        Mr_Monkey: since you were talking about the "current playing" feature of brainzplayer.... given the current state of things, I think we should have the player do absolutely nothing until it is called upon to do something. I think we should load an LB logo or LB like brainz player logo into that place as a placeholder....
      • 2021-04-16 10648, 2021

      • ruaok
        _lucifer: are GH actions enabled in our projects now?
      • 2021-04-16 10604, 2021

      • _lucifer
        ruaok: in LB and BU
      • 2021-04-16 10653, 2021

      • ruaok
        how do I invoke it to test a project?
      • 2021-04-16 10654, 2021

      • _lucifer
        i am going to push a tag and test if the docker push workflow works
      • 2021-04-16 10602, 2021

      • _lucifer
        just open a PR
      • 2021-04-16 10612, 2021

      • ruaok
        is already open.
      • 2021-04-16 10613, 2021

      • _lucifer
        or push a commit to an existing one
      • 2021-04-16 10616, 2021

      • _lucifer
        ruaok, we don't have the test on comment facility yet.
      • 2021-04-16 10638, 2021

      • _lucifer
        i am looking into it. we can probably add that soon
      • 2021-04-16 10643, 2021

      • ruaok
        ok, no rush.
      • 2021-04-16 10648, 2021

      • ruaok
        push on commit is fine for now.
      • 2021-04-16 10648, 2021

      • _lucifer
        but you can re run test using the UI in case needed. the old branches need to be updated with a commit and it'll start to work.
      • 2021-04-16 10633, 2021

      • ruaok
        ok, approaching a commit, so we'll see.
      • 2021-04-16 10643, 2021

      • ruaok
        so, is the new cluster pretty much the one were using now?
      • 2021-04-16 10614, 2021

      • _lucifer
        yes
      • 2021-04-16 10631, 2021

      • _lucifer
        some jobs are failing because they need 3rd party python packages
      • 2021-04-16 10639, 2021

      • _lucifer
        but otherwise its working fine
      • 2021-04-16 10607, 2021

      • ruaok
        ok, please make sure that you have nothing critical remaining on the old cluster. I'd love to stop paying for those machines.
      • 2021-04-16 10612, 2021

      • _lucifer
        we can either install those packages manually or need to find a way to automate that
      • 2021-04-16 10625, 2021

      • ruaok
        zas: ok for me to get rid of the old spark machines? or do you want to keep any of them?
      • 2021-04-16 10628, 2021

      • _lucifer
        yup, i don't have anything on the old cluster.
      • 2021-04-16 10640, 2021

      • ruaok
        great.
      • 2021-04-16 10646, 2021

      • sumedh has quit
      • 2021-04-16 10617, 2021

      • ruaok
        alastairp: did you have more feedback on the big PR? if you do, I could address them now.
      • 2021-04-16 10636, 2021

      • ruaok
        ohh, look at those new shiny icons.
      • 2021-04-16 10627, 2021

      • ruaok
        fast too.
      • 2021-04-16 10629, 2021

      • ruaok
        !m _lucifer
      • 2021-04-16 10629, 2021

      • BrainzBot
        You're doing good work, _lucifer!
      • 2021-04-16 10632, 2021

      • _lucifer
        alastairp as well :D
      • 2021-04-16 10633, 2021

      • BrainzGit
        [musicbrainz-docker] yvanzo merged pull request #190 (master…search-readme): Improve documentation for setting up solr https://github.com/metabrainz/musicbrainz-docker/…
      • 2021-04-16 10633, 2021

      • ruaok wonders how long kilroy was in our codebase
      • 2021-04-16 10658, 2021

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #1391 (master…dependabot/npm_and_yarn/ssri-6.0.2): [Security] Bump ssri from 6.0.1 to 6.0.2 https://github.com/metabrainz/listenbrainz-server…
      • 2021-04-16 10647, 2021

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #1392 (production…dependabot/npm_and_yarn/production/ssri-6.0.2): [Security] Bump ssri from 6.0.1 to 6.0.2 https://github.com/metabrainz/listenbrainz-server…
      • 2021-04-16 10655, 2021

      • t440Music joined the channel
      • 2021-04-16 10617, 2021

      • t440Music
        hello
      • 2021-04-16 10635, 2021

      • ruaok
        good evening.
      • 2021-04-16 10657, 2021

      • t440Music
        I'm having an issue installing a standalone server
      • 2021-04-16 10614, 2021

      • ruaok
        are you using the method that uses docker?
      • 2021-04-16 10600, 2021

      • t440Music
        I think I'm using github
      • 2021-04-16 10615, 2021

      • t440Music
        didn't see anything for docker
      • 2021-04-16 10641, 2021

      • ruaok
      • 2021-04-16 10601, 2021

      • ruaok
        this is the method we support these days. we don't really wish it on anyone to install it by hand.
      • 2021-04-16 10643, 2021

      • t440Music
        thanks I'll give it a try and if I get lost again I'll be back
      • 2021-04-16 10648, 2021

      • t440Music
        ty
      • 2021-04-16 10612, 2021

      • t440Music has quit
      • 2021-04-16 10628, 2021

      • BrainzGit
        [critiquebrainz] dependabot-preview[bot] opened pull request #359 (master…dependabot/npm_and_yarn/ssri-6.0.2): [Security] Bump ssri from 6.0.1 to 6.0.2 https://github.com/metabrainz/critiquebrainz/pull…