ruaok: The PR looks pretty good, although there are parts I'm ill equipped to review.
Reviewed my own front-end code too, looks like nothing's missing.
ruaok
yay. the PR still needs quite a bit of cleanup, but thanks!
shivam-kapila
*and
Mr_Monkey
So apparently, even though the LB documentation says "A minimal payload must include track_metadata/artist_name and track_metadata/track_name elements" it's currently possible to submit listens without those elements.
ruaok: it appears we'll have to deal with the dependencies manually anyways. the workers nodes do not use docker so we need to manually install python packages on all machines.
Mr_Monkey
We could also look at LB-731 while looking at listen validation
[listenbrainz-server] amCap1712 merged pull request #1386 (master…deploy-image): Automatically build and push image to Docker Hub when new tag is pushed https://github.com/metabrainz/listenbrainz-serv...
_lucifer
jenkins projects disabled!
ruaok
Mr_Monkey: since you were talking about the "current playing" feature of brainzplayer.... given the current state of things, I think we should have the player do absolutely nothing until it is called upon to do something. I think we should load an LB logo or LB like brainz player logo into that place as a placeholder....
_lucifer: are GH actions enabled in our projects now?
_lucifer
ruaok: in LB and BU
ruaok
how do I invoke it to test a project?
_lucifer
i am going to push a tag and test if the docker push workflow works
just open a PR
ruaok
is already open.
_lucifer
or push a commit to an existing one
ruaok, we don't have the test on comment facility yet.
i am looking into it. we can probably add that soon
ruaok
ok, no rush.
push on commit is fine for now.
_lucifer
but you can re run test using the UI in case needed. the old branches need to be updated with a commit and it'll start to work.
ruaok
ok, approaching a commit, so we'll see.
so, is the new cluster pretty much the one were using now?
_lucifer
yes
some jobs are failing because they need 3rd party python packages
but otherwise its working fine
ruaok
ok, please make sure that you have nothing critical remaining on the old cluster. I'd love to stop paying for those machines.
_lucifer
we can either install those packages manually or need to find a way to automate that
ruaok
zas: ok for me to get rid of the old spark machines? or do you want to keep any of them?
_lucifer
yup, i don't have anything on the old cluster.
ruaok
great.
sumedh has quit
alastairp: did you have more feedback on the big PR? if you do, I could address them now.
[listenbrainz-server] dependabot-preview[bot] opened pull request #1391 (master…dependabot/npm_and_yarn/ssri-6.0.2): [Security] Bump ssri from 6.0.1 to 6.0.2 https://github.com/metabrainz/listenbrainz-serv...
[listenbrainz-server] dependabot-preview[bot] opened pull request #1392 (production…dependabot/npm_and_yarn/production/ssri-6.0.2): [Security] Bump ssri from 6.0.1 to 6.0.2 https://github.com/metabrainz/listenbrainz-serv...
t440Music joined the channel
t440Music
hello
ruaok
good evening.
t440Music
I'm having an issue installing a standalone server
this is the method we support these days. we don't really wish it on anyone to install it by hand.
t440Music
thanks I'll give it a try and if I get lost again I'll be back
ty
t440Music has quit
BrainzGit
[critiquebrainz] dependabot-preview[bot] opened pull request #359 (master…dependabot/npm_and_yarn/ssri-6.0.2): [Security] Bump ssri from 6.0.1 to 6.0.2 https://github.com/metabrainz/critiquebrainz/pu...