#metabrainz

_lucifer: sorry, did we finalise a decision on tags?

alastairp: i have pushed a change to match with regex for now but we can discuss again when you are available.

that's fine by me

man I love Air NZ

cool, let me know when you have reviewed the two GH action PRs. I'll merge and test it once.

(context: quarantine-free travel between AU and NZ, plus https://en.wikipedia.org/wiki/Underarm_bowling_...)

ruaok: The PR looks pretty good, although there are parts I'm ill equipped to review.

Reviewed my own front-end code too, looks like nothing's missing.

yay. the PR still needs quite a bit of cleanup, but thanks!

*and

So apparently, even though the LB documentation says "A minimal payload must include track_metadata/artist_name and track_metadata/track_name elements" it's currently possible to submit listens without those elements.

This is what it looks like on the front-end https://usercontent.irccloud-cdn.com/file/zfoVw...

In this case, there are artist_ and recording_ MBIDs, so perhaps we could add a check and fetch the metadata accordingly before inserting the listen?

Otherwise, perhaps we should not allow submitting listens with that missing data?

IMO if the MBIDs are there the listen should be accepted and augmented with the relevant metadata.

I create LB-870 to track that

LB-870: If track/artist names are missing, listens are blank on the page https://tickets.metabrainz.org/browse/LB-870

But we do validate this here. https://www.github.com/metabrainz/listenbrainz-...

Line 170

Line 157 sorry

In this case its not missing rather those are empty strings

interesting, that doesn't look good

but we also check against empty strings

though, this data is transformed in a few places between the db and the api, so we could double-check that the data in the db is actually correct

> but we also check against empty strings

Umm. Where. I dont remember this.

that `if not listen['track_metadata']['track_name']:` check does not fail for empty strings

Yeah. I also suspected that. Although I was confused

shivam-kapila: did you know that you can click on a line number and link to it directly? :)

Yep. But I am using the android app which doesnt support that yet

oh

Mr_Monkey: maybe we can grab 10 minutes this afternoon to verify this?

Sure thing

I mean, I ran a quick test on an online python editor and confirmed it :)

ruaok: it appears we'll have to deal with the dependencies manually anyways. the workers nodes do not use docker so we need to manually install python packages on all machines.

We could also look at LB-731 while looking at listen validation

LB-731: Should users be allowed to submit listens in the future? https://tickets.metabrainz.org/browse/LB-731

ruaok: I confirm that as expected the pagination PR on test.lb fixes tickets LB-701 and LB-862, that's great :)

LB-701: My listen page is almost empty https://tickets.metabrainz.org/browse/LB-701

LB-862: Listens view broken after deleting last.fm imported tracks https://tickets.metabrainz.org/browse/LB-862

alastairp: were you able to take a look again at the GH actions PR?

_lucifer: approved

thanks! :D I'll merge.

I suspect we'll need to disable the jobs in Jenkins too to stop it from also trying to run tests?

yes, we'll need to do that

[listenbrainz-server] amCap1712 merged pull request #1385 (master…gh): Ciao Jenkins! https://github.com/metabrainz/listenbrainz-serv...

alastairp, should i go ahead and disable?

_lucifer: what about existing PRs? They're going to have to rebase against master to get the workflow files?

alastairp: no i think they would work out of the box.

let me see if i have an open PR and push a commit to it.

oh great, thanks for checking

let's disable jenkins projects then?

yes!

[listenbrainz-server] amCap1712 merged pull request #1386 (master…deploy-image): Automatically build and push image to Docker Hub when new tag is pushed https://github.com/metabrainz/listenbrainz-serv...

jenkins projects disabled!

Mr_Monkey: since you were talking about the "current playing" feature of brainzplayer.... given the current state of things, I think we should have the player do absolutely nothing until it is called upon to do something. I think we should load an LB logo or LB like brainz player logo into that place as a placeholder....

_lucifer: are GH actions enabled in our projects now?

ruaok: in LB and BU

how do I invoke it to test a project?

i am going to push a tag and test if the docker push workflow works

just open a PR

is already open.

or push a commit to an existing one

ruaok, we don't have the test on comment facility yet.

i am looking into it. we can probably add that soon

ok, no rush.

push on commit is fine for now.

but you can re run test using the UI in case needed. the old branches need to be updated with a commit and it'll start to work.

ok, approaching a commit, so we'll see.

so, is the new cluster pretty much the one were using now?

yes

some jobs are failing because they need 3rd party python packages

but otherwise its working fine

ok, please make sure that you have nothing critical remaining on the old cluster. I'd love to stop paying for those machines.

we can either install those packages manually or need to find a way to automate that

zas: ok for me to get rid of the old spark machines? or do you want to keep any of them?

yup, i don't have anything on the old cluster.

great.

alastairp: did you have more feedback on the big PR? if you do, I could address them now.

ohh, look at those new shiny icons.

fast too.

!m _lucifer

You're doing good work, _lucifer!

alastairp as well :D

[musicbrainz-docker] yvanzo merged pull request #190 (master…search-readme): Improve documentation for setting up solr https://github.com/metabrainz/musicbrainz-docke...

[listenbrainz-server] dependabot-preview[bot] opened pull request #1391 (master…dependabot/npm_and_yarn/ssri-6.0.2): [Security] Bump ssri from 6.0.1 to 6.0.2 https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] dependabot-preview[bot] opened pull request #1392 (production…dependabot/npm_and_yarn/production/ssri-6.0.2): [Security] Bump ssri from 6.0.1 to 6.0.2 https://github.com/metabrainz/listenbrainz-serv...

hello

good evening.

I'm having an issue installing a standalone server

are you using the method that uses docker?

I think I'm using github

didn't see anything for docker

this is the method we support these days. we don't really wish it on anyone to install it by hand.

thanks I'll give it a try and if I get lost again I'll be back

ty

[critiquebrainz] dependabot-preview[bot] opened pull request #359 (master…dependabot/npm_and_yarn/ssri-6.0.2): [Security] Bump ssri from 6.0.1 to 6.0.2 https://github.com/metabrainz/critiquebrainz/pu...