ruaok: The PR looks pretty good, although there are parts I'm ill equipped to review.
2021-04-16 10611, 2021
Mr_Monkey
Reviewed my own front-end code too, looks like nothing's missing.
2021-04-16 10649, 2021
ruaok
yay. the PR still needs quite a bit of cleanup, but thanks!
2021-04-16 10657, 2021
shivam-kapila
*and
2021-04-16 10651, 2021
Mr_Monkey
So apparently, even though the LB documentation says "A minimal payload must include track_metadata/artist_name and track_metadata/track_name elements" it's currently possible to submit listens without those elements.
ruaok: it appears we'll have to deal with the dependencies manually anyways. the workers nodes do not use docker so we need to manually install python packages on all machines.
2021-04-16 10659, 2021
Mr_Monkey
We could also look at LB-731 while looking at listen validation
[listenbrainz-server] amCap1712 merged pull request #1386 (master…deploy-image): Automatically build and push image to Docker Hub when new tag is pushed https://github.com/metabrainz/listenbrainz-server…
2021-04-16 10655, 2021
_lucifer
jenkins projects disabled!
2021-04-16 10621, 2021
ruaok
Mr_Monkey: since you were talking about the "current playing" feature of brainzplayer.... given the current state of things, I think we should have the player do absolutely nothing until it is called upon to do something. I think we should load an LB logo or LB like brainz player logo into that place as a placeholder....
2021-04-16 10648, 2021
ruaok
_lucifer: are GH actions enabled in our projects now?
2021-04-16 10604, 2021
_lucifer
ruaok: in LB and BU
2021-04-16 10653, 2021
ruaok
how do I invoke it to test a project?
2021-04-16 10654, 2021
_lucifer
i am going to push a tag and test if the docker push workflow works
2021-04-16 10602, 2021
_lucifer
just open a PR
2021-04-16 10612, 2021
ruaok
is already open.
2021-04-16 10613, 2021
_lucifer
or push a commit to an existing one
2021-04-16 10616, 2021
_lucifer
ruaok, we don't have the test on comment facility yet.
2021-04-16 10638, 2021
_lucifer
i am looking into it. we can probably add that soon
2021-04-16 10643, 2021
ruaok
ok, no rush.
2021-04-16 10648, 2021
ruaok
push on commit is fine for now.
2021-04-16 10648, 2021
_lucifer
but you can re run test using the UI in case needed. the old branches need to be updated with a commit and it'll start to work.
2021-04-16 10633, 2021
ruaok
ok, approaching a commit, so we'll see.
2021-04-16 10643, 2021
ruaok
so, is the new cluster pretty much the one were using now?
2021-04-16 10614, 2021
_lucifer
yes
2021-04-16 10631, 2021
_lucifer
some jobs are failing because they need 3rd party python packages
2021-04-16 10639, 2021
_lucifer
but otherwise its working fine
2021-04-16 10607, 2021
ruaok
ok, please make sure that you have nothing critical remaining on the old cluster. I'd love to stop paying for those machines.
2021-04-16 10612, 2021
_lucifer
we can either install those packages manually or need to find a way to automate that
2021-04-16 10625, 2021
ruaok
zas: ok for me to get rid of the old spark machines? or do you want to keep any of them?
2021-04-16 10628, 2021
_lucifer
yup, i don't have anything on the old cluster.
2021-04-16 10640, 2021
ruaok
great.
2021-04-16 10646, 2021
sumedh has quit
2021-04-16 10617, 2021
ruaok
alastairp: did you have more feedback on the big PR? if you do, I could address them now.
[listenbrainz-server] dependabot-preview[bot] opened pull request #1391 (master…dependabot/npm_and_yarn/ssri-6.0.2): [Security] Bump ssri from 6.0.1 to 6.0.2 https://github.com/metabrainz/listenbrainz-server…
2021-04-16 10647, 2021
BrainzGit
[listenbrainz-server] dependabot-preview[bot] opened pull request #1392 (production…dependabot/npm_and_yarn/production/ssri-6.0.2): [Security] Bump ssri from 6.0.1 to 6.0.2 https://github.com/metabrainz/listenbrainz-server…
2021-04-16 10655, 2021
t440Music joined the channel
2021-04-16 10617, 2021
t440Music
hello
2021-04-16 10635, 2021
ruaok
good evening.
2021-04-16 10657, 2021
t440Music
I'm having an issue installing a standalone server
this is the method we support these days. we don't really wish it on anyone to install it by hand.
2021-04-16 10643, 2021
t440Music
thanks I'll give it a try and if I get lost again I'll be back
2021-04-16 10648, 2021
t440Music
ty
2021-04-16 10612, 2021
t440Music has quit
2021-04-16 10628, 2021
BrainzGit
[critiquebrainz] dependabot-preview[bot] opened pull request #359 (master…dependabot/npm_and_yarn/ssri-6.0.2): [Security] Bump ssri from 6.0.1 to 6.0.2 https://github.com/metabrainz/critiquebrainz/pull…
