I think it should work in this way: if the lowlevel data contains an MBID it is used to store the submission in the database, if it does not contains the MBID we check the submission usind the md5!
alastairp
but for now I'm not sure we should have a generic endpoint. I think it makes sense to have our normal one, and one for the datasets
Then later, if we want to accept non mbid submissions to general ab, we can merge them
The main reason here is that in general submissions we should not discard duplicate md5 submissions
ariscop joined the channel
Our policy is to always keep duplicates
hellska
So for now I just follow the endpoints as defined in the API doc using an url_prefix /api/v1/datasets
alastairp
However, for the dataset system, we have slightly different requirements. Because we don't have mbids to group by, we need to use the md5s as our deduplication system
Yeah, that's how I would do it
hellska
for duplicates actually the md5 check if a submission is already present and discard the data, but according to your comment we should keep the data even if a duplicae exists?!
alastairp
Hmm, really?
alastairp checks
Are you confusing this with the data sha256?
hellska
no! in fact this not yet implemented :P but this was my idea…
alastairp
Ah, right. Sorry
I think we should discard duplicates based on md5 for the dataset submission, but not for the general submission
hellska
Ok, cool, I start implementing the dataset item submission!
in the API I mean …
alastairp
Cool
Mike_Aiir joined the channel
hellska
I open a ticket in JIRA for that
alastairp
Great
armalcolite
alastairp: reminder(PR's). :)
Mike_Aiir
Hey guys, quick question. I see from logs a couple of days ago someone else was having problems getting search server running and it looks like we were having the same error
I finally got all the indexes built on our server
and now it's telling me it couldn't load the "artist index: null" (does the same for all the others too, recording, release etc...)
and then shows errors like "Caused by: java.lang.RuntimeException: javax.xml.bind.JAXBException: Provider com.sun.xml.bind.v2.ContextFactory could not be instantiated: javax.xml.bind.JAXBException: "com.jthink.brainz.mmd" doesnt contain ObjectFactory.class or jaxb.index"
this is within tomcat7 error log when it's trying to startup the server
ruaok: hey. what are you up to today? Got some time to talk about some jamendo stuff?
ruaok
Possibly in a bit. Headed to BCN at 15:30.
alastairp
Ok. Ping me if you have time
armalcolite96 joined the channel
armalcolite96 has quit
Lotheric joined the channel
ruaok
Ping.
For a few, anyway...
alastairp
I'm at lunch :(
Perhaps I'll forward you the email.
We had some discussion around making sure their core catalog is in acoustid and MB. I think Martin is a little confused about how the parts all fit together still
ruaok
k. I'll be online and off here and there. 18h25 - 20h VST for sure (VST = Vueling Standard Time)
and yeah, there are some odd things happening with jamendo we need to compare notes on.
alastairp
OK, let's punt to later in the week if you want. Perhaps over a beer?
ruaok
thats fine. zas arrives tomorrow. maybe the 4 of us can go for one.
armalcolite96 joined the channel
armalcolite96 has quit
alastairp
Freso: we're downloading their data for audiocommons
Freso
alastairp: In FLAC?
alastairp
Ofc
Freso
🙌
Freso seemed to have some problems getting to the FLACs last he browsed around their site
armalcolite96 joined the channel
armalcolite96 has quit
alastairp
I have a magic API key. Not sure what super powers it gives me
armalcolite96 joined the channel
armalcolite96 has quit
armalcolite joined the channel
armalcolite has quit
jesus2099 joined the channel
armalcolite joined the channel
armalcolite has quit
Slurpee joined the channel
armalcolite joined the channel
armalcolite has quit
hey, what's the status of the bitbucket mbserver mirror?
our mb install is so old that bb is still our origin, I was confused that the schema release wasn't there