#metabrainz

/

      • alastairp
        zas: yes, I found a bug
      • Sorry, didn't notify you
      • kartikgupta0909 joined the channel
      • kartikgupta0909
        I started my AB server, logged in with my ID and when I click on generate API nothing is happening
      • When I check the api_key table , that is empty too
      • anybody knows why is that happening?
      • Gentlecat ^
      • Gentlecat
        no, I don't know what's happening
      • you need to give more information
      • ZarkBit has quit
      • ZarkBit joined the channel
      • kartikgupta0909
      • Gentlecat
        "GET /static/profile.js HTTP/1.1" 404
      • build static files
      • kartikgupta0909
        it worked after building the static files
      • ariscop has quit
      • Gentlecat
        great 👍
      • ariscop joined the channel
      • D4RK-PH0ENiX has quit
      • D4RK-PH0ENiX joined the channel
      • D4RK-PH0ENiX has quit
      • D4RK-PH0ENiX joined the channel
      • MBJenkins
        Project acousticbrainz-server build #164: SUCCESS in 7 min 45 sec: https://ci.metabrainz.org/job/acousticbrainz-se...
      • kartikgupta0909
        alastairp: Hi
      • modwizcode
        Freso: totally, but nobody uses /away (and therefore nobody notice it) and then people contact you and it's bad.
      • hecanjog joined the channel
      • Freso
        modwizcode: I use it. A lot of client will tell you that the client you're /query'ing is marked as /away. /whois'ing someone will tell if they're away (and also their idle time). Some client use the /whois query to check whether people in a given room are away or not and mark them appropriately. Also, how is it bad?
      • modwizcode
        Because Hexchat is a pain and doesn't collect your mentions (afaict) and my bouncer only does it sorta
      • Honestly I need to write an IRC client myself some time, or significantly rework Hexchat
      • Freso
        My setup of my client doesn
      • t collect mentions either, but I just PageUp until I reach my mention(s) and everything is fine.
      • modwizcode
        I have too much backlog. Not here but on Esper there is a lot of chat. More than a 500 line buffer, often more than 1000 lines. Between days.
      • Freso
        Yes?
      • modwizcode
        So I just miss the messages.
      • Freso
        I sometimes have to PgUp 1000's of messages to catch a mention (which was often a tab mis-completion...).
      • modwizcode
        Yeah I don't particularly like that
      • reosarevok
        that sounds awful
      • Leftmost mentions Freso.
      • modwizcode makes a bot to randomly mention Freso
      • Freso
        A lot of times a mention will have context without my nick in it, before and/or after the mention, so I will have to read surrounding talk anyway.
      • ariscop has quit
      • chirlu
        modwizcode: ^
      • ;-)
      • modwizcode
        lol
      • Leftmost
        I just assume people are talking to or about me, regardless of whether another person's name is in place.
      • alastairp
        hi kartikgupta0909
      • Gentlecat
        alastairp: is dmitry around?
      • alastairp
        I don't knwo
      • Gentlecat
        ok
      • kartikgupta0909
        I made a commit with an API endpoint for retreiving th list of all jobs for a user which have to evaluated remotely.
      • And also posted the details on the jira ticket
      • about the communication between the server and client
      • Gentlecat
        doesn't look like he is :(
      • kartikgupta0909
        have a look when you get time
      • alastairp
        what ticket did you put details on?
      • I saw the PR. unfortunately I think we'll have to make some pretty major changes
      • there are a handful of things that we should change. Many of them are things that I've mentioned in previous tickets. let's try and get them right again this time
      • I'll add some comments to the PR. see what you think
      • kartikgupta0909
      • snartal joined the channel
      • alastairp: can you explain me the user logging in part. I didnt really get how it works
      • snartal has quit
      • alastairp
        if you perform an http query to an endpoint that requires you to be logged in, you can set a header "Authorization: Token [your token]", and it will log you in
      • then in the flask view you will have access to the `current_user` variable
      • MBJenkins
        Yippee, build fixed!
      • Project listenbrainz-server build #91: FIXED in 1 min 32 sec: https://ci.metabrainz.org/job/listenbrainz-serv...
      • djwhitey
        any update on a new search-server war file? :)
      • kartikgupta0909
        alastairp: cant we use the API key being given to us by the user (stored in a config file with the client)instead of making them log in?
      • alastairp
        that's what we do
      • if you make an API call with the key in the header, then it will log you in
      • kartikgupta0909
        oh okay, I dont really know how the authentication API works, never worked with one before.
      • and then I can access the user's details using the current user variable?
      • alastairp
        that's fine. we're here to learn
      • you can try it. add the @auth_required decorator to your endpoint
      • you can see an example in api datasets.py
      • then you can try and access it from requests in python or with curl
      • kartikgupta0909
        cool then. I ll have a look and fix the issues.
      • alastairp
      • (assuming that's what you set the name of the blueprint/method to)
      • it should return the http 401 errpr
      • kartikgupta0909
        yeah so I ll name the blueprint dataset-eval
      • alastairp
        but then you can do the query with curl -H "Authorization: Token [your key]" http://localhost/api/v1/dataset-eval/datasets-f...
      • and it should return your data
      • kartikgupta0909
        can you tell me an api endpoint which does something with the API key of the user?
      • I mean it actually uses it for something
      • so that I can refer to it
      • alastairp
        there are 2 in datasets.py in the api
      • kartikgupta0909
        delete dataset has it
      • alastairp
        perhaps you could open a new PR without this initial commit.
      • so that we don't have these methods moving around the files
      • I'd also like to see tests included in the initial pull request
      • gcilou joined the channel
      • armalcolite
        alastairp, just a quick question. Probably Gentlecat can help as well.
      • should tests in a single test class need to be independent?
      • alastairp
        yes
      • no test method should depend on another one having run first
      • armalcolite
        i think i conveyed it wrong
      • alastairp
        in fact, some testing tools run tests in a different random order each time in order to remind you not to do this
      • ok, try again :)
      • armalcolite
        for example, i have 4 tests each of which need to call the multiple functions in the view before testing the final function.
      • djpretzel joined the channel
      • so should i prevent those calls and create the condition using manual SQL inserts.
      • alastairp
        I would
      • armalcolite
        this would mean strict testing of that function
      • alastairp
        it depends
      • if you can call a database write method directly to insert the data, you could do that
      • and then call the final view
      • armalcolite
        this is where i require this
      • to test session i need to do a bunch of things, but they need to be tested as well.
      • it one of them fails, then at least 2 test fail( one is their separate test, and the other one is this one)
      • diana_olhovyk_ has quit
      • s/it/if
      • alastairp
        it's not a huge problem if a failure in method 1 causes the tests for method 2 and 3 to fail too
      • as long as you also have tests for method 1
      • armalcolite
        yeah, i have separate tests for each method in a class
      • Slurpee has quit
      • JesseW joined the channel
      • yeeeargh joined the channel
      • JesseW has quit
      • regagain joined the channel
      • diana_olhovyk joined the channel
      • diana_olhovyk has quit
      • MBJenkins
        Project acousticbrainz-server build #165: SUCCESS in 7 min 46 sec: https://ci.metabrainz.org/job/acousticbrainz-se...
      • kartikgupta0909 has quit
      • gcilou has quit
      • Mineo joined the channel
      • mihaitish has quit
      • zas
        chirlu: DWNI fixed their firewall, rsync should work as expected now.
      • diana_olhovyk_ joined the channel
      • Freso
        Leftmost: Which is why I only talk about you in /query's so you can't read along.
      • zas: How much work would it be to set the old forums back up?
      • zas
        what do you mean ? setting up as RO access ? or ?
      • Freso
        That, or just putting it live as it was, or in some other way re-enabling access to it.
      • Unlike the mailing lists, the forums posts aren't really available elsewhere. :/
      • diana_olhovyk_ has quit
      • fqtw_ joined the channel
      • fqtw has quit
      • LordSputnik
        QuoraUK: a little busy today, mind if I skip the meeting? If you want, do a quick recap of your day and I'll have a read through later!!
      • Zastai joined the channel
      • JonnyJD joined the channel
      • QuoraUK
        LordSputnik: sure, no problem. Basically I got the recruiter achievement done and pushed. Also making a start on refactoring the profile page branch ready to merge into the dummy functions one.
      • Relationship expert to do tommorow and then we are onto the testing, documentation and refactoring stage
      • MArmstrong joined the channel
      • MArmstrong has quit
      • Zastai
        given a relationship entity in a template, what's the correct way of getting the source/target entity's _localized_ type name? rel.source_type and rel.target_type return the internal names (release_group)
      • reosarevok
        IIRC localisation is l('whatever')
      • Zastai
        yes, but there are no i18n entries for 'release_group' and co
      • reosarevok
        Oh, ok, that
      • Zastai
        the problem is that some verbose link phrases include {entity0/1}; and in the context of the appearances list I don't want to interpolate the specific instance name, but just the generic entity type name