CatQuest, click on "Vote for this issue" when viewing an issue.
2016-12-13 34839, 2016
CatQuest
editing the url doesnt work?
2016-12-13 34849, 2016
Freso|laptop
No idea about the latter.
2016-12-13 34833, 2016
CatQuest
I wish things were where I was used to them. :/
2016-12-13 34834, 2016
CatQuest
also wtf is gravatar on jira now
2016-12-13 34805, 2016
CatQuest
I can't read "allopenissues" right either
2016-12-13 34847, 2016
kyan joined the channel
2016-12-13 34852, 2016
CatQuest
うふふふ ：３
2016-12-13 34835, 2016
anshuman73
Gentlecat, I had a look. Seems mostly like a caching issue to me. Both the recent reviews and Popular reviews use the same macro for showing the gravatar. The only difference I could find is that recent reviews get their data directly from the db (https://github.com/metabrainz/critiquebrainz/blob…) whereas the popular reviews can get it from the cache (which should only
anshuman73: could i pursuade you to look int ohow hard it would be to use a differnt source for avatars? liek the community.metabrainz.org ones insted for example?
2016-12-13 34851, 2016
CatQuest
(gravatar isbad)
2016-12-13 34837, 2016
anshuman73
CatQuest, I believe you say that only because gravatar hashes the email ids ?
2016-12-13 34841, 2016
CatQuest
I belive i say that because it also means that I can't actually use my avatar because I use different emails for different sites (and if i enabeled gravatar (ie made an account) I'd star seeing a loads of different places theseavatars which shouldn't be anywere unless i wanted thme to be)
2016-12-13 34820, 2016
anshuman73
That's true..
2016-12-13 34834, 2016
CatQuest
I don't like the persuasive and pervasive utilisation of gravatar and how they do their thing (ie "hashes") is my second thing
2016-12-13 34835, 2016
D4RK-PH0ENiX joined the channel
2016-12-13 34840, 2016
Freso|laptop
anshuman73, and the hashing allows someone to track a person across sites as long as they use the same e-mail address.
Well, I pretty much use the same username everywhere, so it's not like I'm hard to track regardless.
2016-12-13 34823, 2016
anshuman73
Gentlecat, should we move to completely hashing the user-ids instead of email ids ? ^^
2016-12-13 34842, 2016
CatQuest
true, and i'm usually cat* or blup, but then it's my conscious *choice*
2016-12-13 34847, 2016
Freso|laptop
anshuman73, that's not an option with Gravatar though.
2016-12-13 34801, 2016
Freso|laptop
(Unless they've changed.)
2016-12-13 34808, 2016
ruaok
I'm in favor of getting rid of the gravatar, just so we can stop having this conversation over and over again.
2016-12-13 34824, 2016
CatQuest
I really think we should utilize thecommunity avatar thing instead. it woudl be a good use for those!
2016-12-13 34829, 2016
Gentlecat
gravatar is an opt-in option, you don't have to use it
2016-12-13 34833, 2016
CatQuest
on jira and mb proper :D
2016-12-13 34838, 2016
Freso|laptop
+1 @ ruaok
2016-12-13 34840, 2016
CatQuest
Gentlecat: not really?
2016-12-13 34851, 2016
Gentlecat
yes it is, go to your settings in CB
2016-12-13 34852, 2016
anshuman73
Freso|laptop, what we currently do is check if a user wants their gravatar or not and if they have saved an email id or not. if either is false, we generate gravatr images based on hashes of their user ids
2016-12-13 34814, 2016
anshuman73
so no tracking ;)
2016-12-13 34818, 2016
Freso|laptop
Ah, alright.
2016-12-13 34822, 2016
Gentlecat
if there is a good alternative for it, feel free to implement the change
2016-12-13 34836, 2016
CatQuest
I'm brute force opt outing by literally blocking gravatar in request policy, but I stil have a "grvatar" that's syntesized with their whatever based on my email ro something (unless they've changed)
2016-12-13 34840, 2016
anshuman73
Gentlecat, want me to look into the community avatar
2016-12-13 34847, 2016
anshuman73
?
2016-12-13 34819, 2016
CatQuest
+100 t "good alternative!
2016-12-13 34820, 2016
Gentlecat
you are free to do whatever you want
2016-12-13 34836, 2016
CatQuest
I'll litterally give youchocolte if you do that
2016-12-13 34837, 2016
anshuman73
Gentlecat, Also, have a look at my previous message of why popular reviews' gravatars may not be working
2016-12-13 34840, 2016
anshuman73
Gentlecat, ;)
2016-12-13 34842, 2016
CatQuest
erh chocolate*
2016-12-13 34824, 2016
anshuman73 runs immediately to work on it
2016-12-13 34830, 2016
CatQuest
\o/
2016-12-13 34813, 2016
Freso|laptop
Ha.
2016-12-13 34839, 2016
CatQuest
what I don't like is that "f either is false, we generate gravatr images based on hashes of their user ids"
2016-12-13 34840, 2016
CatQuest
I'd want to not have anything instead then. (or pick one to upøoad, or use the community one etc)
2016-12-13 34806, 2016
CatQuest isn't even kidding about the chocolate :D
2016-12-13 34810, 2016
ruaok
no to uploading images.
2016-12-13 34819, 2016
ruaok
I don't want to have to store images on our servers.
2016-12-13 34823, 2016
Gentlecat
well, sorry
2016-12-13 34833, 2016
CatQuest
community avatars though, that's good
2016-12-13 34838, 2016
Gentlecat
can't please everyone
2016-12-13 34850, 2016
anshuman73
Gentlecat, though will that require us to save images of each letter
2016-12-13 34858, 2016
anshuman73
yeah, ruaok said it
2016-12-13 34824, 2016
CatQuest
i don't even care as long as we get rid of gravatar :D
2016-12-13 34825, 2016
ruaok
Gentlecat: not everyone, but I can say no. :)
2016-12-13 34833, 2016
Freso|laptop
(Jira and Discourse allows uploading avatars to the server.)
2016-12-13 34847, 2016
CatQuest
jira does?
2016-12-13 34852, 2016
ruaok
Freso|laptop: that is fine.
2016-12-13 34853, 2016
CatQuest
i'mma gonna try this then
2016-12-13 34859, 2016
Freso|laptop
(But I guess they're also both in the Google Cloud, so technically not our servers.)
Does JIRA cache the gravatars or embed gravatar.com images?
2016-12-13 34819, 2016
Gentlecat
(I probably should just stop caring about those things, but come on..)
2016-12-13 34831, 2016
Leo_Verto
because Gravatar's business model does kind of revolve around collecting data when embedded in other websites
2016-12-13 34838, 2016
ruaok
whatever we do, just please stop bickering about gravatar!!
2016-12-13 34851, 2016
Freso|laptop
Gentlecat, it can be turned on again easily. ruaok said he was in favour of turning it off if it caused the bickering to stop. I agreed and followed up. If we find out we want to keep using it and continue to have people bickering about it every few months, it can be turned on again quite easily.
2016-12-13 34814, 2016
Lord_of_Codes joined the channel
2016-12-13 34848, 2016
Freso|laptop
(Also, I made the ticket exactly so people had somewhere to complain if they feel like it's the wrong decision. So feel free to write a comment on the issue if you feel it should be reverted.)
2016-12-13 34824, 2016
ruaok
20 email left in my inbox. woo!
2016-12-13 34822, 2016
Arthelon
LordSputnik: Am having some issues with attaching client-side hooks to the server rendered React code. I currently have all the editor tabs converted to react, all that's left is to attach js hooks to the react app for the achievements tab. I noticed a controller/achievement.js file that is included in the original jade template but it isn't included in the client build script. After adding it in I ge
2016-12-13 34829, 2016
Arthelon
t the following client-side error when attaching hooks with ReactDOM.render: Uncaught TypeError: Super expression must either be null or a function, not undefined.
2016-12-13 34829, 2016
Arthelon
^ rendering from the server works perfectly fine so I suspect it may be something to do with the build script and babel
2016-12-13 34814, 2016
Arthelon
tldr; I just wanted to ask if there was any reason the achievements.js wasn't included in the build-client script. The achievement form seems to work fine on the live bookbrainz site
2016-12-13 34835, 2016
Leo_Verto
huh
2016-12-13 34802, 2016
Leo_Verto
well adding achievements was QuoraUK's GSoC project so he also might know about that
2016-12-13 34833, 2016
CatQuest
Freso|laptop: +1
2016-12-13 34851, 2016
ruaok
Woo, and now a Gold waltzes in. \ø/
2016-12-13 34803, 2016
ruaok
bitmap: any more thoughts on that job description for the perl hacker?
