17:52 PM
luks
oh, wow, any file?
17:52 PM
samj1912
yeah :\
17:52 PM
its that bad :P
17:52 PM
see PICARD-988
17:52 PM
BrainzBot
17:53 PM
Gentlecat
bitmap: can we actually have triggers on a slave db?
17:55 PM
bitmap
no, only on a primary
17:56 PM
luks
hm, drag&drop works for me with the latest build
17:56 PM
Gentlecat
oh, so you were talking about running another primary instance for testing the indexer?
17:56 PM
luks
but that might be because I have whatever necessary package already installed on the system
17:56 PM
Gentlecat
I misunderstood
17:57 PM
samj1912
luks hmm, can you explicitly add Foundation?
17:57 PM
bitmap
well, just for testing, that would make sense
17:57 PM
Gentlecat
need to test it under load too, ideally
17:58 PM
luks
samj1912: I still get the "Unable to import NSURL" error, so the problem most likely only happens on newer systems
17:58 PM
I'll try fixing the packaging so that it's included
17:58 PM
Gentlecat
that's how we found some of current issues
17:58 PM
samj1912
okay
18:04 PM
bitmap
Gentlecat: if we make sure the triggers are working properly, those can be added back on the primary
18:04 PM
the indexer doesn't have to query the same db the triggers are on though, it can query the slave just fine
18:05 PM
Gentlecat
right
18:08 PM
bitmap
but I'd like to see it do the id queries from the indexer rather than inside the triggers first
18:09 PM
and fix the issue where it's canceling the delete statements
18:12 PM
luks
samj1912: exclusion of the 'zipfile' module was causing pyobjc to fail on import
18:13 PM
samj1912
ohh!, so its fixed now :D?
18:13 PM
luks
after removing that, I no longer get the import error
18:13 PM
samj1912
yay! :D
18:13 PM
luks
I don't know if the problem is fixed, because it only happens on new systems, but in theory it should be
18:13 PM
samj1912
can you build it so ruaok can test?
18:13 PM
luks
let me clean it up and run a new build
18:13 PM
samj1912
okay :D
18:13 PM
thanks! :D
18:15 PM
bitmap can test it too
18:16 PM
deeptibaghel joined the channel
18:16 PM
deeptibaghel has left the channel
18:17 PM
luks
oh, I new can't push to github without an approve :)
18:17 PM
I guess I'll open a pull request then
18:19 PM
18:19 PM
github joined the channel
18:19 PM
github
18:19 PM
github has left the channel
18:20 PM
samj1912
it also has to pass the CI :P
18:20 PM
I can't skip it
18:21 PM
luks
18:21 PM
samj1912
bitmap ^
18:21 PM
bitmap
downloading
18:21 PM
samj1912
also can we build qt4 and qt5 images for docker?
18:22 PM
currently travis reinstalls qt4/qt5 each time
18:22 PM
bitmap
drag & drop works in that build
18:23 PM
samj1912
yay!! :D
18:23 PM
github joined the channel
18:23 PM
github
18:23 PM
github has left the channel
18:24 PM
samj1912
zas should be backport these changes to 1.4.0 and rebuild?
18:24 PM
or releasing it with 1.4.1 is fine?
18:24 PM
suhas2go has quit
18:25 PM
18:26 PM
travis-ci joined the channel
18:26 PM
travis-ci
metabrainz/picard#2054 (master - 5b7178d : Sambhav Kothari): The build passed.
18:26 PM
18:26 PM
18:26 PM
travis-ci has left the channel
18:32 PM
Freso
samj1912: FWIW, I'd say "release with 1.4.1".
18:32 PM
github joined the channel
18:32 PM
github
[picard] lalinsky opened pull request #633: Fix version number in the Windows installer (master...master)
https://git.io/vD5Xg
18:32 PM
github has left the channel
18:36 PM
github joined the channel
18:36 PM
[picard] samj1912 closed pull request #633: Fix version number in the Windows installer (master...master)
https://git.io/vD5Xg
18:36 PM
github has left the channel
18:36 PM
luks
hm, interesting, you have access to push to my repo once I create a PR?
18:36 PM
samj1912
I do? O.o
18:36 PM
Gentlecat
there's a checkbox when you create a PR
18:37 PM
luks
`samj1912 pushed to master at lalinsky/picard`
18:37 PM
Gentlecat
it's checked by default
18:37 PM
luks
that's convenient for some things, but unexpected :)
18:38 PM
travis-ci joined the channel
18:38 PM
travis-ci
metabrainz/picard#2057 (master - b3031a4 : Sambhav Kothari): The build passed.
18:38 PM
18:38 PM
18:38 PM
travis-ci has left the channel
18:45 PM
github joined the channel
18:45 PM
github
[musicbrainz-server] y-van-z opened pull request #471: MBS-9215: Add entity type to attribute editing form (master...mbs-9215-fix-admin-attr)
https://git.io/vD51U
18:45 PM
github has left the channel
18:51 PM
samj1912 did the mistake of trying to compile qt from source in travis :v
18:51 PM
samj1912
apparently it takes 2-3 hours on very fast systems and 12+ on slow ones
18:52 PM
bitmap
there's a way to cache directories inside the container, but yeah
18:52 PM
samj1912
18:53 PM
luks
you should be theoretically able to download and install the official dmg from the command line
18:53 PM
samj1912
let me try then
18:57 PM
luks
samj1912: you know the travis job is running on linux, not os x, right? :)
18:59 PM
samj1912
ah forgot about that, fixed :)
19:01 PM
luks
19:02 PM
still, it's not realistic to build pyqt on every run either
19:02 PM
it would be ideal to have the entire build env prepackaged
19:03 PM
samj1912
hmmm
19:03 PM
how will we do that?
19:03 PM
luks
no idea :)
19:05 PM
19:09 PM
bitmap
that's what I was thinking of earlier
19:10 PM
luks
19:11 PM
this looks like the easiest option for qt, since images have homebrew preinstalled
19:17 PM
agentsim joined the channel
19:31 PM
github joined the channel
19:31 PM
github
[musicbrainz-server] y-van-z opened pull request #472: MBS-9219: Fix editing known languages field in user profile form (master...mbs-9219-fix-profile-editing)
https://git.io/vD5yE
19:31 PM
github has left the channel
19:34 PM
zas
samj1912: we'll release with 1.4.1, i think the only thing missing for it is the last antlarr/samj1912 cover changes for album stuff ;) Then we can call for translators to update for new strings and release.
19:34 PM
samj1912
cool :D
19:34 PM
zas
I think we'll create 1.4.2 as a branch if needed, and start to work on 2.0
19:35 PM
We didn't have much reports of problems with 1.4.0 apart this drag'n'drop macosx only issue
19:35 PM
(not surprising, it was stabilizing since years...))
19:35 PM
samj1912
which was also a qt issue
19:36 PM
I am surprised it wasnt reported earlier during dev releases
19:36 PM
zas
Yes, but this one went undetected until now
19:36 PM
samj1912
yeah
19:36 PM
zas
well, dev releases are not used by as much users, and many people don't even know d'n'd is possible ....
19:37 PM
samj1912
true
19:37 PM
zas
plus it concerns only some macosx
19:37 PM
samj1912
zas, any idea approx how many picard users we have?
19:37 PM
zas
nope, hard to know, but we'll have soon user agent stats
19:37 PM
on the web service
19:37 PM
samj1912
cool! :D
19:38 PM
we can also have it on PW side ?
19:38 PM
zas
Yes
19:38 PM
samj1912
I was planning to add 1.4.1 dev builds to PW
19:39 PM
zas
yes, please do, so people can test
19:39 PM
samj1912
and a known bugs section
19:39 PM
zas
Very good :)
19:39 PM
saifulbkhan joined the channel
19:39 PM
Not as good as an "Unknown bugs section", but it will do
19:39 PM
;)
19:49 PM
samj1912
bitmap: ping
19:49 PM
19:54 PM
CallerNo6
Am I wrong in thinking that the need expressed in CB-231 could be used to help design a spec for ws/3?
19:54 PM
BrainzBot
19:54 PM
bitmap
samj1912: I've tried installing qt4 from homebrew before, but not that specific fork (and not on sierra)
19:55 PM
samj1912
that seems to be an updated fork
19:55 PM
bitmap
the official homebrew version I tried was broken in the same way as builds from source
19:56 PM
samj1912
broken with DnD?
19:56 PM
bitmap
yeah, and icons were oversized for some reason
19:56 PM
samj1912
hmmm
19:57 PM
bitmap
but if this is just for unit tests, that shouldn't matter
19:57 PM
samj1912
19:57 PM
trying a new build
19:57 PM
hopefully works
20:28 PM
20:29 PM
managed a successful osx build :D
20:41 PM
now I have to get it to package picard
20:42 PM
zas
\o/
20:44 PM
samj1912
bitmap: luks can you help me with something
20:44 PM