#metabrainz

/

      • CatQuest
        more cats \o/

        • 2017-06-05 15623, 2017

      • Gentlecat
        and reviewed some code, as usual

        • 2017-06-05 15629, 2017

      • Gentlecat
        fin

        • 2017-06-05 15643, 2017

      • Gentlecat
        bitmap: ?

        • 2017-06-05 15612, 2017

      • bitmap
        fixed some bugs and perf issues with the json dumps, as found on sentry

        • 2017-06-05 15625, 2017

      • bitmap
        also fixed MBS-9342

        • 2017-06-05 15625, 2017

      • BrainzBot
        MBS-9342: InitDb.pl fails to import data with DBD::Pg 3.6.0 https://tickets.metabrainz.org/browse/MBS-9342

        • 2017-06-05 15604, 2017

      • drsaunders joined the channel

        • 2017-06-05 15613, 2017

      • bitmap
        and MBS-9309

        • 2017-06-05 15613, 2017

      • BrainzBot
        MBS-9309: Mediums fail to merge when two recording positions are swapped https://tickets.metabrainz.org/browse/MBS-9309

        • 2017-06-05 15614, 2017

      • reosarevok
        Quesito: https://www.facebook.com/permalink.php?story_fbid…

        • 2017-06-05 15641, 2017

      • Quesito
        Gracias reosarevok

        • 2017-06-05 15644, 2017

      • Quesito
        :)

        • 2017-06-05 15647, 2017

      • bitmap
        and MBS-9365 as reported by ferbncode_ (thanks)

        • 2017-06-05 15648, 2017

      • BrainzBot
        MBS-9365: event_meta_fk_id was never created as part of any upgrade script https://tickets.metabrainz.org/browse/MBS-9365

        • 2017-06-05 15601, 2017

      • bitmap
        other than that, code review and deployed random stuff

        • 2017-06-05 15609, 2017

      • bitmap
        fin, zas

        • 2017-06-05 15601, 2017

      • zas
        played a lot with logs

        • 2017-06-05 15619, 2017

      • zas
        did https://musicbrainz.org/tops/mb_top_stuff.html with the help of bitmap for the jquery part

        • 2017-06-05 15624, 2017

      • ruaok
        that top stuff page looks great, btw. thanks!

        • 2017-06-05 15633, 2017

      • CatQuest
        it's super great :D

        • 2017-06-05 15638, 2017

      • yvanzo
        !m zas

        • 2017-06-05 15638, 2017

      • BrainzBot
        You're doing good work, zas!

        • 2017-06-05 15646, 2017

      • zas
        more will come on this

        • 2017-06-05 15656, 2017

      • CatQuest
        what did you think all my "!m zas" was about? :D

        • 2017-06-05 15659, 2017

      • zas
        i started to block a bunch of ws abusers (again)

        • 2017-06-05 15602, 2017

      • ruaok
        and the spam users are already getting fewer hits. very good

        • 2017-06-05 15606, 2017

      • hibiscuskazeneko has quit

        • 2017-06-05 15624, 2017

      • zas
        plus usual upgrades and server supervision

        • 2017-06-05 15608, 2017

      • samj1912 is here

        • 2017-06-05 15621, 2017

      • zas
        fin, samj1912 !

        • 2017-06-05 15624, 2017

      • zas
        ;)

        • 2017-06-05 15658, 2017

      • Freso
        (Still up: yvanzo, psolanki, ListMyCDs, ferbncode; maybe up (please confirm): alastairp, Leo_Verto[m]; anyone else?)

        • 2017-06-05 15653, 2017

      • ferbncode_
        bitmap: np :)

        • 2017-06-05 15656, 2017

      • samj1912
        spent time this weekend figuring out mbxml code, apart from that fixed a jira ticket and code reviews

        • 2017-06-05 15602, 2017

      • samj1912
        fin

        • 2017-06-05 15616, 2017

      • samj1912
        yvanzo: go

        • 2017-06-05 15639, 2017

      • yvanzo
        salute

        • 2017-06-05 15643, 2017

      • yvanzo
        I spent most of last week debugging a weird issue in tests renderer and coding the removal of illegitimate accounts.

        • 2017-06-05 15659, 2017

      • yvanzo
        Also did normal stuff: reviews, forums

        • 2017-06-05 15624, 2017

      • yvanzo
        finito, ListMyCDs? (psolanki seems to be missing)

        • 2017-06-05 15645, 2017

      • ListMyCDs
        I have little concrete to report. I've been toying with the code and it's been challenging but also rewarding. I've learned a lot.

        • 2017-06-05 15656, 2017

      • ListMyCDs
        go, ferbncode

        • 2017-06-05 15609, 2017

      • ferbncode_
        Hi :)

        • 2017-06-05 15621, 2017

      • ferbncode_
        his week I mostly worked on the docker image for setting up a MB database with the dump imports. Also worked slightly on dump_manager.py related PR and worked on the final PR to get CB code completely off the ORM: https://github.com/metabrainz/critiquebrainz/pull…. That's all for my week. fin !

        • 2017-06-05 15638, 2017

      • ferbncode_
        anyone left?

        • 2017-06-05 15640, 2017

      • hibiscuskazeneko joined the channel

        • 2017-06-05 15610, 2017

      • yvanzo
        alastairp or Leo_Verto[m] maybe

        • 2017-06-05 15630, 2017

      • Freso
        Seems like we're through.

        • 2017-06-05 15640, 2017

      • Freso
        ruaok: spam review

        • 2017-06-05 15651, 2017

      • ruaok
        k

        • 2017-06-05 15624, 2017

      • ruaok
        yvanzo: what is the general state of the spam stuff?

        • 2017-06-05 15636, 2017

      • ruaok
        I'm guessing that bitmap had other things to focus on.

        • 2017-06-05 15624, 2017

      • ruaok prods yvanzo

        • 2017-06-05 15647, 2017

      • Freso
        They were *just* here too...

        • 2017-06-05 15648, 2017

      • ruaok
        ok, we'll get back to spam related things in a minute.

        • 2017-06-05 15652, 2017

      • bitmap
        the PR he has up looks good, I think just tests need fixing

        • 2017-06-05 15657, 2017

      • ruaok
        instead, lets go with ws/2.5

        • 2017-06-05 15603, 2017

      • yvanzo
        It is almost complete, should be in production in two weeks.

        • 2017-06-05 15628, 2017

      • ruaok
        ah, ok. back to spam, I guess. :)

        • 2017-06-05 15639, 2017

      • ruaok
        how about the script to remove old accounts?

        • 2017-06-05 15641, 2017

      • yvanzo
        The PR is for half of tickets, I already worked on the rest.

        • 2017-06-05 15641, 2017

      • bitmap
        I can hotfix it when it's complete

        • 2017-06-05 15641, 2017

      • CatQuest
        Spam Spam Sapm Glorius Spam ♫♪♬

        • 2017-06-05 15605, 2017

      • ruaok
        bitmap: yes, I'd like that when the other fires are put out.

        • 2017-06-05 15611, 2017

      • yvanzo
        We can probably push everything this week then.

        • 2017-06-05 15626, 2017

      • ruaok
        I'm guessing we won't really have much of a change to review the impact before I leave on vacation on thursday.

        • 2017-06-05 15658, 2017

      • ruaok
        does the spammer account removal script have a dry-run option?

        • 2017-06-05 15606, 2017

      • CatQuest
        ♫♪♬ Spam Spam Spam Glorious Spam ♫♪♬

        • 2017-06-05 15614, 2017

      • ruaok
        it might be nice to post an excerpt of the output and let people sanity check it.

        • 2017-06-05 15628, 2017

      • Sophist-UK
        Freso: If you want to try to discuss multi-level works, ping me.

        • 2017-06-05 15642, 2017

      • Freso
        Sophist-UK: I think it's the only topic for tomorrow, so... :)

        • 2017-06-05 15601, 2017

      • ruaok
        yvanzo: please let people sanity check the results before you run it.

        • 2017-06-05 15611, 2017

      • CatQuest
        +++111

        • 2017-06-05 15612, 2017

      • yvanzo
        The removal should not be effective before two weeks.

        • 2017-06-05 15618, 2017

      • ruaok
        sounds like we're too early to have much of a recap on the spam stuff.

        • 2017-06-05 15624, 2017

      • ruaok
        ok, then we can review when I get back.

        • 2017-06-05 15633, 2017

      • ruaok
        onward to WS/2.5

        • 2017-06-05 15658, 2017

      • ruaok
        zas is having to spend a lot of time blocking asshats and in general combatting spammers.

        • 2017-06-05 15619, 2017

      • ruaok
        we really need to move to an API key, there is no way around it MB has become too popular now.

        • 2017-06-05 15638, 2017

      • Quesito
        +1

        • 2017-06-05 15642, 2017

      • ruaok
        there is a toolkit that can make all of this pretty easy... Kong, right zas?

        • 2017-06-05 15650, 2017

      • ruaok
        problem is that it only works with JSON.

        • 2017-06-05 15655, 2017

      • zas
        yes

        • 2017-06-05 15606, 2017

      • zas
        I can explain if you want ruaok

        • 2017-06-05 15612, 2017

      • ruaok
        sure, go!

        • 2017-06-05 15616, 2017

      • zas
        Basically Kong is an API gateway, providing everything to manage an API-key based JSON API, including plugins for rate limiting, oauth, and tons of shit

        • 2017-06-05 15638, 2017

      • zas
        https://getkong.org/

        • 2017-06-05 15655, 2017

      • zas
        but we can't move to it, because our API is mainly XML

        • 2017-06-05 15606, 2017

      • zas
        and it would require too much changes etc...

        • 2017-06-05 15626, 2017

      • reosarevok
        So is it time for a real v3? or why v2.5?

        • 2017-06-05 15637, 2017

      • zas
        here is the 2.5 trick

        • 2017-06-05 15648, 2017

      • zas
        we have XML + JSON atm

        • 2017-06-05 15608, 2017

      • Freso
        Fix the two JSON-out-of-beta blockers and make ws/2 JSON + Kong = ws/2.5?

        • 2017-06-05 15618, 2017

      • ruaok
        reosarevok: it would actually be ws/3, but I did't want to confuse the topic with the actual ws/3

        • 2017-06-05 15622, 2017

      • zas
        Exactly !

        • 2017-06-05 15632, 2017

      • reosarevok
        But doesn't that still kinda force us to keep maintaining 2?

        • 2017-06-05 15637, 2017

      • ruaok
        yes.

        • 2017-06-05 15647, 2017

      • spuniun joined the channel

        • 2017-06-05 15649, 2017

      • ruaok
        we're stuck with ws/2 for at least 2+ years.

        • 2017-06-05 15654, 2017

      • zas
        yes

        • 2017-06-05 15606, 2017

      • Freso
        (But can we kill ws/1 now?)

        • 2017-06-05 15616, 2017

      • ruaok
        Freso: different topic, another day.

        • 2017-06-05 15628, 2017

      • ruaok
        anyways, that is the general idea.

        • 2017-06-05 15631, 2017

      • alastairp
        hi, I'm not really here at the moment, but https://www.3scale.net/ appears to do the same thing from what I understand, and is barcelona local

        • 2017-06-05 15644, 2017

      • samj1912
        and we can also move to mbjsonin picard? :P

        • 2017-06-05 15653, 2017

      • samj1912
        s/jsonin/json in

        • 2017-06-05 15659, 2017

      • zas
        alastairp: interesting, we didn't dig that much yet, i guess there are some alternatives

        • 2017-06-05 15608, 2017

      • zas
        samj1912: yes

        • 2017-06-05 15608, 2017

      • reosarevok
        samj1912: no reason not to I guess, as soon as the two beta issues are solved?

        • 2017-06-05 15615, 2017

      • ruaok
        alastairp: yes, we looked at it many moons ago, but the pricing is shit and traffic has to be routed through them.

        • 2017-06-05 15633, 2017

      • ruaok
        kong is much more in the spirit of being independent.

        • 2017-06-05 15641, 2017

      • Freso
        (Also, not FLOSS, FWIW.)

        • 2017-06-05 15651, 2017

      • ruaok
        but the idea is that we have API keys and a motivation to move people to JSON.

        • 2017-06-05 15603, 2017

      • alastairp
        ruaok: 👍 cool

        • 2017-06-05 15610, 2017

      • ruaok
        we can give the ws/2.5 API better rate limits and ws/2 worse rate limits.

        • 2017-06-05 15616, 2017

      • samj1912
        so we are switching entirely to a key based api now? or will simply having a key allow more requests?

        • 2017-06-05 15618, 2017

      • ruaok
        as a further motivation.

        • 2017-06-05 15625, 2017

      • ruaok
        samj1912: just listen!

        • 2017-06-05 15638, 2017

      • Freso
        Younguns are so impatient these days… :)

        • 2017-06-05 15639, 2017

      • ruaok
        so, we're floating the idea of this.

        • 2017-06-05 15641, 2017

      • samj1912
        okay :P

        • 2017-06-05 15646, 2017

      • ruaok
        what do people think?

        • 2017-06-05 15602, 2017

      • Freso
        I think it sounds dandy.

        • 2017-06-05 15606, 2017

      • Sophist-UK
        Who will have to get a key - a developer of a tool or every user?

        • 2017-06-05 15606, 2017

      • ruaok
        once we have API keys we can do a lot of things.

        • 2017-06-05 15622, 2017

      • ruaok
        give people better rate limits and even charge for them.

        • 2017-06-05 15623, 2017

      • CatQuest
        I just read that as "danky" ಠ_ಠ

        • 2017-06-05 15636, 2017

      • ruaok
        Sophist-UK: developers.

        • 2017-06-05 15613, 2017

      • ruaok
        zas thinks we can do this without a lot of effort, so we wanted to float the idea and see what people thought.

        • 2017-06-05 15630, 2017

      • ruaok
        another thing that we would do is use twitter style rate limiting on the new API.

        • 2017-06-05 15631, 2017

      • reosarevok
        ruaok: so as a Picard user, I can't pay MB to let me hammer it with my own Picard?

        • 2017-06-05 15633, 2017

      • Freso
        ruaok: Do you envision one key per tool/app, or one key per developer?

        • 2017-06-05 15635, 2017

      • samj1912
        charging for rate limits will also include a SLA?

        • 2017-06-05 15643, 2017

      • Sophist-UK
        How about a better rate limit for ws/2.5 than for ws/2 to encourage developers to switch?

        • 2017-06-05 15644, 2017

      • ruaok
        the same concept we use for LB WS.

        • 2017-06-05 15645, 2017

      • Quesito
        I think it's brilliant. and will help in an untold number of ways.

        • 2017-06-05 15659, 2017

      • reosarevok
        Sophist-UK: " we can give the ws/2.5 API better rate limits and ws/2 worse rate limits." above ;

        • 2017-06-05 15659, 2017

      • ruaok
        reosarevok and Freso: Not sure yet. Details to be worked out.

        • 2017-06-05 15600, 2017

      • reosarevok
        p

        • 2017-06-05 15607, 2017

      • Sophist-UK
        Sorry - missed that.

        • 2017-06-05 15614, 2017

      • ruaok
        but ideally, it would be nice for a picard user to get a paid higher rate key.

        • 2017-06-05 15630, 2017

      • CatQuest
        wait.. what now

        • 2017-06-05 15636, 2017

      • CatQuest
        paying for picard usage??

        • 2017-06-05 15644, 2017

      • ruaok
        not that it would bring in a lot of money, but it would shut up some screamers. :)

        • 2017-06-05 15654, 2017

      • ruaok
        CatQuest: paying for FASTER usage.

        • 2017-06-05 15659, 2017

      • CatQuest
        :/

        • 2017-06-05 15602, 2017

      • CatQuest
        i don't like it

        • 2017-06-05 15604, 2017

      • zas
        The idea, to start, is to just put a new front end (different url), but keeping the same backend

        • 2017-06-05 15610, 2017

      • Sophist-UK
        Picard and Picard Pro. (Same code - only difference is that Pro is paid for and gets a better rate limit.)