0:58 AM
rahulr has quit
2017-08-09 22120, 2017
0:58 AM
rahulr joined the channel
2017-08-09 22146, 2017
1:07 AM
SothoTalker_ has quit
2017-08-09 22142, 2017
1:17 AM
SothoTalKer joined the channel
2017-08-09 22129, 2017
1:49 AM
Leftmost
I go const unless let is necessary.
2017-08-09 22103, 2017
1:50 AM
jsturgis has quit
2017-08-09 22147, 2017
2:01 AM
bitmap
that too ^
2017-08-09 22117, 2017
2:02 AM
Gentlecat
:)
2017-08-09 22106, 2017
2:04 AM
Leftmost
I've been writing too much Dart lately, though. It's messing up my JS.
2017-08-09 22107, 2017
2:07 AM
Leftmost
And for a language that transpiles into JS, its interop is horrible.
2017-08-09 22108, 2017
2:13 AM
bitmap
I'll probably just try to set up typescript in mb
2017-08-09 22115, 2017
2:15 AM
bitmap
I wanted to like/use flow but it's been unusable with several showstoppers for years
2017-08-09 22107, 2017
2:18 AM
bitmap
it has infuriating bugs like the intersection types Foo&Bar and Bar&Foo behaving differently
2017-08-09 22152, 2017
2:21 AM
Leftmost
Egad.
2017-08-09 22131, 2017
3:34 AM
github joined the channel
2017-08-09 22131, 2017
3:34 AM
github
[critiquebrainz] gentlecat opened pull request #144: [WIP] CB-88: Guidelines page improvements (master...guide)
https://git.io/v7XTD
2017-08-09 22131, 2017
3:34 AM
github has left the channel
2017-08-09 22106, 2017
4:16 AM
saifulbkhan has quit
2017-08-09 22125, 2017
4:45 AM
antlarr has quit
2017-08-09 22100, 2017
4:57 AM
antlarr joined the channel
2017-08-09 22106, 2017
5:05 AM
github joined the channel
2017-08-09 22106, 2017
5:05 AM
github
[musicbrainz-server] mwiencek closed pull request #531: Run UI tests in a headless chrome environment (master...chrome-headless)
https://git.io/v70sw
2017-08-09 22106, 2017
5:05 AM
github has left the channel
2017-08-09 22130, 2017
5:32 AM
pingupingu joined the channel
2017-08-09 22121, 2017
5:33 AM
drsaunders has quit
2017-08-09 22124, 2017
5:55 AM
pingupingu has quit
2017-08-09 22127, 2017
6:19 AM
rgggn has quit
2017-08-09 22133, 2017
6:27 AM
rgggn joined the channel
2017-08-09 22137, 2017
6:48 AM
kyan has quit
2017-08-09 22135, 2017
6:56 AM
khan joined the channel
2017-08-09 22132, 2017
6:59 AM
khan has quit
2017-08-09 22150, 2017
6:59 AM
khan joined the channel
2017-08-09 22100, 2017
7:00 AM
khan is now known as saifulbkhan
2017-08-09 22144, 2017
7:06 AM
Sophist-UK has quit
2017-08-09 22103, 2017
7:08 AM
saifulbkhan has quit
2017-08-09 22138, 2017
7:10 AM
khan joined the channel
2017-08-09 22137, 2017
7:13 AM
MajorLurker has quit
2017-08-09 22126, 2017
7:37 AM
MajorLurker joined the channel
2017-08-09 22157, 2017
7:42 AM
arbenina_ joined the channel
2017-08-09 22135, 2017
7:49 AM
Quesito
Moin!
2017-08-09 22151, 2017
7:49 AM
MajorLurker
yello!
2017-08-09 22121, 2017
7:50 AM
Quesito
Coffee/vino clink clink MajorLurker 😉
2017-08-09 22135, 2017
7:51 AM
MajorLurker
no vino for me, operation tomorrow
2017-08-09 22145, 2017
7:51 AM
MajorLurker
no coffee either for that matter.
2017-08-09 22109, 2017
7:52 AM
MajorLurker
Will celebrate in a couple of weeks, hopefully.
2017-08-09 22117, 2017
7:54 AM
Quesito
Oh! Hope it goes well MajorLurker! Let us know!
2017-08-09 22132, 2017
7:54 AM
Quesito
Wishing you a speedy recovery!
2017-08-09 22133, 2017
7:54 AM
MajorLurker
I hope the surgeon goes well!
2017-08-09 22144, 2017
7:54 AM
MajorLurker
Thanks!
2017-08-09 22140, 2017
7:57 AM
arbenina_ has quit
2017-08-09 22148, 2017
8:00 AM
khan has quit
2017-08-09 22118, 2017
8:06 AM
Sophist-UK joined the channel
2017-08-09 22136, 2017
8:10 AM
drsaunders joined the channel
2017-08-09 22124, 2017
8:19 AM
drsaunders has quit
2017-08-09 22116, 2017
8:47 AM
rahulr has quit
2017-08-09 22116, 2017
8:47 AM
Gore|woerk has quit
2017-08-09 22117, 2017
8:47 AM
sampsyo has quit
2017-08-09 22118, 2017
8:47 AM
spuniun has quit
2017-08-09 22118, 2017
8:47 AM
navap has quit
2017-08-09 22159, 2017
8:47 AM
arbenina_ joined the channel
2017-08-09 22136, 2017
8:49 AM
jwf has quit
2017-08-09 22116, 2017
8:54 AM
jwf joined the channel
2017-08-09 22135, 2017
8:58 AM
Nyanko-sensei joined the channel
2017-08-09 22124, 2017
9:01 AM
D4RK-PH0ENiX has quit
2017-08-09 22137, 2017
9:05 AM
agentsim has quit
2017-08-09 22109, 2017
9:06 AM
agentsim joined the channel
2017-08-09 22141, 2017
9:10 AM
agentsim has quit
2017-08-09 22159, 2017
9:11 AM
MajorLurker has quit
2017-08-09 22105, 2017
9:14 AM
D4RK-PH0ENiX joined the channel
2017-08-09 22124, 2017
9:15 AM
Nyanko-sensei has quit
2017-08-09 22121, 2017
9:31 AM
Gore|woerk joined the channel
2017-08-09 22127, 2017
9:31 AM
navap joined the channel
2017-08-09 22110, 2017
9:33 AM
sampsyo joined the channel
2017-08-09 22136, 2017
9:33 AM
rahulr joined the channel
2017-08-09 22114, 2017
9:35 AM
spuniun joined the channel
2017-08-09 22116, 2017
9:36 AM
lazka joined the channel
2017-08-09 22133, 2017
9:39 AM
MajorLurker joined the channel
2017-08-09 22112, 2017
9:40 AM
github joined the channel
2017-08-09 22112, 2017
9:40 AM
github
[critiquebrainz] ferbncode opened pull request #145: Fix ISE on entity pages involving mbid redirects. (master...sentry-cb3D)
https://git.io/v7Xuj
2017-08-09 22112, 2017
9:40 AM
github has left the channel
2017-08-09 22111, 2017
9:44 AM
Kode has quit
2017-08-09 22117, 2017
9:45 AM
Kode_ joined the channel
2017-08-09 22133, 2017
9:51 AM
zas
samj1912: ping
2017-08-09 22141, 2017
9:52 AM
samj1912
zas: pong
2017-08-09 22121, 2017
9:53 AM
zas
2017-08-09 22106, 2017
9:54 AM
samj1912
It's using qt4
2017-08-09 22112, 2017
9:54 AM
samj1912
So definitely doesn't
2017-08-09 22119, 2017
9:54 AM
zas
so it should be rebased on 1.0 right ?
2017-08-09 22105, 2017
9:55 AM
samj1912
But isn't 1.0 our default branch on picard plugins?
2017-08-09 22116, 2017
9:55 AM
samj1912
Yes
2017-08-09 22109, 2017
9:56 AM
samj1912
Should we delete the master branch from picard plugins?
2017-08-09 22121, 2017
9:56 AM
samj1912
It creates unnecessary confusion?
2017-08-09 22155, 2017
9:56 AM
zas
it does, but master != 2.0 (and != 1.0 too)
2017-08-09 22104, 2017
9:57 AM
zas
hence my question
2017-08-09 22122, 2017
9:57 AM
zas
the PR is based on master
2017-08-09 22136, 2017
9:57 AM
samj1912
Yeah
2017-08-09 22143, 2017
9:57 AM
samj1912
We should remove master
2017-08-09 22107, 2017
9:58 AM
samj1912
As for now, we can ask the guy to rebase it against 1.0
2017-08-09 22122, 2017
9:58 AM
samj1912
I manually changed the base but it has merge conflicts
2017-08-09 22149, 2017
9:58 AM
github joined the channel
2017-08-09 22149, 2017
9:58 AM
github
[critiquebrainz] ferbncode opened pull request #146: CB-231: Add wrapper for fetch_multiple_places for a single MBID (master...wrapper-get-place-by-gid)
https://git.io/v7Xg1
2017-08-09 22149, 2017
9:58 AM
github has left the channel
2017-08-09 22158, 2017
9:58 AM
zas
yep
2017-08-09 22157, 2017
10:11 AM
github joined the channel
2017-08-09 22157, 2017
10:11 AM
github
[picard-plugins] zas closed pull request #107: featartistsintitles.py: also remove feat. artists from sort tags (master...patch-1)
https://git.io/vHSe0
2017-08-09 22157, 2017
10:11 AM
github has left the channel
2017-08-09 22113, 2017
10:13 AM
zas
samj1912: deleting the branch causes PRs based on it to close
2017-08-09 22155, 2017
10:13 AM
samj1912
They all need to be re based then
2017-08-09 22110, 2017
10:14 AM
samj1912
We can ask the authors to rebase accordingly
2017-08-09 22146, 2017
10:20 AM
zas
yup
2017-08-09 22111, 2017
10:52 AM
D4RK-PH0ENiX has quit
2017-08-09 22139, 2017
10:52 AM
D4RK-PH0ENiX joined the channel
2017-08-09 22148, 2017
10:53 AM
reosarevok
2017-08-09 22115, 2017
10:55 AM
samj1912
Yes I saw
2017-08-09 22131, 2017
10:55 AM
samj1912
PICARD-990
2017-08-09 22131, 2017
10:55 AM
BrainzBot
2017-08-09 22129, 2017
10:57 AM
samj1912
I don't think we made the changes he thinks we did
2017-08-09 22103, 2017
10:58 AM
samj1912
We simply added an extension point which defaults to the normal behavior and can be overwritten by a plugin
2017-08-09 22117, 2017
10:59 AM
samj1912
I don't think he went through the merged commits
2017-08-09 22139, 2017
10:59 AM
samj1912
We solved both the problems since there are compatibility issues
2017-08-09 22156, 2017
10:59 AM
samj1912
There is a plugin you can install for whichever way you want your tags
2017-08-09 22125, 2017
11:01 AM
samj1912
The plugin pr was closed due to a rebase problem
2017-08-09 22134, 2017
11:18 AM
reosarevok
You might want to comment with that on either the PR or the forum :)
2017-08-09 22134, 2017
11:38 AM
MarcusPie joined the channel
2017-08-09 22112, 2017
12:06 PM
khan joined the channel
2017-08-09 22112, 2017
12:08 PM
khan is now known as saifulbkhan
2017-08-09 22116, 2017
12:08 PM
saifulbkhan is now known as khan
2017-08-09 22138, 2017
12:29 PM
D4RK-PH0ENiX has quit
2017-08-09 22104, 2017
12:34 PM
Gazooo has quit
2017-08-09 22108, 2017
12:37 PM
D4RK-PH0ENiX joined the channel
2017-08-09 22108, 2017
12:42 PM
D4RK-PH0ENiX has quit
2017-08-09 22112, 2017
12:47 PM
D4RK-PH0ENiX joined the channel
2017-08-09 22143, 2017
12:48 PM
Gazooo joined the channel
2017-08-09 22140, 2017
12:55 PM
psolanki
2017-08-09 22124, 2017
13:17 PM
Gentlecat
psolanki: ok. keep in mind that the license needs to be included
2017-08-09 22151, 2017
13:17 PM
psolanki
noted
2017-08-09 22135, 2017
13:18 PM
psolanki
And did you render the rating?
2017-08-09 22130, 2017
13:19 PM
Gentlecat
2017-08-09 22148, 2017
13:19 PM
Gentlecat
which means you might not even need to copy the source code
2017-08-09 22150, 2017
13:20 PM
psolanki
But I have made many changes like data-value, color, titles etc
2017-08-09 22130, 2017
13:23 PM
Gentlecat
alright
2017-08-09 22144, 2017
14:06 PM
agentsim joined the channel
2017-08-09 22106, 2017
14:11 PM
agentsim has quit
2017-08-09 22157, 2017
14:21 PM
agentsim joined the channel
2017-08-09 22118, 2017
14:34 PM
ruaok finally gets smart and uses a VM for VM build testing
2017-08-09 22125, 2017
14:34 PM
ruaok
much faster than this borrowed net connection
2017-08-09 22131, 2017
14:40 PM
reosarevok
Freso: how did I add someone to the autoeditors group?
2017-08-09 22157, 2017
14:42 PM
madmouser1 joined the channel
2017-08-09 22149, 2017
14:44 PM
antfoo has quit
2017-08-09 22100, 2017
14:52 PM
ruaok
I forget. who owns the copyright of GSoC work? Org or student?
