0:58 AM
rahulr has quit
0:58 AM
rahulr joined the channel
1:07 AM
SothoTalker_ has quit
1:17 AM
SothoTalKer joined the channel
1:49 AM
Leftmost
I go const unless let is necessary.
1:50 AM
jsturgis has quit
2:01 AM
bitmap
that too ^
2:02 AM
Gentlecat
:)
2:04 AM
Leftmost
I've been writing too much Dart lately, though. It's messing up my JS.
2:07 AM
And for a language that transpiles into JS, its interop is horrible.
2:13 AM
bitmap
I'll probably just try to set up typescript in mb
2:15 AM
I wanted to like/use flow but it's been unusable with several showstoppers for years
2:18 AM
it has infuriating bugs like the intersection types Foo&Bar and Bar&Foo behaving differently
2:21 AM
Leftmost
Egad.
3:34 AM
github joined the channel
3:34 AM
github
[critiquebrainz] gentlecat opened pull request #144: [WIP] CB-88: Guidelines page improvements (master...guide)
https://git.io/v7XTD
3:34 AM
github has left the channel
4:16 AM
saifulbkhan has quit
4:45 AM
antlarr has quit
4:57 AM
antlarr joined the channel
5:05 AM
github joined the channel
5:05 AM
[musicbrainz-server] mwiencek closed pull request #531: Run UI tests in a headless chrome environment (master...chrome-headless)
https://git.io/v70sw
5:05 AM
github has left the channel
5:32 AM
pingupingu joined the channel
5:33 AM
drsaunders has quit
5:55 AM
pingupingu has quit
6:19 AM
rgggn has quit
6:27 AM
rgggn joined the channel
6:48 AM
kyan has quit
6:56 AM
khan joined the channel
6:59 AM
khan has quit
6:59 AM
khan joined the channel
7:00 AM
khan is now known as saifulbkhan
7:06 AM
Sophist-UK has quit
7:08 AM
saifulbkhan has quit
7:10 AM
khan joined the channel
7:13 AM
MajorLurker has quit
7:37 AM
MajorLurker joined the channel
7:42 AM
arbenina_ joined the channel
7:49 AM
Quesito
Moin!
7:49 AM
MajorLurker
yello!
7:50 AM
Quesito
Coffee/vino clink clink MajorLurker 😉
7:51 AM
MajorLurker
no vino for me, operation tomorrow
7:51 AM
no coffee either for that matter.
7:52 AM
Will celebrate in a couple of weeks, hopefully.
7:54 AM
Quesito
Oh! Hope it goes well MajorLurker! Let us know!
7:54 AM
Wishing you a speedy recovery!
7:54 AM
MajorLurker
I hope the surgeon goes well!
7:54 AM
Thanks!
7:57 AM
arbenina_ has quit
8:00 AM
khan has quit
8:06 AM
Sophist-UK joined the channel
8:10 AM
drsaunders joined the channel
8:19 AM
drsaunders has quit
8:47 AM
rahulr has quit
8:47 AM
Gore|woerk has quit
8:47 AM
sampsyo has quit
8:47 AM
spuniun has quit
8:47 AM
navap has quit
8:47 AM
arbenina_ joined the channel
8:49 AM
jwf has quit
8:54 AM
jwf joined the channel
8:58 AM
Nyanko-sensei joined the channel
9:01 AM
D4RK-PH0ENiX has quit
9:05 AM
agentsim has quit
9:06 AM
agentsim joined the channel
9:10 AM
agentsim has quit
9:11 AM
MajorLurker has quit
9:14 AM
D4RK-PH0ENiX joined the channel
9:15 AM
Nyanko-sensei has quit
9:31 AM
Gore|woerk joined the channel
9:31 AM
navap joined the channel
9:33 AM
sampsyo joined the channel
9:33 AM
rahulr joined the channel
9:35 AM
spuniun joined the channel
9:36 AM
lazka joined the channel
9:39 AM
MajorLurker joined the channel
9:40 AM
github joined the channel
9:40 AM
github
[critiquebrainz] ferbncode opened pull request #145: Fix ISE on entity pages involving mbid redirects. (master...sentry-cb3D)
https://git.io/v7Xuj
9:40 AM
github has left the channel
9:44 AM
Kode has quit
9:45 AM
Kode_ joined the channel
9:51 AM
zas
samj1912: ping
9:52 AM
samj1912
zas: pong
9:53 AM
zas
9:54 AM
samj1912
It's using qt4
9:54 AM
So definitely doesn't
9:54 AM
zas
so it should be rebased on 1.0 right ?
9:55 AM
samj1912
But isn't 1.0 our default branch on picard plugins?
9:55 AM
Yes
9:56 AM
Should we delete the master branch from picard plugins?
9:56 AM
It creates unnecessary confusion?
9:56 AM
zas
it does, but master != 2.0 (and != 1.0 too)
9:57 AM
hence my question
9:57 AM
the PR is based on master
9:57 AM
samj1912
Yeah
9:57 AM
We should remove master
9:58 AM
As for now, we can ask the guy to rebase it against 1.0
9:58 AM
I manually changed the base but it has merge conflicts
9:58 AM
github joined the channel
9:58 AM
github
[critiquebrainz] ferbncode opened pull request #146: CB-231: Add wrapper for fetch_multiple_places for a single MBID (master...wrapper-get-place-by-gid)
https://git.io/v7Xg1
9:58 AM
github has left the channel
9:58 AM
zas
yep
10:11 AM
github joined the channel
10:11 AM
github
[picard-plugins] zas closed pull request #107: featartistsintitles.py: also remove feat. artists from sort tags (master...patch-1)
https://git.io/vHSe0
10:11 AM
github has left the channel
10:13 AM
zas
samj1912: deleting the branch causes PRs based on it to close
10:13 AM
samj1912
They all need to be re based then
10:14 AM
We can ask the authors to rebase accordingly
10:20 AM
zas
yup
10:52 AM
D4RK-PH0ENiX has quit
10:52 AM
D4RK-PH0ENiX joined the channel
10:53 AM
reosarevok
10:55 AM
samj1912
Yes I saw
10:55 AM
PICARD-990
10:55 AM
BrainzBot
10:57 AM
samj1912
I don't think we made the changes he thinks we did
10:58 AM
We simply added an extension point which defaults to the normal behavior and can be overwritten by a plugin
10:59 AM
I don't think he went through the merged commits
10:59 AM
We solved both the problems since there are compatibility issues
10:59 AM
There is a plugin you can install for whichever way you want your tags
11:01 AM
The plugin pr was closed due to a rebase problem
11:18 AM
reosarevok
You might want to comment with that on either the PR or the forum :)
11:38 AM
MarcusPie joined the channel
12:06 PM
khan joined the channel
12:08 PM
khan is now known as saifulbkhan
12:08 PM
saifulbkhan is now known as khan
12:29 PM
D4RK-PH0ENiX has quit
12:34 PM
Gazooo has quit
12:37 PM
D4RK-PH0ENiX joined the channel
12:42 PM
D4RK-PH0ENiX has quit
12:47 PM
D4RK-PH0ENiX joined the channel
12:48 PM
Gazooo joined the channel
12:55 PM
psolanki
13:17 PM
Gentlecat
psolanki: ok. keep in mind that the license needs to be included
13:17 PM
psolanki
noted
13:18 PM
And did you render the rating?
13:19 PM
Gentlecat
13:19 PM
which means you might not even need to copy the source code
13:20 PM
psolanki
But I have made many changes like data-value, color, titles etc
13:23 PM
Gentlecat
alright
14:06 PM
agentsim joined the channel
14:11 PM
agentsim has quit
14:21 PM
agentsim joined the channel
14:34 PM
ruaok finally gets smart and uses a VM for VM build testing
14:34 PM
ruaok
much faster than this borrowed net connection
14:40 PM
reosarevok
Freso: how did I add someone to the autoeditors group?
14:42 PM
madmouser1 joined the channel
14:44 PM
antfoo has quit
14:52 PM
ruaok
I forget. who owns the copyright of GSoC work? Org or student?