13:52 PM
iliekcomputers
13:54 PM
ruaok
code running. edited `listenbrainz/webserver/static/js/graphs.js`
13:54 PM
no output from listenbrainz_static_builder_1
13:54 PM
iliekcomputers
did the changes come through in the container?
13:54 PM
ruaok
web_1 container?
13:54 PM
iliekcomputers
docker exec -it listenbrainz_static_builder_1 cat /static/js/graphs.js
13:55 PM
should be in both.
13:55 PM
ruaok
verified.
13:55 PM
iliekcomputers
change one of the files in static/js/jsx/
13:56 PM
the webpack config is set to watch the files there
13:56 PM
>verified.
13:56 PM
this means that the volume is setup correctly, i guess.
13:56 PM
>change one of the files in static/js/jsx/
13:56 PM
ruaok
that works!
13:56 PM
iliekcomputers
works meaning?
13:57 PM
ruaok
13:57 PM
iliekcomputers
lol
13:57 PM
nice
13:57 PM
didn't even change anything
13:57 PM
HenryG has quit
13:57 PM
ruaok
it was a comment that I changed. no actual code.
13:58 PM
so was I editing a wrong file and that is why it didn't fire?
13:58 PM
iliekcomputers
ruaok: might be it, although I remember you saying you changed profile.jsx too
13:58 PM
ruaok
is it supposed to fire on `listenbrainz/webserver/static`
13:58 PM
I did.
13:58 PM
iliekcomputers
it'll fire on changes in the jsx files.
13:59 PM
webpack only builds the jsx files as far as i understand.
13:59 PM
ruaok
yep, but not outside the jsx files.
13:59 PM
ok, so it works as expected then?
13:59 PM
sure looks that way.
13:59 PM
iliekcomputers
lol yea.
13:59 PM
nice
13:59 PM
Cyna joined the channel
14:00 PM
ruaok
ok, let me read #513 in detail.
14:00 PM
or... is there another PR I should start with?
14:01 PM
iliekcomputers
513 first.
14:01 PM
then we can do 509
14:01 PM
ruaok
k
14:01 PM
7 line Dockerfile. lol
14:02 PM
iliekcomputers
:(
14:02 PM
ruaok
I see nothing wrong with that. this is a great fix, I think.
14:04 PM
ruaok moves on to 509
14:04 PM
do you need to merge or rebase 513 before I tackle 509?
14:05 PM
iliekcomputers
yes, 513 merges into 509
14:06 PM
merged.
14:06 PM
ruaok
513 is hard for me to review. I don't know react.
14:07 PM
iliekcomputers
i just looked at the python parts and the webpack setup.
14:07 PM
ruaok
those parts look fine -- mostly stuff from 513...
14:08 PM
iliekcomputers adds learning react to list
14:09 PM
good idea.
14:10 PM
I can wait the 20 minutes that will take you.
14:10 PM
go!
14:10 PM
iliekcomputers
lol
14:10 PM
ruaok
damn code ninja you are. :)
14:11 PM
iliekcomputers
:)
14:11 PM
509 is the branch that is running on beta I think.
14:11 PM
I vote for merging and fixing problems as we go forward.
14:12 PM
ruaok
agreed.
14:12 PM
ruaok reads 512
14:12 PM
iliekcomputers
+1
14:13 PM
merged #509
14:16 PM
ruaok
512 looks good to me.
14:16 PM
shall we toss #488 ?
14:16 PM
how about merging $70?
14:16 PM
#470
14:17 PM
iliekcomputers
ruaok: yes, 488 needs closing.
14:17 PM
I think alastairp might have some comments on 470, other than that it looks good to me.
14:18 PM
ruaok
maybe we should merge #470. that seems to get his attention to PRs. 🤣
14:18 PM
alastairp
hah
14:18 PM
ruaok
oh hai.
14:18 PM
alastairp
not true, I promise
14:18 PM
470 looks ok, go ahead
14:18 PM
ruaok
glad you finally got the root beer.
14:18 PM
woo!
14:18 PM
PR zero coming quickly!
14:18 PM
alastairp
that is, I've not actually tested it myself
14:19 PM
but iliekcomputers' comments were good, and vansika made the changes in response to it
14:19 PM
so sure, let's see how it goes
14:19 PM
ruaok is building the spotify-permissions branch
14:20 PM
just glancing through the changed files again, I don't see any specific tests for expiring sessions by changing a user's alternate user id
14:20 PM
oh,
14:20 PM
iliekcomputers: did we talk about defaulting the user_login_id to the username
14:20 PM
so that users won't get signed out?
14:22 PM
iliekcomputers
alastairp: hmm, i think we did. defaulting to user IDs, I guess?
14:22 PM
alastairp
whatever the current thing that we use to identify users is
14:23 PM
HenryG joined the channel
14:24 PM
ruaok
> the spotipy lib has a bug which makes it lose the scope returned by the Spotify API.
14:24 PM
in this case iliekcomputers imported/crafted a custom function to deal with this.
14:24 PM
alastairp
ruaok: if you didn't know, spotipy is paul lamere, so we should just fix the bug and ask him to make a new release ;)
14:25 PM
iliekcomputers
14:25 PM
ruaok
an ok solution.. an alternative would be to fork the repo, fix the issue and then send a PR and use our repo for our builds.
14:25 PM
alastairp
absolutely
14:25 PM
iliekcomputers
just need to remove this line.
14:25 PM
alastairp
"fix the bug", I mean send a PR
14:25 PM
ruaok
32 PRs.
14:25 PM
sigh.
14:25 PM
iliekcomputers
i can send a PR and once a release is done, remove the extra code I added.
14:26 PM
ruaok misses the old days
14:26 PM
ruaok
yeah, lets do that.
14:26 PM
iliekcomputers
cool.
14:26 PM
code_master5
woah! 32! 👏
14:27 PM
ruaok
iliekcomputers: the only real comment I have on #511 is the name of the column "active".
14:27 PM
that seems... confusing in this context.
14:27 PM
"record_listens" ?
14:27 PM
alastairp
ruaok: the good old days when the maintainer disappears and no one is able to suggest changes?
14:27 PM
:)
14:27 PM
ruaok
good ole days when we ran off to hack days all the time.
14:27 PM
alastairp
oh yeah, those days too
14:28 PM
ruaok
but 32PRs isn't exactly oozing with confidence that this is a priority for Paul, no?
14:28 PM
alastairp
iliekcomputers: why is that a bug?
14:28 PM
sure
14:28 PM
iliekcomputers
alastairp: the Spotify api sends the permissions associated with the code itself.
14:29 PM
alastairp
instead of being able to request a new one?'
14:29 PM
iliekcomputers
so, we have a use case where we have the code from the callback request but we don't know what permissions the user has granted.
14:29 PM
if spotipy overwrites the data sent by the API, we don't have a way of knowing what permissions were granted.
14:29 PM
alastairp
right, drat
14:29 PM
code_master5
About CB-315, contributions for last 7 days or starting from Monday?
14:29 PM
BrainzBot
14:30 PM
iliekcomputers
code_master5: not sure, what does MusicBrainz do?
14:30 PM
alastairp
14:30 PM
I'm not offering to look at this myself, but just saying that it looks like there was a reason that this guy made the change as-is
14:31 PM
code_master5
iliekcomputers: MB shows only recent additions on homepage! 🤔
14:32 PM
Cyna
Hi Im working on the Music Brainz app
14:33 PM
I cant find the app on Play Store
14:33 PM
code_master5
amCap1712: ^
14:34 PM
Cyna: Well, right now it's a work in progress. Please consult amCap1712 for more info.
14:34 PM
iliekcomputers
alastairp: it looks like they're trying to save the scope in the token info, but the thing is that the spotify API now returns the `scope` key itself.
14:34 PM
so overwriting it doesn't really make sense.
14:34 PM
amCap1712
code_master5: 👍
14:35 PM
cyna: do you mean the test version I am working on or the official app which was in use previously?
14:35 PM
iliekcomputers
ruaok: do you want to do a schema change?
14:35 PM
alastairp
right, do you think that this is a change that spotify made since the change was added?
14:36 PM
iliekcomputers
yes.
14:36 PM
alastairp
ok! that's fine then
14:36 PM
iliekcomputers
i can't find the spotify changelog, but let me look.
14:36 PM
ruaok
just like a root canal, no one ever wants to do a schema change. :(
14:36 PM
iliekcomputers
lol
14:36 PM
alastairp
iliekcomputers: nah, no problem
14:36 PM
iliekcomputers
but if we want to change the name of the column, we should also consider storing permissions we've been granted in the db too.
14:37 PM
ruaok
iliekcomputers: that was my original hope.
14:37 PM
alastairp
I'm sure that if ruaok or I tweet a paul and show that it's for a good cause, he can make a PR :)
14:37 PM
uh, pr-> release
14:37 PM
ruaok
I'd be happy to tweet.
14:37 PM
iliekcomputers: let's either fix this correctly with a schema change or make a ticket that next time we touch anything related to this, we fix it properly.
14:38 PM
iliekcomputers
let me make a PR, then tweets would be helpful.
14:38 PM
ruaok
I'll leave that decision to you.
14:38 PM
iliekcomputers
let's just fix it rn.
14:39 PM
14:39 PM
ruaok
what is the sound that a ninja makes when getting ready to fight?
14:39 PM
oh wait, ninjas make no sounds.