13:52 PM
iliekcomputers
2019-02-08 03906, 2019
13:54 PM
ruaok
code running. edited `listenbrainz/webserver/static/js/graphs.js`
2019-02-08 03920, 2019
13:54 PM
ruaok
no output from listenbrainz_static_builder_1
2019-02-08 03939, 2019
13:54 PM
iliekcomputers
did the changes come through in the container?
2019-02-08 03953, 2019
13:54 PM
ruaok
web_1 container?
2019-02-08 03957, 2019
13:54 PM
iliekcomputers
docker exec -it listenbrainz_static_builder_1 cat /static/js/graphs.js
2019-02-08 03903, 2019
13:55 PM
iliekcomputers
should be in both.
2019-02-08 03923, 2019
13:55 PM
ruaok
verified.
2019-02-08 03954, 2019
13:55 PM
iliekcomputers
change one of the files in static/js/jsx/
2019-02-08 03908, 2019
13:56 PM
iliekcomputers
the webpack config is set to watch the files there
2019-02-08 03920, 2019
13:56 PM
iliekcomputers
>verified.
2019-02-08 03932, 2019
13:56 PM
iliekcomputers
this means that the volume is setup correctly, i guess.
2019-02-08 03941, 2019
13:56 PM
iliekcomputers
>change one of the files in static/js/jsx/
2019-02-08 03951, 2019
13:56 PM
ruaok
that works!
2019-02-08 03958, 2019
13:56 PM
iliekcomputers
works meaning?
2019-02-08 03911, 2019
13:57 PM
ruaok
2019-02-08 03924, 2019
13:57 PM
iliekcomputers
lol
2019-02-08 03927, 2019
13:57 PM
iliekcomputers
nice
2019-02-08 03932, 2019
13:57 PM
iliekcomputers
didn't even change anything
2019-02-08 03935, 2019
13:57 PM
HenryG has quit
2019-02-08 03944, 2019
13:57 PM
ruaok
it was a comment that I changed. no actual code.
2019-02-08 03901, 2019
13:58 PM
ruaok
so was I editing a wrong file and that is why it didn't fire?
2019-02-08 03927, 2019
13:58 PM
iliekcomputers
ruaok: might be it, although I remember you saying you changed profile.jsx too
2019-02-08 03928, 2019
13:58 PM
ruaok
is it supposed to fire on `listenbrainz/webserver/static`
2019-02-08 03934, 2019
13:58 PM
ruaok
I did.
2019-02-08 03942, 2019
13:58 PM
iliekcomputers
it'll fire on changes in the jsx files.
2019-02-08 03900, 2019
13:59 PM
iliekcomputers
webpack only builds the jsx files as far as i understand.
2019-02-08 03901, 2019
13:59 PM
ruaok
yep, but not outside the jsx files.
2019-02-08 03911, 2019
13:59 PM
ruaok
ok, so it works as expected then?
2019-02-08 03914, 2019
13:59 PM
ruaok
sure looks that way.
2019-02-08 03919, 2019
13:59 PM
iliekcomputers
lol yea.
2019-02-08 03919, 2019
13:59 PM
iliekcomputers
nice
2019-02-08 03936, 2019
13:59 PM
Cyna joined the channel
2019-02-08 03928, 2019
14:00 PM
ruaok
ok, let me read #513 in detail.
2019-02-08 03935, 2019
14:00 PM
ruaok
or... is there another PR I should start with?
2019-02-08 03900, 2019
14:01 PM
iliekcomputers
513 first.
2019-02-08 03921, 2019
14:01 PM
iliekcomputers
then we can do 509
2019-02-08 03926, 2019
14:01 PM
ruaok
k
2019-02-08 03958, 2019
14:01 PM
ruaok
7 line Dockerfile. lol
2019-02-08 03919, 2019
14:02 PM
iliekcomputers
:(
2019-02-08 03948, 2019
14:02 PM
ruaok
I see nothing wrong with that. this is a great fix, I think.
2019-02-08 03905, 2019
14:04 PM
ruaok moves on to 509
2019-02-08 03942, 2019
14:04 PM
ruaok
do you need to merge or rebase 513 before I tackle 509?
2019-02-08 03903, 2019
14:05 PM
iliekcomputers
yes, 513 merges into 509
2019-02-08 03921, 2019
14:06 PM
iliekcomputers
merged.
2019-02-08 03947, 2019
14:06 PM
ruaok
513 is hard for me to review. I don't know react.
2019-02-08 03904, 2019
14:07 PM
iliekcomputers
i just looked at the python parts and the webpack setup.
2019-02-08 03930, 2019
14:07 PM
ruaok
those parts look fine -- mostly stuff from 513...
2019-02-08 03931, 2019
14:08 PM
iliekcomputers adds learning react to list
2019-02-08 03957, 2019
14:09 PM
ruaok
good idea.
2019-02-08 03904, 2019
14:10 PM
ruaok
I can wait the 20 minutes that will take you.
2019-02-08 03906, 2019
14:10 PM
ruaok
go!
2019-02-08 03910, 2019
14:10 PM
iliekcomputers
lol
2019-02-08 03930, 2019
14:10 PM
ruaok
damn code ninja you are. :)
2019-02-08 03920, 2019
14:11 PM
iliekcomputers
:)
2019-02-08 03930, 2019
14:11 PM
iliekcomputers
509 is the branch that is running on beta I think.
2019-02-08 03942, 2019
14:11 PM
iliekcomputers
I vote for merging and fixing problems as we go forward.
2019-02-08 03900, 2019
14:12 PM
ruaok
agreed.
2019-02-08 03913, 2019
14:12 PM
ruaok reads 512
2019-02-08 03917, 2019
14:12 PM
iliekcomputers
+1
2019-02-08 03946, 2019
14:13 PM
iliekcomputers
merged #509
2019-02-08 03912, 2019
14:16 PM
ruaok
512 looks good to me.
2019-02-08 03918, 2019
14:16 PM
ruaok
shall we toss #488 ?
2019-02-08 03923, 2019
14:16 PM
ruaok
how about merging $70?
2019-02-08 03928, 2019
14:16 PM
ruaok
#470
2019-02-08 03902, 2019
14:17 PM
iliekcomputers
ruaok: yes, 488 needs closing.
2019-02-08 03925, 2019
14:17 PM
iliekcomputers
I think alastairp might have some comments on 470, other than that it looks good to me.
2019-02-08 03903, 2019
14:18 PM
ruaok
maybe we should merge #470. that seems to get his attention to PRs. 🤣
2019-02-08 03908, 2019
14:18 PM
alastairp
hah
2019-02-08 03915, 2019
14:18 PM
ruaok
oh hai.
2019-02-08 03915, 2019
14:18 PM
alastairp
not true, I promise
2019-02-08 03920, 2019
14:18 PM
alastairp
470 looks ok, go ahead
2019-02-08 03923, 2019
14:18 PM
ruaok
glad you finally got the root beer.
2019-02-08 03925, 2019
14:18 PM
ruaok
woo!
2019-02-08 03930, 2019
14:18 PM
ruaok
PR zero coming quickly!
2019-02-08 03937, 2019
14:18 PM
alastairp
that is, I've not actually tested it myself
2019-02-08 03900, 2019
14:19 PM
alastairp
but iliekcomputers' comments were good, and vansika made the changes in response to it
2019-02-08 03905, 2019
14:19 PM
alastairp
so sure, let's see how it goes
2019-02-08 03916, 2019
14:19 PM
ruaok is building the spotify-permissions branch
2019-02-08 03903, 2019
14:20 PM
alastairp
just glancing through the changed files again, I don't see any specific tests for expiring sessions by changing a user's alternate user id
2019-02-08 03923, 2019
14:20 PM
alastairp
oh,
2019-02-08 03950, 2019
14:20 PM
alastairp
iliekcomputers: did we talk about defaulting the user_login_id to the username
2019-02-08 03957, 2019
14:20 PM
alastairp
so that users won't get signed out?
2019-02-08 03912, 2019
14:22 PM
iliekcomputers
alastairp: hmm, i think we did. defaulting to user IDs, I guess?
2019-02-08 03930, 2019
14:22 PM
alastairp
whatever the current thing that we use to identify users is
2019-02-08 03926, 2019
14:23 PM
HenryG joined the channel
2019-02-08 03903, 2019
14:24 PM
ruaok
> the spotipy lib has a bug which makes it lose the scope returned by the Spotify API.
2019-02-08 03923, 2019
14:24 PM
ruaok
in this case iliekcomputers imported/crafted a custom function to deal with this.
2019-02-08 03939, 2019
14:24 PM
alastairp
ruaok: if you didn't know, spotipy is paul lamere, so we should just fix the bug and ask him to make a new release ;)
2019-02-08 03909, 2019
14:25 PM
iliekcomputers
2019-02-08 03912, 2019
14:25 PM
ruaok
an ok solution.. an alternative would be to fork the repo, fix the issue and then send a PR and use our repo for our builds.
2019-02-08 03918, 2019
14:25 PM
alastairp
absolutely
2019-02-08 03921, 2019
14:25 PM
iliekcomputers
just need to remove this line.
2019-02-08 03928, 2019
14:25 PM
alastairp
"fix the bug", I mean send a PR
2019-02-08 03948, 2019
14:25 PM
ruaok
32 PRs.
2019-02-08 03953, 2019
14:25 PM
ruaok
sigh.
2019-02-08 03958, 2019
14:25 PM
iliekcomputers
i can send a PR and once a release is done, remove the extra code I added.
2019-02-08 03900, 2019
14:26 PM
ruaok misses the old days
2019-02-08 03910, 2019
14:26 PM
ruaok
yeah, lets do that.
2019-02-08 03915, 2019
14:26 PM
iliekcomputers
cool.
2019-02-08 03916, 2019
14:26 PM
code_master5
woah! 32! 👏
2019-02-08 03900, 2019
14:27 PM
ruaok
iliekcomputers: the only real comment I have on #511 is the name of the column "active".
2019-02-08 03913, 2019
14:27 PM
ruaok
that seems... confusing in this context.
2019-02-08 03921, 2019
14:27 PM
ruaok
"record_listens" ?
2019-02-08 03922, 2019
14:27 PM
alastairp
ruaok: the good old days when the maintainer disappears and no one is able to suggest changes?
2019-02-08 03923, 2019
14:27 PM
alastairp
:)
2019-02-08 03943, 2019
14:27 PM
ruaok
good ole days when we ran off to hack days all the time.
2019-02-08 03948, 2019
14:27 PM
alastairp
oh yeah, those days too
2019-02-08 03903, 2019
14:28 PM
ruaok
but 32PRs isn't exactly oozing with confidence that this is a priority for Paul, no?
2019-02-08 03909, 2019
14:28 PM
alastairp
iliekcomputers: why is that a bug?
2019-02-08 03914, 2019
14:28 PM
alastairp
sure
2019-02-08 03942, 2019
14:28 PM
iliekcomputers
alastairp: the Spotify api sends the permissions associated with the code itself.
2019-02-08 03903, 2019
14:29 PM
alastairp
instead of being able to request a new one?'
2019-02-08 03914, 2019
14:29 PM
iliekcomputers
so, we have a use case where we have the code from the callback request but we don't know what permissions the user has granted.
2019-02-08 03943, 2019
14:29 PM
iliekcomputers
if spotipy overwrites the data sent by the API, we don't have a way of knowing what permissions were granted.
2019-02-08 03952, 2019
14:29 PM
alastairp
right, drat
2019-02-08 03956, 2019
14:29 PM
code_master5
About CB-315, contributions for last 7 days or starting from Monday?
2019-02-08 03956, 2019
14:29 PM
BrainzBot
2019-02-08 03914, 2019
14:30 PM
iliekcomputers
code_master5: not sure, what does MusicBrainz do?
2019-02-08 03931, 2019
14:30 PM
alastairp
2019-02-08 03954, 2019
14:30 PM
alastairp
I'm not offering to look at this myself, but just saying that it looks like there was a reason that this guy made the change as-is
2019-02-08 03942, 2019
14:31 PM
code_master5
iliekcomputers: MB shows only recent additions on homepage! 🤔
2019-02-08 03957, 2019
14:32 PM
Cyna
Hi Im working on the Music Brainz app
2019-02-08 03906, 2019
14:33 PM
Cyna
I cant find the app on Play Store
2019-02-08 03928, 2019
14:33 PM
code_master5
amCap1712: ^
2019-02-08 03905, 2019
14:34 PM
code_master5
Cyna: Well, right now it's a work in progress. Please consult amCap1712 for more info.
2019-02-08 03936, 2019
14:34 PM
iliekcomputers
alastairp: it looks like they're trying to save the scope in the token info, but the thing is that the spotify API now returns the `scope` key itself.
2019-02-08 03948, 2019
14:34 PM
iliekcomputers
so overwriting it doesn't really make sense.
2019-02-08 03958, 2019
14:34 PM
amCap1712
code_master5: 👍
2019-02-08 03901, 2019
14:35 PM
amCap1712
cyna: do you mean the test version I am working on or the official app which was in use previously?
2019-02-08 03947, 2019
14:35 PM
iliekcomputers
ruaok: do you want to do a schema change?
2019-02-08 03953, 2019
14:35 PM
alastairp
right, do you think that this is a change that spotify made since the change was added?
2019-02-08 03900, 2019
14:36 PM
iliekcomputers
yes.
2019-02-08 03905, 2019
14:36 PM
alastairp
ok! that's fine then
2019-02-08 03918, 2019
14:36 PM
iliekcomputers
i can't find the spotify changelog, but let me look.
2019-02-08 03920, 2019
14:36 PM
ruaok
just like a root canal, no one ever wants to do a schema change. :(
2019-02-08 03925, 2019
14:36 PM
iliekcomputers
lol
2019-02-08 03949, 2019
14:36 PM
alastairp
iliekcomputers: nah, no problem
2019-02-08 03953, 2019
14:36 PM
iliekcomputers
but if we want to change the name of the column, we should also consider storing permissions we've been granted in the db too.
2019-02-08 03903, 2019
14:37 PM
ruaok
iliekcomputers: that was my original hope.
2019-02-08 03909, 2019
14:37 PM
alastairp
I'm sure that if ruaok or I tweet a paul and show that it's for a good cause, he can make a PR :)
2019-02-08 03920, 2019
14:37 PM
alastairp
uh, pr-> release
2019-02-08 03931, 2019
14:37 PM
ruaok
I'd be happy to tweet.
2019-02-08 03959, 2019
14:37 PM
ruaok
iliekcomputers: let's either fix this correctly with a schema change or make a ticket that next time we touch anything related to this, we fix it properly.
2019-02-08 03906, 2019
14:38 PM
iliekcomputers
let me make a PR, then tweets would be helpful.
2019-02-08 03916, 2019
14:38 PM
ruaok
I'll leave that decision to you.
2019-02-08 03939, 2019
14:38 PM
iliekcomputers
let's just fix it rn.
2019-02-08 03920, 2019
14:39 PM
iliekcomputers
2019-02-08 03933, 2019
14:39 PM
ruaok
what is the sound that a ninja makes when getting ready to fight?
2019-02-08 03942, 2019
14:39 PM
ruaok
oh wait, ninjas make no sounds.
