ok, let me chat with Mr_Monkey for a minute, then I'm on that.
2019-03-06 06538, 2019
CatQuest
*may-be
2019-03-06 06552, 2019
CatQuest
π
2019-03-06 06507, 2019
reosarevok
CatQuest: improvement works
2019-03-06 06507, 2019
pulkit6559
alastairp: i figure we could have a new artist page in acousticbrainz, should i open a ticket for it?
2019-03-06 06522, 2019
alastairp
pulkit6559: what would the artist page show?
2019-03-06 06535, 2019
alastairp
(there's an artist page on musicbrainz already!)
2019-03-06 06509, 2019
reosarevok
alastairp: if anything, I'd show exclusively recordings for which you have actual submitted data, but not sure if needed
2019-03-06 06528, 2019
reosarevok
yvanzo: so I'd suggest renaming MBS-9926 to "Convert subscribers pages to React" and then adding a new "Convert user subscriptions lists to React" ticket - given nothing from that ticket is in beta yet, I think it's not really that confusing and it makes more sense than waiting to merge until the entire subscriptions/ folder is converted. It'd help us merge this now for the next beta, and then work on the other thing post schema change
because a single query can with right inc parameters can get us all data we need in a single query, I suppose
2019-03-06 06553, 2019
amCap1712
gr0uch0mars: ^
2019-03-06 06507, 2019
gr0uch0mars
yes, I was thinking about `inc` params. We should use them
2019-03-06 06513, 2019
amCap1712
or we should wait for tabs to open and query each separately
2019-03-06 06517, 2019
gr0uch0mars
I don't think they will delay too much the response
2019-03-06 06524, 2019
amCap1712
I think one query is better
2019-03-06 06549, 2019
amCap1712
because I read that viewpager keeps 2 offpage fragments on hold as well
2019-03-06 06555, 2019
amCap1712
and we have 4
2019-03-06 06508, 2019
amCap1712
so in any case there will be 3 calls
2019-03-06 06524, 2019
amCap1712
so going with one query
2019-03-06 06526, 2019
adhawkins
ruaok: Last replication packet took about 25 minutes to process. Not sure if that's better or not to be honest! Could be disk I guess...
2019-03-06 06531, 2019
reosarevok
yvanzo: it is, if we split the "root/user/subscriptions/" part mentioned in the ticket description to a different ticket :)
2019-03-06 06537, 2019
reosarevok
(that's what I'm asking about)
2019-03-06 06550, 2019
reosarevok
(I have no PRs nor code written for that ATM)
2019-03-06 06553, 2019
gr0uch0mars
yes, and in the future I was thinking of caching that single response. If you re-enter the same artist, you already have all the necessary info
2019-03-06 06509, 2019
gr0uch0mars
requesting multiple queries would make caching more difficult
2019-03-06 06524, 2019
amCap1712
retrofit does auto caching i suppose
2019-03-06 06554, 2019
amCap1712
also in searchviewmodel , we first check if uery had changed and only then we uery again otherwise display the same
2019-03-06 06502, 2019
gr0uch0mars
between sessions? I meant if you close the app and open it tomorrow
2019-03-06 06509, 2019
amCap1712
no not that
2019-03-06 06520, 2019
gr0uch0mars
ah ok. I was thinking too much into future :)
2019-03-06 06521, 2019
yvanzo
reosarevok: IIUC, only subscribers lists have been converted so far (if we include this PR), the rest for this ticket is subscriptions lists, right?
2019-03-06 06524, 2019
amCap1712
as long as its in memory/background
2019-03-06 06543, 2019
amCap1712
we can do that in a util class
2019-03-06 06546, 2019
gr0uch0mars
yes, your implementation is great, too. We should query only when strictly necessary
2019-03-06 06559, 2019
reosarevok
yvanzo: yes, but while all the subscribers lists are sharing code and very related, the subscriptions lists are not connected to them :)
2019-03-06 06536, 2019
reosarevok
(so we'd definitely be adding them as separate tickets if we were doing it now, with our smaller PR approach)
2019-03-06 06542, 2019
yvanzo
reosarevok: got it :) sure, go ahead!
2019-03-06 06545, 2019
amCap1712
I'll try to do it here as well with MBIDs
2019-03-06 06508, 2019
reosarevok
yvanzo: yay, thanks
2019-03-06 06509, 2019
CatQuest
huh. why do we not have "session" ability for performance (instrument/vocal) roles
2019-03-06 06523, 2019
reosarevok
CatQuest: what do you mean? :)
2019-03-06 06535, 2019
gr0uch0mars
amCap1712: I was thinking of using the Repository to query first local DB (for cache) and, if not, then API
2019-03-06 06525, 2019
gr0uch0mars
amCap1712: just implement another data layer (cache in DB) in the Repo. So your ViewModels query are not touched
2019-03-06 06531, 2019
reosarevok
yvanzo: then I think there's only two sets of half-done things for me to finish sending for merge RN, the stats code and the ES6 changes. The stats has only one or two PRs left (the open one + one of the other two is where you had issues with a sample DB, haven't fixed that one yet)
iliekcomputers: On my side, I'm changing the follow page playlist functionality a bit, and that will only leave implementing refresh tokens for the player.
2019-03-06 06540, 2019
Prashant1223
hi, I am getting an error when importing the sql database in psql using command : sudo -u postgres pg_restore -e -C -O latest.sql -d postgres . Error showing is pg_restore: [archiver] input file appears to be a text format dump. Please use psql. Is there any other way to do it?
2019-03-06 06541, 2019
Mr_Monkey
I'd love to talk about it with you at some point
2019-03-06 06558, 2019
iliekcomputers
Mr_Monkey: I'm here right now if you want?
2019-03-06 06506, 2019
Mr_Monkey
As for ruaok , he's out at the moment, so won't speak for him.
2019-03-06 06508, 2019
Mr_Monkey
Sure :)
2019-03-06 06543, 2019
iliekcomputers
Prashant1223: what project is this?
2019-03-06 06507, 2019
Prashant1223
bookbrainz-site repository
2019-03-06 06526, 2019
CallerNo6
yvanzo, Cyna: hi, I'd like a link to that doc too please
2019-03-06 06533, 2019
Mr_Monkey
Sooo. Currently the user's spotify token we get from the db is used to connect to the web playback api, which returns a token that expires after an hour. Not ideal. How did you set it up on the server side? Is there any way I can use the same method ?
2019-03-06 06542, 2019
CallerNo6
(tt β react that is)
2019-03-06 06542, 2019
Mr_Monkey
I.e a private API endpoint or something
2019-03-06 06540, 2019
iliekcomputers
there isn't an endpoint yet.
2019-03-06 06544, 2019
iliekcomputers
but i could create one.
2019-03-06 06544, 2019
Mr_Monkey
Prashant1223: I'll be with you very soon.
2019-03-06 06557, 2019
Prashant1223
Okay
2019-03-06 06503, 2019
CatQuest
iliekcomputers: i am annoyed how norway is not in this list
2019-03-06 06512, 2019
CatQuest
but i pay like 79nok for 1 GB so
2019-03-06 06530, 2019
Mr_Monkey
iliekcomputers: Well, that would be great.
2019-03-06 06537, 2019
iliekcomputers
i don't think LB has any private API endpoints yet.
2019-03-06 06547, 2019
Mr_Monkey
I suppose that means you have it implemented in the server at the moment
2019-03-06 06502, 2019
iliekcomputers
Mr_Monkey: yep, there is a function to refresh tokens.
2019-03-06 06506, 2019
iliekcomputers finds a link.
2019-03-06 06523, 2019
pulkit6559
hi, is there a guide somewhere to the musicbrainz api?
pulkit6559: normally redirects will just get redirected, I think? :) Why?
2019-03-06 06558, 2019
iliekcomputers
we only refresh tokens during the import loop
2019-03-06 06552, 2019
pulkit6559
i was trying to work this out in AB "Use the musicbrainz mbid redirect tables to find more duplicates", so i think ill need to access endpoints for redirect tables
