0:04 AM
D4RK-PH0ENiX has quit
2019-07-08 18925, 2019
0:10 AM
Wizzup has quit
2019-07-08 18931, 2019
0:14 AM
Delemas
2019-07-08 18901, 2019
0:17 AM
Wizzup joined the channel
2019-07-08 18936, 2019
0:23 AM
D4RK-PH0ENiX joined the channel
2019-07-08 18943, 2019
0:23 AM
D4RK-PH0ENiX has quit
2019-07-08 18922, 2019
0:24 AM
D4RK-PH0ENiX joined the channel
2019-07-08 18951, 2019
0:25 AM
Wizzup has quit
2019-07-08 18959, 2019
0:25 AM
Wizzup joined the channel
2019-07-08 18942, 2019
0:30 AM
Wizzup has quit
2019-07-08 18957, 2019
1:02 AM
Nyanko-sensei joined the channel
2019-07-08 18900, 2019
1:06 AM
D4RK-PH0ENiX has quit
2019-07-08 18903, 2019
1:07 AM
Wizzup joined the channel
2019-07-08 18903, 2019
1:11 AM
ephemer0l has quit
2019-07-08 18950, 2019
1:11 AM
ephemer0l_ joined the channel
2019-07-08 18940, 2019
1:26 AM
Nyanko-sensei has quit
2019-07-08 18918, 2019
1:27 AM
D4RK-PH0ENiX joined the channel
2019-07-08 18916, 2019
1:31 AM
Wizzup has quit
2019-07-08 18924, 2019
1:48 AM
Wizzup joined the channel
2019-07-08 18959, 2019
2:03 AM
G0re joined the channel
2019-07-08 18942, 2019
2:06 AM
Gore has quit
2019-07-08 18909, 2019
2:10 AM
Wizzup has quit
2019-07-08 18950, 2019
2:16 AM
Wizzup joined the channel
2019-07-08 18925, 2019
2:23 AM
Wizzup has quit
2019-07-08 18923, 2019
2:24 AM
Wizzup joined the channel
2019-07-08 18918, 2019
2:32 AM
Wizzup has quit
2019-07-08 18956, 2019
2:47 AM
Wizzup joined the channel
2019-07-08 18940, 2019
2:48 AM
BestSteve has quit
2019-07-08 18903, 2019
2:50 AM
BestSteve joined the channel
2019-07-08 18946, 2019
2:53 AM
Wizzup has quit
2019-07-08 18958, 2019
3:09 AM
Wizzup joined the channel
2019-07-08 18917, 2019
3:17 AM
Lotheric has quit
2019-07-08 18904, 2019
3:18 AM
Lotheric joined the channel
2019-07-08 18932, 2019
3:18 AM
Wizzup has quit
2019-07-08 18926, 2019
3:31 AM
Wizzup joined the channel
2019-07-08 18920, 2019
3:44 AM
Wizzup has quit
2019-07-08 18945, 2019
3:48 AM
Wizzup joined the channel
2019-07-08 18921, 2019
4:40 AM
Wizzup has quit
2019-07-08 18925, 2019
4:47 AM
Wizzup joined the channel
2019-07-08 18906, 2019
5:05 AM
yvanzo
mo’’in’
2019-07-08 18911, 2019
5:43 AM
Lotheric_ joined the channel
2019-07-08 18916, 2019
5:43 AM
Lotheric has quit
2019-07-08 18932, 2019
6:14 AM
Gore|work joined the channel
2019-07-08 18906, 2019
6:15 AM
G0re has quit
2019-07-08 18951, 2019
6:56 AM
Nyanko-sensei joined the channel
2019-07-08 18917, 2019
6:58 AM
D4RK-PH0ENiX has quit
2019-07-08 18927, 2019
7:55 AM
ruaok
mooin
2019-07-08 18946, 2019
7:55 AM
ruaok
massive thunderstorms rolling over the city today...
2019-07-08 18923, 2019
7:59 AM
zas
mo'in
2019-07-08 18918, 2019
8:00 AM
amCap1712
hi zas
2019-07-08 18958, 2019
8:00 AM
amCap1712
i had opened a few tickets as discussed. can you take a look at those?
2019-07-08 18921, 2019
8:01 AM
amCap1712
PICARD-1551 , PICARD-1552, PICAD-1553
2019-07-08 18922, 2019
8:01 AM
BrainzBot
2019-07-08 18922, 2019
8:01 AM
BrainzBot
2019-07-08 18945, 2019
8:01 AM
amCap1712
PICARD-1553
2019-07-08 18945, 2019
8:01 AM
BrainzBot
2019-07-08 18909, 2019
8:02 AM
zas
amCap1712: yes, I saw, thanks we'll have a look soon
2019-07-08 18952, 2019
8:02 AM
amCap1712
yeah, that would be great
2019-07-08 18955, 2019
8:07 AM
pristine__
ruaok: hey!
2019-07-08 18912, 2019
8:08 AM
ruaok
hi!
2019-07-08 18939, 2019
8:10 AM
pristine__
Our next goal is to get recommendation on Lemmy and test on beta?
2019-07-08 18933, 2019
8:11 AM
ruaok
yes.
2019-07-08 18954, 2019
8:11 AM
pristine__
Okay.....What should be the approach?
2019-07-08 18951, 2019
8:12 AM
Nyanko-sensei has quit
2019-07-08 18951, 2019
8:13 AM
D4RK-PH0ENiX joined the channel
2019-07-08 18930, 2019
8:15 AM
gr0uch0mars joined the channel
2019-07-08 18930, 2019
8:28 AM
MajorLurker joined the channel
2019-07-08 18920, 2019
8:47 AM
BrainzGit
2019-07-08 18935, 2019
9:36 AM
alastairp
iliekcomputers: good morning, how are you for looking at https, ratelimiting, and init?
2019-07-08 18941, 2019
9:36 AM
alastairp
today, or tomorrow?
2019-07-08 18925, 2019
9:41 AM
ruaok
pristine__: let me get caught up on the work you've done last week.
2019-07-08 18930, 2019
9:41 AM
ruaok
2019-07-08 18908, 2019
9:42 AM
ruaok
I feel that this is a bit too specific for the things that have developed since you opened that PR....
2019-07-08 18903, 2019
10:48 AM
reosarevok
yvanzo, bitmap
2019-07-08 18923, 2019
10:48 AM
reosarevok
2019-07-08 18924, 2019
10:48 AM
BrainzBot
MBS-3871: Flag URLs with inappropriate content
2019-07-08 18901, 2019
11:26 AM
pristine__
ruaok: yes agreed #578 needs a lot of changes.
2019-07-08 18915, 2019
11:26 AM
ruaok
maybe close it for now?
2019-07-08 18928, 2019
11:26 AM
pristine__
Yup
2019-07-08 18941, 2019
11:26 AM
pristine__
I will close it.
2019-07-08 18948, 2019
11:26 AM
ruaok
I think a good first intermediary step is to store the data CF tracks into a new schema on lemmy.
2019-07-08 18948, 2019
11:26 AM
Lotheric_ is now known as Lotheric
2019-07-08 18917, 2019
11:27 AM
iliekcomputers
alastairp: morning, I haven't gotten to redirects now. Let me work on that, we can do a release today
2019-07-08 18931, 2019
11:27 AM
pristine__
How should the schema look?
2019-07-08 18944, 2019
11:27 AM
pristine__
Two different col/fields for two playlists.
2019-07-08 18912, 2019
11:28 AM
ruaok
well right now they should not even be playlists, but just tracks.
2019-07-08 18931, 2019
11:28 AM
pristine__
Yes, my bad. Tracks.
2019-07-08 18932, 2019
11:28 AM
iliekcomputers
ruaok: I've been testing incremental dumps over the past week. I think they should be ready for release after this batch of PRs.
2019-07-08 18957, 2019
11:28 AM
ruaok
iliekcomputers: great. I'm trying to touch up the last bits on the quickbooks stuff so that can finally be merged.
2019-07-08 18903, 2019
11:29 AM
ruaok
after that i'll circle back on PRs
2019-07-08 18929, 2019
11:31 AM
ruaok
pristine__: I guess the schema might be: row id, user id, track id, last_used (timestamp)
2019-07-08 18948, 2019
11:31 AM
ruaok
that way when we use the track, we can keep track of it having been used for a playlist, so we don't overuse it.
2019-07-08 18907, 2019
11:33 AM
BrainzGit
2019-07-08 18923, 2019
11:38 AM
pristine__
ruaok: so we will need to remember the timestamp in Spark when the track was displayed on beta for user to listen, and if the last used is greater than this timestamp, it means user has listened to the track, other wise not.
2019-07-08 18905, 2019
12:00 PM
iliekcomputers
how will you get the timestamps to spark?
2019-07-08 18925, 2019
12:07 PM
ruaok
my plan wasn't to make spark aware of timestamps.
2019-07-08 18955, 2019
12:07 PM
ruaok
I was hoping we can generate loads of tracks and store them in lemmy and keep timestamps there.
2019-07-08 18940, 2019
12:10 PM
pristine__
Umm.... Okay. CF spark will just generates loads of tracks and Lemmy will do the other work ( keeping track of tracks listened to by user etc.)
2019-07-08 18923, 2019
12:11 PM
ruaok
yep. let's hope that works for now. if we need to feed back which tracks have been used, we'll do that later.
2019-07-08 18917, 2019
12:12 PM
iliekcomputers
alright.
2019-07-08 18920, 2019
12:12 PM
pristine__
Cool.
2019-07-08 18913, 2019
12:15 PM
gr0uch0mars has quit
2019-07-08 18929, 2019
12:25 PM
iliekcomputers
>There are other GET methods here that we shouldn't redirect on either.
2019-07-08 18936, 2019
12:25 PM
iliekcomputers
alastairp: which ones are those exactly?
2019-07-08 18900, 2019
12:48 PM
alastairp
iliekcomputers: I was thinking about the legacy endpoints
2019-07-08 18936, 2019
12:50 PM
iliekcomputers
Right, all of them, I guess?
2019-07-08 18937, 2019
12:50 PM
alastairp
I'm not sure if it makes sense to keep them http-only, or just go ahead and do everything except legacy POST
2019-07-08 18904, 2019
12:51 PM
iliekcomputers
Would redirecting break clients?
2019-07-08 18929, 2019
12:51 PM
alastairp
it has the potential to break POSTs, which is why I don't want to do it, but I'm not sure about the GETs
2019-07-08 18956, 2019
12:52 PM
alastairp
especially since you added the exception to the whole api
2019-07-08 18911, 2019
12:53 PM
alastairp
if the legacy endpoints are part of the api, then it makes sense to exclude those too
2019-07-08 18902, 2019
12:54 PM
iliekcomputers
Hmm, yeah.
2019-07-08 18913, 2019
12:54 PM
iliekcomputers
Let's not redirect for all of them
2019-07-08 18949, 2019
12:56 PM
alastairp
2019-07-08 18930, 2019
12:57 PM
alastairp
I wonder if there's a version of that which will tell us the blueprint of the view too
2019-07-08 18944, 2019
12:57 PM
iliekcomputers
I guess adding exceptions for this will be harder, there's no prefix
2019-07-08 18908, 2019
12:58 PM
alastairp
there's no prefix, but it's in a separate blueprint
2019-07-08 18922, 2019
12:58 PM
iliekcomputers
Oh, you're looking at the same thing, great minds ;)
2019-07-08 18926, 2019
12:58 PM
iliekcomputers
Lemme take a look
2019-07-08 18918, 2019
13:02 PM
alastairp
2019-07-08 18928, 2019
13:02 PM
alastairp
> The endpoint for the :func:`url_for` function is prefixed with the name of the blueprint.
2019-07-08 18955, 2019
13:02 PM
alastairp
at the very least, we might just be able to do that - "if urlfor-name.startswith("blueprint.")
2019-07-08 18923, 2019
13:04 PM
alastairp
ah - I just noticed also that there are specific blueprint before_request handlers... does that make sense?
2019-07-08 18927, 2019
13:07 PM
iliekcomputers
That sounds nicer
2019-07-08 18948, 2019
13:07 PM
alastairp
we have quite a few regular BPs, though
2019-07-08 18933, 2019
13:14 PM
iliekcomputers
I was thinking of overriding it somehow for the API blueprints, but the startswith thing is probably less complicated and less work
2019-07-08 18914, 2019
13:20 PM
alastairp
setting a global one and then overriding it for the api one sounds a bit difficult/complext
2019-07-08 18940, 2019
13:20 PM
alastairp
mmm, so. additionally: if you're in a request context, `request.blueprint` is the text name of the blueprint
2019-07-08 18950, 2019
13:20 PM
alastairp
no need for any lookups. just match against a string
2019-07-08 18954, 2019
13:23 PM
BrainzGit
2019-07-08 18955, 2019
13:23 PM
BrainzBot
2019-07-08 18959, 2019
13:59 PM
iliekcomputers
alastairp: zas: what was the header to check to see the original protocol from flask? `X-Forwarded-Proto` is None
2019-07-08 18935, 2019
14:00 PM
alastairp
that's what it should be. maybe it's not set properly on beta?
2019-07-08 18951, 2019
14:00 PM
BrainzGit
2019-07-08 18953, 2019
14:00 PM
BrainzBot
2019-07-08 18953, 2019
14:00 PM
BrainzBot
2019-07-08 18922, 2019
14:02 PM
iliekcomputers
2019-07-08 18902, 2019
14:03 PM
iliekcomputers
2019-07-08 18954, 2019
14:08 PM
alastairp
if everything else does and just that one doesn't, I'd say it's an oversight
2019-07-08 18926, 2019
14:10 PM
D4RK-PH0ENiX has quit
2019-07-08 18919, 2019
14:11 PM
iliekcomputers
i'm not sure, i haven't really used that header
2019-07-08 18931, 2019
14:19 PM
CallerNo6 has quit
2019-07-08 18951, 2019
14:20 PM
yvanzo
reosarevok: it is clearly not top priority, but I wouldn't mark it as won't fix, just found it is related to MBS-6686 btw.
2019-07-08 18951, 2019
14:20 PM
BrainzBot
2019-07-08 18959, 2019
14:21 PM
iliekcomputers
alastairp: request.url contains http and https correctly, from me seeing. I think it's because right now we only have the one container for the webserver, gonna need zas to confirm
2019-07-08 18905, 2019
14:27 PM
D4RK-PH0ENiX joined the channel
2019-07-08 18957, 2019
14:51 PM
iliekcomputers
alastairp: if you're around, we should release ratelimiting today, i'm don't think this will be ready today.
2019-07-08 18928, 2019
15:03 PM
iliekcomputers
not sure why it's redirecting in tests, wtf. i'm gonna look at this tomorrow, this is a bit irritating.
2019-07-08 18949, 2019
15:11 PM
BrainzGit
2019-07-08 18942, 2019
16:27 PM
Cyna
bitmap: I need help sorting out flow errors in taskOne branch. After that I could continue my work with place entity
