[listenbrainz-server] paramsingh opened pull request #605 (master…param/lbdumps-use): Create a lbdumps user inside the container to use new storage boxes correctly. https://github.com/metabrainz/listenbrainz-serv...
> The goal of this project is to utilize the GTZAN dataset to train a convolutional neural network to classify melspectrograms into music genres
so it will suffer from bad training data, as usual. It'd be interesting to see how well the network works with better data
ruaok
Another job for AB, in time...
alastairp
we were looking to see if it would be possible to integrate one of these autotaggers into the extractor
it's too much data to extract enough info from audio to store in AB and build models, but we could extract a middle-ground that's useful for lots of tasks, and then integrate some really well-functioning models directly into the extractor to get some tags/annotations
it has the unfortunate limitation that we can't do the incremental model generation like we currently do
gr0uch0mars joined the channel
Gazooo has quit
rdswift has quit
akhilesh
Mr_Monkey: Please ping me, when you are available!
akhilesh: So far from what I see it's working fine, great to see !
akhilesh
now run the test-search.js only
D4RK-PH0ENiX joined the channel
CatQuest
akhilesh: I'm awake and i'm doing the dishes and making brekafast :D
akhilesh
something `npm test /...../test-search.js`
Mr_Monkey: ^
CatQuest
(i knew that wasnt for me akilesh ;))
alastairp
pristine__: hi, you mentioned me a few days ago. how are you?
Mr_Monkey
akhilesh: I see the "expected null to equal 'Work'" issue
akhilesh
yes, same request goes from test but result not coming from elasticsearch, check your test.json
that the issue Mr_Monkey
Mr_Monkey
akhilesh: I just put a breakpoint and ran the test again, and it looks like in the search endpoint definition, `const collection = req.query.collection || null;` ends up as null, because req.query.collection is undefined
Looks like the request sent doesn't have the collection
akhilesh
that ok I think, collection is not essential
Mr_Monkey
OK, sorry, that's not the issue
akhilesh
is any problem with config/test.json Mr_Monkey
gr0uch0mars has quit
Mr_Monkey
I need a bit of time, this is all new code for me. I'm walking through bit by bit to see what the problem might be
akhilesh
Mr_Monkey: once again, please share your debugging configuration in .vscode folder
Mr_Monkey
akhilesh: vscode folder is ignored by git, but here's my config:
I reached at issue Mr_Monkey, It the problem of reindexing, If you will change the data base in the test.json, will work fine. Please check
Means on testing time orm of bb_test database passed to the elastic search
Mr_Monkey
Not sure I understand that last sentence akhilesh. But an index issue is likely. I tried to reindex earlier but saw no issue
That being said, I shouldn't get search results from my test database, which means the index must be that of the main DB
akhilesh
did you check after changing `"database": "bookbrainz",` in test.json Mr_Monkey
amCap1712
gr0uch0mars: hi
Mr_Monkey
I trust your result, but let me check as well if you want
akhilesh
why not, please
Mr_Monkey
Well, I'm pretty sure the test code is going to wipe a lot of data from the database, but I can always recreate it
Tests do pass after changing the databse akhilesh
akhilesh
What it means?
I think, when test.search.js running no data present in the test db, that's why all result are null Mr_Monkey
But Not sure
Mr_Monkey
OK, I need a bit of time to think about this issue. we currently get ES indexes of the main database rather than the test one.
That being said, with the test currently as is, the search shouldn't return anything, as there are no entities in it when we start the test.
So we can either 1) fake the ES response or 2) add entity to the database and make sure ES has it indexed before querying it.
akhilesh
what do you prefer? Mine option 2
Mr_Monkey
akhilesh: I think it'll have to be option 1, as we don't have ElasticSearch set up for the automated tests
akhilesh
ok, that s also good option
Mr_Monkey
And it's likely to be a headache to set it up, slow down the tests, and become irrelevant soon
akhilesh
If I will remove second test, then no problem, In first test we are checking response structure which is passing in this situation also. Whats your opinion Mr_Monkey ?
Mr_Monkey
akhilesh: Let's do that for now, that give me the time to se if we need that second test and how to best fake ES
akhilesh
ok, Is any more functionality required for search endpoint Mr_Monkey ? I think it's fine for now.
Mr_Monkey
akhilesh: Seems OK for now. I'll have another read through later today
As well as for the other PRs
akhilesh
I have another issue on browse, May we discuss now or later Mr_Monkey