I mean, maybe we should just rename that rel to "performed instrument" :p
nav2002 joined the channel
bitmap
I'm sure tons of people still expect those names to be constant though :/
reosarevok
We've changed them before
bitmap
doesn't mean it doesn't break things
reosarevok
And there's only so long we should wait for people to move to gids
If we break stuff, maybe that'll make people do that :p
In any case, my plan is to eventually get rid of that rel, so
(and have vocals and instruments and orchestra etc as parts of a general "performs" rel)
bitmap
okay
the roles might make sense if you added -ed + instrument to everything
like balance -> balanced instrument
but not sure we want to have new strings for all those
otherwise just changing to column name seems fine
reosarevok
We could hardcode a change for "instrument" to "performed instrument" or something
But then that'll break if we rename it :p
bitmap
presumably we'd use the gid :P
it's not the only confusing one though
reosarevok
Well, that'd mean getting all from the query - right now we just get the names because I expected to not need anything else
Half of our rels have shitty names though, because we don't change them not to break stuff :p
bitmap
sure
it's just that the name of the link type (no matter what it is) can't fully describe what role the instrument had there
reosarevok
Sure
bitmap
is "Relationship Appearances" better? idk
reosarevok
At first I had something like "Instrument roles (credits)", to make it clear that this was a credit, btw, but then I dropped it because I wasn't sure it didn't look dumb
"Relationship Types" maybe? That says literally what it is
bitmap
that seems fine enough
reosarevok
What about credits?
Should the header explicitly mention them?
Relationship Appearances (Credits Used) or something?
bitmap
hrm
don't think we absolutely need to mention credits in the header
reosarevok
Ok
pristine__
Freso: can you give me the link to GCI task page one more time? I will star it this time ;)