18:25 PM
bitmap
18:28 PM
approved that one, feel free to merge
18:38 PM
seems like nobody is around, so I'll just look at gci stuff :P
18:38 PM
ZaphodBeeblebrox is now known as CatQuest
18:40 PM
revi has quit
18:40 PM
yvanzo
bitmap: sure :)
18:41 PM
antara has quit
18:43 PM
reosarevok
Sorry, got distracted photographing a fruit fly
18:43 PM
reosarevok is norma
18:43 PM
*normal
18:43 PM
Now back
18:43 PM
Cyna
Focusing on exams for next 5 days
18:45 PM
revi joined the channel
18:46 PM
yvanzo
Keep it up Cyna!
18:47 PM
rahul24
good luck
18:52 PM
yvanzo
18:52 PM
BrainzBot
18:53 PM
bitmap
I saw, we were thinking of adding a gci task for it
18:53 PM
Cyna
Add gci task for selenium test cases too
18:54 PM
bitmap
Cyna: one problem is it's not documented at all how to write those for our setup
18:57 PM
reosarevok
So, first task, document them? :p
18:57 PM
jbs1 joined the channel
18:58 PM
bitmap
I'm still unsure how to proceed with our selenium setup
18:59 PM
yvanzo
reosarevok: do you want me to create a ticket for that first task? ;)
18:59 PM
bitmap
ideally we could use the new ide to make tests, but we also have quite a few custom commands written at this point
18:59 PM
yvanzo
by the way reosarevok, how is the dev setup using musicbrainz-docker?
18:59 PM
bitmap
which wouldn't work in the ide at all. you'd still need to run them without a custom test runner (t/selenium.js)
18:59 PM
reosarevok
yvanzo: halfway :p
19:00 PM
Will reboot to Linux and continue with it
19:00 PM
bitmap
s/without/with our/
19:00 PM
yvanzo
this could be helpful for beginners
19:01 PM
I still have to install dependencies for selenium test
19:03 PM
BrainzGit
19:03 PM
BrainzBot
19:03 PM
yvanzo
bitmap: what are these custom commands again?
19:04 PM
reosarevok
19:05 PM
yvanzo
reosarevok: too late for that one? :P
19:05 PM
reosarevok
Oh, I guess for the commit it is, I was thinking more about for the blog post
19:06 PM
yvanzo
but yes, you can create sub-tickets.
19:06 PM
reosarevok
Or maybe we can just do all the tables this week and then we don't need them :p
19:06 PM
yvanzo
reosarevok: I would prefer this option too :)
19:06 PM
reosarevok
19:07 PM
bitmap
yvanzo: I don't have the old ide anymore so I forget, but at least assertEditData, handleAlert
19:07 PM
and the new ide removed quite a few commands from the old one which we still use
19:07 PM
rahul24 has quit
19:09 PM
particularly to fire events and eval scripts
19:10 PM
c1e0 has quit
19:12 PM
ok they added an 'execute script' command now, not sure if it's the same
19:12 PM
one option could be to move our custom commands to client js, but run them from the ide and check their output there
19:13 PM
reosarevok
Who wants to debug?
19:13 PM
19:13 PM
yvanzo
Can we just deprecate the few selenium tests we currently have, and try to convert these once we have a working setup for the new selenium ide?
19:13 PM
reosarevok
Add medium -> existing medium is broken
19:14 PM
BrainzGit
19:14 PM
reosarevok
bitmap: also, any specific GCI PRs I should review?
19:15 PM
bitmap
19:15 PM
not approved on gci yet
19:18 PM
reosarevok
Last changes seem fine, let's do it
19:19 PM
Squash all, I assume
19:19 PM
yvanzo
19:20 PM
reosarevok
Huh
19:20 PM
yvanzo
UI language was set to English, and I rebuilding mb_server.pot did not help.
19:21 PM
(Maybe it is just my dev env though, but the page would just not load on test.mb.o)
19:22 PM
reosarevok
wtf
19:22 PM
Wonder what we broke
19:23 PM
BrainzGit
19:32 PM
rahul24 joined the channel
19:36 PM
Wassabi has quit
19:39 PM
rahul24 has quit
19:42 PM
reosarevok
yvanzo: back to your docker thing for now (will also look at that bug)
19:43 PM
sbvkrishna has quit
19:45 PM
jbs1 has quit
19:49 PM
yvanzo: around?
19:50 PM
rahul24 joined the channel
19:52 PM
rahul24
is there no active mobile dev team?
19:53 PM
or is that Gsoc material only
19:54 PM
reosarevok
Not really, no. We're too small. amCap1712 has been working on mobile though
19:57 PM
bitmap
reosarevok: I see the issue for the medium search thing at least, don't think it's related to the error yvanzo posted
19:57 PM
reosarevok
Did I break it? :p
19:57 PM
bitmap
someone else
19:57 PM
bitmap hides
19:57 PM
reosarevok
Phew
19:59 PM
bitmap
20:02 PM
yvanzo
reosarevok: always around, just ask!
20:02 PM
bitmap: added to the next milestone then ^
20:04 PM
reosarevok
yvanzo: so, I ran out of disc space and my db creation died
20:04 PM
How do I remove the DB? I assume it's in some container
20:04 PM
bitmap
thx
20:04 PM
is there a ticket for the medium search bug?
20:05 PM
yvanzo
reosarevok: you can use recreatedb
20:06 PM
reosarevok
bitmap: not yet
20:06 PM
bitmap
ok I'll make one
20:06 PM
yvanzo
reosarevok: sudo docker-compose run --rm musicbrainz /recreatedb.sh -sample
20:07 PM
(no -fetch if you only downloaded it)
20:08 PM
or if you just want to remove it without recreating it: sudo docker volume rm musicbrainz-docker_pgdata
20:11 PM
reosarevok
volume is in use
20:18 PM
yvanzo: ^
20:19 PM
rahul24 has quit
20:20 PM
yvanzo
reosarevok: stop containers that uses it ^^
20:21 PM
reosarevok
Ok
20:21 PM
yvanzo
more likely: sudo docker-compose stop db
20:21 PM
reosarevok
I still don't know shit about docker, remember :p
20:21 PM
Got it
20:22 PM
yvanzo
20:22 PM
BrainzGit
20:22 PM
BrainzBot
20:24 PM
rahul24 joined the channel
20:24 PM
rahul24
ah i see, i’d love to help out with mobile dev as much as i can
20:28 PM
yvanzo
reosarevok: you might also want to use: sudo docker system prune
20:30 PM
reosarevok
Well, it did start the site fwiw
20:30 PM
yvanzo: I have 900 MB free :p Is there a point trying the indexing even of sample data only?
20:31 PM
yvanzo
not sure
20:31 PM
but you can use the site without search
20:32 PM
reosarevok
Sure
20:33 PM
What would you want me to test?
20:33 PM
BrainzGit
20:33 PM
yvanzo
Are you able to test your local branches using this?
20:34 PM
reosarevok
I got an ISE trying to add a label
20:36 PM
yvanzo
reosarevok: try: sudo docker-compose logs musicbrainz
20:36 PM
reosarevok
wtf :D
20:37 PM
20:41 PM
yvanzo
is it current master?
20:54 PM
reosarevok: why version of DBD::Pg do you use?
20:54 PM
*which
20:55 PM
reosarevok
It's whatever it came with? I haven't touched anything
20:56 PM
20:57 PM
bitmap
yep, let me fix the branch
20:59 PM
chaban has quit
20:59 PM
BrainzGit
20:59 PM
BrainzBot
21:02 PM
reosarevok
yvanzo: cpanm is 3.10.0
21:02 PM
But dunno if that's what the docker uses
21:03 PM
yvanzo
but usually what do you use?
21:04 PM
reosarevok
Well, whatever cpanm has, I assume, since I have MBS locally
21:05 PM
bitmap
you can check with `perl -E 'use DBD::Pg; print $DBD::Pg::VERSION;'` if it matters
21:06 PM
reosarevok
Yes, 3.10.0
21:08 PM
yvanzo
ty, it's not related to this error then.
21:09 PM
bitmap
just saw the error, sounds like a_ins_edit_artist / b_ins_edit_materialize_status isn't running? are there triggers in that db?
21:10 PM
(if it's a slave then no)
21:10 PM
but you can't make edits on a slave db anyway
21:11 PM
reosarevok
Well, I used admin/configure add musicbrainz-standalone
21:11 PM
From yvanzo's instructions
21:15 PM
bitmap
that sounds like it should install triggers, but
21:15 PM
if you can connect with psql and do \d edit_label
21:15 PM
it should list a_ins_edit_artist under Triggers
21:15 PM
(the name is wrong for some reason)
21:18 PM
21:18 PM
reosarevok
21:19 PM
yvanzo
fwiw, it works here
21:19 PM
bitmap
no triggers or foreign keys there, so must've did the slave setup somehow