Hi prabal! You had questions about the revisions page ticket?
2020-01-06 00609, 2020
prabal
Yeah. For the pagination thing in revisions page , the way I'm doing is to change the numberofRevisions in the query to 'from+size', and then slice the array from 'from' to end. I'll get 'from' and 'size' from req.query. Can there be much better way than this because if 'from' is very high, the size of array will be large
2020-01-06 00622, 2020
Mr_Monkey
Let me have a look. You're talking about the query used on the server/routes/index.js page I assume?
2020-01-06 00633, 2020
prabal
Yeah. The same query will be used for the revisions page right?
2020-01-06 00618, 2020
CatQuest has left the channel
2020-01-06 00647, 2020
Mr_Monkey
prabal: Hmm. I'm definitely not an SQL pro, and haven't tried pagination methods. I'm not sure what the most efficient way of doing it is, but I'll read up on it, and suggest you do the same if you haven't already.
2020-01-06 00653, 2020
CatQuest joined the channel
2020-01-06 00653, 2020
CatQuest has quit
2020-01-06 00653, 2020
CatQuest joined the channel
2020-01-06 00627, 2020
ruaok
Mr_Monkey: the easiest thing to do is to paginate sql queries
2020-01-06 00630, 2020
Mr_Monkey
My initial thought is using LIMIT X OFFSET Y, but you'd have to see if that remains efficient with a very big offset
2020-01-06 00638, 2020
ruaok
that.
2020-01-06 00639, 2020
Mr_Monkey
ah, good timing ruaok
2020-01-06 00647, 2020
Mr_Monkey
Well, does that scale up nicely?
2020-01-06 00619, 2020
ruaok
postgres does well, yes. should be safe to use. but reosarevok, yvanzo and bitmap might have more insight to this as this is a common issue for MB as well.
2020-01-06 00603, 2020
Mr_Monkey
In any case, prabal, using LIMIT & OFFSET in the sql query seems like a good direction for a first implementation.
MBS-10547: Regression: "Reveal my email address" in editor reporting doesn’t do that
2020-01-06 00646, 2020
CatQuest
.. when does he remember by himself anything?
2020-01-06 00646, 2020
CatQuest
(not that i'm equally as bad at remembering but)
2020-01-06 00656, 2020
CatQuest
I'm not as*
2020-01-06 00624, 2020
Freso
(Just curious because I had expected you to assign yourself to it, but you still haven’t. :))
2020-01-06 00654, 2020
CatQuest
oh, also for the support on bookbrainz proposal freso. it looks less empty now (and with one interaction, maybe shy folks now will feel more at home doing it too!)
2020-01-06 00602, 2020
CatQuest
eh
2020-01-06 00609, 2020
CatQuest
"also *thank you* for the..
2020-01-06 00628, 2020
c1e0 has quit
2020-01-06 00635, 2020
c1e0 joined the channel
2020-01-06 00612, 2020
CatQuest is now known as BilleeKhoj
2020-01-06 00633, 2020
BilleeKhoj is now known as CatQuest
2020-01-06 00643, 2020
yokel has quit
2020-01-06 00630, 2020
c1e0 has quit
2020-01-06 00638, 2020
yokel joined the channel
2020-01-06 00654, 2020
BrainzGit
[bookbrainz-site] MonkeyDo merged pull request #335 (master…dependabot/npm_and_yarn/handlebars-4.5.3): chore(deps): bump handlebars from 4.1.2 to 4.5.3 https://github.com/bookbrainz/bookbrainz-site/pul…
People up for reviews: reosarevok, yvanzo, zas, Mr_Monkey, Freso, pristine__, ruaok, bitmap, iliekcomputers, sbvkrishna, Cyna, CatQuest – anyone else, let me know ASAP!
2020-01-06 00616, 2020
Freso
reosarevok: Go!
2020-01-06 00623, 2020
reosarevok
Hi!
2020-01-06 00639, 2020
reosarevok
This week I dealt with GCI reviewing and otherwise had a Christmas / NY holiday
2020-01-06 00641, 2020
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GCI students start here: https://bit.ly/34O3FY8 | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Meeting agenda: Reviews
Freso had beans for dinner before realising it was bean day 🤷
2020-01-06 00653, 2020
CatQuest
hipster :P
2020-01-06 00654, 2020
CatQuest
But it was not a disaster because there were other mentors on instrument tasks <3
2020-01-06 00654, 2020
CatQuest
(a little confusion about adding more task instances, but no matter :))
2020-01-06 00605, 2020
CatQuest
I hope gci does not go on during christmas next year. it's a bad idea.
2020-01-06 00605, 2020
CatQuest
In instrument adding ways it's still kinda dead. I've been playing pokémon shield, Let's go Pikachu and BotW :P
2020-01-06 00606, 2020
CatQuest
(guess what kind of handheld game thingy I got for my birthday :P)
2020-01-06 00629, 2020
CatQuest
Now it is back to work days however and I'm looking to mentor stuff. Got a couple tasks written up.
2020-01-06 00633, 2020
CatQuest
A specialised one for a model student and a couple that still needs a bit of work for BookBrainz. Hope to get monkey onboard for collaborating with those, and freso himself seemed to be interested in the audiobook one :D
2020-01-06 00646, 2020
CatQuest
Got a instrument blogpost written and waiting for the final instrument being done.
2020-01-06 00656, 2020
CatQuest
D4RK-PH0ENiX aka Nyanko-sensei has completed the IROM translation, so we (me and reosarevok) will soon send this email, so expect to se development in that field Soon™
CatQuest (and reosarevok and others): Be sure to write GCI team about not wanting it over Christmas. You can hope all you want, but if nobody actually tells their hopes/experiences to GCI team, they won’t know to adjust accordingly.
