sarthak_jain: reviewing code on gists is difficult, also you should upload listens to HDFS on your local machine ( follow the steps I told shivam-kapila yesterday, he may guide you). Test your changes on your local environment first
2020-01-28 02830, 2020
pristine__
Now testing doesn't mean pytest only. See if the output you are getting after running queries is desirable or not.
2020-01-28 02835, 2020
prabal has quit
2020-01-28 02850, 2020
ZaphodBeeblebrox joined the channel
2020-01-28 02819, 2020
CatQuest has quit
2020-01-28 02808, 2020
MusicbrainzB0T joined the channel
2020-01-28 02804, 2020
MusicbrainzB0T1 has quit
2020-01-28 02831, 2020
prabal joined the channel
2020-01-28 02810, 2020
sarthak_jain joined the channel
2020-01-28 02821, 2020
sarthak_jain
pristine__, I understand what you’re saying. But the thing is, if I am not making any changes, and just trying to run ‘pytest test_utils’, I face import error.
2020-01-28 02850, 2020
sarthak_jain
Even though I hve not made any changes to utils file yet.
2020-01-28 02856, 2020
sarthak_jain
Any reason for that?
2020-01-28 02819, 2020
c1e0_ joined the channel
2020-01-28 02850, 2020
pristine__
I am not sure because it's running fine on my local machine. Have you pulled lb-server master branch, so that you have recent changes
2020-01-28 02803, 2020
pristine__
Labs repo has been merged into Lb-server
2020-01-28 02826, 2020
sarthak_jain has quit
2020-01-28 02812, 2020
c1e0 has quit
2020-01-28 02834, 2020
sarthak_jain joined the channel
2020-01-28 02813, 2020
sarthak_jain
Yes pristine__. Accidentally I had deleted the previous fork. So I forked it today and cloned on my machine.
2020-01-28 02835, 2020
sarthak_jain
And set the dev environment following the steps I did last time
2020-01-28 02804, 2020
sarthak_jain
only difference was I did not run the commands to setup databases
2020-01-28 02845, 2020
sarthak_jain
Just did ./develop.sh
2020-01-28 02804, 2020
sarthak_jain has quit
2020-01-28 02846, 2020
sarthak_jain joined the channel
2020-01-28 02804, 2020
sarthak_jain
I will check again in the evening and let you know
2020-01-28 02832, 2020
sarthak_jain
The good thing is the majority of the task has been done, I guess
2020-01-28 02838, 2020
sarthak_jain has quit
2020-01-28 02803, 2020
shivam-kapila joined the channel
2020-01-28 02813, 2020
shivam-kapila
pristine__: Hi. I followed the steps as you told
2020-01-28 02832, 2020
shivam-kapila
I am getting stuck at error `ftplib.error_perm: 550 failed to change directory.`
2020-01-28 02842, 2020
pristine__
shivam-kapila: I will ping you when I have a laptop nearby.
2020-01-28 02846, 2020
pristine__
:)
2020-01-28 02824, 2020
shivam-kapila
I even did the `WRITE MODE=ON`
2020-01-28 02836, 2020
shivam-kapila
The error comes when I run `/usr/local/spark/bin/spark-submit spark_manage.py upload_listens`
2020-01-28 02844, 2020
shivam-kapila
pristine__: Cool :)
2020-01-28 02845, 2020
shivam-kapila
iliekcomputers: Hi. Did you have a look the new design I sent yesterday?
2020-01-28 02856, 2020
pristine__
shivam-kapila: can you please paste the complete error?
2020-01-28 02801, 2020
pristine__
On gist
2020-01-28 02822, 2020
shivam-kapila
Sure.
2020-01-28 02845, 2020
iliekcomputers
shivam-kapila: not yet, I'll get back to you when I do
2020-01-28 02809, 2020
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC students start here: https://bit.ly/2NUaxgb | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Meeting agenda: Reviews, GSoC Ideas page (ruaok)
2020-01-28 02823, 2020
ZaphodBeeblebrox is now known as CatQuest
2020-01-28 02854, 2020
CatQuest
morn morn Mr_Monkey
2020-01-28 02807, 2020
thomasross has quit
2020-01-28 02808, 2020
thomasross joined the channel
2020-01-28 02836, 2020
Mr_Monkey
moin !
2020-01-28 02853, 2020
c1e0_ has quit
2020-01-28 02819, 2020
c1e0_ joined the channel
2020-01-28 02800, 2020
CatQuest
:D
2020-01-28 02848, 2020
CatQuest
wow I had a though. wat if there was a bot, or a botplugin that automatically submitted every link posted here (or in #musicbrainz) to the IA?
or like singh is the indian equivalent to "smith" or "olsen" :D
2020-01-28 02801, 2020
CatQuest
!m prabal singh
2020-01-28 02802, 2020
BrainzBot
You're doing good work, prabal singh!
2020-01-28 02811, 2020
CatQuest has left the channel
2020-01-28 02834, 2020
CatQuest joined the channel
2020-01-28 02835, 2020
CatQuest has quit
2020-01-28 02835, 2020
CatQuest joined the channel
2020-01-28 02810, 2020
CatQuest
ah.. typing out the names of entities every time is a bore :'D
2020-01-28 02829, 2020
CatQuest
Mr_Monkey: we need to work on "10 recently used entities" in search dropdowns. really
2020-01-28 02842, 2020
CatQuest
for entities and languages and countries
2020-01-28 02818, 2020
CatQuest
one thing: so the title has a language that is mandatory (never midn if a person doesnt know what language the title might be in or that the title might be in a madeup language or just be a name ex)
2020-01-28 02846, 2020
CatQuest
then the *other* language field (which is totally optional)
2020-01-28 02857, 2020
CatQuest
what is that? for the text of the book right?
2020-01-28 02843, 2020
CatQuest
wouldn't it make sense to either: collate these so if one is filled the other is als ofilled (with the caveheat that exeptios *do* ocur but then what is the point of even having alanguage setting for the *title*)
2020-01-28 02858, 2020
CatQuest
how often does it ocur that a book is in one language but the title is in another?
2020-01-28 02823, 2020
CatQuest
and then is the language of the book's title really that important
2020-01-28 02822, 2020
Mr_Monkey
Language title is going to be important down the line, I think
2020-01-28 02837, 2020
Mr_Monkey
I envision some use with localization for example
2020-01-28 02852, 2020
CatQuest
hmh..
2020-01-28 02854, 2020
Mr_Monkey
But it's also helpful for search
2020-01-28 02811, 2020
CatQuest
it's the thing about setting it twice. writing it twice
2020-01-28 02825, 2020
CatQuest
i think that by default if you will it in the othero ne shoudl be filled also
2020-01-28 02831, 2020
Mr_Monkey
As for how often a title and content aren't the same language, that's a good question. I know for sure it happens, maybe more often than we think
2020-01-28 02844, 2020
CatQuest
(we could put in a text to tell to make sure it is correct)
2020-01-28 02814, 2020
CatQuest
yea maye in aply named englsih book. but for instnace in norwegian translations. especially of osme years old. almost never
2020-01-28 02822, 2020
Mr_Monkey
There's those "?" icons that give a short explanation. You think it needs more?
2020-01-28 02848, 2020
CatQuest
I mean if we would implement a "fill in from title's language" button maybe
2020-01-28 02814, 2020
CatQuest
my grip is that I have to type "norw" (or engl") twice
2020-01-28 02833, 2020
Mr_Monkey
That des'nt seem too bad to me, frankly
2020-01-28 02835, 2020
CatQuest
and this for *every* single. entity.
2020-01-28 02848, 2020
CatQuest
it is. it gets old, really quick
2020-01-28 02823, 2020
CatQuest
i've got atleast 00 books (probably more) to add
2020-01-28 02826, 2020
CatQuest
eh
2020-01-28 02829, 2020
CatQuest
i've got atleast 100 books (probably more) to add
2020-01-28 02851, 2020
Mr_Monkey
Truthfully, it's the sort name i'd like to get rid of. It's hard for new users to understand and get right, and it doesn't seem useful to me. I think in BB it's currently completely unused
2020-01-28 02800, 2020
CatQuest
remember in mb: i cna jsut select them ost common one fro ma list
2020-01-28 02812, 2020
CatQuest
it's mandatory so it is used :D
2020-01-28 02814, 2020
CatQuest
but yes
2020-01-28 02829, 2020
CatQuest
also the "guess" button is bad. there shoudl be a "copy" button
2020-01-28 02831, 2020
Mr_Monkey
Well, that seems like a good solution to me. last 10 used or common ones at the top
2020-01-28 02837, 2020
CatQuest
indeed.
2020-01-28 02841, 2020
Mr_Monkey
Mandatory how?
2020-01-28 02846, 2020
CatQuest
that's also something I wrote in that docu i send you :D
2020-01-28 02854, 2020
CatQuest
you can't not fill in the sort name
2020-01-28 02803, 2020
CatQuest
jsut lie kyou can't not fill in the title language
2020-01-28 02810, 2020
CatQuest
it is red and x'ed
2020-01-28 02810, 2020
Mr_Monkey
Right, but we don't do anything with that data.
2020-01-28 02818, 2020
CatQuest
sure.
2020-01-28 02826, 2020
CatQuest
but we might at soem point
2020-01-28 02835, 2020
CatQuest
honestly
2020-01-28 02856, 2020
Mr_Monkey
I haven't been able to find one myself. Can you think of any?
2020-01-28 02815, 2020
CatQuest
when we had several languages the aliases and different named aliases on each language made sene. but we're not doing that anymore. so I don't relaly see the point of setting "language of title" (especially separate of "language of edition") when we do infact in ADDITION have "language of title of work" and "language of work"
2020-01-28 02850, 2020
CatQuest
we don't have "language of title" and "language of tracklist" separate in mb
2020-01-28 02859, 2020
CatQuest
(we have a language of work" (ie sung language))
2020-01-28 02808, 2020
CatQuest
in BB we can even sset severla langauges
2020-01-28 02856, 2020
CatQuest
why not just set language once and if. on the (honestly rare times?) when language of title != language of textof the book we can set a flag or a specia lbox then
2020-01-28 02850, 2020
Mr_Monkey
I think that would be a good improvement
2020-01-28 02853, 2020
Mr_Monkey
Much simpler
2020-01-28 02813, 2020
CatQuest
:D
2020-01-28 02831, 2020
prabal
@CatQuest: haha no we're not related :P it's a common last name here xD
2020-01-28 02852, 2020
CatQuest
oh also, do we want really language of author's name? I mean, many names are not "norwegian" in origin . some are dutch or german. and how do you know if "pettersen" is danish or norwegian, really
