When free do have a look as I am not 100% if the logic is correct or not.
*100% sure
ruaok
pristine__: hey.
so, I was pondering your function naming conundrum.
your function names are sometimes not very descriptive and you've expressed frustration with naming functions.
pristine__
:(
ruaok
but then you give a short, succinct description of what the function does.
which is often times a very good function name.
as I've already written in the review, why not name the function something intentionally wrong, then write the quip that describes the function and then go back and update the function name to reflect the quip?
you clearly know how to do it, but I think you feel some pressure about naming functions since they are more permanent than comments are. I think.
CatQuest
loi, this is why all my tickets have shait names too :D
c1e0_ joined the channel
c1e0 has quit
pristine__
ruaok: thank you for the review :) if you could write comments to point out a bad function name (since there are many), it will help me better. Other wise I can refactor the whole PR.
:)
ruaok
I do that already, but I am convinced you can do this yourself -- you've demonstrated this several times. I'm just wondering if I can guide to do this yourself...
pristine__
When I think of it, I have always tried to give nice function names. At this moment I cannot think of any bad function name but I if you and iliekcomputers feel that way, I am convinced that it should be improved.
here you test adding an invalid path, but I dont see how that test result is being evaluated.
zas
pristine__: finding good function/variables names is an hard task, for everyone, but on the long term it helps all contributors to understand code, without going to each function description and code. Don't worry, every dev went through this, and experienced devs still struggle with it ;)
ruaok
ohhh, wait. I think I get it now.
abhishekpanwar
Mr_Monkey: Okay
pristine__
> here you test adding an invalid path, but I dont see how that test result is being evaluated.
That will be evaluated later.
Mr_Monkey sits in front of his screen for minutes at a time trying to think of the right function names
zas: while I am not the target audience for your question, the answer should be yes.
pristine__
zas: Mr_Monkey thanks :)
ruaok
there are plenty of people in india who do not speak english. and some regions think that english is their official language.
we should not think of india as one monolithic cultural entity, but like many other large countries as an amalgamation of many different cultures. and of these groups needs picard in hindi.
I would prefer us to find someone to fill up the hindi translations.
zas
ruaok: I totally agree, we're about to blog post about new Picard beta, with a call to translators, I expect someone would pick Hindi translation, with all nice Indian people we have around. If interested, head to https://www.transifex.com/musicbrainz/musicbrai... (it requires a free transifex account)
current status ~2% translated...
ruaok
I bet we could also get people interested in contributing to picard for gsoc to write the translations as a first community task.
zas: maybe add that to the gsoc ideas page as a first task for getting aqcuainted with the community?
zas
good idea
antara
hi, I'd love to help with this if possible! (even if it is a gsoc task?)
ruaok
antara: please do, no need to help. see the link above to jump in.
no need to wait. sigh.
antara
okay, found it - thanks!
ruaok waits for his brain to find the right timezone
iliekcomputers
zas: yes
(to the i18n question)
reosarevok
For that there's a need to help...
ruaok
reosarevok: call the lost luggage dept at Swiss?
or go buy chocolate?
KassOtsimine joined the channel
zas
antara: if you need help regarding i18n and Picard, ask me
we plan a beta on Thursday, which means string freeze until final release (prolly in few weeks), it'd be amazing to have Hindi translation by this time ;)
ruaok
just curious, how many string are there in picard?
antara
okay, thank you :)
zas
ruaok: 1177, 3824 words
antara
I do have school, so I'm not sure how active I can be, but I'll try to do as much as possible
zas
and there are few more in picard_appstream
ruaok
11 lakhs worth, zas?
ruaok is confused
zas
ahah, 1177 strings ;)
ruaok
ahh, I see.
lots.
zas
yup, huge app ;)
antara
I'm getting started on countries now :D
zas
thanks!
note: MusicBrainz website and Picard are sharing some translations, like countries
antara
oh okay! overlap might be helpful
outsidecontext
I would love to see Picard translation getting improved in the next release cycle. I'm not happy with a few things
Btw, has using Weblate for MB translations been considered at some point?
zas
I don't think so, at least, never heard about using this alternative. Something we may evaluate, what are pros/cons compared to transifex?
I see we can self-host it (for free/full featured) or just use free version (for open source projects) but it has few limitations compared to paid versions
outsidecontext
It has pretty great integration with git, is free software, can be self hosted but the developer also provides free hosting for open source and the developer is a nice guy
What I really don't like about Transifex is that it does not really make it transparent who has translated what. But it does not make sense for a sine MB project to use something different
zas
ok, perhaps time to list alternatives and evaluate if it is worth moving to one. For sure, moving to an open source one is a strong argument for me... and if it helps to have a wider translator community while providing similar or better features than our current solution...
outsidecontext
Transifex gained a proper GitHub integration, that was lacking for a long time. I never used it, but we should try if it works for us with Picard
zas
Imho, Github integration shouldn't be top requirement, we still don't know where github will go in future years ... (reminder: it is M$ property, and open source community should be careful). But if it has also gitlab (or other alternatives to gtihub) integration. GitHub integration is a plus for sure, at least until we are forced to move our projects away from it....
yvanzo
I think I evaluated weblate for GSoC ideas two years ago, pontoon was pretty bleeding-edge was featuring in-place localization (for websites), but I don’t recall what dismissed weblate.
Transifex just feels pretty limited in most regards, e.g. glossary is very limited, nearly no quality checks, TM export I think is not possible in the free version
zas
outsidecontext: I tend to agree (about transifex)
yvanzo
no gitlab integration :( I just imagined it
+1 glossary is very limited.
outsidecontext
Also while the translation editor itself is fine, the rest of the UI is confusing. Also requiring user's to register at a commercial nthird party is not so great
Weblate actually would allow oauth 2 based single sign on using MB account
Maybe we should start a comparison of different tools and MB requirements. I can start something to get into a discussion
iliekcomputers
zas: not to ping you too on this much, but any chance you looked into the code search livegrep thing?
abhishekpanwar
Mr_Monkey: So for each of the relationship in the relationship_set of the deleted work, we would have to go to the target of these relationships and then delete the relationships from these target entity's relationship_set where the deleted work is the source.
zas
iliekcomputers: I didn't had time today, but it is planned ;) I think about setting up a VM for it