#metabrainz

/

      • Zastai has quit
      • 2020-04-10 10142, 2020

      • supersandro20004 joined the channel
      • 2020-04-10 10154, 2020

      • supersandro2000 has quit
      • 2020-04-10 10157, 2020

      • D4RK-PH0ENiX has quit
      • 2020-04-10 10109, 2020

      • D4RK-PH0ENiX joined the channel
      • 2020-04-10 10109, 2020

      • D4RK-PH0ENiX has quit
      • 2020-04-10 10155, 2020

      • D4RK-PH0ENiX joined the channel
      • 2020-04-10 10103, 2020

      • shivam-kapila has quit
      • 2020-04-10 10153, 2020

      • Chinmay3199 has quit
      • 2020-04-10 10106, 2020

      • supersandro20004 has quit
      • 2020-04-10 10130, 2020

      • supersandro2000 joined the channel
      • 2020-04-10 10120, 2020

      • travis-ci joined the channel
      • 2020-04-10 10120, 2020

      • travis-ci
        Project bookbrainz-data-js build #1426: passed in 1 min 46 sec: https://travis-ci.org/bookbrainz/bookbrainz-data-…
      • 2020-04-10 10120, 2020

      • travis-ci has left the channel
      • 2020-04-10 10138, 2020

      • HenryG has quit
      • 2020-04-10 10125, 2020

      • HenryG joined the channel
      • 2020-04-10 10140, 2020

      • ishaanshah[m]
        iliekcomputers: Hi! Slept early last night, 3 PM sounds good to me.
      • 2020-04-10 10108, 2020

      • Darkloke joined the channel
      • 2020-04-10 10113, 2020

      • prabal joined the channel
      • 2020-04-10 10133, 2020

      • SkweezyJibbz has quit
      • 2020-04-10 10124, 2020

      • yvanzo
        mo’’in’
      • 2020-04-10 10107, 2020

      • yvanzo
        update beta.mb.o
      • 2020-04-10 10140, 2020

      • bitmap
        yvanzo: thanks
      • 2020-04-10 10101, 2020

      • bitmap
        failed to get to that earlier but I'll update prod with the aliases fix now then see about running the sql script
      • 2020-04-10 10147, 2020

      • iliekcomputers
        ishaanshah[m]: no worries, it was pretty late anyways
      • 2020-04-10 10105, 2020

      • bitmap
        updating prod mb containers w/ MBS-9169
      • 2020-04-10 10107, 2020

      • BrainzBot
        MBS-9169: Inconsistent locale identifiers https://tickets.metabrainz.org/browse/MBS-9169
      • 2020-04-10 10152, 2020

      • bitmap
        done, going to run the sql to fix the locales in the DB now
      • 2020-04-10 10139, 2020

      • bitmap
        also done
      • 2020-04-10 10103, 2020

      • Zastai joined the channel
      • 2020-04-10 10145, 2020

      • Chinmay3199 joined the channel
      • 2020-04-10 10120, 2020

      • v6lur joined the channel
      • 2020-04-10 10102, 2020

      • Gazooo has quit
      • 2020-04-10 10145, 2020

      • Gazooo joined the channel
      • 2020-04-10 10129, 2020

      • iliekcomputers
        ishaanshah[m]: hi, i'm around
      • 2020-04-10 10152, 2020

      • ishaanshah[m]
        iliekcomputers Hi
      • 2020-04-10 10108, 2020

      • iliekcomputers
        heyo
      • 2020-04-10 10111, 2020

      • iliekcomputers
        how are you?
      • 2020-04-10 10118, 2020

      • ruaok
      • 2020-04-10 10119, 2020

      • ishaanshah[m]
        Doing well, got nothing to do except uni work :(
      • 2020-04-10 10149, 2020

      • iliekcomputers
        well, we can fix that soon :P
      • 2020-04-10 10151, 2020

      • iliekcomputers
        i was looking at the files we need to port over to ts.
      • 2020-04-10 10103, 2020

      • iliekcomputers
        there's like 15-16, I guess?
      • 2020-04-10 10110, 2020

      • iliekcomputers
        including tests
      • 2020-04-10 10103, 2020

      • ishaanshah[m]
        Yep
      • 2020-04-10 10131, 2020

      • iliekcomputers
        cool.
      • 2020-04-10 10137, 2020

      • shivam-kapila joined the channel
      • 2020-04-10 10145, 2020

      • iliekcomputers
        do you think we should port over those or is there something else you'd like to work on?
      • 2020-04-10 10132, 2020

      • ishaanshah[m]
        I think we should port them
      • 2020-04-10 10139, 2020

      • iliekcomputers
        my opinion here is that we should just knock them out while we're at it, otherwise we'll never get to them
      • 2020-04-10 10141, 2020

      • iliekcomputers
        ah cool.
      • 2020-04-10 10148, 2020

      • iliekcomputers
        so here's what I was thinking.
      • 2020-04-10 10101, 2020

      • iliekcomputers
        you start with the lastfm importer files you added
      • 2020-04-10 10115, 2020

      • iliekcomputers
        should be easy because you wrote them relatively recently.
      • 2020-04-10 10121, 2020

      • iliekcomputers
        i'll start looking at the ones from before that.
      • 2020-04-10 10158, 2020

      • iliekcomputers
        i think reasonably we can port all of these over to ts in a week.
      • 2020-04-10 10107, 2020

      • iliekcomputers
        then we can look at the eslint errors
      • 2020-04-10 10117, 2020

      • iliekcomputers
        does that sound reasonable?
      • 2020-04-10 10133, 2020

      • ishaanshah[m]
        Yep, thats doable
      • 2020-04-10 10107, 2020

      • iliekcomputers
        cool cool cool
      • 2020-04-10 10109, 2020

      • ishaanshah[m]
        Should we add tests for the remaining components too?
      • 2020-04-10 10139, 2020

      • ishaanshah[m]
        Also while porting should we add tests for the remaining components?
      • 2020-04-10 10101, 2020

      • ishaanshah[m]
        sorry for the double messages, matrix is acting wierd lately
      • 2020-04-10 10107, 2020

      • iliekcomputers
        no worries.
      • 2020-04-10 10119, 2020

      • iliekcomputers
        about tests for the old components, i'm neutral.
      • 2020-04-10 10153, 2020

      • iliekcomputers
        let's add a basic snapshot test where possible, but I don't want to get into it too much, there's other stuff we can focus on.
      • 2020-04-10 10121, 2020

      • ishaanshah[m]
        Ok, makes sense
      • 2020-04-10 10119, 2020

      • ishaanshah[m]
        Also can you give me a brief overview of how I can setup stat generation in my local environment
      • 2020-04-10 10157, 2020

      • ishaanshah[m]
        I tried doing it before, but couldn't get request consumer working
      • 2020-04-10 10150, 2020

      • iliekcomputers
        right, the spark environment isn't very good for local development yet. i think that's something we'll have to work on a bit.
      • 2020-04-10 10109, 2020

      • iliekcomputers
        let me think about it for a while and get back to you on that.
      • 2020-04-10 10146, 2020

      • ishaanshah[m]
        Sure, maybe we can work on that next week.
      • 2020-04-10 10111, 2020

      • iliekcomputers
        yeah, that's what i was thinking too. I'd be pretty happy to knock that out before gsoc too.
      • 2020-04-10 10121, 2020

      • iliekcomputers
        do you think you have enough work for this week?
      • 2020-04-10 10129, 2020

      • ishaanshah[m]
        I will work on porting now, which is much better than doing assignments:D
      • 2020-04-10 10142, 2020

      • ishaanshah[m]
        > do you think you have enough work for this week?
      • 2020-04-10 10143, 2020

      • ishaanshah[m]
        yes
      • 2020-04-10 10148, 2020

      • iliekcomputers
        👍🏽
      • 2020-04-10 10121, 2020

      • iliekcomputers
        awesome. if you get done earlier, just start fixing the eslint problems :)
      • 2020-04-10 10126, 2020

      • iliekcomputers
        thanks ishaanshah[m] !
      • 2020-04-10 10108, 2020

      • shivam-kapila
        Morning!
      • 2020-04-10 10114, 2020

      • iliekcomputers
        i'm currently looking at the utils.jsx file, should have a PR open soon-ish
      • 2020-04-10 10136, 2020

      • iliekcomputers
        if you start work on one of the non lastfm importer files, just ping me once so that we don't duplicate work.
      • 2020-04-10 10156, 2020

      • ishaanshah[m]
        Yep will do
      • 2020-04-10 10128, 2020

      • shivam-kapila
        ruaok: Hey. How did the morning coffee company go? :)
      • 2020-04-10 10109, 2020

      • ruaok
        much less useful than I had hoped, shivam-kapila. I did a software update on my mac mini yesterday and its been unstable since then.
      • 2020-04-10 10126, 2020

      • ruaok
        I'm going to try a full re-install of the OS, so now trying to get setup on my laptop.
      • 2020-04-10 10117, 2020

      • shivam-kapila
        ruaok: Oh I first interpreted the tests being much less useful
      • 2020-04-10 10104, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh opened pull request #784 (master…param/migrate-to-ts): [wip] Converting utils.js to typescript https://github.com/metabrainz/listenbrainz-server…
      • 2020-04-10 10145, 2020

      • BrainzGit
        [bookbrainz-site] prabalsingh24 opened pull request #410 (master…revision-display): BB-444: Revision Display Page Improvement https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2020-04-10 10146, 2020

      • BrainzBot
        BB-444: Revision page should display name as well as BBIDs https://tickets.metabrainz.org/browse/BB-444
      • 2020-04-10 10142, 2020

      • v6lur has quit
      • 2020-04-10 10140, 2020

      • prabal
        Mr_Monkey: I've got couple of questions... https://github.com/bookbrainz/bookbrainz-site/pul… Have a look whenever you're free. :D
      • 2020-04-10 10100, 2020

      • Mr_Monkey
        Will do
      • 2020-04-10 10137, 2020

      • niceplace has quit
      • 2020-04-10 10137, 2020

      • niceplace joined the channel
      • 2020-04-10 10108, 2020

      • CatQuest
        reosarevok: even in norwegian it's important to make distinctions to certain things.. like for example you say "spiller et trekkspill"(playing an accordion) "spiller en guitar" (playing a guitar) (and even "spiller trekkspill" (plays accordion) "spiller guitar (plays guitar))
      • 2020-04-10 10104, 2020

      • CatQuest
        and. "spiller fele" "spiller ei fele" (hurra gender words)
      • 2020-04-10 10134, 2020

      • D4RK-PH0ENiX has quit
      • 2020-04-10 10152, 2020

      • D4RK-PH0ENiX joined the channel
      • 2020-04-10 10133, 2020

      • iliekcomputers
        zas: seems to me that livegrep hasn't updated indexes in a long time
      • 2020-04-10 10100, 2020

      • iliekcomputers
      • 2020-04-10 10148, 2020

      • zas
        I'll have a look
      • 2020-04-10 10126, 2020

      • iliekcomputers
        thanks!
      • 2020-04-10 10144, 2020

      • zas
        well, indexes are updated, but I think it doesn't remove old ones
      • 2020-04-10 10131, 2020

      • zas
      • 2020-04-10 10129, 2020

      • zas
        perhaps we could re-index from scratch once in a while, removing the whole index file
      • 2020-04-10 10134, 2020

      • zas
        I removed it, let's see what happens on next re-index timer call
      • 2020-04-10 10150, 2020

      • zas
        hmmm, no change, it still indexes removed files it seems
      • 2020-04-10 10108, 2020

      • CatQuest
        hi zas and iliekcomputers
      • 2020-04-10 10136, 2020

      • iliekcomputers
        zas: i also can't find new files added to LB recently
      • 2020-04-10 10149, 2020

      • iliekcomputers
        for example we added a .eslintrc yesterday: http://livegrep.metabrainz.org/search/livegrep?q=…
      • 2020-04-10 10119, 2020

      • zas
        I'm rebuilding it, but as far I can tell, indexing is working
      • 2020-04-10 10121, 2020

      • Lotheric has quit
      • 2020-04-10 10151, 2020

      • Lotheric joined the channel
      • 2020-04-10 10125, 2020

      • iliekcomputers
      • 2020-04-10 10119, 2020

      • ruaok
        shivam-kapila: I finally have things running (and my main computer install is moving along)
      • 2020-04-10 10140, 2020

      • ruaok
        I see only two tests failing now, using your branch -- the to_influx and from_influx
      • 2020-04-10 10144, 2020

      • ruaok
        does that sound right?
      • 2020-04-10 10123, 2020

      • shivam-kapila
        Yes
      • 2020-04-10 10137, 2020

      • shivam-kapila
        I havent worked on them till now
      • 2020-04-10 10120, 2020

      • shivam-kapila
        I will look into them soon
      • 2020-04-10 10134, 2020

      • ruaok
        ok, glad we're seeing the same things.
      • 2020-04-10 10146, 2020

      • ruaok
        if you have time to work on those, that would be great.
      • 2020-04-10 10107, 2020

      • shivam-kapila
        Yeah sure I will.
      • 2020-04-10 10109, 2020

      • ruaok
        I can start thinking about migration
      • 2020-04-10 10156, 2020

      • shivam-kapila
        I was gonna ask you about it. What major part is left for migration. The timescale writer?
      • 2020-04-10 10107, 2020

      • ruaok
        the timescale writer is another part, yes.
      • 2020-04-10 10138, 2020

      • ruaok
        but the migration of the database as i described it to iliekcomputers yesterday (or so) needs to be solidified.
      • 2020-04-10 10159, 2020

      • ruaok
        the process of copying the data from influx to timescale and not losing a single listen is some work.
      • 2020-04-10 10118, 2020

      • ruaok
        and moving timescale to be properly monitored in our infrastructure is another one.
      • 2020-04-10 10148, 2020

      • shivam-kapila
        Hmm. Getting it.
      • 2020-04-10 10152, 2020

      • ishaanshah[m]
        iliekcomputers: I took a look at your PR, lgtm
      • 2020-04-10 10110, 2020

      • ishaanshah[m]
        I have ported lastFMImporter, opening a PR rn
      • 2020-04-10 10116, 2020

      • ishaanshah[m]
        Please have a look
      • 2020-04-10 10131, 2020

      • iliekcomputers
        ishaanshah[m]: thanks, can you approve it on github?
      • 2020-04-10 10157, 2020

      • ishaanshah[m]
        Can we keep the console.warn statements for now
      • 2020-04-10 10138, 2020

      • iliekcomputers
        I'm not sure about that.
      • 2020-04-10 10151, 2020

      • iliekcomputers
        What benefit do we get keeping that?
      • 2020-04-10 10139, 2020

      • ishaanshah[m]
        Right now we are not showing the error to the user, but ideally we should right?
      • 2020-04-10 10122, 2020

      • ishaanshah[m]
        So keeping it will help us point out where we should do that
      • 2020-04-10 10117, 2020

      • iliekcomputers
        Add a comment instead, I guess. The console.warn would show up in every user's console, which I don't really think we need to do.
      • 2020-04-10 10108, 2020

      • ishaanshah[m]
        Ohk, will do that
      • 2020-04-10 10116, 2020

      • ishaanshah[m]
        Can you do that in your PR too
      • 2020-04-10 10103, 2020

      • iliekcomputers
        In the console.error I removed?
      • 2020-04-10 10112, 2020

      • ishaanshah[m]
        Yep
      • 2020-04-10 10115, 2020

      • iliekcomputers
        Yeah, sure.
      • 2020-04-10 10128, 2020

      • iliekcomputers
        ishaanshah[m]: done
      • 2020-04-10 10159, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #784 (master…param/migrate-to-ts): Convert utils.js to typescript https://github.com/metabrainz/listenbrainz-server…
      • 2020-04-10 10101, 2020

      • BrainzGit
        [listenbrainz-server] ishaanshah opened pull request #785 (master…typescript-port): Port lastFmImporter to Typescript https://github.com/metabrainz/listenbrainz-server…