0:01 AM
Zastai has quit
0:34 AM
supersandro20004 joined the channel
0:37 AM
supersandro2000 has quit
1:12 AM
D4RK-PH0ENiX has quit
1:23 AM
D4RK-PH0ENiX joined the channel
1:23 AM
D4RK-PH0ENiX has quit
1:23 AM
D4RK-PH0ENiX joined the channel
1:24 AM
shivam-kapila has quit
1:34 AM
Chinmay3199 has quit
1:42 AM
supersandro20004 has quit
1:42 AM
supersandro2000 joined the channel
2:49 AM
travis-ci joined the channel
2:49 AM
travis-ci
2:49 AM
travis-ci has left the channel
3:43 AM
HenryG has quit
3:44 AM
HenryG joined the channel
3:47 AM
ishaanshah[m]
iliekcomputers: Hi! Slept early last night, 3 PM sounds good to me.
5:10 AM
Darkloke joined the channel
5:33 AM
prabal joined the channel
6:01 AM
SkweezyJibbz has quit
6:07 AM
yvanzo
mo’’in’
6:23 AM
update beta.mb.o
6:46 AM
bitmap
yvanzo: thanks
6:47 AM
failed to get to that earlier but I'll update prod with the aliases fix now then see about running the sql script
6:48 AM
iliekcomputers
ishaanshah[m]: no worries, it was pretty late anyways
6:56 AM
bitmap
updating prod mb containers w/ MBS-9169
6:56 AM
BrainzBot
7:14 AM
bitmap
done, going to run the sql to fix the locales in the DB now
7:16 AM
also done
8:03 AM
Zastai joined the channel
8:25 AM
Chinmay3199 joined the channel
8:34 AM
v6lur joined the channel
9:05 AM
Gazooo has quit
9:06 AM
Gazooo joined the channel
9:33 AM
iliekcomputers
ishaanshah[m]: hi, i'm around
9:33 AM
ishaanshah[m]
iliekcomputers Hi
9:35 AM
iliekcomputers
heyo
9:35 AM
how are you?
9:36 AM
ruaok
\ø
9:36 AM
ishaanshah[m]
Doing well, got nothing to do except uni work :(
9:36 AM
iliekcomputers
well, we can fix that soon :P
9:37 AM
i was looking at the files we need to port over to ts.
9:38 AM
there's like 15-16, I guess?
9:38 AM
including tests
9:39 AM
ishaanshah[m]
Yep
9:39 AM
iliekcomputers
cool.
9:39 AM
shivam-kapila joined the channel
9:39 AM
do you think we should port over those or is there something else you'd like to work on?
9:40 AM
ishaanshah[m]
I think we should port them
9:40 AM
iliekcomputers
my opinion here is that we should just knock them out while we're at it, otherwise we'll never get to them
9:40 AM
ah cool.
9:40 AM
so here's what I was thinking.
9:41 AM
you start with the lastfm importer files you added
9:41 AM
should be easy because you wrote them relatively recently.
9:41 AM
i'll start looking at the ones from before that.
9:41 AM
i think reasonably we can port all of these over to ts in a week.
9:42 AM
then we can look at the eslint errors
9:42 AM
does that sound reasonable?
9:42 AM
ishaanshah[m]
Yep, thats doable
9:43 AM
iliekcomputers
cool cool cool
9:43 AM
ishaanshah[m]
Should we add tests for the remaining components too?
9:43 AM
Also while porting should we add tests for the remaining components?
9:44 AM
sorry for the double messages, matrix is acting wierd lately
9:44 AM
iliekcomputers
no worries.
9:44 AM
about tests for the old components, i'm neutral.
9:44 AM
let's add a basic snapshot test where possible, but I don't want to get into it too much, there's other stuff we can focus on.
9:45 AM
ishaanshah[m]
Ok, makes sense
9:46 AM
Also can you give me a brief overview of how I can setup stat generation in my local environment
9:46 AM
I tried doing it before, but couldn't get request consumer working
9:47 AM
iliekcomputers
right, the spark environment isn't very good for local development yet. i think that's something we'll have to work on a bit.
9:48 AM
let me think about it for a while and get back to you on that.
9:48 AM
ishaanshah[m]
Sure, maybe we can work on that next week.
9:49 AM
iliekcomputers
yeah, that's what i was thinking too. I'd be pretty happy to knock that out before gsoc too.
9:49 AM
do you think you have enough work for this week?
9:49 AM
ishaanshah[m]
I will work on porting now, which is much better than doing assignments:D
9:49 AM
> do you think you have enough work for this week?
9:49 AM
yes
9:49 AM
iliekcomputers
👍🏽
9:50 AM
awesome. if you get done earlier, just start fixing the eslint problems :)
9:50 AM
thanks ishaanshah[m] !
9:51 AM
shivam-kapila
Morning!
9:51 AM
iliekcomputers
i'm currently looking at the utils.jsx file, should have a PR open soon-ish
9:51 AM
if you start work on one of the non lastfm importer files, just ping me once so that we don't duplicate work.
9:51 AM
ishaanshah[m]
Yep will do
9:53 AM
shivam-kapila
ruaok: Hey. How did the morning coffee company go? :)
9:58 AM
ruaok
much less useful than I had hoped, shivam-kapila. I did a software update on my mac mini yesterday and its been unstable since then.
9:58 AM
I'm going to try a full re-install of the OS, so now trying to get setup on my laptop.
9:59 AM
shivam-kapila
ruaok: Oh I first interpreted the tests being much less useful
10:13 AM
BrainzGit
10:14 AM
10:14 AM
BrainzBot
10:19 AM
v6lur has quit
10:25 AM
prabal
10:27 AM
Mr_Monkey
Will do
10:36 AM
niceplace has quit
10:37 AM
niceplace joined the channel
10:49 AM
CatQuest
reosarevok: even in norwegian it's important to make distinctions to certain things.. like for example you say "spiller et trekkspill"(playing an accordion) "spiller en guitar" (playing a guitar) (and even "spiller trekkspill" (plays accordion) "spiller guitar (plays guitar))
10:53 AM
and. "spiller fele" "spiller ei fele" (hurra gender words)
10:55 AM
D4RK-PH0ENiX has quit
11:08 AM
D4RK-PH0ENiX joined the channel
11:17 AM
iliekcomputers
zas: seems to me that livegrep hasn't updated indexes in a long time
11:18 AM
11:21 AM
zas
I'll have a look
11:22 AM
iliekcomputers
thanks!
11:25 AM
zas
well, indexes are updated, but I think it doesn't remove old ones
11:27 AM
11:28 AM
perhaps we could re-index from scratch once in a while, removing the whole index file
11:30 AM
I removed it, let's see what happens on next re-index timer call
11:31 AM
hmmm, no change, it still indexes removed files it seems
11:45 AM
CatQuest
hi zas and iliekcomputers
11:46 AM
iliekcomputers
zas: i also can't find new files added to LB recently
11:46 AM
11:47 AM
zas
I'm rebuilding it, but as far I can tell, indexing is working
11:47 AM
Lotheric has quit
11:50 AM
Lotheric joined the channel
11:51 AM
iliekcomputers
12:09 PM
ruaok
shivam-kapila: I finally have things running (and my main computer install is moving along)
12:09 PM
I see only two tests failing now, using your branch -- the to_influx and from_influx
12:09 PM
does that sound right?
12:10 PM
shivam-kapila
Yes
12:10 PM
I havent worked on them till now
12:11 PM
I will look into them soon
12:11 PM
ruaok
ok, glad we're seeing the same things.
12:11 PM
if you have time to work on those, that would be great.
12:12 PM
shivam-kapila
Yeah sure I will.
12:12 PM
ruaok
I can start thinking about migration
12:12 PM
shivam-kapila
I was gonna ask you about it. What major part is left for migration. The timescale writer?
12:14 PM
ruaok
the timescale writer is another part, yes.
12:14 PM
but the migration of the database as i described it to iliekcomputers yesterday (or so) needs to be solidified.
12:14 PM
the process of copying the data from influx to timescale and not losing a single listen is some work.
12:15 PM
and moving timescale to be properly monitored in our infrastructure is another one.
12:16 PM
shivam-kapila
Hmm. Getting it.
12:16 PM
ishaanshah[m]
iliekcomputers: I took a look at your PR, lgtm
12:17 PM
I have ported lastFMImporter, opening a PR rn
12:17 PM
Please have a look
12:17 PM
iliekcomputers
ishaanshah[m]: thanks, can you approve it on github?
12:17 PM
ishaanshah[m]
Can we keep the console.warn statements for now
12:18 PM
iliekcomputers
I'm not sure about that.
12:18 PM
What benefit do we get keeping that?
12:19 PM
ishaanshah[m]
Right now we are not showing the error to the user, but ideally we should right?
12:20 PM
So keeping it will help us point out where we should do that
12:21 PM
iliekcomputers
Add a comment instead, I guess. The console.warn would show up in every user's console, which I don't really think we need to do.
12:23 PM
ishaanshah[m]
Ohk, will do that
12:23 PM
Can you do that in your PR too
12:24 PM
iliekcomputers
In the console.error I removed?
12:24 PM
ishaanshah[m]
Yep
12:24 PM
iliekcomputers
Yeah, sure.
12:28 PM
ishaanshah[m]: done
12:35 PM
BrainzGit
12:42 PM