#metabrainz

bitmap: I was away, but yes, go ahead and let's see what happens?

Freso: Sorry! See you found it :)

[musicbrainz-server] mwiencek merged pull request #1475 (master…csrf): MBS-10717, MBS-10778: Set SameSite=None on session cookie and add CSRF tokens to user/admin forms https://github.com/metabrainz/musicbrainz-serve...

MBS-10717: Adjust cookie attributes for new behavior in browsers https://tickets.metabrainz.org/browse/MBS-10717

MBS-10778: User/admin forms are prone to CSRF attacks https://tickets.metabrainz.org/browse/MBS-10778

updating the beta.mb containers

bitmap: thanks!

bitmap: which command did you use for https://github.com/metabrainz/musicbrainz-serve... ?

we may need to pass option --pure-lockfile to yarn now, otherwise it will revert these changes on build

Mr_Monkey: I wont be working much today.. have to go off to complete some work

🔥

Good luck with work !

mooooin!

That meme has memories 🤣

Morning!!

alastairp, Mr_Monkey, Zastai: are you using either docker toolbox or docker desktop on windows? do you run it from scripts?

Negative.

most of our repos (AB, BB, LB, MB) have bash scripts running docker commands.

I wonder if these scripts can be used on Windows at all.

I've used it before a couple of years ago and hated the whole experience. Not certain about bash scripts, but some contributors have had issues with develop.sh on windows (for BookBrainz)

it seems that (old) docker toolbox can be used with mingw64: https://github.com/metabrainz/musicbrainz-docke...

I use VirtualBox on Windows, so can't use the current Docker for Windows. I only run docker inside a Debian VirtualBox vm, for listenbrainz

and (new) docker desktop could be used with WSL: https://blog.jayway.com/2017/04/19/running-dock...

depends on how fancy they are. Git-Bash may be able to use them, if the relevant tools are on the path

and if you are doing Brainz work, chances are you have Git-Bash installed already

ishaanshah[m]: My condolences are with you 😜

There are also other projects that add bash-like behavior on windows like https://www.cygwin.com/

And on Windows 10, there's the Linux subsystem: https://www.howtogeek.com/249966/how-to-install...

Simple commands like "docker-compose exec musicbrainz /createdb.sh" already needs to be changed because Git Bash changes paths automatically.

Also may be worth trying with PowerShell?

with escaped path: "docker-compose exec musicbrainz //createdb.sh"

it might be solved using "MSYS_NO_PATHCONV=1"

sometimes 'winpty' command is needed as a prefix

Mr_Monkey: wouldn't that require even more specific instructions?

PS or Linux subsystem?

that is WSL?

Yes, but if you end up with as close as possible to linux bash, which is definitely a plus, and not just for using docker

IMO

Even more instructions: https://pythonise.com/series/windows-subsystem-...

It seems to be possible to setup Git Bash to work nicely with Docker for Windows, but I don't use this system anyway.

The new windows terminal supports linux type terminal

Since there were scripts for running docker in other repos, I was hoping someone found a fine setup already :)

Would you just recommend using VirtualBox/Ubuntu instead?

(That seems much more simple but might be overkill, dunno.)

yvanzo: Tried the ubuntu app available on windows app store??

shivam-kapila: thanks but again, I’m not using Windows.

Ah ok.

Mr_Monkey: Powershell can launch bash scripts?

I'm hazy on that, but it's supposed to have better support yes

(I'm not on Windows, so it's all hearsay :) )

yvanzo: ./rabbitmqadmin --username ruaok --password [pwd] -P 65414 -V /listenbrainz delete queue name=ts_incoming

that finally worked after I added the administrator tag to the ruaok account.

with : `rabbitmqctl set_user_tags ruaok administrator` from inside the container.

[musicbrainz-docker] yvanzo opened pull request #133 (mbvm-38-dev…msys): [WIP] Trying to add support Windows as Docker host https://github.com/metabrainz/musicbrainz-docke...

Mr_Monkey, shivam-kapila, Zastai: thanks.

:)

I'll reboot herb, switch gateway to it after, reboot kiki, switch back, applying upgrades and changes to openresty stuff

yvanzo: no, I don't use windows with docker, and it hadn't really come up as necessary for AB yet

of course, everything that you can do with our develop.sh you can do with just docker-compose commands, but it's a bit more work

iliekcomputers: sentry issues are mine, working to setup test.lb.org -plz ignore

🎊🎊

Setting up test.lb for client devs was a feature request in jira

Nice that we got to it with this :D

alastairp: yup, that is the same for MB, maybe it's even more work because it uses more containers for Solr search.

The point of develop.sh and such scripts is to make setup easy for newcomers, so IMHO we should just recommend using VirtualBox/Ubuntu as host to Docker novices using Windows.

(also found https://github.com/lfurzewaddock/wsldocker )

yvanzo: i think recommending Ubuntu as a VM makes sense too

most of our stuff is geared towards linux and i don't think there is much motivation to spend time keeping windows compatibility

I can't find what's wrong with lb LE cert renewal, still nothing in logs, I'll try to clean redis storage (in fact, enforce a prefix to related keys to force autossl to rewrite them)

zas: :(

zas: remind me, how can I find out what services are currently defined in consul ?

in particular is `listenbrainz-timescale` up right now?

iliekcomputers: Yup, if was hoping it would be simpler than it is. That compatibility should be added by someone actually using it, and we don't.

yvanzo: in what situations do people have to do more than "docker-compose up" ?

ruaok: you can use the consul http api: https://www.consul.io/api/catalog.html

for example, your example of /createdb could be solved by adding an entrypoint to that container which allows you to run that command

ruaok: curl http://10.2.2.25:8500/v1/catalog/services

hah, I just constructed that url. thanks!

curl http://10.2.2.25:8500/v1/catalog/service/timesc...

will give you details

hmm. not the service name I was expecting. that would be the problem.

to provide the service name, you need to define SERVICE_{port}_NAME env var, yes?

> "listenbrainz-timescale" : [],

much better.

alastairp: yes, probably many of these scripts could be replaced with docker environment, not sure.

for example, enabling/disabling replication and live indexing.

also reindexing search, and installing db triggers for live indexing.

but that would probably not handy either: editing .env, running docker-compose up, editing .env, ...

/createdb.sh has options depending on which data you want to install.

right, but my intution is that there's a format that we could structure this command to not require a /, for example

having said that, my point of view is that musicbrainz is a complex piece of software which requires specific configuration. I don't think it's unreasonable to expect people to make specific changes to files depending on their requirements

Maintaining a patch over a repo can be a PITA, musicbrainz-docker tries to prevent that to be needed as much as possible (via .env file and local/ dir).

But supporting Windows can only be contributed by someone actually using it and having a strong motivation for it.

yes, agreed

but if we supported this for linux, it'd be equal on windows (one hopes)

ha clever.

grrr. messybrainz is a separate repo. iliekcomputers +1 to your proposal.

Anything stuck?

not stuck, just tedious as hell. :)

I've been working 4 hours on getting the server up and running. lol.

Oh. Thats quite much.

yeah, I'm also doing three separate projects at the same time, so not unexpected.

Wow. Multitasking 😶

no choice.

Hard lyf :)

monorepos are amazing tbh

Google has ONE.

yeah

and when I started looking at the BB project with its... 6? gah! hell.