bitmap: I was away, but yes, go ahead and let's see what happens?
2020-04-23 11450, 2020
reosarevok
Freso: Sorry! See you found it :)
2020-04-23 11402, 2020
BrainzGit
[musicbrainz-server] mwiencek merged pull request #1475 (master…csrf): MBS-10717, MBS-10778: Set SameSite=None on session cookie and add CSRF tokens to user/admin forms https://github.com/metabrainz/musicbrainz-server/…
alastairp, Mr_Monkey, Zastai: are you using either docker toolbox or docker desktop on windows? do you run it from scripts?
2020-04-23 11442, 2020
Mr_Monkey
Negative.
2020-04-23 11406, 2020
yvanzo
most of our repos (AB, BB, LB, MB) have bash scripts running docker commands.
2020-04-23 11425, 2020
yvanzo
I wonder if these scripts can be used on Windows at all.
2020-04-23 11406, 2020
Mr_Monkey
I've used it before a couple of years ago and hated the whole experience. Not certain about bash scripts, but some contributors have had issues with develop.sh on windows (for BookBrainz)
It seems to be possible to setup Git Bash to work nicely with Docker for Windows, but I don't use this system anyway.
2020-04-23 11447, 2020
shivam-kapila
The new windows terminal supports linux type terminal
2020-04-23 11412, 2020
yvanzo
Since there were scripts for running docker in other repos, I was hoping someone found a fine setup already :)
2020-04-23 11430, 2020
yvanzo
Would you just recommend using VirtualBox/Ubuntu instead?
2020-04-23 11411, 2020
yvanzo
(That seems much more simple but might be overkill, dunno.)
2020-04-23 11426, 2020
shivam-kapila
yvanzo: Tried the ubuntu app available on windows app store??
2020-04-23 11402, 2020
yvanzo
shivam-kapila: thanks but again, I’m not using Windows.
2020-04-23 11414, 2020
Mr_Monkey
I thinkt he first and easiest step is to try with PowerShell, since it likely comes pre-installed. If that fails and user is on win10, using WSL is probably second best. VM is slower and trickier in my opinion
2020-04-23 11422, 2020
shivam-kapila
Ah ok.
2020-04-23 11435, 2020
BestSteve has quit
2020-04-23 11444, 2020
yvanzo
Mr_Monkey: Powershell can launch bash scripts?
2020-04-23 11402, 2020
Mr_Monkey
I'm hazy on that, but it's supposed to have better support yes
I'll reboot herb, switch gateway to it after, reboot kiki, switch back, applying upgrades and changes to openresty stuff
2020-04-23 11402, 2020
alastairp
yvanzo: no, I don't use windows with docker, and it hadn't really come up as necessary for AB yet
2020-04-23 11424, 2020
alastairp
of course, everything that you can do with our develop.sh you can do with just docker-compose commands, but it's a bit more work
2020-04-23 11459, 2020
ruaok
iliekcomputers: sentry issues are mine, working to setup test.lb.org -plz ignore
2020-04-23 11422, 2020
iliekcomputers
🎊🎊
2020-04-23 11450, 2020
iliekcomputers
Setting up test.lb for client devs was a feature request in jira
2020-04-23 11401, 2020
iliekcomputers
Nice that we got to it with this :D
2020-04-23 11446, 2020
BrainzGit has quit
2020-04-23 11402, 2020
BrainzGit joined the channel
2020-04-23 11403, 2020
BestSteve has quit
2020-04-23 11418, 2020
BestSteve joined the channel
2020-04-23 11442, 2020
yvanzo
alastairp: yup, that is the same for MB, maybe it's even more work because it uses more containers for Solr search.
2020-04-23 11453, 2020
yvanzo
The point of develop.sh and such scripts is to make setup easy for newcomers, so IMHO we should just recommend using VirtualBox/Ubuntu as host to Docker novices using Windows.
yvanzo: i think recommending Ubuntu as a VM makes sense too
2020-04-23 11433, 2020
iliekcomputers
most of our stuff is geared towards linux and i don't think there is much motivation to spend time keeping windows compatibility
2020-04-23 11455, 2020
supersandro20004 has quit
2020-04-23 11457, 2020
zas
I can't find what's wrong with lb LE cert renewal, still nothing in logs, I'll try to clean redis storage (in fact, enforce a prefix to related keys to force autossl to rewrite them)
2020-04-23 11417, 2020
supersandro2000 joined the channel
2020-04-23 11419, 2020
ruaok
zas: :(
2020-04-23 11435, 2020
ruaok
zas: remind me, how can I find out what services are currently defined in consul ?
2020-04-23 11450, 2020
ruaok
in particular is `listenbrainz-timescale` up right now?
2020-04-23 11431, 2020
yvanzo
iliekcomputers: Yup, if was hoping it would be simpler than it is. That compatibility should be added by someone actually using it, and we don't.
2020-04-23 11425, 2020
alastairp
yvanzo: in what situations do people have to do more than "docker-compose up" ?
hmm. not the service name I was expecting. that would be the problem.
2020-04-23 11428, 2020
ruaok
to provide the service name, you need to define SERVICE_{port}_NAME env var, yes?
2020-04-23 11410, 2020
ruaok
> "listenbrainz-timescale" : [],
2020-04-23 11414, 2020
ruaok
much better.
2020-04-23 11422, 2020
yvanzo
alastairp: yes, probably many of these scripts could be replaced with docker environment, not sure.
2020-04-23 11442, 2020
yvanzo
for example, enabling/disabling replication and live indexing.
2020-04-23 11451, 2020
yvanzo
also reindexing search, and installing db triggers for live indexing.
2020-04-23 11402, 2020
yvanzo
but that would probably not handy either: editing .env, running docker-compose up, editing .env, ...
2020-04-23 11434, 2020
yvanzo
/createdb.sh has options depending on which data you want to install.
2020-04-23 11449, 2020
alastairp
right, but my intution is that there's a format that we could structure this command to not require a /, for example
2020-04-23 11450, 2020
alastairp
having said that, my point of view is that musicbrainz is a complex piece of software which requires specific configuration. I don't think it's unreasonable to expect people to make specific changes to files depending on their requirements
2020-04-23 11435, 2020
yvanzo
Maintaining a patch over a repo can be a PITA, musicbrainz-docker tries to prevent that to be needed as much as possible (via .env file and local/ dir).
2020-04-23 11412, 2020
yvanzo
But supporting Windows can only be contributed by someone actually using it and having a strong motivation for it.
2020-04-23 11456, 2020
alastairp
yes, agreed
2020-04-23 11424, 2020
alastairp
but if we supported this for linux, it'd be equal on windows (one hopes)
2020-04-23 11438, 2020
ruaok
ha clever.
2020-04-23 11450, 2020
ptitjano_ has quit
2020-04-23 11409, 2020
ptitjano joined the channel
2020-04-23 11443, 2020
ruaok
grrr. messybrainz is a separate repo. iliekcomputers +1 to your proposal.
2020-04-23 11449, 2020
shivam-kapila
Anything stuck?
2020-04-23 11405, 2020
ruaok
not stuck, just tedious as hell. :)
2020-04-23 11425, 2020
ruaok
I've been working 4 hours on getting the server up and running. lol.
2020-04-23 11417, 2020
shivam-kapila
Oh. Thats quite much.
2020-04-23 11412, 2020
ruaok
yeah, I'm also doing three separate projects at the same time, so not unexpected.
2020-04-23 11446, 2020
shivam-kapila
Wow. Multitasking 😶
2020-04-23 11454, 2020
ruaok
no choice.
2020-04-23 11403, 2020
shivam-kapila
Hard lyf :)
2020-04-23 11445, 2020
iliekcomputers
monorepos are amazing tbh
2020-04-23 11400, 2020
ruaok
Google has ONE.
2020-04-23 11408, 2020
iliekcomputers
yeah
2020-04-23 11418, 2020
ruaok
and when I started looking at the BB project with its... 6? gah! hell.
