c1e0: Well, I'm not too involved with BB but I do like them!
2020-04-30 12145, 2020
c1e0
reosarevok: Ah, I'm glad you like them. I've been considering doing this since last year, but never found the time to make an attempt until now :D
2020-04-30 12133, 2020
jmp_music joined the channel
2020-04-30 12111, 2020
shivam-kapila joined the channel
2020-04-30 12128, 2020
shivam-kapila
iliekcomputers: I saw that PR #782 is merged but #762 isnt. I will ask ruaok what to do about it when he is free.
2020-04-30 12158, 2020
ZaphodBeeblebrox
c1e0: hey!
2020-04-30 12158, 2020
ZaphodBeeblebrox
talk about that with Mr_Monkey I think
2020-04-30 12158, 2020
ZaphodBeeblebrox
(I'll check them out once i'm awake on the phone, beenfeeling crummy lately)
2020-04-30 12133, 2020
shivam-kapila
c1e0: Those are some awesome icons. I like them :)
2020-04-30 12154, 2020
ZaphodBeeblebrox
oh c1e0 I love them!
2020-04-30 12155, 2020
ZaphodBeeblebrox
I agree the old badges are.. rather bland to the max.
2020-04-30 12155, 2020
ZaphodBeeblebrox
the pencil ones are cute!
2020-04-30 12155, 2020
ZaphodBeeblebrox
but I also like the ink on paper ones, if the pencil-to-quill ones are the ones used, the ink ones should be used for something else imho
2020-04-30 12145, 2020
ZaphodBeeblebrox
I lao realy like thei dea of renaming these
2020-04-30 12156, 2020
ZaphodBeeblebrox
just "revisionist I, II , III" is so bland
2020-04-30 12105, 2020
ZaphodBeeblebrox
<3
2020-04-30 12153, 2020
BestSteve has quit
2020-04-30 12121, 2020
BestSteve joined the channel
2020-04-30 12130, 2020
Mr_Monkey
Awesome work c1e0 ! I'll answer more in depth on the blog post, but they look really good, well done!
2020-04-30 12118, 2020
c1e0
shavim-kapila ZaphodBeeblebrox : Happy you guys like them :)
2020-04-30 12154, 2020
c1e0
ZaphodBeeblebrox: Agree with using the ink on paper ones for something else
2020-04-30 12123, 2020
c1e0
Mr_Monkey. Thanks :)
2020-04-30 12146, 2020
c1e0
Mr_Monkey: Also, some badges do not display correctly for me. One image is repeated across several achievements. https://bookbrainz.org/editor/681/achievements Don't know if anyone else is facing this.
Looks like the badges have a link to the wrong file in the database
2020-04-30 12129, 2020
ruaok
moooin!
2020-04-30 12142, 2020
ruaok
shivam-kapila: today I can return to doing technical work. woo!
2020-04-30 12106, 2020
ruaok
let me get the remainder of the business/planning work out of the way and then I'll jump back in.
2020-04-30 12106, 2020
shivam-kapila
Heya ruaok. Nice to hear that
2020-04-30 12110, 2020
Mr_Monkey
c1e0: I fixed the icons, you should see the correct ones now
2020-04-30 12123, 2020
Mr_Monkey
The'yre in great need of improvement :)
2020-04-30 12104, 2020
c1e0
Mr_Monkey: That was fast. Here was I planning to fix the issue myself :D
2020-04-30 12151, 2020
Mr_Monkey
Ah well, you would have needed access to the database anyway, consequently having to go through me…
2020-04-30 12123, 2020
reg[m] has quit
2020-04-30 12124, 2020
MagnusSvensson[m has quit
2020-04-30 12124, 2020
kepstin has quit
2020-04-30 12125, 2020
adi5026[m] has quit
2020-04-30 12126, 2020
elomatreb[m] has quit
2020-04-30 12133, 2020
ishaanshah[m] has quit
2020-04-30 12134, 2020
heyarne[m] has quit
2020-04-30 12134, 2020
goldenshimmer has quit
2020-04-30 12128, 2020
ishaanshah[m] joined the channel
2020-04-30 12128, 2020
ishaanshah[m]
iliekcomputers: Hi, I am done with all the tests except the SocketIO one. I didn't understand how to write the test for that. Should I just check if addWebsocketHandler is being called?
2020-04-30 12115, 2020
ishaanshah[m]
Also for the other test which was failing yesterday, I changed let to const because eslint was complaining, but now the tests pass
2020-04-30 12128, 2020
ishaanshah[m]
I am not sure what is happening
2020-04-30 12102, 2020
Gazooo has quit
2020-04-30 12149, 2020
Gazooo joined the channel
2020-04-30 12124, 2020
iliekcomputers
ishaanshah[m]: we want to check that `socket.on` has been called with the correct callback functions
2020-04-30 12115, 2020
iliekcomputers
you could move the callback functions into the class giving them a name, and then assert that socket.on is called with `("listen", instance.listenHandler)` or something
2020-04-30 12102, 2020
iliekcomputers
about the other test, the only thing i changed was making the data smaller and removing a `result.slice(0, 99)`, maybe that removed some javascript weirdness
2020-04-30 12105, 2020
ruaok checks the GSoC site one last time
2020-04-30 12122, 2020
ruaok
all slots taken and proper mentors assigned. looking good.
2020-04-30 12134, 2020
ruaok can't wait to press the famous fail all button
2020-04-30 12122, 2020
shivam-kapila
🙄🥺
2020-04-30 12145, 2020
ishaanshah[m]
I actually tried adding that too
2020-04-30 12150, 2020
ishaanshah[m]
Still worked
2020-04-30 12157, 2020
ishaanshah[m]
:D
2020-04-30 12121, 2020
iliekcomputers
lol
2020-04-30 12125, 2020
iliekcomputers
*shrug*
2020-04-30 12125, 2020
iliekcomputers
ishaanshah[m]: is there a reason you're doing mockdata["listens"] instead of mockdata.listens
ishaanshah[m]: could you add the json.parse(json.dumps(obj)) comment everywhere you use it
2020-04-30 12115, 2020
ishaanshah[m]
Sure
2020-04-30 12111, 2020
ishaanshah[m]
Is it fine if I add it to the top of each function?
2020-04-30 12117, 2020
ishaanshah[m]
which uses it
2020-04-30 12127, 2020
iliekcomputers
i would add it just before you use it
2020-04-30 12139, 2020
ishaanshah[m]
Ok
2020-04-30 12146, 2020
kepstin joined the channel
2020-04-30 12146, 2020
reg[m] joined the channel
2020-04-30 12146, 2020
heyarne[m] joined the channel
2020-04-30 12146, 2020
elomatreb[m] joined the channel
2020-04-30 12146, 2020
adi5026[m] joined the channel
2020-04-30 12146, 2020
MagnusSvensson[m joined the channel
2020-04-30 12146, 2020
goldenshimmer joined the channel
2020-04-30 12111, 2020
ruaok
yvanzo: ping
2020-04-30 12140, 2020
yvanzo
ruaok: pong
2020-04-30 12105, 2020
ruaok
moin! what is the status of the SOLR stuff in musicbrainz-docker?
2020-04-30 12133, 2020
ruaok
I'm getting reports from potential customers finding it hard to install MB, particular search stuff.
2020-04-30 12153, 2020
ruaok
I feel that your work, especially as of late, make installing MB quite a bit easier.
2020-04-30 12103, 2020
yvanzo
There still are issues with live indexing which potentially lagging behind replicated data.
2020-04-30 12106, 2020
ruaok
can we make the mbvn-38 branch official soon?
2020-04-30 12127, 2020
yvanzo
Yes, I plan to make mbvm-38-dev branch official by the end of next week.
2020-04-30 12128, 2020
ruaok
how severe/common are these problems?
2020-04-30 12143, 2020
ruaok
ah, very good!
2020-04-30 12115, 2020
ruaok
then carry on -- can you please update the docs after that making it very clear that the musicbrainz-docker project is the key method for installing your own copy of MB?
2020-04-30 12148, 2020
ruaok
I'll push these latest customers to the mbvm-38 branch in the meantime.
2020-04-30 12153, 2020
yvanzo
The main problem is search results do not keep up-to-date, this is the last issue so far I need to debug/document better at least.
