#metabrainz

I've redesigned some BookBrainz achievement badges. Any opinions/feedback? https://community.metabrainz.org/t/redesigning-...

c1e0: Well, I'm not too involved with BB but I do like them!

reosarevok: Ah, I'm glad you like them. I've been considering doing this since last year, but never found the time to make an attempt until now :D

iliekcomputers: I saw that PR #782 is merged but #762 isnt. I will ask ruaok what to do about it when he is free.

c1e0: hey!

talk about that with Mr_Monkey I think

(I'll check them out once i'm awake on the phone, beenfeeling crummy lately)

c1e0: Those are some awesome icons. I like them :)

oh c1e0 I love them!

I agree the old badges are.. rather bland to the max.

the pencil ones are cute!

but I also like the ink on paper ones, if the pencil-to-quill ones are the ones used, the ink ones should be used for something else imho

I lao realy like thei dea of renaming these

just "revisionist I, II , III" is so bland

<3

Awesome work c1e0 ! I'll answer more in depth on the blog post, but they look really good, well done!

shavim-kapila ZaphodBeeblebrox : Happy you guys like them :)

ZaphodBeeblebrox: Agree with using the ink on paper ones for something else

Mr_Monkey. Thanks :)

Mr_Monkey: Also, some badges do not display correctly for me. One image is repeated across several achievements. https://bookbrainz.org/editor/681/achievements Don't know if anyone else is facing this.

Might be a bug?

It's a bug indeed :)

I'll create a ticket

Here's what you should see for worker bee 1 for example: https://bookbrainz.org/images/workerbeeI.svg

Looks like the badges have a link to the wrong file in the database

moooin!

shivam-kapila: today I can return to doing technical work. woo!

let me get the remainder of the business/planning work out of the way and then I'll jump back in.

Heya ruaok. Nice to hear that

c1e0: I fixed the icons, you should see the correct ones now

The'yre in great need of improvement :)

Mr_Monkey: That was fast. Here was I planning to fix the issue myself :D

Ah well, you would have needed access to the database anyway, consequently having to go through me…

iliekcomputers: Hi, I am done with all the tests except the SocketIO one. I didn't understand how to write the test for that. Should I just check if addWebsocketHandler is being called?

Also for the other test which was failing yesterday, I changed let to const because eslint was complaining, but now the tests pass

I am not sure what is happening

ishaanshah[m]: we want to check that `socket.on` has been called with the correct callback functions

you could move the callback functions into the class giving them a name, and then assert that socket.on is called with `("listen", instance.listenHandler)` or something

about the other test, the only thing i changed was making the data smaller and removing a `result.slice(0, 99)`, maybe that removed some javascript weirdness

all slots taken and proper mentors assigned. looking good.

🙄🥺

I actually tried adding that too

Still worked

:D

lol

*shrug*

ishaanshah[m]: is there a reason you're doing mockdata["listens"] instead of mockdata.listens

I'm not sure we need the eslintdisables

The socket object is declared as private

Here, for example

As this is only a typescript thing, there were two options

Not the socket object

Oh, sorry for that

I will change that

I have intended to use bracket notation for private members only

* I intended to use bracket notation for private members only

I understood the mistake that I was making in socketIO test

My mock implementation was incorrect

Great!

Push you fixes, I'll take a final look tonight, but it looks pretty good to me.

*your

[metabrainz.org] mayhem merged pull request #343 (master…current-pledges): Add current supporters page https://github.com/metabrainz/metabrainz.org/pu...

ishaanshah[m]: could you add the json.parse(json.dumps(obj)) comment everywhere you use it

Sure

Is it fine if I add it to the top of each function?

which uses it

i would add it just before you use it

Ok

yvanzo: ping

ruaok: pong

moin! what is the status of the SOLR stuff in musicbrainz-docker?

I'm getting reports from potential customers finding it hard to install MB, particular search stuff.

I feel that your work, especially as of late, make installing MB quite a bit easier.

There still are issues with live indexing which potentially lagging behind replicated data.

can we make the mbvn-38 branch official soon?

Yes, I plan to make mbvm-38-dev branch official by the end of next week.

how severe/common are these problems?

ah, very good!

then carry on -- can you please update the docs after that making it very clear that the musicbrainz-docker project is the key method for installing your own copy of MB?

I'll push these latest customers to the mbvm-38 branch in the meantime.

The main problem is search results do not keep up-to-date, this is the last issue so far I need to debug/document better at least.

It is recommended to use for one month: https://musicbrainz.org/doc/MusicBrainz_Server/...

good. I think we should remove 90% of the content from that page to make it clear which way to use going forward.

it makes me happy that we've arrived here. this is critical for us.

I think we have an opportunity to pick up some customers who are not feeling that the competition is too expensive.

and making it so that MB is easy to get addicted to is a very good method for that.

Cool, I will further simplify installation steps, but hardware requirements will stay high due to search.

and search is still optional, right? which gives people an option for lower resource use if they dont need search.

Another good outcome of this: we will be able to easier test/debug/fix search components.

Yes, it is.

great.

next question: the deadling for the PG upgrade is coming soon. I've heard very little about this -- the MB team hasn't forgotten about it, right?

No, we briefly discussed it again just yesterday.

ok. its not a lot of work, just tricky... best to not leave it for too long

It will require special attention regarding extensions at least.

Freso (and MB bot owners): Just created https://tickets.metabrainz.org/projects/MBBE for OTHER-356!

OTHER-356: Add MusicBrainz Data Quality (MBDQ) project https://tickets.metabrainz.org/browse/OTHER-356