#metabrainz

400s on empty payloads should be okay, right?

I could be convinced that an empty payload is valid. it just has nothing in it

what's the usecase though

a noop api request?

i guess the ability to clear the playing now is a nice-to-have, but i would prefer it being more explicit

I guess https://listenbrainz.readthedocs.io/en/producti... implies that payload should have only one item

it's not clear

having said that - we've had people ask for the ability to test that their auth works anyway, submitting a listen with no payload would be great for that ;)

I'm OK with making it required, if that's the case then the documentation should be updated to make this very explicit

I have no strong feelings on the matter.

It’s Star Wars Monday!

People up for reviews: reosarevok, ruaok, bitmap, zas, pristine__, Freso, yvanzo, alastairp, Mr_Monkey, shivam-kapila, CatQuest, Cyna, _lucifer, ishaanshah[m] – anyone else who wants to give a review, please let me know ASAP! :)

reosarevok: Go!

reosarevok says…

"""

Hi!

Last week I worked on more edit conversions, and fixing the open edit conversions as needed.

Additionally, yesterday and today I fixed a couple of small bugs (thanks ruaok for the immediate help on the MetaBrainz side for MBS-10768!).

And, now that my pending genre code is merged, I finally started looking at all the pile of genre requests, so there's a lot of new, mostly obscure genres added now, from guaguancó to harsh noise wall!

MBS-10768: ISE on "Donation Check" tab for users with / in their names https://tickets.metabrainz.org/browse/MBS-10768

This week I plan to continue working on React and small tickets, as usual.

"""

ruaok: Go!

👀

I guess ruaok is AFK getting refreshments or something. bitmap, around? If so, go!

hi

I spent most of last week on stuff related to the postgres 12 upgrade

firstly worked on v12 branches for all necessary changes in musicbrainz-server, docker-postgres-cluster, musicbrainz-docker, etc.

then wrote some upgrade scripts and tested the upgrade with musicbrainz-docker

there's an issue with the earthdistance extension that breaks pg_upgrade

we can easily fix it, but it'll require people to run a script before & after the upgrade to replace a function and drop & rebuild an index (assuming they don't just import from scratch)

later I set up some clones of our production cluster on williams and plan to do a simulation of the prod upgrade there early this week. started a doc to keep notes on that

also prepared a blog post for today to remind people of the upgrade and answer some questions, but I added a meeting topic re: some PG extensions I'd like to clarify first

fin, zas ?

Hey

bitmap: will it change next MBS release date?

I upgraded grafana & influxdb, plus all usual sec upgrades

code review on Picard

yvanzo: not the upcoming release, but we'll have a v-2020-05-18 tag for sure

and usual supervision, that's all. yvanzo ?

thanks!

Last week, I released v-2020-04-27, fixed small bugs and reviewed PRs.

I merged MBVM-52 into the branch 'mbvm-38-dev' of musicbrainz-docker.

MBVM-52: Allow to load search indexes from FTP onto MusicBrainz slave server https://tickets.metabrainz.org/browse/MBVM-52

[listenbrainz-server] paramsingh opened pull request #831 (master…param/playing-now-endpoint-bug): LB-511: Raise 400 if the payload doesn't contain any listens https://github.com/metabrainz/listenbrainz-serv...

LB-511: Inconsistent response when submitting playing-now listens https://tickets.metabrainz.org/browse/LB-511

That branch still has issues with live indexing but is fine otherwise.

It should be merged and released this week as officially recommended setup.

Finally merged GitHub docs welcoming contributors to MBS repository.

Thanks to everyone for the many inputs on this pull request!

I used this PR and files from other repos to create https://github.com/metabrainz/.github

It makes GitHub to use these files for each MeB repository that is missing them.

Also finally created https://tickets.metabrainz.org/projects/MBBE for OTHER-356

OTHER-356: Add MusicBrainz Data Quality (MBDQ) project https://tickets.metabrainz.org/browse/OTHER-356

(The ticket is still open for reviews/feedback/suggestions before closing...)

Plus maintenance (500 on too many rels) and support (musicbrainz-docker).

That's all from me, reosarevok?

reosarevok went first. :p

Or maybe pristine__?

ruaok: Back?

yerp

Whichever writes first, goes first. :D

on it.

Hey

last week was mostly spent planning MeB stuff in response to the coronavirus. we've got a board meeting scheduled for thursday when we will discuss the plan in detail.

the good news: even though we've lost a couple of customers, we're still not in the red.

(QNAP and AEGLive are gone. Ticketmaster will be reduced)

😭

part of what is likely going to happen is that we're going to circle the wagons a bit and focus on trying to get our data to be used by more people in an effort to try and bring in more customers.

the musicbrainz team is likely going to be wholly unafffected.

alastair, Mr_Monkey and myself however, are going to work together to bring some recommendation stuff to the forefront with the goal of getting something out the door soon.

I've been doing some reading on recommendation stuff and trying to come up with a coherent plan. I posted my first thoughts on the matter in a doc earlier today.

still early times there.

I also spent some time working on the timescale migration and have upgrade the data migration tool and am now waiting for a new LB dump to test my dedup code.

hopefully we will have a clean roadmap for the next 6 months in place sometime next week.

fin.

pristine__: welcome back! go.

ruaok: thanks

(People still up: Freso, alastairp, Mr_Monkey, shivam-kapila, CatQuest, Cyna, _lucifer, ishaanshah[m] – anyone else who wants to give a review, please let me know ASAP! :))

(pristine__: Welcome back)

Freso: Me

[listenbrainz-server] paramsingh merged pull request #831 (master…param/playing-now-endpoint-bug): LB-511: Raise 400 if the payload doesn't contain any listens https://github.com/metabrainz/listenbrainz-serv...

LB-511: Inconsistent response when submitting playing-now listens https://tickets.metabrainz.org/browse/LB-511

I have not stepped out of the house since 16th March. Have been doing exercise, yoga and focussing in general health. Got a lil fever once but not sure if it was the virus

I finally got my spectacles after the lockdown eased a lil. I skimmed over doc shared by ruaok . It will be great if I can be of some help ( I will have to bring back everything, kinda lost track in this month)

fin!

shivam-kapila: go!

Hi everyone

The first part of last week was mostly revising React stuff

This weekend I did some small patches of contributions

Fixed spark tests on lovcal setup

Fixed max_ts = null bug while browsing listens

Reviewed iliekcomputers docs PR. Thanks for the chance. Was my 1st review. :)

Read ruaok plan for future and I pretty excited about stuff we will be doing

Also working on reset stats on listen delete. That part is done. The part left is clubbing stats for artsits with same name

Also making some changes in setup scripts and test.sh. Will push it in a while

Thats it. Thanks everyone

Freso: go

🙋

chaban had been reporting a bunch of spam stuff on the wiki, so I finally got around going through those and cleaning those up + found a couple extra things. While I was poking around, I also found some other things to clean up in the wiki, so did that, too.

Other than that, mostly the usual of being around and about.

fin.

alastairp: Go!

hi

last week I finished up a number of tasks that I had been working on the last few weeks

specifically, I got AB-392, AB-391, and AB-432 merged

AB-392: Upgrade react https://tickets.metabrainz.org/browse/AB-392

AB-391: Switch to webpack instead of gulp https://tickets.metabrainz.org/browse/AB-391

AB-432: API accepts poorly formed MBIDs but postgres doesn't like them https://tickets.metabrainz.org/browse/AB-432

I also worked with jmp_music on AB-436, which is now merged too.

AB-436: Datasets loaded with the csv loader don't set class descriptions to an empty string https://tickets.metabrainz.org/browse/AB-436

I did a release this afternoon and everything is up and running, and I worked on deployment guidelines to put a bit more structure to this task

thanks to jmp_music for the release, and Mr_Monkey for helping me with react

that's me, CatQuest?

No CatQuest? Mr_Monkey, go!

Hey !

(People still up: Cyna, _lucifer, ishaanshah[m], Chinmay3199 – anyone else who wants to give a review, please let me know ASAP! :))

Some good PR reviews last week, and also reviewing good looking new badges that c1eo has been working on (https://community.metabrainz.org/t/redesigning-...)

I also continued the long process of database cleanup, mainly borked identifiers from back when anything could be applied to anything

I took up the merging tool again, now that I have a bit more time. I finally managed to mock authentication for tests and am writing tests full steam ahead

There was also a long and painful rebase in the mix

And finally a sprinkle of SEC ticket upgrades.

That's it for me ! Cyna go !

Hey all

I've been mostly offline the past week

Cyna: fun?

For the other two previous week's which I haven't reviewed. I got PRs merged for handling deleting entities for BB and edit details for MB

*fin :p

Ah.

fin!

ishaanshah[m]: next ?

Hi everyone!

(Only _lucifer and Chinmay3199 remaining on my list! Last call for others who might want to give a review!)

Last week I finally got around to complete the Recent Listen tests

(Freso: Fun awaiting too. 27 minutes to result. :p)

I setup stats generation on my laptop, thanks to iliekcomputers and shivam-kapila.

I spent some time understanding how spark works with the webserver

(Me too. Thanks to iliekcomputers and ishaanshah[m]. It was exciting. Sorry to interrupt)

[listenbrainz-server] paramsingh opened pull request #832 (master…param/docs-fix): Add line about not allowing zero length payloads to json docs https://github.com/metabrainz/listenbrainz-serv...

Apart from that made a small patch to spark manager to import any dump

thats all for me

_lucifer: next?

hi all

i worked on fixing a bug in the metadata system so that app gets correctly built on fdroid

nothing else for me

Chinmay3199: next?