decided to take sometime away from the keyboard but that lasted for 3 days
2020-05-04 12557, 2020
Chinmay3199
Worked mostly around with the BB identifier and cleaning up the database there
2020-05-04 12522, 2020
Chinmay3199
Get back to learning more about End to end testing with Cypress
2020-05-04 12539, 2020
Chinmay3199
Finished some pending college assignments XD
2020-05-04 12541, 2020
Chinmay3199
fin.
2020-05-04 12549, 2020
Freso
Alright!
2020-05-04 12558, 2020
Freso
Thank you everyone for your reviews!
2020-05-04 12512, 2020
Freso
One more topic on today’s agenda…
2020-05-04 12520, 2020
Freso
bitmap: PG extensions
2020-05-04 12523, 2020
bitmap
okay
2020-05-04 12527, 2020
bitmap
one sec, have some text to paste
2020-05-04 12543, 2020
bitmap
one thing I'd like for us to do to simplify the PG upgrade is to drop the musicbrainz-collate and -unaccent extensions - we can replace those with functionality built into PG, even without breaking 9.5 (not using any v12 features)
2020-05-04 12553, 2020
bitmap
there have been some years-old requests to drop these extensions so people can more easily run MBS on AWS for example, so it'd be nice to do it while manual intervention is required
2020-05-04 12508, 2020
bitmap
this would require adding a couple functions and rebuilding some indexes, but I guess that might be fine since we already have to fix the earthdistance extension that way, as I mentioned earlier
2020-05-04 12509, 2020
ruaok
now is the time for this.
2020-05-04 12517, 2020
bitmap
to be clear, this would modify some functions and rebuild some indexes, but it wouldn't affect replication one way or another. does that sound okay?
2020-05-04 12527, 2020
yvanzo
+1
2020-05-04 12529, 2020
ruaok
fine by me.
2020-05-04 12530, 2020
iliekcomputers
sgtm
2020-05-04 12530, 2020
ruaok
+1
2020-05-04 12539, 2020
bitmap
ok, motion carried then. thanks!
2020-05-04 12543, 2020
Freso
Alright!
2020-05-04 12554, 2020
Freso
That is all for this meeting then.
2020-05-04 12509, 2020
Freso
Thank you everyone for your time. Please stay safe out there!
2020-05-04 12511, 2020
Freso
</BANG>
2020-05-04 12516, 2020
alastairp
bitmap: does that mean that postgres has since gained the functionality to do what we needed these extensions for previously?
2020-05-04 12536, 2020
Mr_Monkey
Thanks Freso !
2020-05-04 12540, 2020
Mr_Monkey
Take care everyone !
2020-05-04 12546, 2020
alastairp
iliekcomputers: thanks for the pr :)
2020-05-04 12551, 2020
bitmap
alastairp: it's had functionality for both of these things since at least 9.5, though the unaccent extension has been improved since
2020-05-04 12503, 2020
alastairp
that's great
2020-05-04 12523, 2020
bitmap
so I think it's suitable enough to replace musicbrainz-unaccent - we only really use it for direct search & deciding whether a disambiguation comment is required, anyway
2020-05-04 12531, 2020
iliekcomputers
np!
2020-05-04 12509, 2020
yvanzo
Thanks!
2020-05-04 12511, 2020
bitmap
& with the COLLATE feature PG I was able to basically reproduce the musicbrainz-collate sort order almost exactly
2020-05-04 12526, 2020
yvanzo
Freso: maybe can you please update the list of "people up for reviews" after pasting the ones you have been reported?
2020-05-04 12552, 2020
yvanzo
I always read these last because it goes too fast and we cannot interact with anyway.
2020-05-04 12508, 2020
Freso
yvanzo: I do post updated lists several times during the meeting.
2020-05-04 12529, 2020
shivam-kapila
I think he means like after todats reosarevok review
2020-05-04 12554, 2020
alastairp
iliekcomputers: did you see yvanzo's comment on your old guidelines PR? Do you know why you originally opened this pr in guidelines and not syswiki?
2020-05-04 12516, 2020
iliekcomputers
alastairp: i did see the comment, i don't remember the reason. I'm happy to put it in syswiki
2020-05-04 12503, 2020
alastairp
thanks. It felt ok to me to have it public as kind of a "this is why we have things like push.sh, and this is generally how we work, how tags are made, etc, even if you can't actually deploy it youself"
2020-05-04 12513, 2020
alastairp
but I agree that there's no clear reason to have it there
2020-05-04 12549, 2020
yvanzo
Freso: it's just I read this list minus people actually connected that went for review, anyway, not a big deal. :)
2020-05-04 12554, 2020
Freso
Ah, I see. I’ll consider it. FWIW, the first name on the list will always be the one I call on first.
