It mostly brings more React conversion by reosarveok.
Also looked at sockpuppets in MB editors, and updated spambrainz stuff from backlog.
Leo_Verto
Freso: I'm up tonight as well.
yvanzo
Plus usual PR reviews, Jira admin, cleaned up blog a bit, fin.
Go Leo_Verto?
Leo_Verto
Thanks!
First of all, I helped with some questions regarding the SpamBrainz GSoC project.
Right now I'm looking into updating and dockering BrainzBot.
CatQuest still remembers viking-helmet logo
It's currently running on an EOL'd Ubuntu release using an EOL'd python and Django version. Honestly getting it from Django 1.8 to 3 has been the hardest part so far.
Chinmay3199 joined the channel
fin. Mr_Monkey?
Mr_Monkey
Hi !
Last week I mainly worked on the ListenBrainz player and general music recommendation hype. I'm adding another source to be able to play tracks from youtube if a user doesn't have spotify or the track can't be found there.
I also worked a tiny bit more on tests for the merging tool on BookBrainz, and reviewed some PRs.
And finally, a bit of work on revision diffs, which are currently so-so on BookBrainz. This with the goal of deploying the Merging tool ASAP. I'll have to deploy on beta and prod very close to each other, as they share database (and merging tool is going to impact the DB)
That's it. bitmap Go!
jlh has quit
bitmap
hey
Freso
(People still up for reviews: alastairp, ruaok, ishaanshah[m], shivam-kapila, Cyna[m], _lucifer – anyone else who wants to give a review, please let me know ASAP!)
ruaok
the bad-ass of the hour!
bitmap
last week I mostly worked on preparations for the the pg12 upgrade today...
mostly testing the migration on williams and writing upgrade notes / instructions
did a small amount of code review but that's about it.
ruaok: lol thanks
fin! alastairp ?
alastairp
hi
last week I did a release of AB to launch an API that allows us to request a specific feature of a low-level document (like just BPM)
this is some work of aidan's that he started _before_ soc started last year, so I'm glad we finally got it launched (thanks aidan!)
this is so that we can start using it as a datasource for this new recommendation malarkey
I also started looking at aidan's SoC project, which is track to track similarity using acousticbrainz features
we found at the summit last year that the initialisation process got slower and slower as it processed more and more data. My estimates showed that we processed about 7 million items in 24h, but then took another 24h to process the next 1m items
so it was going to take 7-10 days to complete
ruaok
if ever.
alastairp
I managed to optimise this and get it down to 6 hours
so that was nice.
look to deploy that on bono this week so that we'll have similarity for recommendations
Mr_Monkey
Quite the optimization.
iliekcomputers
the entire process in 6 hours?
alastairp
yes
ruaok
!m alastairp
BrainzBot
You're doing good work, alastairp!
alastairp
finally, on Friday after talking to some uni colleagues, I took one of my coworker's recommendation tools that he had made to get recommendations from last.fm scrobbles, and I modified it to use the LB artist stats
and got some great recommendations out of the data
thanks to iliekcomputers and whoever else worked on artist stats, this is pretty exciting, that we can get similar results to active research with our 100% open data
will keep looking at that this week
fin. ruaok ?
ruaok
this week I spent time on recommendation malarkey and hype!
I also reviewed some PRs and moved the recommendation code along.
did some PG-12 prep over the weekend and a minor bit of work on the timescale port. I need to focus on that this week.
exciting times, really!
I'm glad to have the PG-12 move done. feels good.
fin.
ishaanshah[m]: go
reosarevok
So next will be PG-13?
ruaok
maybe shivam-kapila instead?
reosarevok
Mild violence!
Freso
shivam-kapila: Go!
shivam-kapila
Thanks!
Hi everyone
Freso
(Only Cyna[m] and _lucifer left on my list. Last call for anyone else who might want to give review!)
shivam-kapila
Last week I made some pre projects preps to start my GSoC project.
As iliekcomputers suggested
I am thinking to start it tomorrow if ruaok agrees
ruaok
anytime!
shivam-kapila
Apart from that I made a PR to upgradd the psql-client in LB
A small text issue was in prod. Made a PR to solve that
Did some PR reviews whilst PEP-8 bot was away
Thats it for me
_lucifer: go!
_lucifer
hi all
i worked on writing some ui tests for the app
and added some support for firebase test lab on the app side
will setup it on the server side this week
thats it for me
ishaanshah[m]: next?
ishaanshah[m]
Hey
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC students start here: https://bit.ly/2NUaxgb | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Meeting agenda: Reviews, 2 accounts 1 email (reo)
_lucifer
ruaok: are you available for a few minutes after the meeting today?
ishaanshah[m]
Last week I worked on fixing couple of minor bugs in the stats endpoint
ruaok
sure
ishaanshah[m]
Completed the artist graph port to react
After that worked on adding support for more time ranges for artist stats
shivam-kapila
(graph pagination is goood :) )
ishaanshah[m]
I grossly underestimated the time that would take
iliekcomputers
:D
reosarevok
That's how we always work ;)
iliekcomputers
learnings for next time :)
ishaanshah[m]
Hoping to get that done in next couple of days :D
Mr_Monkey
-> Soon™
ishaanshah[m]
Thats it for me, Cyna next
shivam-kapila
lol
ishaanshah[m]
😅
Freso
Cyna[m]: ^ go :)
Or maybe there’s no Cyna[m]. Well then. No more up for reviews to go in their stead, so…
Thank you to everyone who gave reviews for your reviews! We have one more item on today’s agenda.
reo: 2 accounts 1 email
reosarevok
Hi!
Mr_Monkey
That can't be PG 12
jmp_music
Hello to everyone! hello to everyone. As a new member of the community, I have to say, that my last week was mainly devoted to studying the AB publications as well as playing with the Gaia tool and reading its code. I could start building the python relevant tool since next week I think.
:)
reosarevok
Oh!
!m jmp_music
BrainzBot
You're doing good work, jmp_music!
reosarevok
Good that someone reads all that stuff :D
So, we have an issue where some people keep making new accounts with the same email when they get blocked from editing
The first thought was "why do we even allow to have the same email on several accounts, that's just making it easy for sockpuppet people too"
But then I remembered my bot account uses the same email, so that's at least one legit use
Might not be enough of a legit use though, I guess the bot accounts could always be made to use a different address?
Guest45208 has quit
Anyway, I made a quick query, found that we have over 20000 emails that have been used more than once
(most of them look spammy)
Freso
FWIW, having one e-mail = one account would also make Discourse interaction a lot more sane.
But that’s a secondary (or maybe even tertiary) concern.
reosarevok
...I also found that I actually had two more accounts with my email I didn't remember at all, which was fun
_lucifer
more than once in the sense that the same email or the + thing gmail allows
shivam-kapila
(I also use same mail for two accounts. 1 major and other for testing but I can move it to new account.)
reosarevok
_lucifer: just the same
I'm thinking it might actually be fine to restrict emails to once only
But we'd need to figure out two things
Freso
And for people with Google accounts, you can do accountname+botname@gmail or such to "create" a "new" e-mail for the purpose of MB.
reosarevok
a) what do we do for stuff like bots
and b) what do we do for the 20k+ existing ones
Freso
(Not all mail providers provide this, of course.)
_lucifer
The + should be banned as well in that case?
reosarevok
Oh, and I guess c) do we want to also block the + thing to avoid sockpuppets
yvanzo
There is another case: when you don't recall about your previous account. That doesn’t require to allow for 2 accounts, but then it should be handled.
reosarevok
yvanzo: yeah, that's why I have 4 I think :D
That one might just give the user "there's already an account with this email, you can recover your username <a>here</a>"
Freso
There is also the privacy problem of checking whether someone has an account at all by trying to use their known address to register with, so that’s someone to be aware of too.
Freso: sure, but most pages do that, so I don't think it would be a big deal
(say "this email is already in use" I mean)
Freso
reosarevok: Doesn’t mean we can’t do better. :)
reosarevok
I don't know how we can do better *and* still block reuse :)
cleo joined the channel
Freso
It’s an implementation detail, so something to keep in mind for later. We have to decide policy first.
yvanzo
We can change the workflow to register to ask people to check their emails first.
cleo is now known as Guest74203
reosarevok
Anyway
Freso
a) For bots. We clearly mark accounts as bots so we could "force set" bot accounts to use the same e-mail as their owner on their behalf?
reosarevok
The bot issue could maybe be solved just by saying "if you want to register a ...
Yeah, that
Freso
I’d still want the owner to read edit notes to bot edits.
alastairp
Freso: in Freesound when people change their email address, we say "we'll send you an email if this change is allowed". We don't say "you can't, it's already been used". If it's been used, we just silently ignore it. It seems to be a common pattern
Mr_Monkey
Considering how easy it is to set up an email address with redirect, I'd say limiting to 1 account per email makes sense if it solves real issues
Freso
alastairp: Yeah, something like that.
reosarevok
What do we do with the existing accounts with the same email? Do we just consider them grandfathered in?
zas
can we create an exception list for accounts allowed to re-use an email address, and enforce one email/one account for all accounts not listed in this list?
alastairp
also, while it's true that gmail + addresses might be aproblem, I suspect that in 90% of the cases, people who want to make sockpuppet accounts aren't probably going to use that. just a hunch