It mostly brings more React conversion by reosarveok.
2020-05-18 13930, 2020
yvanzo
Also looked at sockpuppets in MB editors, and updated spambrainz stuff from backlog.
2020-05-18 13934, 2020
Leo_Verto
Freso: I'm up tonight as well.
2020-05-18 13939, 2020
yvanzo
Plus usual PR reviews, Jira admin, cleaned up blog a bit, fin.
2020-05-18 13947, 2020
yvanzo
Go Leo_Verto?
2020-05-18 13953, 2020
Leo_Verto
Thanks!
2020-05-18 13925, 2020
Leo_Verto
First of all, I helped with some questions regarding the SpamBrainz GSoC project.
2020-05-18 13936, 2020
Leo_Verto
Right now I'm looking into updating and dockering BrainzBot.
2020-05-18 13941, 2020
CatQuest still remembers viking-helmet logo
2020-05-18 13909, 2020
Leo_Verto
It's currently running on an EOL'd Ubuntu release using an EOL'd python and Django version. Honestly getting it from Django 1.8 to 3 has been the hardest part so far.
2020-05-18 13919, 2020
Chinmay3199 joined the channel
2020-05-18 13920, 2020
Leo_Verto
fin. Mr_Monkey?
2020-05-18 13924, 2020
Mr_Monkey
Hi !
2020-05-18 13921, 2020
Mr_Monkey
Last week I mainly worked on the ListenBrainz player and general music recommendation hype. I'm adding another source to be able to play tracks from youtube if a user doesn't have spotify or the track can't be found there.
2020-05-18 13957, 2020
Mr_Monkey
I also worked a tiny bit more on tests for the merging tool on BookBrainz, and reviewed some PRs.
2020-05-18 13901, 2020
Mr_Monkey
And finally, a bit of work on revision diffs, which are currently so-so on BookBrainz. This with the goal of deploying the Merging tool ASAP. I'll have to deploy on beta and prod very close to each other, as they share database (and merging tool is going to impact the DB)
2020-05-18 13914, 2020
Mr_Monkey
That's it. bitmap Go!
2020-05-18 13917, 2020
jlh has quit
2020-05-18 13920, 2020
bitmap
hey
2020-05-18 13937, 2020
Freso
(People still up for reviews: alastairp, ruaok, ishaanshah[m], shivam-kapila, Cyna[m], _lucifer – anyone else who wants to give a review, please let me know ASAP!)
2020-05-18 13939, 2020
ruaok
the bad-ass of the hour!
2020-05-18 13942, 2020
bitmap
last week I mostly worked on preparations for the the pg12 upgrade today...
2020-05-18 13959, 2020
bitmap
mostly testing the migration on williams and writing upgrade notes / instructions
2020-05-18 13922, 2020
bitmap
did a small amount of code review but that's about it.
2020-05-18 13928, 2020
bitmap
ruaok: lol thanks
2020-05-18 13943, 2020
bitmap
fin! alastairp ?
2020-05-18 13948, 2020
alastairp
hi
2020-05-18 13923, 2020
alastairp
last week I did a release of AB to launch an API that allows us to request a specific feature of a low-level document (like just BPM)
2020-05-18 13951, 2020
alastairp
this is some work of aidan's that he started _before_ soc started last year, so I'm glad we finally got it launched (thanks aidan!)
2020-05-18 13915, 2020
alastairp
this is so that we can start using it as a datasource for this new recommendation malarkey
2020-05-18 13935, 2020
alastairp
I also started looking at aidan's SoC project, which is track to track similarity using acousticbrainz features
2020-05-18 13925, 2020
alastairp
we found at the summit last year that the initialisation process got slower and slower as it processed more and more data. My estimates showed that we processed about 7 million items in 24h, but then took another 24h to process the next 1m items
2020-05-18 13934, 2020
alastairp
so it was going to take 7-10 days to complete
2020-05-18 13940, 2020
ruaok
if ever.
2020-05-18 13943, 2020
alastairp
I managed to optimise this and get it down to 6 hours
2020-05-18 13949, 2020
alastairp
so that was nice.
2020-05-18 13901, 2020
alastairp
look to deploy that on bono this week so that we'll have similarity for recommendations
2020-05-18 13906, 2020
Mr_Monkey
Quite the optimization.
2020-05-18 13924, 2020
iliekcomputers
the entire process in 6 hours?
2020-05-18 13928, 2020
alastairp
yes
2020-05-18 13933, 2020
ruaok
!m alastairp
2020-05-18 13933, 2020
BrainzBot
You're doing good work, alastairp!
2020-05-18 13947, 2020
alastairp
finally, on Friday after talking to some uni colleagues, I took one of my coworker's recommendation tools that he had made to get recommendations from last.fm scrobbles, and I modified it to use the LB artist stats
2020-05-18 13954, 2020
alastairp
and got some great recommendations out of the data
2020-05-18 13923, 2020
alastairp
thanks to iliekcomputers and whoever else worked on artist stats, this is pretty exciting, that we can get similar results to active research with our 100% open data
2020-05-18 13936, 2020
alastairp
will keep looking at that this week
2020-05-18 13937, 2020
alastairp
fin. ruaok ?
2020-05-18 13951, 2020
ruaok
this week I spent time on recommendation malarkey and hype!
2020-05-18 13911, 2020
ruaok
I also reviewed some PRs and moved the recommendation code along.
2020-05-18 13942, 2020
ruaok
did some PG-12 prep over the weekend and a minor bit of work on the timescale port. I need to focus on that this week.
2020-05-18 13952, 2020
ruaok
exciting times, really!
2020-05-18 13908, 2020
ruaok
I'm glad to have the PG-12 move done. feels good.
2020-05-18 13912, 2020
ruaok
fin.
2020-05-18 13920, 2020
ruaok
ishaanshah[m]: go
2020-05-18 13948, 2020
reosarevok
So next will be PG-13?
2020-05-18 13952, 2020
ruaok
maybe shivam-kapila instead?
2020-05-18 13954, 2020
reosarevok
Mild violence!
2020-05-18 13904, 2020
Freso
shivam-kapila: Go!
2020-05-18 13912, 2020
shivam-kapila
Thanks!
2020-05-18 13916, 2020
shivam-kapila
Hi everyone
2020-05-18 13932, 2020
Freso
(Only Cyna[m] and _lucifer left on my list. Last call for anyone else who might want to give review!)
2020-05-18 13939, 2020
shivam-kapila
Last week I made some pre projects preps to start my GSoC project.
2020-05-18 13959, 2020
shivam-kapila
As iliekcomputers suggested
2020-05-18 13923, 2020
shivam-kapila
I am thinking to start it tomorrow if ruaok agrees
2020-05-18 13934, 2020
ruaok
anytime!
2020-05-18 13953, 2020
shivam-kapila
Apart from that I made a PR to upgradd the psql-client in LB
2020-05-18 13914, 2020
shivam-kapila
A small text issue was in prod. Made a PR to solve that
2020-05-18 13937, 2020
shivam-kapila
Did some PR reviews whilst PEP-8 bot was away
2020-05-18 13943, 2020
shivam-kapila
Thats it for me
2020-05-18 13949, 2020
shivam-kapila
_lucifer: go!
2020-05-18 13955, 2020
_lucifer
hi all
2020-05-18 13909, 2020
_lucifer
i worked on writing some ui tests for the app
2020-05-18 13931, 2020
_lucifer
and added some support for firebase test lab on the app side
2020-05-18 13944, 2020
_lucifer
will setup it on the server side this week
2020-05-18 13949, 2020
_lucifer
thats it for me
2020-05-18 13953, 2020
_lucifer
ishaanshah[m]: next?
2020-05-18 13905, 2020
ishaanshah[m]
Hey
2020-05-18 13906, 2020
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC students start here: https://bit.ly/2NUaxgb | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Meeting agenda: Reviews, 2 accounts 1 email (reo)
2020-05-18 13933, 2020
_lucifer
ruaok: are you available for a few minutes after the meeting today?
2020-05-18 13935, 2020
ishaanshah[m]
Last week I worked on fixing couple of minor bugs in the stats endpoint
2020-05-18 13946, 2020
ruaok
sure
2020-05-18 13949, 2020
ishaanshah[m]
Completed the artist graph port to react
2020-05-18 13922, 2020
ishaanshah[m]
After that worked on adding support for more time ranges for artist stats
2020-05-18 13931, 2020
shivam-kapila
(graph pagination is goood :) )
2020-05-18 13950, 2020
ishaanshah[m]
I grossly underestimated the time that would take
2020-05-18 13959, 2020
iliekcomputers
:D
2020-05-18 13909, 2020
reosarevok
That's how we always work ;)
2020-05-18 13911, 2020
iliekcomputers
learnings for next time :)
2020-05-18 13917, 2020
ishaanshah[m]
Hoping to get that done in next couple of days :D
2020-05-18 13931, 2020
Mr_Monkey
-> Soon™
2020-05-18 13945, 2020
ishaanshah[m]
Thats it for me, Cyna next
2020-05-18 13947, 2020
shivam-kapila
lol
2020-05-18 13955, 2020
ishaanshah[m]
😅
2020-05-18 13910, 2020
Freso
Cyna[m]: ^ go :)
2020-05-18 13952, 2020
Freso
Or maybe there’s no Cyna[m]. Well then. No more up for reviews to go in their stead, so…
2020-05-18 13959, 2020
Freso
Thank you to everyone who gave reviews for your reviews! We have one more item on today’s agenda.
2020-05-18 13904, 2020
Freso
reo: 2 accounts 1 email
2020-05-18 13920, 2020
reosarevok
Hi!
2020-05-18 13930, 2020
Mr_Monkey
That can't be PG 12
2020-05-18 13938, 2020
jmp_music
Hello to everyone! hello to everyone. As a new member of the community, I have to say, that my last week was mainly devoted to studying the AB publications as well as playing with the Gaia tool and reading its code. I could start building the python relevant tool since next week I think.
2020-05-18 13942, 2020
jmp_music
:)
2020-05-18 13959, 2020
reosarevok
Oh!
2020-05-18 13902, 2020
reosarevok
!m jmp_music
2020-05-18 13902, 2020
BrainzBot
You're doing good work, jmp_music!
2020-05-18 13909, 2020
reosarevok
Good that someone reads all that stuff :D
2020-05-18 13946, 2020
reosarevok
So, we have an issue where some people keep making new accounts with the same email when they get blocked from editing
2020-05-18 13928, 2020
reosarevok
The first thought was "why do we even allow to have the same email on several accounts, that's just making it easy for sockpuppet people too"
2020-05-18 13901, 2020
reosarevok
But then I remembered my bot account uses the same email, so that's at least one legit use
2020-05-18 13924, 2020
reosarevok
Might not be enough of a legit use though, I guess the bot accounts could always be made to use a different address?
2020-05-18 13931, 2020
Guest45208 has quit
2020-05-18 13943, 2020
reosarevok
Anyway, I made a quick query, found that we have over 20000 emails that have been used more than once
2020-05-18 13949, 2020
reosarevok
(most of them look spammy)
2020-05-18 13951, 2020
Freso
FWIW, having one e-mail = one account would also make Discourse interaction a lot more sane.
2020-05-18 13907, 2020
Freso
But that’s a secondary (or maybe even tertiary) concern.
2020-05-18 13912, 2020
reosarevok
...I also found that I actually had two more accounts with my email I didn't remember at all, which was fun
2020-05-18 13931, 2020
_lucifer
more than once in the sense that the same email or the + thing gmail allows
2020-05-18 13933, 2020
shivam-kapila
(I also use same mail for two accounts. 1 major and other for testing but I can move it to new account.)
2020-05-18 13942, 2020
reosarevok
_lucifer: just the same
2020-05-18 13949, 2020
reosarevok
I'm thinking it might actually be fine to restrict emails to once only
2020-05-18 13906, 2020
reosarevok
But we'd need to figure out two things
2020-05-18 13909, 2020
Freso
And for people with Google accounts, you can do accountname+botname@gmail or such to "create" a "new" e-mail for the purpose of MB.
2020-05-18 13913, 2020
reosarevok
a) what do we do for stuff like bots
2020-05-18 13921, 2020
reosarevok
and b) what do we do for the 20k+ existing ones
2020-05-18 13922, 2020
Freso
(Not all mail providers provide this, of course.)
2020-05-18 13943, 2020
_lucifer
The + should be banned as well in that case?
2020-05-18 13944, 2020
reosarevok
Oh, and I guess c) do we want to also block the + thing to avoid sockpuppets
2020-05-18 13949, 2020
yvanzo
There is another case: when you don't recall about your previous account. That doesn’t require to allow for 2 accounts, but then it should be handled.
2020-05-18 13913, 2020
reosarevok
yvanzo: yeah, that's why I have 4 I think :D
2020-05-18 13937, 2020
reosarevok
That one might just give the user "there's already an account with this email, you can recover your username <a>here</a>"
2020-05-18 13951, 2020
Freso
There is also the privacy problem of checking whether someone has an account at all by trying to use their known address to register with, so that’s someone to be aware of too.
Freso: sure, but most pages do that, so I don't think it would be a big deal
2020-05-18 13929, 2020
reosarevok
(say "this email is already in use" I mean)
2020-05-18 13929, 2020
Freso
reosarevok: Doesn’t mean we can’t do better. :)
2020-05-18 13944, 2020
reosarevok
I don't know how we can do better *and* still block reuse :)
2020-05-18 13957, 2020
cleo joined the channel
2020-05-18 13907, 2020
Freso
It’s an implementation detail, so something to keep in mind for later. We have to decide policy first.
2020-05-18 13907, 2020
yvanzo
We can change the workflow to register to ask people to check their emails first.
2020-05-18 13919, 2020
cleo is now known as Guest74203
2020-05-18 13945, 2020
reosarevok
Anyway
2020-05-18 13904, 2020
Freso
a) For bots. We clearly mark accounts as bots so we could "force set" bot accounts to use the same e-mail as their owner on their behalf?
2020-05-18 13909, 2020
reosarevok
The bot issue could maybe be solved just by saying "if you want to register a ...
2020-05-18 13912, 2020
reosarevok
Yeah, that
2020-05-18 13917, 2020
Freso
I’d still want the owner to read edit notes to bot edits.
2020-05-18 13919, 2020
alastairp
Freso: in Freesound when people change their email address, we say "we'll send you an email if this change is allowed". We don't say "you can't, it's already been used". If it's been used, we just silently ignore it. It seems to be a common pattern
2020-05-18 13922, 2020
Mr_Monkey
Considering how easy it is to set up an email address with redirect, I'd say limiting to 1 account per email makes sense if it solves real issues
2020-05-18 13939, 2020
Freso
alastairp: Yeah, something like that.
2020-05-18 13954, 2020
reosarevok
What do we do with the existing accounts with the same email? Do we just consider them grandfathered in?
2020-05-18 13904, 2020
zas
can we create an exception list for accounts allowed to re-use an email address, and enforce one email/one account for all accounts not listed in this list?
2020-05-18 13910, 2020
alastairp
also, while it's true that gmail + addresses might be aproblem, I suspect that in 90% of the cases, people who want to make sockpuppet accounts aren't probably going to use that. just a hunch
