ruaok: I am currently free now. What exact behaviour do we want to test for more than 3 week spaced listens?
rdswift has quit
ruaok
to make sure we don't miss any.
iliekcomputers
alastairp: thanks for the feedback!
Making a new ticket for it would be nice, we'll try to fix those things this week.
alastairp
sure, I wasn't sure where to put it
that is, the specific issue you raised is fixed, yeah, but this seems to be all involved somehow
I just had a big discussion with Mr_Monkey about it, he said he'd give some feedback when he got home
iliekcomputers
Yeah, this kind of feedback is really valuable. And small things like this are harder to notice for me and ishaanshah because we're too deep into the implementation. Thanks!
alastairp
it seems like this kind of page interaction is going to be really important in LB, so it makes sense to work out how to do it well, so that we can just copy/paste onto a new page
Mr_Monkey showed me how the flask app sends data to the react on the listens page, this seems like a neat way of doing the interaction
iliekcomputers
Totally agree about getting it right early. I think react-router should reasonably handle all of these issues.
I do like using the API in javascript better than rendering the data into the html template though.
ishaanshah
Is this about the back button not working on graphs page
LB-610: The URL in the browser should update with parameters for the history page
ishaanshah
Oh
Although yeah the back button doesnt work
I tried to get it to work, but its difficult to sync state and parameters
alastairp
as I said, I had a bit of a chat with Mr_Monkey about it, he said that we could spend some time working out a standard for how do to this, synchronising the state between the server and the frontend
this will be useful for some parts of AB too
ishaanshah
as iliekcomputers said React Router provides a solution for that
*For back button
Chinmay3199 joined the channel
alastairp
ishaanshah: a suggestion for next time - feel free to add a comment to any pull request or ticket saying if you found a problem but were unable to find a solution
for example if you knew that the back button wasn't working in this case, just a comment "I know the back button isn't working, but can't work out how to handle this nicely" would have been great
ishaanshah
Yep, will do that next time
Mr_Monkey
> I do like using the API in javascript better than rendering the data into the html template though.
iliekcomputers: The ideal world is doing both, IMO. Load the page with initial data (like we do for listens page), and then the next/previous buttons make call to the API (like the stats page does).
Currently those two page are missing what the other one has…
ishaanshah: I'm interested in all the solutions, quirks and issues you/we find for url parameters, as it's fairly high on my list for BookBrainz (now that we have better pagination)
Is react router really needed? is it not overkill for just changing url params and browser history?
iliekcomputers
Mr_Monkey: what's the benefit of loading the page with initial data? It'll need more code which we could avoid.
Mr_Monkey
Better user experience, less API calls from the client
alastairp
yeah, it prevents the browser from having to do _another_ round trip for the API data
Mr_Monkey
If I have a really slow connection and I navigate to page 2, instead of the page1 flashing I't'll slowly show page 1, then slowly do another API call to show the correct page. Not ideal.
Freso
Also not showing a blank page for people with JS disabled.
alastairp
Nothing to stop us using the API server endpoint in flask to get the data for the right page
Mr_Monkey
Or, alternativaly, if any of the URL parameters are not the default ones, maybe skip the initial API call?
iliekcomputers
Yeah, that's what I was thinking, we should just skip the initial API call
Mr_Monkey
Freso: That's another story… we're talking about sending data with the page rather than rendered html
alastairp
Freso: our suggestion isn't a complete fix to this, the page data will still be rendered by js
BrainzGit
[musicbrainz-server] yvanzo merged pull request #1540 (master…MBS-10469-delay-showing-CAA-on-front-page): MBS-10469: Add 10 minute delay to shown CAA on front page https://github.com/metabrainz/musicbrainz-serve...
That being said, skipping the API call will already solve that flash of incorrect content issue
ruaok
I'm inclined to fire off the calculation of that on page load, but to load it from the browser via a JS call so the page load doesn't need to wait.
iliekcomputers
While I would love for it to be as snappy as possible, I don't really feel good about having to maintain two paths from which data could come into the component unless absolutely necessary
ishaanshah
The initial flash can be solved by fetching data in componentDidMount seperately
ruaok
I feel that sentiment.
ishaanshah
Right now I am using other functions to do this to avoid duplication
iliekcomputers
The flash is definitely an issue we need to fix
alastairp
> I don't really feel good about having to maintain two paths from which data could come into the component unless absolutely necessary
I'm not convinced that this is as much of a problem as it seems
I'd be happy to have a discussion/hack day soon to see if we can work out how to do it without repeating code
iliekcomputers
We'll have to reuse the code that fetches data in the API endpoint in the profile view. The frontend should be ok.
alastairp
I'm not sure what you mean by "reuse code"
do you mean copy some code and have it duplicated in 2 places, or "call a function"?
iliekcomputers
Call a function, ideally.
ruaok
gah.
bitmap: I hope you're staying home. CTA is closed. when did that happen last? (besides yesterday, I guess)
iliekcomputers
What's CTA?
bitmap
ruaok: never that I can remember. pretty crazy
ruaok
chicago transit authority.
all public transit is shut.
bitmap
I was visiting my parents' so I'll be stuck here for a while I guess
ruaok
so... bitmpa, when are you moving to the EU?
iliekcomputers
Crazy times, stay safe, bitmap. :(
bitmap
good question lol
yvanzo
likely not today
ruaok
LOL
not anytime soon, really. the EU is largely still closed. esp to the US.