ruaok: I am currently free now. What exact behaviour do we want to test for more than 3 week spaced listens?
2020-06-01 15346, 2020
rdswift has quit
2020-06-01 15303, 2020
ruaok
to make sure we don't miss any.
2020-06-01 15310, 2020
iliekcomputers
alastairp: thanks for the feedback!
2020-06-01 15338, 2020
iliekcomputers
Making a new ticket for it would be nice, we'll try to fix those things this week.
2020-06-01 15345, 2020
alastairp
sure, I wasn't sure where to put it
2020-06-01 15321, 2020
alastairp
that is, the specific issue you raised is fixed, yeah, but this seems to be all involved somehow
2020-06-01 15335, 2020
alastairp
I just had a big discussion with Mr_Monkey about it, he said he'd give some feedback when he got home
2020-06-01 15302, 2020
iliekcomputers
Yeah, this kind of feedback is really valuable. And small things like this are harder to notice for me and ishaanshah because we're too deep into the implementation. Thanks!
2020-06-01 15319, 2020
alastairp
it seems like this kind of page interaction is going to be really important in LB, so it makes sense to work out how to do it well, so that we can just copy/paste onto a new page
2020-06-01 15344, 2020
alastairp
Mr_Monkey showed me how the flask app sends data to the react on the listens page, this seems like a neat way of doing the interaction
2020-06-01 15333, 2020
iliekcomputers
Totally agree about getting it right early. I think react-router should reasonably handle all of these issues.
2020-06-01 15300, 2020
iliekcomputers
I do like using the API in javascript better than rendering the data into the html template though.
2020-06-01 15351, 2020
ishaanshah
Is this about the back button not working on graphs page
LB-610: The URL in the browser should update with parameters for the history page
2020-06-01 15303, 2020
ishaanshah
Oh
2020-06-01 15315, 2020
ishaanshah
Although yeah the back button doesnt work
2020-06-01 15302, 2020
ishaanshah
I tried to get it to work, but its difficult to sync state and parameters
2020-06-01 15326, 2020
alastairp
as I said, I had a bit of a chat with Mr_Monkey about it, he said that we could spend some time working out a standard for how do to this, synchronising the state between the server and the frontend
2020-06-01 15337, 2020
alastairp
this will be useful for some parts of AB too
2020-06-01 15350, 2020
ishaanshah
as iliekcomputers said React Router provides a solution for that
2020-06-01 15323, 2020
ishaanshah
*For back button
2020-06-01 15307, 2020
Chinmay3199 joined the channel
2020-06-01 15303, 2020
alastairp
ishaanshah: a suggestion for next time - feel free to add a comment to any pull request or ticket saying if you found a problem but were unable to find a solution
2020-06-01 15336, 2020
alastairp
for example if you knew that the back button wasn't working in this case, just a comment "I know the back button isn't working, but can't work out how to handle this nicely" would have been great
2020-06-01 15358, 2020
ishaanshah
Yep, will do that next time
2020-06-01 15301, 2020
Mr_Monkey
> I do like using the API in javascript better than rendering the data into the html template though.
2020-06-01 15301, 2020
Mr_Monkey
iliekcomputers: The ideal world is doing both, IMO. Load the page with initial data (like we do for listens page), and then the next/previous buttons make call to the API (like the stats page does).
2020-06-01 15301, 2020
Mr_Monkey
Currently those two page are missing what the other one has…
2020-06-01 15317, 2020
Mr_Monkey
ishaanshah: I'm interested in all the solutions, quirks and issues you/we find for url parameters, as it's fairly high on my list for BookBrainz (now that we have better pagination)
2020-06-01 15351, 2020
Mr_Monkey
Is react router really needed? is it not overkill for just changing url params and browser history?
2020-06-01 15358, 2020
iliekcomputers
Mr_Monkey: what's the benefit of loading the page with initial data? It'll need more code which we could avoid.
2020-06-01 15324, 2020
Mr_Monkey
Better user experience, less API calls from the client
2020-06-01 15335, 2020
alastairp
yeah, it prevents the browser from having to do _another_ round trip for the API data
2020-06-01 15351, 2020
Mr_Monkey
If I have a really slow connection and I navigate to page 2, instead of the page1 flashing I't'll slowly show page 1, then slowly do another API call to show the correct page. Not ideal.
2020-06-01 15305, 2020
Freso
Also not showing a blank page for people with JS disabled.
2020-06-01 15315, 2020
alastairp
Nothing to stop us using the API server endpoint in flask to get the data for the right page
2020-06-01 15320, 2020
Mr_Monkey
Or, alternativaly, if any of the URL parameters are not the default ones, maybe skip the initial API call?
2020-06-01 15341, 2020
iliekcomputers
Yeah, that's what I was thinking, we should just skip the initial API call
2020-06-01 15342, 2020
Mr_Monkey
Freso: That's another story… we're talking about sending data with the page rather than rendered html
2020-06-01 15343, 2020
alastairp
Freso: our suggestion isn't a complete fix to this, the page data will still be rendered by js
2020-06-01 15348, 2020
BrainzGit
[musicbrainz-server] yvanzo merged pull request #1540 (master…MBS-10469-delay-showing-CAA-on-front-page): MBS-10469: Add 10 minute delay to shown CAA on front page https://github.com/metabrainz/musicbrainz-server/…
That being said, skipping the API call will already solve that flash of incorrect content issue
2020-06-01 15304, 2020
ruaok
I'm inclined to fire off the calculation of that on page load, but to load it from the browser via a JS call so the page load doesn't need to wait.
2020-06-01 15347, 2020
iliekcomputers
While I would love for it to be as snappy as possible, I don't really feel good about having to maintain two paths from which data could come into the component unless absolutely necessary
2020-06-01 15323, 2020
ishaanshah
The initial flash can be solved by fetching data in componentDidMount seperately
2020-06-01 15329, 2020
ruaok
I feel that sentiment.
2020-06-01 15356, 2020
ishaanshah
Right now I am using other functions to do this to avoid duplication
2020-06-01 15304, 2020
iliekcomputers
The flash is definitely an issue we need to fix
2020-06-01 15315, 2020
alastairp
> I don't really feel good about having to maintain two paths from which data could come into the component unless absolutely necessary
2020-06-01 15329, 2020
alastairp
I'm not convinced that this is as much of a problem as it seems
2020-06-01 15351, 2020
alastairp
I'd be happy to have a discussion/hack day soon to see if we can work out how to do it without repeating code
2020-06-01 15311, 2020
iliekcomputers
We'll have to reuse the code that fetches data in the API endpoint in the profile view. The frontend should be ok.
2020-06-01 15330, 2020
alastairp
I'm not sure what you mean by "reuse code"
2020-06-01 15348, 2020
alastairp
do you mean copy some code and have it duplicated in 2 places, or "call a function"?
2020-06-01 15326, 2020
iliekcomputers
Call a function, ideally.
2020-06-01 15331, 2020
ruaok
gah.
2020-06-01 15350, 2020
ruaok
bitmap: I hope you're staying home. CTA is closed. when did that happen last? (besides yesterday, I guess)
2020-06-01 15322, 2020
iliekcomputers
What's CTA?
2020-06-01 15333, 2020
bitmap
ruaok: never that I can remember. pretty crazy
2020-06-01 15344, 2020
ruaok
chicago transit authority.
2020-06-01 15353, 2020
ruaok
all public transit is shut.
2020-06-01 15304, 2020
bitmap
I was visiting my parents' so I'll be stuck here for a while I guess
2020-06-01 15310, 2020
ruaok
so... bitmpa, when are you moving to the EU?
2020-06-01 15312, 2020
iliekcomputers
Crazy times, stay safe, bitmap. :(
2020-06-01 15335, 2020
bitmap
good question lol
2020-06-01 15305, 2020
yvanzo
likely not today
2020-06-01 15314, 2020
ruaok
LOL
2020-06-01 15338, 2020
ruaok
not anytime soon, really. the EU is largely still closed. esp to the US.
