0:52 AM
supersandro2000 has quit
0:52 AM
supersandro20000 joined the channel
0:53 AM
supersandro20000 has quit
0:54 AM
supersandro2000 joined the channel
1:11 AM
d4rkie has quit
1:13 AM
D4RK-PH0ENiX joined the channel
4:08 AM
MusicbrainzB0T1 joined the channel
4:12 AM
MusicbrainzB0T has quit
4:38 AM
Leftmost
Mr_Monkey, I think
https://github.com/bookbrainz/bookbrainz-site/c... is in a reasonable state as far as functionality. Still ugly as sin, but I think it basically does what it ought to. If you wouldn't mind playing around with it and letting me know how it feels, I'd appreciate it.
4:45 AM
sumedh joined the channel
5:17 AM
Chinmay3199 joined the channel
5:54 AM
sumedh has quit
6:06 AM
RustyFork joined the channel
6:08 AM
sumedh joined the channel
6:48 AM
CatQuest
!m Leftmost
6:48 AM
BrainzBot
You're doing good work, Leftmost!
6:51 AM
CatQuest
Leftmost: actually on line 21 it says "import {FontAwesomeIcon} from '@fortawesome/react-fontawesome';" should that say "fortawesome" ?
6:52 AM
(in author-credit-editor.js )
6:55 AM
Leftmost
Seemingly not. I believe fortawesome is the org. That's what the packages are named, certainly.
7:02 AM
BrainzGit
7:02 AM
BrainzBot
7:51 AM
sumedh has quit
7:56 AM
sumedh joined the channel
8:13 AM
sumedh has quit
8:18 AM
sumedh joined the channel
8:32 AM
sumedh has quit
8:45 AM
sumedh joined the channel
9:03 AM
MrBrave joined the channel
9:05 AM
Gazooo has quit
9:06 AM
v6lur joined the channel
9:06 AM
Gazooo joined the channel
9:48 AM
BrainzGit
10:29 AM
shivam-kapila
ruaok: Hey. Did you get some solution to GRANT
10:29 AM
I did some research but couldn't :(
10:30 AM
ruaok
no, I was AFK for a bit.
10:30 AM
here is one thing to try: just before the call to create_tables, we should make a connection to TS and ask: what user am I?
10:31 AM
and if the user is root or something not listenbrainz_ts, then our code to change the DB connection string is not working.
10:31 AM
if the user is listenbrainz_ts, then we. uhm, need to dig more.
10:31 AM
can you run that one test for me please?
10:31 AM
shivam-kapila
On it
10:32 AM
v6lur has quit
10:38 AM
CallerNo6 has quit
10:41 AM
sumedh has quit
10:46 AM
BrainzGit
10:47 AM
BrainzBot
10:49 AM
BrainzGit
10:49 AM
BrainzBot
10:49 AM
yvanzo
loujine: I can push it to test.mb.o if you want to check i18n.
10:51 AM
CallerNo6 joined the channel
10:51 AM
CallerNo6 has quit
10:51 AM
CallerNo6 joined the channel
10:54 AM
BrainzGit
10:56 AM
shivam-kapila
ruaok: The user is listenbrainz_ts if we connect to SQLALCHEMY_TIMESCALE_URI
10:57 AM
ruaok
ok, so then that is correct.
10:57 AM
and the tables that are created are owned by?
10:59 AM
shivam-kapila
11:00 AM
listenbrainz_ts
11:01 AM
ruaok
do you have the test failure error message to hand? lets look at that again.
11:06 AM
shivam-kapila
11:11 AM
ruaok
ok, continuing out divide can conquer approach, let's do this: run the server without the GRANT and see if you can import listens from last. fm. if you can, then it means our tests have a bug. if you can't then we need to look at which error we get.
11:11 AM
make sense?
11:11 AM
I have to go out and buy some food for the weekend. when I get back I can help take a look.
11:12 AM
shivam-kapila
okay. I will try this till then
11:25 AM
sumedh joined the channel
11:25 AM
Strangely it worked
11:27 AM
ruaok
I think the test setup is borked.
11:33 AM
shivam-kapila
11:34 AM
ruaok
better. what did you change?
11:34 AM
shivam-kapila
The reset_timescale_db() in tests was still using postgres instead of listenbrainz_ts
11:35 AM
I never looked there before to update the URI
11:35 AM
ruaok
yes, that would do it.
11:36 AM
shivam-kapila
The 2 failing are
11:36 AM
1. The listen_count view dependent test
11:36 AM
2. The test I added for try_harder which fails due to incomplete try_harder for `to_ts`
11:36 AM
In crux, problem is solved now
11:36 AM
ruaok
phew.
11:37 AM
shivam-kapila
Huh. Finally. Thanks
11:38 AM
ruaok
and now you know the divide and conquer method for debugging things like this.
11:38 AM
shivam-kapila
Yup. Credits to you
11:55 AM
BrainzGit
12:30 PM
shivam-kapila
ruaok: Fixed try_harder for `to_ts`, added test, updated try_harder to search_larger_time_range
12:30 PM
and pushed
12:58 PM
ruaok
great. did you resolve the conversations on the PR that correspond to the issues you've fixed?
13:01 PM
shivam-kapila
No I didn't
13:02 PM
Shall I do it now or wait till those commits get added into the PR?
13:04 PM
ruaok
pulled, running tests. let's do it soon, hopefully.
13:07 PM
sumedh has quit
13:08 PM
13:08 PM
much much better!
13:08 PM
let me push these changes now.
13:08 PM
shivam-kapila
This test sometimes works sometimes doesnt
13:08 PM
ruaok
timing issue?
13:08 PM
shivam-kapila
Depends on did the view update in 2 sec or it didnt
13:09 PM
> timing issue?
13:09 PM
Yeah
13:10 PM
Plus I can't resolve the conversations. I can only comment on them
13:10 PM
sumedh joined the channel
13:13 PM
ruaok
I
13:14 PM
I've resolved all the issues we just closed. two more items left that I can handle... and dump improvements.
13:14 PM
thanks for all your help shivam-kapila.
13:14 PM
but, I think now its time for you to get back to your gsoc project.
13:14 PM
dseomn has quit
13:14 PM
shivam-kapila
Sure thing. I was slowly slowly doing it sideways
13:22 PM
ruaok
.. on the side ...
13:23 PM
dseomn joined the channel
13:27 PM
shivam-kapila
oh 😅
13:38 PM
GH android app is now out for everyone
14:05 PM
Sophist-UK joined the channel
14:13 PM
sumedh has quit
14:40 PM
BrainzGit
14:48 PM
MrBrave has quit
14:53 PM
Chinmay3199 has quit
15:11 PM
Sophist_UK joined the channel
15:13 PM
Sophist-UK has quit
15:14 PM
Sophist-UK joined the channel
15:15 PM
Sophist_UK has quit
15:17 PM
Sophist_UK joined the channel
15:18 PM
Sophist-UK has quit
16:15 PM
ishaanshah
shivam-kapila: Updated the link
16:15 PM
shivam-kapila
ishaanshah: Hey. Thanks
16:15 PM
If we can do something like this with LB logo it will be really coook
16:15 PM
coool*
16:16 PM
16:16 PM
ishaanshah
It's a bit too much imo
16:16 PM
shivam-kapila
Yeah
16:17 PM
ishaanshah
But I would like to use bootstrap loader with orange or purple color
16:17 PM
But that is not present in Bootstrap 3
16:17 PM
shivam-kapila
Hmm we should consider migrating to bootstrap 4
16:18 PM
ishaanshah
Yep we definitely should
16:21 PM
Sophist-UK joined the channel
16:23 PM
Sophist_UK has quit
16:24 PM
shivam-kapila
Just trying stuff :D
16:24 PM
16:27 PM
ishaanshah
that looks really cool
16:28 PM
shivam-kapila
I stole that 🤫
16:42 PM
KindTwo joined the channel
16:43 PM
KindOne has quit
16:46 PM
KindTwo is now known as KindOne
16:54 PM
KindTwo joined the channel
16:56 PM
KindOne has quit
16:58 PM
KindTwo is now known as KindOne
17:22 PM
Zastai joined the channel
17:31 PM
KindTwo joined the channel
17:33 PM
KindOne has quit
17:35 PM
KindTwo is now known as KindOne
17:52 PM
Chinmay3199 joined the channel
18:01 PM
jwf has quit
18:01 PM
ShraddhaAg has quit
18:54 PM
jwf joined the channel
18:55 PM
ShraddhaAg joined the channel