12 hours for the ISP to figure out it's not fixable remotely…
sumedh has quit
sumedh joined the channel
v6lur joined the channel
CatQuest
iliekcomputers: huh, so I was wondering whytf ircloud wasn't connecting on mobile. thnx for info
Darkloke has quit
iliekcomputers has quit
chaban joined the channel
iliekcomputers joined the channel
ishaanshah has quit
iliekcomputers has quit
jmp_music joined the channel
supersandro2000 has quit
supersandro2000 joined the channel
alastairp has quit
prabal joined the channel
prabal
Mr_Monkey: `<th style={{width: '50%'}}>Name</th>` is this alrigh? or do you prefer to have css class in `style.less` ?
mr_monkey
prabal: that's good. If we have to do any more styling we'll move it to a css class
prabal
okayy. I made that change
It can be merged now
mr_monkey
I'll have a look in a minute.
A quick question prabal: I'm working on having pagination show in the address bar, and stumbled on this line: https://github.com/bookbrainz/bookbrainz-site/b... Is it supposed to have that "q=" at the end? There's no query needed for revisions, right?
Same for editor revisions tab. I suppose they're just a copy paste leftover that isn't causing any problem, but don't serve any purpose in this case
prabal
I did same in collections too
but q is required for search tables
in case of revision, collection, q is empty string and in case of search q is the query
mr_monkey
Right.
IK, I'm going to remove it from the revisions pagination
just ends with "?"
OK*
I'd suggest doing the same to the collection pagination endpoints at some point
mr_monkey feels dirty. Gonna find a better way to do this
iliekcomputers joined the channel
Yuck.
prabal
xD
mr_monkey
prabal: Regarding the `<th>` element on PR 468, I don't think you need any other hardcoded width apart from the first column (name). The rest will take the appropriate amount of space as necessary instead of wrapping around
[bookbrainz-site] prabalsingh24 opened pull request #469 (UserCollection…disableEditTypeForNonEmptyCollection): fix: disable edit EntityType field for non empty collection https://github.com/bookbrainz/bookbrainz-site/p...
mr_monkey
Woot
mr_monkey has quit
prabal has quit
chaban joined the channel
jmp_music has quit
ishaanshah joined the channel
iliekcomputers
some of those twitter replies on the irccloud thread are getting mean
ishaanshah has quit
ishaanshah joined the channel
ishaanshah
iliekcomputers: hey
iliekcomputers
heyo
ishaanshah
IRCcloud was down today
didn't realise that until now
You didn't have any messages before now right?
iliekcomputers
nope!
ishaanshah
cool
iliekcomputers
my personal laptop has been dying randomly, i haven't been able to review PRs, but I will try to today.
ishaanshah
cool, let me know if any changes should be made
iliekcomputers
mhmm
ishaanshah
I worked on the top 10 entities today
the UI is ready, I will complete the tests by tomorrow afternoon
iliekcomputers
nice nice
ishaanshah
Thats all I had for today
iliekcomputers
me too!
have a nice evening, hopefully irccloud is back tomorrow :)