or does it need to be added to root/server/components.js ?
(because "Added entities" is not localized either)
bitmap
user/UserProfile? it's already there
reosarevok
Added entities just doesn't have a translation, does it?
bitmap
probably not, it's a new string afaict
yvanzo
oh right
adding comment
reosarevok
Yay teamwork
nelgin
aaand finally, it's working. Thanks yvanzo.
Looks like there's a bit of work to do in the docs to get it working seamlessly.
yvanzo
nelgin: any suggestion about improving doc organization is welcome.
I tried to keep it compact but the topic needs more details anyway, maybe it should be split into distinct readme files.
thanks reosarevok, do you use specific URLs to test your edit template conversion PRs?
reosarevok
Normally just an edit search for both the earliest and latest edits of the type
If it's one of the historic ones that can be hard to find, I sometimes temporarily change the name to test it easily
Since the edit search just uses the names on the perl files
yvanzo
I had to find the edit type id in constants to use in the URL for the last historic edit PR I checked.
Please add your link to search related edits for such PR in the future.
It's not really a lot of work for 1 PR but there are many :)
Also if you found specific edit with unusual data to be tested, just link to it too :)
goldenshimmer has quit
DjSlash has quit
heyarne[m] has quit
reg[m] has quit
kepstin has quit
joshuaboniface has quit
Leo_Verto has quit
MagnusSvensson[m has quit
maxlath[m] has quit
reosarevok
I guess that only works for cases where I didn't need to change the name for it to work? :)
But I can try to keep it in mind
Sure
yvanzo
No, it should work for both cases because the URL refers to edit type id, not its name.
DjSlash joined the channel
reosarevok
Oh. How does that even work when there are several edits with the same name that normally are searched together?
kepstin joined the channel
yvanzo
I didn't think about that, dunno.
nelgin
yvanzo, definitely don't split it up. I hate jumping around. It's well organized, I just think there's a few technical items that need to be fixed like those issues I came across with the index being created somehow.
[listenbrainz-server] paramsingh opened pull request #1032 (master…param/number-of-listens-per-day): [wip] Show number of listens for today and yesterday on status page. https://github.com/metabrainz/listenbrainz-serv...
rdswift_lt joined the channel
[listenbrainz-server] paramsingh opened pull request #1033 (master…param/dont-trust-lastfm-recording-mbids): LB-431: Save recording mbids from lastfm in a specific field, instead of saving in the recording mbid field https://github.com/metabrainz/listenbrainz-serv...