or does it need to be added to root/server/components.js ?
2020-08-12 22541, 2020
yvanzo
(because "Added entities" is not localized either)
2020-08-12 22544, 2020
bitmap
user/UserProfile? it's already there
2020-08-12 22506, 2020
reosarevok
Added entities just doesn't have a translation, does it?
2020-08-12 22533, 2020
bitmap
probably not, it's a new string afaict
2020-08-12 22540, 2020
yvanzo
oh right
2020-08-12 22555, 2020
yvanzo
adding comment
2020-08-12 22519, 2020
reosarevok
Yay teamwork
2020-08-12 22559, 2020
nelgin
aaand finally, it's working. Thanks yvanzo.
2020-08-12 22512, 2020
nelgin
Looks like there's a bit of work to do in the docs to get it working seamlessly.
2020-08-12 22524, 2020
yvanzo
nelgin: any suggestion about improving doc organization is welcome.
2020-08-12 22512, 2020
yvanzo
I tried to keep it compact but the topic needs more details anyway, maybe it should be split into distinct readme files.
2020-08-12 22541, 2020
yvanzo
thanks reosarevok, do you use specific URLs to test your edit template conversion PRs?
2020-08-12 22559, 2020
reosarevok
Normally just an edit search for both the earliest and latest edits of the type
2020-08-12 22518, 2020
reosarevok
If it's one of the historic ones that can be hard to find, I sometimes temporarily change the name to test it easily
2020-08-12 22534, 2020
reosarevok
Since the edit search just uses the names on the perl files
2020-08-12 22534, 2020
yvanzo
I had to find the edit type id in constants to use in the URL for the last historic edit PR I checked.
2020-08-12 22508, 2020
yvanzo
Please add your link to search related edits for such PR in the future.
2020-08-12 22533, 2020
yvanzo
It's not really a lot of work for 1 PR but there are many :)
2020-08-12 22526, 2020
yvanzo
Also if you found specific edit with unusual data to be tested, just link to it too :)
2020-08-12 22531, 2020
goldenshimmer has quit
2020-08-12 22532, 2020
DjSlash has quit
2020-08-12 22527, 2020
heyarne[m] has quit
2020-08-12 22530, 2020
reg[m] has quit
2020-08-12 22534, 2020
kepstin has quit
2020-08-12 22538, 2020
joshuaboniface has quit
2020-08-12 22538, 2020
Leo_Verto has quit
2020-08-12 22540, 2020
MagnusSvensson[m has quit
2020-08-12 22543, 2020
maxlath[m] has quit
2020-08-12 22545, 2020
reosarevok
I guess that only works for cases where I didn't need to change the name for it to work? :)
2020-08-12 22551, 2020
reosarevok
But I can try to keep it in mind
2020-08-12 22552, 2020
reosarevok
Sure
2020-08-12 22511, 2020
yvanzo
No, it should work for both cases because the URL refers to edit type id, not its name.
2020-08-12 22533, 2020
DjSlash joined the channel
2020-08-12 22557, 2020
reosarevok
Oh. How does that even work when there are several edits with the same name that normally are searched together?
2020-08-12 22526, 2020
kepstin joined the channel
2020-08-12 22516, 2020
yvanzo
I didn't think about that, dunno.
2020-08-12 22554, 2020
nelgin
yvanzo, definitely don't split it up. I hate jumping around. It's well organized, I just think there's a few technical items that need to be fixed like those issues I came across with the index being created somehow.
[listenbrainz-server] paramsingh opened pull request #1032 (master…param/number-of-listens-per-day): [wip] Show number of listens for today and yesterday on status page. https://github.com/metabrainz/listenbrainz-server…
2020-08-12 22529, 2020
rdswift_lt joined the channel
2020-08-12 22502, 2020
BrainzGit
[listenbrainz-server] paramsingh opened pull request #1033 (master…param/dont-trust-lastfm-recording-mbids): LB-431: Save recording mbids from lastfm in a specific field, instead of saving in the recording mbid field https://github.com/metabrainz/listenbrainz-server…
