ok, let me re-read it one more time and make edits.
2020-09-01 24554, 2020
pristine___
Cool
2020-09-01 24539, 2020
ruaok
ok, I think that text is good enough for now. can you please update your PR with that text?
2020-09-01 24518, 2020
pristine___
Hmm. Also, we will have to post to the community first to include that link in the PR.
2020-09-01 24539, 2020
ruaok
yeah, a bit catch-22.
2020-09-01 24510, 2020
ruaok
but right before merging the PR we should put a placeholder post, get the URL and then do there release and add the text after the release.
2020-09-01 24558, 2020
iliekcomputers
why not just put the text on the site?
2020-09-01 24504, 2020
iliekcomputers
does it need to be a community post?
2020-09-01 24553, 2020
ruaok
the site doesn't have a way to comment/discuss....
2020-09-01 24524, 2020
iliekcomputers
hmm.
2020-09-01 24525, 2020
iliekcomputers
true
2020-09-01 24526, 2020
shivam-kapila
I am prompted to have something like a release notification modal
2020-09-01 24533, 2020
shivam-kapila
for nex ttime
2020-09-01 24541, 2020
iliekcomputers
ah ok. i see we're linking to a community post for comments
2020-09-01 24504, 2020
ruaok
and more verbiage.
2020-09-01 24535, 2020
shivam-kapila
pristine___: are you releasing with feedback controls
2020-09-01 24521, 2020
pristine___
No.
2020-09-01 24501, 2020
ruaok
pristine___: in the doc we say that we process the data each week. are we actually doing that now?
2020-09-01 24552, 2020
pristine___
That's the plan. We will have to write a cron job for that
2020-09-01 24526, 2020
pristine___
It should be updates weekly, at least
2020-09-01 24533, 2020
pristine___
Updated*
2020-09-01 24535, 2020
ruaok
k.
2020-09-01 24547, 2020
ruaok
the text in the doc suggests that we are in fact already doing that.
2020-09-01 24513, 2020
ruaok adds "will soon" to the doc
2020-09-01 24538, 2020
ruaok
is the "last updated" timestamp shown in the tab with the recommended tracks?
2020-09-01 24553, 2020
pristine___
No.
2020-09-01 24511, 2020
ruaok
Can you please add that? people will want to know that.
2020-09-01 24512, 2020
pristine___
I was thinking to first write the cron job,
2020-09-01 24527, 2020
pristine___
And then release the PR to sync it.
2020-09-01 24539, 2020
pristine___
> Can you please add that? people will want to know that.
2020-09-01 24540, 2020
pristine___
Okay
2020-09-01 24556, 2020
pristine___
> adds "will soon" to the doc
2020-09-01 24521, 2020
pristine___
I am not really sure adding this.
2020-09-01 24525, 2020
pristine___
About*
2020-09-01 24546, 2020
ruaok
why not? this whole post is about managing expectations and we need to state things clearly and correctly.
2020-09-01 24507, 2020
iliekcomputers
stuff like that has a bad habit of staying in 2 years after it's been done and dusted :)
2020-09-01 24530, 2020
ruaok
I'm open for suggestings on how to do it better.
2020-09-01 24538, 2020
pristine___
I mean shouldn't we first write the cron job
2020-09-01 24544, 2020
pristine___
For weekly updates
2020-09-01 24549, 2020
pristine___
And then release this thing
2020-09-01 24501, 2020
iliekcomputers
what pristine___ says makes sense to me
2020-09-01 24511, 2020
pristine___
I am really comfortable with the idea of saying we will do it weekly soonish
2020-09-01 24514, 2020
pristine___
Not*
2020-09-01 24537, 2020
ruaok
ok, then we'll delay the release of this until we have them generating on a weekly basis.
2020-09-01 24550, 2020
ruaok
the cron job is easy. the fallout from the cron job may not be.
2020-09-01 24552, 2020
iliekcomputers
what's blocking the generation weekly, pristine___ ?
2020-09-01 24515, 2020
ruaok
it may just tie up the spark cluster for a day or two, for each run.
2020-09-01 24516, 2020
pristine___
Nothing. I just didn't write the cron job. I will do it.
2020-09-01 24529, 2020
ruaok
how does that play with the stats jobs?
2020-09-01 24550, 2020
iliekcomputers
they'll be in the queue
2020-09-01 24503, 2020
iliekcomputers
but they'll be blocked until after recommendations are done.
2020-09-01 24526, 2020
pristine___
Right. That's why I said about releasing the recent prs. We will get to know the total time in generating recs
2020-09-01 24545, 2020
pristine___
Then we can sync recs and stas accordingly
2020-09-01 24506, 2020
iliekcomputers
i think we should just add them in, we've done them a few times already, seemed safe enough, but also add a ticket about making request consumer support timeouts somehow.
2020-09-01 24514, 2020
ruaok
so then doing a release is actually more important than reviewing this doc?
2020-09-01 24544, 2020
pristine___
iliekcomputers: I still want to knon the approx time before final release of showing recs on site
2020-09-01 24557, 2020
pristine___
> so then doing a release is actually more important than reviewing this doc?
2020-09-01 24533, 2020
ruaok
iliekcomputers: what are the steps to release then? merge PRs, build & push with today's tag, then restart running services?
2020-09-01 24552, 2020
pristine___
1. Release the merged PRs
2020-09-01 24552, 2020
pristine___
2. Write the cron job
2020-09-01 24552, 2020
pristine___
3 Publish the community post
2020-09-01 24552, 2020
pristine___
4 release the PR to show recs on site
2020-09-01 24500, 2020
pristine___
Is what I think should be done.
2020-09-01 24529, 2020
iliekcomputers
merge PRs to master, deploy beta to check that things look sane, merge master to production, build and push images, restart running services
[listenbrainz-server] mayhem merged pull request #1059 (master…dont-send-last-week-listens-in-rec): Recommended recordings should not include recordings the user listened to recently. https://github.com/metabrainz/listenbrainz-server…
2020-09-01 24530, 2020
iliekcomputers
also, don't need to restart all services, just related ones. i'd do web and spark-reader, not cron because that is running a data dump right now.
iliekcomputers: oh! I thought you are on it so I didn't pick it up.
2020-09-01 24547, 2020
ruaok
there were some local changes on the docker-server-configs repo for lemmy. should start start_listenbrainz_cron be v-2020-07-26.1 or v-2020-08-28.0? (I'm not going to restart it, I just want the file to be correct)
2020-09-01 24551, 2020
ruaok
iliekcomputers: ^
2020-09-01 24517, 2020
iliekcomputers
the latest one, 28.0
2020-09-01 24549, 2020
nelgin joined the channel
2020-09-01 24533, 2020
nelgin
Hi all. I just started up my VM and started replication manually and getting a ton of "WARNING: amqp could not commit tx mode on broker 1, reply_type=3, library_errno=0" messages. Any suggestions?
2020-09-01 24508, 2020
ruaok
one docker layer is always suuuuuper slow to push. gonna take another 20 minutes. anyone else get that?
2020-09-01 24540, 2020
shivam-kapila
ruaok: BTDT
2020-09-01 24511, 2020
iliekcomputers
ruaok: 20 min is a lot
2020-09-01 24522, 2020
iliekcomputers
i just push from lemmy and it's always fast
2020-09-01 24550, 2020
ruaok
this is not my connection, but a docker server issue, I think.
2020-09-01 24526, 2020
ruaok
must be their shiny new TCP-over-carrier-pigeon implementation
can't believe stats is finished, 3 years after my gsoc project lol
2020-09-01 24510, 2020
iliekcomputers
had to become a mentor to finish it off
2020-09-01 24515, 2020
ruaok
heh
2020-09-01 24544, 2020
ruaok
what was the user-user feature called again? user neighborhood?
2020-09-01 24526, 2020
iliekcomputers
I was calling it neighbours
2020-09-01 24527, 2020
shivam-kapila
do we want percentage or something like snapchat
2020-09-01 24555, 2020
iliekcomputers
haven't fleshed it out yet.
2020-09-01 24508, 2020
iliekcomputers
right now i'm trying to zoom out and think of stuff that we could build
2020-09-01 24520, 2020
shivam-kapila
ah ohkj
2020-09-01 24522, 2020
iliekcomputers
then i'll try to list them in order of impact
2020-09-01 24533, 2020
iliekcomputers
then take the highest impact thing and flesh it out
2020-09-01 24521, 2020
slriv has quit
2020-09-01 24532, 2020
ruaok does the actual release now
2020-09-01 24544, 2020
shivam-kapila
ah ohk
2020-09-01 24500, 2020
shivam-kapila
I thought it was released
2020-09-01 24517, 2020
nelgin
I just updated to 2020-08-24 and now when I run replication it's complaining about noit being able to find JSON.pm
2020-09-01 24532, 2020
ruaok
LB release complete.
2020-09-01 24547, 2020
ruaok
iliekcomputers: will you do the release announcement later with your nifty tool?
2020-09-01 24556, 2020
iliekcomputers
sure
2020-09-01 24558, 2020
ruaok
err, that may have sounded wrong....
2020-09-01 24550, 2020
iliekcomputers
ruaok: given that i'll have time to write code now that gsoc's over, do you want to chat about priorities soon? i'd like to take one big piece of work and focus on that for a while.
