#metabrainz

/

      • ruaok
        ok, let me re-read it one more time and make edits.
      • pristine___
        Cool
      • ruaok
        ok, I think that text is good enough for now. can you please update your PR with that text?
      • pristine___
        Hmm. Also, we will have to post to the community first to include that link in the PR.
      • ruaok
        yeah, a bit catch-22.
      • but right before merging the PR we should put a placeholder post, get the URL and then do there release and add the text after the release.
      • iliekcomputers
        why not just put the text on the site?
      • does it need to be a community post?
      • ruaok
        the site doesn't have a way to comment/discuss....
      • iliekcomputers
        hmm.
      • true
      • shivam-kapila
        I am prompted to have something like a release notification modal
      • for nex ttime
      • iliekcomputers
        ah ok. i see we're linking to a community post for comments
      • ruaok
        and more verbiage.
      • shivam-kapila
        pristine___: are you releasing with feedback controls
      • pristine___
        No.
      • ruaok
        pristine___: in the doc we say that we process the data each week. are we actually doing that now?
      • pristine___
        That's the plan. We will have to write a cron job for that
      • It should be updates weekly, at least
      • Updated*
      • ruaok
        k.
      • the text in the doc suggests that we are in fact already doing that.
      • ruaok adds "will soon" to the doc
      • is the "last updated" timestamp shown in the tab with the recommended tracks?
      • pristine___
        No.
      • ruaok
        Can you please add that? people will want to know that.
      • pristine___
        I was thinking to first write the cron job,
      • And then release the PR to sync it.
      • > Can you please add that? people will want to know that.
      • Okay
      • > adds "will soon" to the doc
      • I am not really sure adding this.
      • About*
      • ruaok
        why not? this whole post is about managing expectations and we need to state things clearly and correctly.
      • iliekcomputers
        stuff like that has a bad habit of staying in 2 years after it's been done and dusted :)
      • ruaok
        I'm open for suggestings on how to do it better.
      • pristine___
        I mean shouldn't we first write the cron job
      • For weekly updates
      • And then release this thing
      • iliekcomputers
        what pristine___ says makes sense to me
      • pristine___
        I am really comfortable with the idea of saying we will do it weekly soonish
      • Not*
      • ruaok
        ok, then we'll delay the release of this until we have them generating on a weekly basis.
      • the cron job is easy. the fallout from the cron job may not be.
      • iliekcomputers
        what's blocking the generation weekly, pristine___ ?
      • ruaok
        it may just tie up the spark cluster for a day or two, for each run.
      • pristine___
        Nothing. I just didn't write the cron job. I will do it.
      • ruaok
        how does that play with the stats jobs?
      • iliekcomputers
        they'll be in the queue
      • but they'll be blocked until after recommendations are done.
      • pristine___
        Right. That's why I said about releasing the recent prs. We will get to know the total time in generating recs
      • Then we can sync recs and stas accordingly
      • iliekcomputers
        i think we should just add them in, we've done them a few times already, seemed safe enough, but also add a ticket about making request consumer support timeouts somehow.
      • ruaok
        so then doing a release is actually more important than reviewing this doc?
      • pristine___
        iliekcomputers: I still want to knon the approx time before final release of showing recs on site
      • > so then doing a release is actually more important than reviewing this doc?
      • ruaok
        iliekcomputers: what are the steps to release then? merge PRs, build & push with today's tag, then restart running services?
      • pristine___
        1. Release the merged PRs
      • 2. Write the cron job
      • 3 Publish the community post
      • 4 release the PR to show recs on site
      • Is what I think should be done.
      • iliekcomputers
        merge PRs to master, deploy beta to check that things look sane, merge master to production, build and push images, restart running services
      • ruaok
        ok, which PRs need merging?
      • pristine___
        they are merged already.
      • iliekcomputers
      • would get this one in too, while you're at it
      • BrainzGit
        [listenbrainz-server] mayhem merged pull request #1059 (master…dont-send-last-week-listens-in-rec): Recommended recordings should not include recordings the user listened to recently. https://github.com/metabrainz/listenbrainz-serv...
      • iliekcomputers
        also, don't need to restart all services, just related ones. i'd do web and spark-reader, not cron because that is running a data dump right now.
      • ruaok
        :+1
      • pristine___
      • the commands
      • ruaok
        its gonna take some time before I get there, pristine___
      • pristine___
        just for reference. cool
      • gr0uch0mars
        ruaok: GSoC evals sent. I’m very proud of _lucifer and SomalRudra and the work they’ve done 🥳👏🏻
      • _lucifer: ^
      • SomalRudra: ^
      • The MB Android app has been totally reworked and now looks great! 📱🎨
      • ruaok
        I would have to agree on both counts!
      • !m SomalRudra & _lucifer
      • BrainzBot
        You're doing good work, SomalRudra & _lucifer!
      • ruaok
        I find that the search results still could use some love. are those on the radar for the app?
      • pristine___
        iliekcomputers: I see that you have assigned *write cron job for recs* to yourself.
      • ruaok
        iliekcomputers: pristine___ : Beta updated. help sanity check, please.
      • iliekcomputers
        pristine___: i'm the default assignee :)
      • ruaok: it loads, so lgtm :)
      • ruaok
        lolol
      • ok, I think it looks fine.
      • gr0uch0mars
        ruaok: yes, still some work has to be done. 😊 But the app now has a strong foundation for new features and mantainability.
      • ruaok
        iliekcomputers: `git checkout production && git merge master && <handle issues> && git push origin production` ?
      • iliekcomputers
        yep
      • ruaok
        gr0uch0mars: thank you for your mentorship -- it looks so much more professional now!
      • iliekcomputers
        handle issues should be a noop
      • no-op*
      • ruaok
        confirmed.
      • pushed
      • iliekcomputers
        🎉
      • gr0uch0mars
        ruaok: thanks for trusting me. I wish I could have done more! 😊
      • ruaok
        :)
      • iliekcomputers: v-2020-09-01.0 tagged and pushed
      • as for updating the tag for nodes/lemmy do you just push commit the new tag to master directly?
      • iliekcomputers
        yeah, that's what i've been doing
      • ruaok
      • iliekcomputers
        lgtm
      • pristine___
        iliekcomputers: oh! I thought you are on it so I didn't pick it up.
      • ruaok
        there were some local changes on the docker-server-configs repo for lemmy. should start start_listenbrainz_cron be v-2020-07-26.1 or v-2020-08-28.0? (I'm not going to restart it, I just want the file to be correct)
      • iliekcomputers: ^
      • iliekcomputers
        the latest one, 28.0
      • nelgin joined the channel
      • nelgin
        Hi all. I just started up my VM and started replication manually and getting a ton of "WARNING: amqp could not commit tx mode on broker 1, reply_type=3, library_errno=0" messages. Any suggestions?
      • ruaok
        one docker layer is always suuuuuper slow to push. gonna take another 20 minutes. anyone else get that?
      • shivam-kapila
        ruaok: BTDT
      • iliekcomputers
        ruaok: 20 min is a lot
      • i just push from lemmy and it's always fast
      • ruaok
        this is not my connection, but a docker server issue, I think.
      • must be their shiny new TCP-over-carrier-pigeon implementation
      • iconoclasthero has quit
      • iliekcomputers
        i started on a first version of the planning doc here: https://www.dropbox.com/scl/fi/niem4dby5hz7ar9z...
      • _lucifer: ishaanshah: shivam-kapila: ideas on what you wanna work on would be appreciated ^
      • ruaok: pristine___ ^
      • shivam-kapila
        iliekcomputers: Post design stuff I want to jump into recs
      • ruaok
        wow, paper is annoying.
      • 8 thing to click away just to type some nonsense.
      • travis-ci joined the channel
      • travis-ci
        Project bookbrainz-site build #3403: passed in 4 min 48 sec: https://travis-ci.org/bookbrainz/bookbrainz-sit...
      • travis-ci has left the channel
      • iliekcomputers
        can't believe stats is finished, 3 years after my gsoc project lol
      • had to become a mentor to finish it off
      • ruaok
        heh
      • what was the user-user feature called again? user neighborhood?
      • iliekcomputers
        I was calling it neighbours
      • shivam-kapila
        do we want percentage or something like snapchat
      • iliekcomputers
        haven't fleshed it out yet.
      • right now i'm trying to zoom out and think of stuff that we could build
      • shivam-kapila
        ah ohkj
      • iliekcomputers
        then i'll try to list them in order of impact
      • then take the highest impact thing and flesh it out
      • slriv has quit
      • ruaok does the actual release now
      • shivam-kapila
        ah ohk
      • I thought it was released
      • nelgin
        I just updated to 2020-08-24 and now when I run replication it's complaining about noit being able to find JSON.pm
      • ruaok
        LB release complete.
      • iliekcomputers: will you do the release announcement later with your nifty tool?
      • iliekcomputers
        sure
      • ruaok
        err, that may have sounded wrong....
      • iliekcomputers
        ruaok: given that i'll have time to write code now that gsoc's over, do you want to chat about priorities soon? i'd like to take one big piece of work and focus on that for a while.
      • lots of options
      • ruaok
        can do tomorrow...